gitlab_quality-test_tooling 1.32.1 → 1.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3c5680095668ee71c082a8183693ec031714d59641fbd0ba7f2ef32555a73dc
-  data.tar.gz: 42c9bc53f92cb752fddb7cbf529e08f951245c751dcfac35835fd002a307ed30
+  metadata.gz: 6d3f45e3af6f11c3ebca5f44f3d717960c1ac20cffdc13db75a16d68c9eecfbd
+  data.tar.gz: 0edf629fc7f432a779141be67a231887224a78793defedad416df50b327ecbcb
 SHA512:
-  metadata.gz: a1f2f1791fd8e59b4e4b8e2a3ef5ca1d0c501d34ccdb9525eb621b3776495d28ac810c1280a5a0b3007b7c73aa9b08775ce87c9da5ef01cda1d396c7c79f1840
-  data.tar.gz: e7d5b62b448ce3e48a50368feebc11bd5d2956f61c34628de7484ad658fdc6d1ab027eee716d754b8d16d2732245820ee220a809199b1ef9295c7457b54f7ea4
+  metadata.gz: 7570cde0cd99ea0fe3148f9a8c1f9a7035c165fb0f5506623a79d3f2c3227581d6de878fd56c9a5d5f4c4bae22191d688f49355c74e4b4926b6362ef5d3f8d06
+  data.tar.gz: 0112df035902806c60a82433118669b43bcd9feff89fd8dc7061ee6ffcda9c53ead791c7df4c188567b2b16ee3be8880e269088f4bee944b944aa2dafb60bfef

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (1.32.1)
+    gitlab_quality-test_tooling (1.34.0)
       activesupport (>= 7.0, < 7.2)
       amatch (~> 0.4.1)
       gitlab (~> 4.19)

data/lib/gitlab_quality/test_tooling/knapsack_reports/spec_run_time.rb

@@ -4,19 +4,39 @@ module GitlabQuality
   module TestTooling
     module KnapsackReports
       class SpecRunTime
-        attr_reader :project, :file, :expected, :actual, :expected_suite_duration, :actual_suite_duration
+        attr_reader :file, :expected, :actual, :expected_suite_duration, :actual_suite_duration, :project, :ref
 
         ACTUAL_TO_EXPECTED_SPEC_RUN_TIME_RATIO_THRESHOLD = 1.5 # actual run time is longer than expected by 50% +
         SPEC_WEIGHT_PERCENTAGE_TRESHOLD = 15 # a spec file takes 15%+ of the total test suite run time
         SUITE_DURATION_THRESHOLD = 70 * 60 # if test suite takes more than 70 minutes, job risks timing out
-
-        def initialize(project:, file:, expected:, actual:, expected_suite_duration:, actual_suite_duration:)
-          @project = project
+        FEATURE_CATEGORY_METADATA_REGEX = /(?<=feature_category: :)(?<feature_category>\w+)/
+
+        def initialize(
+          file:,
+          expected:,
+          actual:,
+          expected_suite_duration:,
+          actual_suite_duration:,
+          token: '',
+          project: Runtime::Env.ci_project_path,
+          ref: Runtime::Env.ci_commit_ref_name)
           @file = file
           @expected = expected.to_f
           @actual = actual.to_f
           @expected_suite_duration = expected_suite_duration.to_f
           @actual_suite_duration = actual_suite_duration.to_f
+          @token = token
+          @project = project
+          @ref = ref
+        end
+
+        def feature_category
+          file_lines.each do |line|
+            match = FEATURE_CATEGORY_METADATA_REGEX.match(line)
+            next unless match
+
+            break match[:feature_category]
+          end
         end
 
         def should_report?
@@ -50,6 +70,8 @@ module GitlabQuality
 
         private
 
+        attr_reader :token
+
         def exceed_actual_to_expected_ratio_threshold?
           actual / expected >= ACTUAL_TO_EXPECTED_SPEC_RUN_TIME_RATIO_THRESHOLD
         end
@@ -80,6 +102,18 @@ module GitlabQuality
         def file_link
           "https://gitlab.com/#{project}/-/blob/#{Runtime::Env.ci_commit_ref_name}/#{file}"
         end
+
+        def file_lines
+          files_client.file_contents.lines(chomp: true)
+        end
+
+        def files_client
+          @files_client ||= GitlabClient::RepositoryFilesClient.new(
+            token: token,
+            project: project,
+            file_path: file,
+            ref: ref)
+        end
       end
     end
   end

data/lib/gitlab_quality/test_tooling/knapsack_reports/spec_run_time_report.rb

@@ -8,10 +8,11 @@ module GitlabQuality
       class SpecRunTimeReport
         attr_reader :project, :expected_report, :actual_report
 
-        def initialize(project:, expected_report_path:, actual_report_path:)
+        def initialize(project:, expected_report_path:, actual_report_path:, token: '')
           @project = project
           @expected_report = parse(expected_report_path)
           @actual_report = parse(actual_report_path)
+          @token = token
         end
 
         def filtered_report
@@ -25,6 +26,7 @@ module GitlabQuality
             end
 
             spec_run_time = SpecRunTime.new(
+              token: token,
               project: project,
               file: spec_file,
               expected: expected_run_time,
@@ -39,6 +41,8 @@ module GitlabQuality
 
         private
 
+        attr_reader :token
+
         def parse(report_path)
           JSON.parse(File.read(report_path))
         end

data/lib/gitlab_quality/test_tooling/labels_inference.rb

@@ -10,7 +10,6 @@ module GitlabQuality
       WWW_GITLAB_COM_SITE = 'https://about.gitlab.com'
       WWW_GITLAB_COM_GROUPS_JSON = "#{WWW_GITLAB_COM_SITE}/groups.json".freeze
       WWW_GITLAB_COM_CATEGORIES_JSON = "#{WWW_GITLAB_COM_SITE}/categories.json".freeze
-      FEATURE_CATEGORY_METADATA_REGEX = /(?<=feature_category: :)\w+/
 
       def infer_labels_from_product_group(product_group)
         [groups_mapping.dig(product_group, 'label')].compact.to_set

data/lib/gitlab_quality/test_tooling/report/concerns/group_and_category_labels.rb

@@ -10,11 +10,14 @@ module GitlabQuality
           end
 
           def new_issue_labels(test)
-            puts "  => [DEBUG] product_group: #{test.product_group}; feature_category: #{test.feature_category}"
+            debug_line = '  => [DEBUG] '
+            debug_line += "product_group: #{test&.product_group}; " if test.respond_to?(:product_group)
+            debug_line += "feature_category: #{test&.feature_category}" if test.respond_to?(:feature_category)
+            puts debug_line
 
-            new_labels = self.class::NEW_ISSUE_LABELS +
-              labels_inference.infer_labels_from_product_group(test.product_group) +
-              labels_inference.infer_labels_from_feature_category(test.feature_category)
+            new_labels = self.class::NEW_ISSUE_LABELS
+            new_labels += labels_inference.infer_labels_from_product_group(test.product_group) if test.respond_to?(:product_group)
+            new_labels += labels_inference.infer_labels_from_feature_category(test.feature_category) if test.respond_to?(:feature_category)
             up_to_date_labels(test: test, new_labels: new_labels)
           end
         end

data/lib/gitlab_quality/test_tooling/report/knapsack_report_issue.rb

@@ -14,6 +14,8 @@ module GitlabQuality
       #   - If not found:
       #     - Create a new issue with the run time data
       class KnapsackReportIssue < ReportAsIssue
+        include Concerns::GroupAndCategoryLabels
+
         NEW_ISSUE_LABELS = Set.new(['test', 'type::maintenance', 'maintenance::performance', 'priority::3', 'severity::3', 'knapsack_report']).freeze
         SEARCH_LABELS = %w[test maintenance::performance knapsack_report].freeze
         JOB_TIMEOUT_EPIC_URL = 'https://gitlab.com/groups/gitlab-org/quality/engineering-productivity/-/epics/19'
@@ -36,6 +38,7 @@ module GitlabQuality
 
         def search_and_create_issue
           filtered_report = KnapsackReports::SpecRunTimeReport.new(
+            token: token,
             project: project,
             expected_report_path: expected_report_path,
             actual_report_path: actual_report_path
@@ -67,10 +70,6 @@ module GitlabQuality
           files.first
         end
 
-        def new_issue_labels(_spec_run_time)
-          NEW_ISSUE_LABELS
-        end
-
         def new_issue_title(spec_run_time)
           "Job timeout risk: #{spec_run_time.file} ran much longer than expected"
         end
@@ -110,6 +109,10 @@ module GitlabQuality
             description: updated_description
           }
 
+          # We reopen closed issues to not lose any history
+          state_event = issue.state == 'closed' ? 'reopen' : nil
+          issue_attrs[:state_event] = state_event if state_event
+
           gitlab.edit_issue(iid: issue.iid, options: issue_attrs)
           puts "  => Added a report in #{issue.web_url}!"
         end

data/lib/gitlab_quality/test_tooling/report/report_as_issue.rb

@@ -149,14 +149,14 @@ module GitlabQuality
           labels |= new_labels.to_set
           ee_test?(test) ? labels << 'Enterprise Edition' : labels.delete('Enterprise Edition')
 
-          if test.quarantine?
+          if test.respond_to?(:quarantine?) && test.quarantine?
             labels << 'quarantine'
             labels << "quarantine::#{test.quarantine_type}"
           else
             labels.delete_if { |label| label.include?('quarantine') }
           end
 
-          labels << 'rspec-shared-examples' if test.calls_shared_examples?
+          labels << 'rspec-shared-examples' if test.respond_to?(:calls_shared_examples?) && test.calls_shared_examples?
 
           labels
         end

data/lib/gitlab_quality/test_tooling/report/slow_test_issue.rb

@@ -44,11 +44,11 @@ module GitlabQuality
 
         def health_problem_status_label_quick_action(reports_list)
           case reports_list.reports_count
-          when 40..Float::INFINITY
+          when 6099..Float::INFINITY
             '/label ~"slowness::1"'
-          when 28..39
+          when 2177..6098
             '/label ~"slowness::2"'
-          when 12..27
+          when 521..2176
             '/label ~"slowness::3"'
           else
             '/label ~"slowness::4"'

data/lib/gitlab_quality/test_tooling/test_meta/test_meta_updater.rb

@@ -11,7 +11,6 @@ module GitlabQuality
         attr_reader :project, :ref, :report_issue, :processed_commits
 
         TEST_PLATFORM_MAINTAINERS_SLACK_CHANNEL_ID = 'C0437FV9KBN' # test-platform-maintainers
-        BATCH_LIMIT = 10
 
         def initialize(token:, project:, specs_file:, processor:, ref: 'master', dry_run: false)
           @specs_file = specs_file
@@ -29,7 +28,7 @@ module GitlabQuality
 
             contents['specs'].each do |spec|
               processor.create_commit(spec, self)
-              break if processed_commits.keys.count >= BATCH_LIMIT
+              break if processed_commits.keys.count >= ENV.fetch('BATCH_LIMIT', 10)
             end
 
             processor.create_merge_requests(self)

data/lib/gitlab_quality/test_tooling/test_result/base_test_result.rb

@@ -32,10 +32,6 @@ module GitlabQuality
           raise NotImplementedError
         end
 
-        def line_number
-          raise NotImplementedError
-        end
-
         def section
           raise NotImplementedError
         end
@@ -52,10 +48,53 @@ module GitlabQuality
           raise NotImplementedError
         end
 
+        def product_group
+          report['product_group'].to_s
+        end
+
+        def feature_category
+          report['feature_category']
+        end
+
         def failures?
           failures.any?
         end
 
+        def product_group?
+          product_group != ''
+        end
+
+        def failure_issue
+          report['failure_issue']
+        end
+
+        def failure_issue=(new_failure_issue)
+          report['failure_issue'] = new_failure_issue
+        end
+
+        def line_number
+          report['line_number']
+        end
+
+        def level
+          report['level']
+        end
+
+        def run_time
+          report['run_time'].to_f.round(2)
+        end
+
+        def screenshot?
+          !!screenshot
+        end
+
+        def quarantine?
+          # The value for 'quarantine' could be nil, a hash, a string,
+          # or true (if the test just has the :quarantine tag)
+          # But any non-nil or false value should means the test is in quarantine
+          !!quarantine
+        end
+
         def file
           @file ||= relative_file.start_with?('qa/') ? "qa/#{relative_file}" : relative_file
         end
@@ -98,6 +137,14 @@ module GitlabQuality
         private
 
         attr_reader :token, :project, :ref
+
+        def screenshot
+          report.fetch('screenshot', nil)
+        end
+
+        def quarantine
+          report.fetch('quarantine', nil)
+        end
       end
     end
   end

data/lib/gitlab_quality/test_tooling/test_result/j_unit_test_result.rb

@@ -40,64 +40,13 @@ module GitlabQuality
           end
         end
 
-        def quarantine
-          !report['quarantine'].nil?
-        end
-
-        def quarantine?
-          # The value for 'quarantine' could be nil, a hash, a string,
-          # or true (if the test just has the :quarantine tag)
-          # But any non-nil or false value should means the test is in quarantine
-          !!quarantine
-        end
-
-        def line_number
-          report['line_number']
-        end
-
-        def level
-          report['level']
-        end
-
-        def run_time
-          report['run_time'].to_f.round(2)
-        end
-
-        def screenshot
-          report['screenshot']
-        end
-
-        def screenshot?
-          !!screenshot
-        end
-
         def max_duration_for_test
-          ""
+          ''
         end
 
         def ci_job_url
           ENV.fetch('CI_JOB_URL', '')
         end
-
-        def product_group
-          report['product_group'].to_s
-        end
-
-        def product_group?
-          product_group != ''
-        end
-
-        def feature_category
-          report['feature_category']
-        end
-
-        def failure_issue
-          report['failure_issue']
-        end
-
-        def failure_issue=(new_failure_issue)
-          report['failure_issue'] = new_failure_issue
-        end
       end
     end
   end

data/lib/gitlab_quality/test_tooling/test_result/json_test_result.rb

@@ -68,21 +68,6 @@ module GitlabQuality
           report['testcase'] = new_testcase
         end
 
-        def failure_issue
-          report['failure_issue']
-        end
-
-        def failure_issue=(new_failure_issue)
-          report['failure_issue'] = new_failure_issue
-        end
-
-        def quarantine?
-          # The value for 'quarantine' could be nil, a hash, a string,
-          # or true (if the test just has the :quarantine tag)
-          # But any non-nil or false value should means the test is in quarantine
-          !!quarantine
-        end
-
         def quarantine_type
           quarantine['type'] if quarantine?
         end
@@ -91,26 +76,10 @@ module GitlabQuality
           quarantine['issue'] if quarantine?
         end
 
-        def screenshot?
-          !!screenshot
-        end
-
         def screenshot_image
           screenshot['image'] if screenshot?
         end
 
-        def product_group
-          report['product_group'].to_s
-        end
-
-        def product_group?
-          product_group != ''
-        end
-
-        def feature_category
-          report['feature_category']
-        end
-
         def section
           report['section']
         end
@@ -119,22 +88,10 @@ module GitlabQuality
           report['category']
         end
 
-        def run_time
-          report['run_time'].to_f.round(2)
-        end
-
         def example_id
           report['id']
         end
 
-        def line_number
-          report['line_number']
-        end
-
-        def level
-          report['level']
-        end
-
         def ci_job_id
           report['ci_job_url'].split('/').last
         end
@@ -180,14 +137,6 @@ module GitlabQuality
 
         private
 
-        def quarantine
-          report.fetch('quarantine', nil)
-        end
-
-        def screenshot
-          report.fetch('screenshot', nil)
-        end
-
         def format_message_lines(message_lines)
           message_lines.is_a?(Array) ? message_lines.join("\n") : message_lines
         end

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "1.32.1"
+    VERSION = "1.34.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 1.32.1
+  version: 1.34.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-25 00:00:00.000000000 Z
+date: 2024-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control