gitlab_quality-test_tooling 1.27.0 → 1.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a5b3317b1df5c3f923259fb0dbb71e9cfdf9b4e32f9338b2189758538aaacb30
-  data.tar.gz: 60fda58d2a830e1849c8175347050cb81f62658a20e1ee4c9bdde2cb3049d965
+  metadata.gz: 274b4abf8943ea35b4bfae544d82981cba229feb7864e6f8d5c3b0ccda8bbc24
+  data.tar.gz: 6cb2d671d4fa654b9744c289d8f2ead55d65c340b1fd7abb83fbf6cfae03522a
 SHA512:
-  metadata.gz: 0c70f1860b051ccd633aae6cb58298a90edecdd8a93a598e76f90ac8b2a337f755d77e30fa8b1dd6bcd3df7473c9af31c8a6e46509b59a5047d1be03a4bb2910
-  data.tar.gz: 1ae2fbf63375f49d43ef28cb5a5ec44af6940a5ffd46b43a07c07855085449994858bc49b4ca61c0cd73737c7d4960de9f5f092019681668ad339326f069c741
+  metadata.gz: 97e948985110b8742c7584e1526801a43c0cd99d8f14932329f8c34e2c0ed30c6994fb8681e3b68f6d10c9c71387d2aa9f597b2b006eefdf9d2d1c29d13ba138
+  data.tar.gz: 254cb3965e8b0a3e7f0596c8268c87871fbf20611a6627ef06c0cba44c268f643c7eeb74543852e3f435813443309c7c8f0e68cce210fe499cfb72991dcd44b5

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (1.27.0)
-      activesupport (~> 7.1)
+    gitlab_quality-test_tooling (1.28.0)
+      activesupport (>= 7.0, < 7.2)
       amatch (~> 0.4.1)
       gitlab (~> 4.19)
       http (~> 5.0)
@@ -330,4 +330,4 @@ DEPENDENCIES
   webmock (= 3.7.0)
 
 BUNDLED WITH
-   2.5.4
+   2.5.6

data/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb

@@ -9,8 +9,9 @@ module GitlabQuality
         module IssueReports
           JOB_URL_REGEX = %r{(?<job_url>https://(?<host>[\w.]+)/(?<project_path>[\w\-./]+)/-/jobs/\d+)}
           FAILED_JOB_DESCRIPTION_REGEX = /First happened in #{JOB_URL_REGEX}\./m
-          REPORT_ITEM_REGEX = /^1\. \d{4}-\d{2}-\d{2}: #{JOB_URL_REGEX} \((?<pipeline_url>\S+)\)/
+          REPORT_ITEM_REGEX = /^1\. (?<report_date>\d{4}-\d{2}-\d{2}): #{JOB_URL_REGEX} \((?<pipeline_url>\S+)\) ?(?<extra_content>.*)$/
           LATEST_REPORTS_TO_SHOW = 10
+          DAILY_REPORTS_THRESHOLDS = 10
 
           class ReportsList
             def initialize(preserved_content:, section_header:, reports:, extra_content:)
@@ -21,7 +22,12 @@ module GitlabQuality
             end
 
             def self.report_list_item(test, item_extra_content: nil)
-              "1. #{Time.new.utc.strftime('%F')}: #{test.ci_job_url} (#{ENV.fetch('CI_PIPELINE_URL', 'pipeline url is missing')}) #{item_extra_content}".strip
+              ReportListItem.new(job_url: test.ci_job_url, extra_content: item_extra_content)
+            end
+
+            def self.parse_report_date_from_string(date_string)
+              parsed_time = Time.strptime(date_string, '%F')
+              Time.utc(parsed_time.year, parsed_time.month, parsed_time.day)
             end
 
             def reports_count
@@ -32,21 +38,27 @@ module GitlabQuality
               [
                 preserved_content,
                 "#{section_header} (#{reports_count})",
-                reports_list(reports),
+                reports_list,
                 extra_content
               ].reject(&:blank?).compact.join("\n\n")
             end
 
+            def spiked_in_short_period?
+              latest_report = sorted_reports.first
+
+              reports_for_latest_report_day = sorted_reports.count { |report| report.report_date == latest_report.report_date }
+
+              reports_for_latest_report_day >= DAILY_REPORTS_THRESHOLDS
+            end
+
             private
 
             attr_reader :preserved_content, :section_header, :reports, :extra_content
 
-            def reports_list(reports)
-              sorted_reports = reports.sort.reverse
-
+            def reports_list
               if sorted_reports.size > LATEST_REPORTS_TO_SHOW
                 [
-                  "Last 10 reports:",
+                  "Last #{LATEST_REPORTS_TO_SHOW} reports:",
                   sorted_reports[...LATEST_REPORTS_TO_SHOW].join("\n"),
                   "<details><summary>See #{sorted_reports.size - LATEST_REPORTS_TO_SHOW} more reports</summary>",
                   sorted_reports[LATEST_REPORTS_TO_SHOW..].join("\n"),
@@ -56,6 +68,41 @@ module GitlabQuality
                 sorted_reports.join("\n")
               end
             end
+
+            def sorted_reports
+              @sorted_reports ||= reports.sort.reverse
+            end
+          end
+
+          class ReportListItem
+            attr_reader :report_date
+
+            def initialize(job_url:, report_date: now, pipeline_url: default_pipeline_url, extra_content: '')
+              @job_url = job_url
+              @report_date = report_date
+              @pipeline_url = pipeline_url
+              @extra_content = extra_content
+            end
+
+            def to_s
+              "1. #{report_date}: #{job_url} (#{pipeline_url}) #{extra_content}".strip
+            end
+
+            def <=>(other)
+              to_s <=> other.to_s
+            end
+
+            private
+
+            attr_reader :job_url, :pipeline_url, :extra_content
+
+            def default_pipeline_url
+              ENV.fetch('CI_PIPELINE_URL', 'pipeline url is missing')
+            end
+
+            def now
+              Time.new.utc.strftime('%F')
+            end
           end
 
           def initial_reports_section(test)
@@ -98,7 +145,13 @@ module GitlabQuality
           private
 
           def report_lines(content)
-            content.lines.grep(REPORT_ITEM_REGEX).map(&:strip)
+            content.lines.filter_map do |line|
+              match = line.match(REPORT_ITEM_REGEX)
+              next unless match
+
+              match_data_hash = match.named_captures.transform_keys(&:to_sym)
+              ReportListItem.new(**match_data_hash.slice(:job_url, :report_date, :pipeline_url, :extra_content))
+            end
           end
 
           def job_urls_from_description(issue_description, regex)

data/lib/gitlab_quality/test_tooling/report/failed_test_issue.rb

@@ -94,7 +94,7 @@ module GitlabQuality
 
           note_body = [
             new_reports_list.to_s,
-            identity_labels_quick_action,
+            labels_quick_action(new_reports_list),
             relate_issues_quick_actions(related_issues)
           ].join("\n")
 
@@ -227,9 +227,16 @@ module GitlabQuality
           end
         end
 
-        def identity_labels_quick_action
-          labels_list = IDENTITY_LABELS.map { |label| %(~"#{label}") }.join(' ')
-          %(/label #{labels_list})
+        def labels_quick_action(reports_list)
+          labels_to_apply = identity_labels
+
+          labels_to_apply.push('~"severity::1"') if reports_list.spiked_in_short_period?
+
+          %(/label #{labels_to_apply.join(' ')})
+        end
+
+        def identity_labels
+          IDENTITY_LABELS.map { |label| %(~"#{label}") }
         end
 
         def relate_issues_quick_actions(issues)

data/lib/gitlab_quality/test_tooling/runtime/logger.rb

@@ -38,7 +38,11 @@ module GitlabQuality
               console_log = console_logger(source: source, level: Env.log_level)
               file_log = file_logger(source: source, path: log_path)
 
-              ActiveSupport::BroadcastLogger.new(console_log, file_log, file_log)
+              if ActiveSupport.const_defined?(:BroadcastLogger) # only available in ActiveSupport >= 7.1.0
+                ActiveSupport::BroadcastLogger.new(console_log, file_log, file_log)
+              else
+                console_log.extend(ActiveSupport::Logger.broadcast(file_log))
+              end
             end
           end
 

data/lib/gitlab_quality/test_tooling/test_metrics_exporter/test_metrics.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'time'
+
 module GitlabQuality
   module TestTooling
     module TestMetricsExporter
@@ -11,7 +13,7 @@ module GitlabQuality
           return @time if defined?(@time)
 
           created_at = Time.strptime(env('CI_PIPELINE_CREATED_AT'), '%Y-%m-%dT%H:%M:%S%z') if env('CI_PIPELINE_CREATED_AT')
-          @time = (created_at || Time.now).utc.strftime('%Y-%m-%dT%H:%M:%S%z')
+          @time = Time.parse((created_at || Time.now).utc.strftime('%Y-%m-%d %H:%M:%S %z'))
         end
 
         # rubocop:disable Metrics/AbcSize

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "1.27.0"
+    VERSION = "1.28.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 1.27.0
+  version: 1.28.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-05-23 00:00:00.000000000 Z
+date: 2024-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -196,16 +196,22 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: amatch
   requirement: !ruby/object:Gem::Requirement