gitlab_quality-test_tooling 0.9.1 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 145ee9c8df7307958d5fa46edbff45de7ed0bb604dc213fb9ac5813cd1057327
-  data.tar.gz: 4308fca7357956cf7a236cd59337eb9677de2582f459c2a617da06ba157c60cb
+  metadata.gz: fa16a309741761cbce53a73d541cef1c6bb587cd790492cddc02face87e4338b
+  data.tar.gz: 9cdba5b6c53c83adba07ce9cc0316568b4e8137955fe46faef7705b4b577a5d9
 SHA512:
-  metadata.gz: d5a96691899147d6e61e6d98c24e63b8efe2e5d6cbf4870ea9c1095dfdc7d5091e9381def5a77a5b43dfa85e8c49b6b64bce34852f00b5a4dd61fbda6da70d10
-  data.tar.gz: daa62f692125939eb89b2ffe0664527bcc7078574327a874fe180889358d421686de8cbaeb22ddb83ef71247cea967f3b5d2dd3888415eb764569b2f701034e0
+  metadata.gz: dbb5472b2c4a5d70b26806c2467faae4a8b6770a2cf0ddc61f27e2c082f51459f5f8f7a4d640ec93ee3a8da0a126f5effdbae174d7aaf71d2054eddee0854529
+  data.tar.gz: 98bdef30f3db77c15256ed2ef02e9b3550d8ed6d653e932f0550b35ba3b4f99bd899cedd518dd9a3e0e422ad07e232b2ee1eb1a3abfa2713927312a788c17ad5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (0.9.1)
+    gitlab_quality-test_tooling (0.9.3)
       activesupport (>= 6.1, < 7.1)
       gitlab (~> 4.19)
       http (~> 5.0)

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -176,12 +176,10 @@ module GitlabQuality
         end
 
         def full_stacktrace(test)
-          first_failure = test.failures.first
+          test.failures.each do |failure|
+            next if IGNORED_FAILURES.any? { |e| failure['message'].include?(e) }
 
-          if first_failure['message_lines'].empty?
-            first_failure['message']
-          else
-            first_failure['message_lines'].join("\n")
+            return failure['message_lines'].empty? ? failure['message'] : failure['message_lines'].join("\n")
           end
         end
 
@@ -193,9 +191,9 @@ module GitlabQuality
         end
 
         def cleaned_stacktrace_from_test(test)
-          first_test_failure_stacktrace = sanitize_stacktrace(full_stacktrace(test),
+          test_failure_stacktrace = sanitize_stacktrace(full_stacktrace(test),
             FAILURE_STACKTRACE_REGEX) || full_stacktrace(test)
-          remove_unique_resource_names(first_test_failure_stacktrace)
+          remove_unique_resource_names(test_failure_stacktrace)
         end
 
         def compare_stack_traces(stack_trace_first, stack_trace_second)

data/lib/gitlab_quality/test_tooling/report/slow_test_issue.rb

@@ -38,9 +38,11 @@ module GitlabQuality
 
         def new_issue_description(test)
           super +
-            <<~DESCRIPTION
+            <<~DESCRIPTION.chomp
               Slow tests were detected, please see the [test speed best practices guide](https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#test-speed)
               to improve them. More context available about this issue in the [top slow tests guide](https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#top-slow-tests).
+
+              Add `allowed_to_be_slow: true` to the RSpec test if this is a legit slow test and close the issue.
             DESCRIPTION
         end
 
@@ -59,7 +61,7 @@ module GitlabQuality
         end
 
         def should_create_slow_issue?(test)
-          test.run_time > max_duration_for_test(test)
+          !test.allowed_to_be_slow? && test.run_time > max_duration_for_test(test)
         end
       end
     end

data/lib/gitlab_quality/test_tooling/test_result/json_test_result.rb

@@ -119,6 +119,10 @@ module GitlabQuality
           failures.any?
         end
 
+        def allowed_to_be_slow?
+          !!report['allowed_to_be_slow']
+        end
+
         private
 
         def quarantine

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "0.9.1"
+    VERSION = "0.9.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.3
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-13 00:00:00.000000000 Z
+date: 2023-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control