gitlab_quality-test_tooling 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7119bececf62cc7d2d1aa0a025c4ee193535d74cfe62777e2e4b2ff88590687
-  data.tar.gz: 3e5a13270e9718b683d9554583a4b6b3c1d5f2a3bd5109477b51cdd931610600
+  metadata.gz: 710c5fd717aaeb8311c535e229573763b36fdf8437bc4d561aa5307441740747
+  data.tar.gz: f790b54c1f16a507d416a216d9457c55e86ed91c6776c60dbc3c5c0963ef22e1
 SHA512:
-  metadata.gz: c4cbc83f6bba83bd34ed42e619382778b5255dcc94df168d1cf0436c3b7f2d16c191ed9a6997db3d31e2cc030551a6359d30dc0ec380a8badc8e99d7373e070d
-  data.tar.gz: a87000a5dec45c065e46f836e9f1a7002d43aedf5c4eb11f59f9e69f321bad17537cc035269a7ce3adabef06e189b53cf69d46441bb7c5c245abd3b595a8df8b
+  metadata.gz: d74b227420252c2fd0ec41e0494c18f47f2be12e093eea47c44c97ccbd6e613c1990f257d928c7c9dfd3684b6685e0212667d6099d1ba4e3c03eaa77ed129db5
+  data.tar.gz: 49e42227f975b6a91ddae3052c2b4ac62fa47f462427a4a051462e57e4ff8ffed62e709470426864d324beb4c54b86e3b51aecc425290ef02084218551de76f6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (0.4.1)
+    gitlab_quality-test_tooling (0.4.3)
       activesupport (~> 6.1)
       gitlab (~> 4.18.0)
       http (~> 5.0)

data/lib/gitlab_quality/test_tooling/report/generate_test_session.rb

@@ -269,7 +269,7 @@ module GitlabQuality
           <<~MARKDOWN.chomp
           ## Link to Grafana dashboard for run-type of #{Runtime::Env.qa_run_type}
 
-          * https://dashboards.quality.gitlab.net/d/kuNYMgDnz/test-run-metrics?orgId=1&refresh=1m&var-run_type=#{Runtime::Env.qa_run_type}
+          * https://dashboards.quality.gitlab.net/d/tR_SmBDVk/main-runs?orgId=1&refresh=1m&var-run_type=#{Runtime::Env.qa_run_type}
           MARKDOWN
         end
       end

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -60,10 +60,10 @@ module GitlabQuality
           puts "  => Searching issues for test '#{test.name}'..."
 
           begin
-            issue = test.quarantine? ? find_and_link_issue(test) : find_and_link_issue(test) || create_issue(test)
-            return unless issue
+            issue, issue_already_commented = find_and_link_issue(test)
+            return create_issue(test) unless issue || test.quarantine?
 
-            update_labels(issue, test)
+            update_labels(issue, test) unless issue_already_commented
           rescue MultipleIssuesFound => e
             warn(e.message)
           end
@@ -71,19 +71,22 @@ module GitlabQuality
 
         def find_and_link_issue(test)
           issue, diff_ratio = find_failure_issue(test)
-          issue_already_commented = issue ? @commented_issue_list.include?(issue.web_url) : nil
+          return [false, true] unless issue
 
-          if issue && !issue_already_commented
+          issue_already_commented = issue_already_commented?(issue)
+          if issue_already_commented
+            puts " => Failure already commented on issue."
+          else
             puts "  => Found issue #{issue.web_url} for test '#{test.name}' with a diff ratio of #{(diff_ratio * 100).round(2)}%."
             post_or_update_failed_job_note(issue, test)
             @commented_issue_list.add(issue.web_url)
-          else
-            puts " => Failure already commented on issue." if issue_already_commented
-
-            return false
           end
 
-          issue
+          [issue, issue_already_commented]
+        end
+
+        def issue_already_commented?(issue)
+          @commented_issue_list.include?(issue.web_url)
         end
 
         def create_issue(test)
@@ -94,8 +97,11 @@ module GitlabQuality
             puts " => Will not create new issue for this failing spec"
             similar_issues.each do |similar_issue|
               puts "Please check issue: #{similar_issue.web_url}"
-              gitlab.create_issue_note(iid: similar_issue.iid,
-                note: "This failed job is most likely related: #{test.ci_job_url}")
+
+              unless existing_failure_note(similar_issue, test.ci_job_url)
+                gitlab.create_issue_note(iid: similar_issue.iid,
+                  note: "This failed job is most likely related: #{test.ci_job_url}")
+              end
             end
             return
           end
@@ -309,9 +315,9 @@ module GitlabQuality
           "Failure in #{super}"
         end
 
-        def existing_failure_note(issue)
+        def existing_failure_note(issue, content = "Failed most recently in")
           gitlab.find_issue_notes(iid: issue.iid)&.find do |note|
-            note.body.include?('Failed most recently in')
+            note.body.include?(content)
           end
         end
 

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "0.4.1"
+    VERSION = "0.4.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control