gitlab_quality-test_tooling 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7119bececf62cc7d2d1aa0a025c4ee193535d74cfe62777e2e4b2ff88590687
-  data.tar.gz: 3e5a13270e9718b683d9554583a4b6b3c1d5f2a3bd5109477b51cdd931610600
+  metadata.gz: '09db516b126bd859b0d15c2a02eafe9be450b362253248d017f30f8e22c83b22'
+  data.tar.gz: 42a2999e91fb42a288985212156daf500e99e38084b10207385773b0ed130a8f
 SHA512:
-  metadata.gz: c4cbc83f6bba83bd34ed42e619382778b5255dcc94df168d1cf0436c3b7f2d16c191ed9a6997db3d31e2cc030551a6359d30dc0ec380a8badc8e99d7373e070d
-  data.tar.gz: a87000a5dec45c065e46f836e9f1a7002d43aedf5c4eb11f59f9e69f321bad17537cc035269a7ce3adabef06e189b53cf69d46441bb7c5c245abd3b595a8df8b
+  metadata.gz: edb9ac2763c96f21fdf584a2002ba6522eb5c6a61bbc7ce604453c4d61d87fc7103489f2f386afa5e5d8ba660a4377796ca5cf57765f4848425fb194ce006737
+  data.tar.gz: 33fb7a6951bbdfec91b2be742a82dd91528ca2f27fbb346ae722bc93ad8505e5344e65d77f276445e89bb7c431e509b6841b9a7cdc26629fda7786f2704571ca

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (0.4.1)
+    gitlab_quality-test_tooling (0.4.2)
       activesupport (~> 6.1)
       gitlab (~> 4.18.0)
       http (~> 5.0)

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -60,10 +60,10 @@ module GitlabQuality
           puts "  => Searching issues for test '#{test.name}'..."
 
           begin
-            issue = test.quarantine? ? find_and_link_issue(test) : find_and_link_issue(test) || create_issue(test)
-            return unless issue
+            issue, issue_already_commented = find_and_link_issue(test)
+            return create_issue(test) unless issue || test.quarantine?
 
-            update_labels(issue, test)
+            update_labels(issue, test) unless issue_already_commented
           rescue MultipleIssuesFound => e
             warn(e.message)
           end
@@ -71,19 +71,22 @@ module GitlabQuality
 
         def find_and_link_issue(test)
           issue, diff_ratio = find_failure_issue(test)
-          issue_already_commented = issue ? @commented_issue_list.include?(issue.web_url) : nil
+          return [false, true] unless issue
 
-          if issue && !issue_already_commented
+          issue_already_commented = issue_already_commented?(issue)
+          if issue_already_commented
+            puts " => Failure already commented on issue."
+          else
             puts "  => Found issue #{issue.web_url} for test '#{test.name}' with a diff ratio of #{(diff_ratio * 100).round(2)}%."
             post_or_update_failed_job_note(issue, test)
             @commented_issue_list.add(issue.web_url)
-          else
-            puts " => Failure already commented on issue." if issue_already_commented
-
-            return false
           end
 
-          issue
+          [issue, issue_already_commented]
+        end
+
+        def issue_already_commented?(issue)
+          @commented_issue_list.include?(issue.web_url)
         end
 
         def create_issue(test)
@@ -94,8 +97,11 @@ module GitlabQuality
             puts " => Will not create new issue for this failing spec"
             similar_issues.each do |similar_issue|
               puts "Please check issue: #{similar_issue.web_url}"
-              gitlab.create_issue_note(iid: similar_issue.iid,
-                note: "This failed job is most likely related: #{test.ci_job_url}")
+
+              unless existing_failure_note(similar_issue, test.ci_job_url)
+                gitlab.create_issue_note(iid: similar_issue.iid,
+                  note: "This failed job is most likely related: #{test.ci_job_url}")
+              end
             end
             return
           end
@@ -309,9 +315,9 @@ module GitlabQuality
           "Failure in #{super}"
         end
 
-        def existing_failure_note(issue)
+        def existing_failure_note(issue, content = "Failed most recently in")
           gitlab.find_issue_notes(iid: issue.iid)&.find do |note|
-            note.body.include?('Failed most recently in')
+            note.body.include?(content)
           end
         end
 

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "0.4.1"
+    VERSION = "0.4.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control