gitlab 4.8.0 → 4.13.0

data/lib/gitlab/request.rb

@@ -42,7 +42,12 @@ module Gitlab
     %w[get post put delete].each do |method|
       define_method method do |path, options = {}|
         httparty_config(options)
-        authorization_header(options)
+
+        unless options[:unauthenticated]
+          options[:headers] ||= {}
+          options[:headers].merge!(authorization_header)
+        end
+
         validate self.class.send(method, @endpoint + path, options)
       end
     end
@@ -50,19 +55,7 @@ module Gitlab
     # Checks the response code for common errors.
     # Returns parsed response for successful requests.
     def validate(response)
-      error_klass = case response.code
-                    when 400 then Error::BadRequest
-                    when 401 then Error::Unauthorized
-                    when 403 then Error::Forbidden
-                    when 404 then Error::NotFound
-                    when 405 then Error::MethodNotAllowed
-                    when 409 then Error::Conflict
-                    when 422 then Error::Unprocessable
-                    when 500 then Error::InternalServerError
-                    when 502 then Error::BadGateway
-                    when 503 then Error::ServiceUnavailable
-                    end
-
+      error_klass = Error::STATUS_MAPPINGS[response.code]
       raise error_klass, response if error_klass
 
       parsed = response.parsed_response
@@ -74,28 +67,25 @@ module Gitlab
     # Sets a base_uri and default_params for requests.
     # @raise [Error::MissingCredentials] if endpoint not set.
     def request_defaults(sudo = nil)
-      self.class.default_params sudo: sudo
       raise Error::MissingCredentials, 'Please set an endpoint to API' unless @endpoint
 
+      self.class.default_params sudo: sudo
       self.class.default_params.delete(:sudo) if sudo.nil?
     end
 
     private
 
-    # Sets a PRIVATE-TOKEN or Authorization header for requests.
+    # Returns an Authorization header hash
     #
-    # @param [Hash] options A customizable set of options.
-    # @option options [Boolean] :unauthenticated true if the API call does not require user authentication.
     # @raise [Error::MissingCredentials] if private_token and auth_token are not set.
-    def authorization_header(options)
-      return if options[:unauthenticated]
+    def authorization_header
       raise Error::MissingCredentials, 'Please provide a private_token or auth_token for user' unless @private_token
 
-      options[:headers] = if @private_token.size < 21
-                            { 'PRIVATE-TOKEN' => @private_token }
-                          else
-                            { 'Authorization' => "Bearer #{@private_token}" }
-                          end
+      if @private_token.size < 21
+        { 'PRIVATE-TOKEN' => @private_token }
+      else
+        { 'Authorization' => "Bearer #{@private_token}" }
+      end
     end
 
     # Set HTTParty configuration

data/lib/gitlab/shell_history.rb

@@ -30,12 +30,8 @@ class Gitlab::Shell
     private
 
     def history_file
-      if defined?(@history_file)
-        @history_file
-      else
-        @history_file = File.open(history_file_path, 'w', 0o600).tap do |file|
-          file.sync = true
-        end
+      @history_file ||= File.open(history_file_path, 'w', 0o600).tap do |file|
+        file.sync = true
       end
     rescue Errno::EACCES
       warn 'History not saved; unable to open your history file for writing.'
@@ -50,8 +46,8 @@ class Gitlab::Shell
       path = history_file_path
 
       File.foreach(path) { |line| yield(line) } if File.exist?(path)
-    rescue StandardError => error
-      warn "History file not loaded: #{error.message}"
+    rescue StandardError => e
+      warn "History file not loaded: #{e.message}"
     end
 
     def max_lines

data/lib/gitlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gitlab
-  VERSION = '4.8.0'
+  VERSION = '4.13.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab
 version: !ruby/object:Gem::Version
-  version: 4.8.0
+  version: 4.13.0
 platform: ruby
 authors:
 - Nihad Abbasov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-27 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -18,6 +18,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.14.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -25,10 +28,16 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.14.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.1
@@ -36,6 +45,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.1
@@ -111,32 +123,25 @@ dependencies:
         version: '0'
 description: Ruby client and CLI for GitLab API
 email:
-- mail@narkoz.me
+- nihad@42na.in
 - asedge@gmail.com
 executables:
 - gitlab
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/stale.yml"
-- ".gitignore"
-- ".rubocop_todo.yml"
 - CHANGELOG.md
-- CONTRIBUTING.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
-- bin/console
-- bin/setup
 - exe/gitlab
-- gitlab.gemspec
 - lib/gitlab.rb
 - lib/gitlab/api.rb
 - lib/gitlab/cli.rb
 - lib/gitlab/cli_helpers.rb
 - lib/gitlab/client.rb
 - lib/gitlab/client/access_requests.rb
+- lib/gitlab/client/application_settings.rb
+- lib/gitlab/client/avatar.rb
 - lib/gitlab/client/award_emojis.rb
 - lib/gitlab/client/boards.rb
 - lib/gitlab/client/branches.rb
@@ -144,15 +149,23 @@ files:
 - lib/gitlab/client/build_variables.rb
 - lib/gitlab/client/builds.rb
 - lib/gitlab/client/commits.rb
+- lib/gitlab/client/container_registry.rb
 - lib/gitlab/client/deployments.rb
 - lib/gitlab/client/environments.rb
+- lib/gitlab/client/epics.rb
 - lib/gitlab/client/events.rb
+- lib/gitlab/client/features.rb
+- lib/gitlab/client/group_boards.rb
+- lib/gitlab/client/group_labels.rb
 - lib/gitlab/client/group_milestones.rb
 - lib/gitlab/client/groups.rb
+- lib/gitlab/client/issue_links.rb
 - lib/gitlab/client/issues.rb
 - lib/gitlab/client/jobs.rb
 - lib/gitlab/client/keys.rb
 - lib/gitlab/client/labels.rb
+- lib/gitlab/client/lint.rb
+- lib/gitlab/client/markdown.rb
 - lib/gitlab/client/merge_request_approvals.rb
 - lib/gitlab/client/merge_requests.rb
 - lib/gitlab/client/milestones.rb
@@ -162,12 +175,17 @@ files:
 - lib/gitlab/client/pipeline_triggers.rb
 - lib/gitlab/client/pipelines.rb
 - lib/gitlab/client/project_badges.rb
+- lib/gitlab/client/project_clusters.rb
+- lib/gitlab/client/project_release_links.rb
+- lib/gitlab/client/project_releases.rb
 - lib/gitlab/client/projects.rb
 - lib/gitlab/client/protected_tags.rb
 - lib/gitlab/client/repositories.rb
 - lib/gitlab/client/repository_files.rb
 - lib/gitlab/client/repository_submodules.rb
+- lib/gitlab/client/resource_label_events.rb
 - lib/gitlab/client/runners.rb
+- lib/gitlab/client/search.rb
 - lib/gitlab/client/services.rb
 - lib/gitlab/client/sidekiq.rb
 - lib/gitlab/client/snippets.rb
@@ -189,9 +207,9 @@ files:
 - lib/gitlab/shell.rb
 - lib/gitlab/shell_history.rb
 - lib/gitlab/version.rb
-homepage: https://github.com/narkoz/gitlab
+homepage: https://github.com/NARKOZ/gitlab
 licenses:
-- BSD
+- BSD-2-Clause
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -208,7 +226,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper and CLI for the GitLab API

data/.github/stale.yml

@@ -1,18 +0,0 @@
-# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 90
-# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 10
-# Issues with these labels will never be considered stale
-exemptLabels:
-  - pinned
-  - security
-  - contribution welcome
-# Label to use when marking an issue as stale
-staleLabel: stale
-# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
-  This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false

data/.gitignore

@@ -1,22 +0,0 @@
-*.gem
-*.rbc
-*.swp
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-vendor/bundle
-.idea
-.ruby-version
-.ruby-gemset

data/.rubocop_todo.yml

@@ -1,46 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2018-10-10 10:25:27 +0400 using RuboCop version 0.59.2.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-Lint/UriEscapeUnescape:
-  Exclude:
-    - 'lib/gitlab/client.rb'
-
-# Offense count: 5
-Metrics/AbcSize:
-  Max: 34
-
-# Offense count: 4
-Metrics/CyclomaticComplexity:
-  Max: 14
-
-# Offense count: 10
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/MethodLength:
-  Max: 34
-
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 165
-
-# Offense count: 2
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 6
-
-# Offense count: 1
-Metrics/PerceivedComplexity:
-  Max: 10
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Security/JSONLoad:
-  Exclude:
-    - 'lib/gitlab/request.rb'

data/CONTRIBUTING.md

@@ -1,195 +0,0 @@
-# Contributing to Gitlab
-
-Please take a moment to review this document in order to make the contribution
-process easy and effective for everyone involved!
-
-## Using the issue tracker
-
-You can use the issues tracker for:
-
-* [bug reports](#bug-reports)
-* [feature requests](#feature-requests)
-* [submitting pull requests](#pull-requests)
-
-Use [Stackoverflow](http://stackoverflow.com/) for questions and personal support requests.
-
-## Bug reports
-
-A bug is a _demonstrable problem_ that is caused by the code in the repository.
-Good bug reports are extremely helpful - thank you!
-
-Guidelines for bug reports:
-
-1. **Use the GitHub issue search** — check if the issue has already been
-   reported.
-
-2. **Check if the issue has been fixed** — try to reproduce it using the
-   `master` branch in the repository.
-
-3. **Isolate and report the problem** — ideally create a reduced test
-   case.
-
-Please try to be as detailed as possible in your report. Include information about
-your Ruby, Gitlab client and GitLab instance versions. Please provide steps to
-reproduce the issue as well as the outcome you were expecting! All these details
-will help developers to fix any potential bugs.
-
-Example:
-
-> Short and descriptive example bug report title
->
-> A summary of the issue and the environment in which it occurs. If suitable,
-> include the steps required to reproduce the bug.
->
-> 1. This is the first step
-> 2. This is the second step
-> 3. Further steps, etc.
->
-> Any other information you want to share that is relevant to the issue being
-> reported. This might include the lines of code that you have identified as
-> causing the bug, and potential solutions (and your opinions on their
-> merits).
-
-## Feature requests
-
-Feature requests are welcome. But take a moment to find out whether your idea
-fits with the scope and aims of the project. It's up to *you* to make a strong
-case to convince the community of the merits of this feature.
-Please provide as much detail and context as possible.
-
-## Contributing Documentation
-
-Code documentation has a special convention: it uses [YARD](http://yardoc.org/)
-formatting and the first paragraph is considered to be a short summary.
-
-For methods say what it will do. For example write something like:
-
-```ruby
-# Reverses the contents of a String or IO object.
-#
-# @param [String, #read] contents the contents to reverse
-# @return [String] the contents reversed lexically
-def reverse(contents)
-  contents = contents.read if contents.respond_to? :read
-  contents.reverse
-end
-```
-
-For classes, modules say what it is. For example write something like:
-
-```ruby
-# Defines methods related to groups.
-module Groups
-```
-
-Keep in mind that the documentation notes might show up in a summary somewhere,
-long texts in the documentation notes create very ugly summaries. As a rule of thumb
-anything longer than 80 characters is too long.
-
-Try to keep unnecessary details out of the first paragraph, it's only there to
-give a user a quick idea of what the documented "thing" does/is. The rest of the
-documentation notes can contain the details, for example parameters and what
-is returned.
-
-If possible include examples. For example:
-
-```ruby
-# Gets information about a project.
-#
-# @example
-#   Gitlab.project(3)
-#   Gitlab.project('gitlab')
-#
-# @param  [Integer, String] id The ID or name of a project.
-# @return [Gitlab::ObjectifiedHash]
-def project(id)
-```
-
-This makes it easy to test the examples so that they don't go stale and examples
-are often a great help in explaining what a method does.
-
-## Pull requests
-
-Good pull requests - patches, improvements, new features - are a fantastic
-help. They should remain focused in scope and avoid containing unrelated
-commits.
-
-**IMPORTANT**: By submitting a patch, you agree that your work will be
-licensed under the license used by the project.
-
-If you have any large pull request in mind (e.g. implementing features,
-refactoring code, etc), **please ask first** otherwise you risk spending
-a lot of time working on something that the project's developers might
-not want to merge into the project.
-
-Please adhere to the coding conventions in the project (indentation,
-accurate comments, etc.) and don't forget to add your own tests and
-documentation. When working with git, we recommend the following process
-in order to craft an excellent pull request:
-
-1. [Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your fork,
-   and configure the remotes:
-
-   ```sh
-   # Clone your fork of the repo into the current directory
-   git clone https://github.com/<your-username>/gitlab
-   # Navigate to the newly cloned directory
-   cd gitlab
-   # Assign the original repo to a remote called "upstream"
-   git remote add upstream https://github.com/NARKOZ/gitlab
-   ```
-
-2. If you cloned a while ago, get the latest changes from upstream:
-
-   ```bash
-   git checkout master
-   git pull upstream master
-   ```
-
-3. Create a new topic branch (off of `master`) to contain your feature, change,
-   or fix.
-
-   **IMPORTANT**: Making changes in `master` is discouraged. You should always
-   keep your local `master` in sync with upstream `master` and make your
-   changes in topic branches.
-
-   ```sh
-   git checkout -b <topic-branch-name>
-   ```
-
-4. Commit your changes in logical chunks. Keep your commit messages organized,
-   with a short description in the first line and more detailed information on
-   the following lines. Feel free to use Git's
-   [interactive rebase](https://help.github.com/articles/about-git-rebase/)
-   feature to tidy up your commits before making them public.
-
-5. Make sure all the tests are still passing.
-
-   ```sh
-   rake
-   ```
-
-6. Push your topic branch up to your fork:
-
-   ```sh
-   git push origin <topic-branch-name>
-   ```
-
-7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
-    with a clear title and description.
-
-8. If you haven't updated your pull request for a while, you should consider
-   rebasing on master and resolving any conflicts.
-
-   **IMPORTANT**: _Never ever_ merge upstream `master` into your branches. You
-   should always `git rebase` on `master` to bring your changes up to date when
-   necessary.
-
-   ```sh
-   git checkout master
-   git pull upstream master
-   git checkout <your-topic-branch>
-   git rebase master
-   ```
-
-Thank you for your contributions!