gitlab 4.5.0 → 4.6.0

data/lib/gitlab/client/versions.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+# Defines methods related to version
+# @see https://docs.gitlab.com/ce/api/version.html
+module Versions
+  # Returns server version.
+  # @see https://docs.gitlab.com/ce/api/version.html
+  #
+  # @example
+  #   Gitlab.version
+  #
+  # @return [Array<Gitlab::ObjectifiedHash>]
+  def version
+    get('/version')
+  end
+end

data/lib/gitlab/configuration.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 require 'gitlab/cli_helpers'
 module Gitlab
   # Defines constants and methods related to configuration.
   module Configuration
     # An array of valid keys in the options hash when configuring a Gitlab::API.
-    VALID_OPTIONS_KEYS = %i(endpoint private_token user_agent sudo httparty).freeze
+    VALID_OPTIONS_KEYS = %i[endpoint private_token user_agent sudo httparty].freeze
 
     # The user agent that will be sent to the API endpoint if none is set.
-    DEFAULT_USER_AGENT = "Gitlab Ruby Gem #{Gitlab::VERSION}".freeze
+    DEFAULT_USER_AGENT = "Gitlab Ruby Gem #{Gitlab::VERSION}"
 
     # @private
     attr_accessor(*VALID_OPTIONS_KEYS)
     # @private
-    alias_method :auth_token=, :private_token=
+    alias auth_token= private_token=
 
     # Sets all configuration options to their default values
     # when this module is extended.
@@ -44,11 +46,11 @@ module Gitlab
 
     # Allows HTTParty config to be specified in ENV using YAML hash.
     def get_httparty_config(options)
-      return options if options.nil?
+      return if options.nil?
 
       httparty = Gitlab::CLI::Helpers.yaml_load(options)
-
       raise ArgumentError, 'HTTParty config should be a Hash.' unless httparty.is_a? Hash
+
       Gitlab::CLI::Helpers.symbolize_keys httparty
     end
   end

data/lib/gitlab/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Error
     # Custom error class for rescuing from all Gitlab errors.
@@ -11,7 +13,7 @@ module Gitlab
 
     # Custom error class for rescuing from HTTP response errors.
     class ResponseError < Error
-      POSSIBLE_MESSAGE_KEYS = %i(message error_description error)
+      POSSIBLE_MESSAGE_KEYS = %i[message error_description error].freeze
 
       def initialize(response)
         @response = response

data/lib/gitlab/file_response.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Gitlab
   # Wrapper class of file response.
   class FileResponse
-    HEADER_CONTENT_DISPOSITION = 'Content-Disposition'.freeze
+    HEADER_CONTENT_DISPOSITION = 'Content-Disposition'
 
     attr_reader :filename
 
@@ -18,7 +20,7 @@ module Gitlab
     def to_hash
       { filename: @filename, data: @file }
     end
-    alias_method :to_h, :to_hash
+    alias to_h to_hash
 
     # @return [String] Formatted string with the class name, object id and filename.
     def inspect

data/lib/gitlab/help.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gitlab'
 require 'gitlab/cli_helpers'
 
@@ -32,9 +34,7 @@ module Gitlab::Help
     # @return [String]
     def ri_cmd
       which_ri = `which ri`.chomp
-      if which_ri.empty?
-        raise "'ri' tool not found in $PATH. Please install it to use the help."
-      end
+      raise "'ri' tool not found in $PATH. Please install it to use the help." if which_ri.empty?
 
       which_ri
     end
@@ -47,8 +47,8 @@ module Gitlab::Help
     def help_map
       @help_map ||= begin
         actions.each_with_object({}) do |action, hsh|
-          key = client.method(action).
-                owner.to_s.gsub(/Gitlab::(?:Client::)?/, '')
+          key = client.method(action)
+                      .owner.to_s.gsub(/Gitlab::(?:Client::)?/, '')
           hsh[key] ||= []
           hsh[key] << action.to_s
         end
@@ -58,7 +58,7 @@ module Gitlab::Help
     # Table with available commands.
     #
     # @return [Terminal::Table]
-    def actions_table(topic=nil)
+    def actions_table(topic = nil)
       rows = topic ? help_map[topic] : help_map.keys
       table do |t|
         t.title = topic || 'Help Topics'
@@ -73,9 +73,9 @@ module Gitlab::Help
 
     # Returns full namespace of a command (e.g. Gitlab::Client::Branches.cmd)
     def namespace(cmd)
-      method_owners.select { |method| method[:name] == cmd }.
-        map { |method| method[:owner] + '.' + method[:name] }.
-        shift
+      method_owners.select { |method| method[:name] == cmd }
+                   .map { |method| 'Gitlab::Client::' + method[:owner] + '.' + method[:name] }
+                   .shift
     end
 
     # Massage output from 'ri'.

data/lib/gitlab/objectified_hash.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
+
 module Gitlab
   # Converts hashes to the objects.
   class ObjectifiedHash
     # Creates a new ObjectifiedHash object.
     def initialize(hash)
       @hash = hash
-      @data = hash.inject({}) do |data, (key, value)|
+      @data = hash.each_with_object({}) do |(key, value), data|
         value = ObjectifiedHash.new(value) if value.is_a? Hash
         data[key.to_s] = value
-        data
       end
     end
 
@@ -15,7 +16,7 @@ module Gitlab
     def to_hash
       @hash
     end
-    alias_method :to_h, :to_hash
+    alias to_h to_hash
 
     # @return [String] Formatted string with the class name, object id and original hash.
     def inspect
@@ -24,7 +25,7 @@ module Gitlab
 
     # Delegate to ObjectifiedHash.
     def method_missing(key)
-      @data.key?(key.to_s) ? @data[key.to_s] : nil
+      @data.key?(key.to_s) ? @data[key.to_s] : super
     end
 
     def respond_to_missing?(method_name, include_private = false)

data/lib/gitlab/page_links.rb

@@ -1,21 +1,21 @@
+# frozen_string_literal: true
+
 module Gitlab
   # Parses link header.
   #
   # @private
   class PageLinks
-    HEADER_LINK = 'Link'.freeze
-    DELIM_LINKS = ','.freeze
+    HEADER_LINK = 'Link'
+    DELIM_LINKS = ','
     LINK_REGEX = /<([^>]+)>; rel=\"([^\"]+)\"/
-    METAS = %w(last next first prev).freeze
+    METAS = %w[last next first prev].freeze
 
     attr_accessor(*METAS)
 
     def initialize(headers)
       link_header = headers[HEADER_LINK]
 
-      if link_header && link_header =~ /(next|first|last|prev)/
-        extract_links(link_header)
-      end
+      extract_links(link_header) if link_header && link_header =~ /(next|first|last|prev)/
     end
 
     private
@@ -23,8 +23,10 @@ module Gitlab
     def extract_links(header)
       header.split(DELIM_LINKS).each do |link|
         LINK_REGEX.match(link.strip) do |match|
-          url, meta = match[1], match[2]
+          url = match[1]
+          meta = match[2]
           next if !url || !meta || METAS.index(meta).nil?
+
           send("#{meta}=", url)
         end
       end

data/lib/gitlab/paginated_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   # Wrapper class of paginated response.
   class PaginatedResponse
@@ -54,42 +56,50 @@ module Gitlab
       response
     end
 
-    def has_last_page?
+    def last_page?
       !(@links.nil? || @links.last.nil?)
     end
+    alias has_last_page? last_page?
 
     def last_page
       return nil if @client.nil? || !has_last_page?
+
       path = @links.last.sub(/#{@client.endpoint}/, '')
       @client.get(path)
     end
 
-    def has_first_page?
+    def first_page?
       !(@links.nil? || @links.first.nil?)
     end
+    alias has_first_page? first_page?
 
     def first_page
       return nil if @client.nil? || !has_first_page?
+
       path = @links.first.sub(/#{@client.endpoint}/, '')
       @client.get(path)
     end
 
-    def has_next_page?
+    def next_page?
       !(@links.nil? || @links.next.nil?)
     end
+    alias has_next_page? next_page?
 
     def next_page
       return nil if @client.nil? || !has_next_page?
+
       path = @links.next.sub(/#{@client.endpoint}/, '')
       @client.get(path)
     end
 
-    def has_prev_page?
+    def prev_page?
       !(@links.nil? || @links.prev.nil?)
     end
+    alias has_prev_page? prev_page?
 
     def prev_page
       return nil if @client.nil? || !has_prev_page?
+
       path = @links.prev.sub(/#{@client.endpoint}/, '')
       @client.get(path)
     end

data/lib/gitlab/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'httparty'
 require 'json'
 
@@ -7,7 +9,7 @@ module Gitlab
     include HTTParty
     format :json
     headers 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded'
-    parser proc { |body, _| parse(body) }
+    parser(proc { |body, _| parse(body) })
 
     attr_accessor :private_token, :endpoint
 
@@ -32,13 +34,13 @@ module Gitlab
 
     # Decodes a JSON response into Ruby object.
     def self.decode(response)
-      return response ? JSON.load(response) : {}     
+      response ? JSON.load(response) : {}
     rescue JSON::ParserError
       raise Error::Parsing, 'The response is not a valid JSON'
     end
 
-    %w(get post put delete).each do |method|
-      define_method method do |path, options={}|
+    %w[get post put delete].each do |method|
+      define_method method do |path, options = {}|
         httparty_config(options)
         authorization_header(options)
         validate self.class.send(method, @endpoint + path, options)
@@ -71,9 +73,10 @@ module Gitlab
 
     # Sets a base_uri and default_params for requests.
     # @raise [Error::MissingCredentials] if endpoint not set.
-    def request_defaults(sudo=nil)
+    def request_defaults(sudo = nil)
       self.class.default_params sudo: sudo
       raise Error::MissingCredentials, 'Please set an endpoint to API' unless @endpoint
+
       self.class.default_params.delete(:sudo) if sudo.nil?
     end
 

data/lib/gitlab/shell.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gitlab'
 require 'gitlab/help'
 require 'gitlab/cli_helpers'
@@ -15,7 +17,7 @@ class Gitlab::Shell
       trap('INT') { quit_shell } # capture ctrl-c
       setup
 
-      while buffer = Readline.readline('gitlab> ')
+      while (buffer = Readline.readline('gitlab> '))
         begin
           parse_input buffer
 
@@ -34,7 +36,7 @@ class Gitlab::Shell
             data = execute command, arguments
             output_table command, arguments, data
           end
-        rescue => e
+        rescue StandardError => e
           puts e.message
         end
       end
@@ -46,7 +48,7 @@ class Gitlab::Shell
       buf = Shellwords.shellwords(buffer)
 
       @command = buf.shift
-      @arguments = buf.count > 0 ? buf : []
+      @arguments = buf.count.positive? ? buf : []
     end
 
     def setup
@@ -62,7 +64,7 @@ class Gitlab::Shell
     end
 
     # Execute a given command with arguements
-    def execute(cmd=command, args=arguments)
+    def execute(cmd = command, args = arguments)
       raise "Unknown command: #{cmd}. See the 'help' for a list of valid commands." unless actions.include?(cmd.to_sym)
 
       confirm_command(cmd)

data/lib/gitlab/shell_history.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 class Gitlab::Shell
   class History
     DEFAULT_HISTFILESIZE = 200
     DEFAULT_FILE_PATH = File.join(Dir.home, '.gitlab_shell_history')
 
-    def initialize(options={})
+    def initialize(options = {})
       @file_path = options[:file_path] || DEFAULT_FILE_PATH
       Readline::HISTORY.clear
     end
@@ -13,13 +15,13 @@ class Gitlab::Shell
     end
 
     def save
-      lines.each { |line| history_file.puts line if history_file }
+      lines.each { |line| history_file&.puts line }
     end
 
     def push(line)
       Readline::HISTORY << line
     end
-    alias_method :<<, :push
+    alias << push
 
     def lines
       Readline::HISTORY.to_a.last(max_lines)
@@ -31,7 +33,7 @@ class Gitlab::Shell
       if defined?(@history_file)
         @history_file
       else
-        @history_file = File.open(history_file_path, 'w', 0600).tap do |file|
+        @history_file = File.open(history_file_path, 'w', 0o600).tap do |file|
           file.sync = true
         end
       end
@@ -48,7 +50,7 @@ class Gitlab::Shell
       path = history_file_path
 
       File.foreach(path) { |line| yield(line) } if File.exist?(path)
-    rescue => error
+    rescue StandardError => error
       warn "History file not loaded: #{error.message}"
     end
 

data/lib/gitlab/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
-  VERSION = '4.5.0'.freeze
+  VERSION = '4.6.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab
 version: !ruby/object:Gem::Version
-  version: 4.5.0
+  version: 4.6.0
 platform: ruby
 authors:
 - Nihad Abbasov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-07 00:00:00.000000000 Z
+date: 2018-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -82,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -96,7 +96,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -118,7 +118,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/stale.yml"
 - ".gitignore"
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
@@ -169,6 +171,7 @@ files:
 - lib/gitlab/client/tags.rb
 - lib/gitlab/client/todos.rb
 - lib/gitlab/client/users.rb
+- lib/gitlab/client/versions.rb
 - lib/gitlab/configuration.rb
 - lib/gitlab/error.rb
 - lib/gitlab/file_response.rb
@@ -192,7 +195,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="