gitlab 4.10.0 → 4.19.0

data/lib/gitlab/request.rb

@@ -8,6 +8,7 @@ module Gitlab
   class Request
     include HTTParty
     format :json
+    maintain_method_across_redirects true
     headers 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded'
     parser(proc { |body, _| parse(body) })
 
@@ -25,8 +26,6 @@ module Gitlab
         true
       elsif !body
         false
-      elsif body.nil?
-        false
       else
         raise Error::Parsing, "Couldn't parse a response body"
       end
@@ -41,29 +40,34 @@ module Gitlab
 
     %w[get post put delete].each do |method|
       define_method method do |path, options = {}|
-        httparty_config(options)
-        authorization_header(options)
-        validate self.class.send(method, @endpoint + path, options)
+        params = options.dup
+
+        httparty_config(params)
+
+        unless params[:unauthenticated]
+          params[:headers] ||= {}
+          params[:headers].merge!(authorization_header)
+        end
+
+        retries_left = params[:ratelimit_retries] || 3
+        begin
+          response = self.class.send(method, endpoint + path, params)
+          validate response
+        rescue Gitlab::Error::TooManyRequests => e
+          retries_left -= 1
+          raise e if retries_left.zero?
+
+          wait_time = response.headers['Retry-After'] || 2
+          sleep(wait_time.to_i)
+          retry
+        end
       end
     end
 
     # Checks the response code for common errors.
     # Returns parsed response for successful requests.
     def validate(response)
-      error_klass = case response.code
-                    when 400 then Error::BadRequest
-                    when 401 then Error::Unauthorized
-                    when 403 then Error::Forbidden
-                    when 404 then Error::NotFound
-                    when 405 then Error::MethodNotAllowed
-                    when 409 then Error::Conflict
-                    when 422 then Error::Unprocessable
-                    when 429 then Error::TooManyRequests
-                    when 500 then Error::InternalServerError
-                    when 502 then Error::BadGateway
-                    when 503 then Error::ServiceUnavailable
-                    end
-
+      error_klass = Error.klass(response)
       raise error_klass, response if error_klass
 
       parsed = response.parsed_response
@@ -75,28 +79,25 @@ module Gitlab
     # Sets a base_uri and default_params for requests.
     # @raise [Error::MissingCredentials] if endpoint not set.
     def request_defaults(sudo = nil)
-      self.class.default_params sudo: sudo
-      raise Error::MissingCredentials, 'Please set an endpoint to API' unless @endpoint
+      raise Error::MissingCredentials, 'Please set an endpoint to API' unless endpoint
 
+      self.class.default_params sudo: sudo
       self.class.default_params.delete(:sudo) if sudo.nil?
     end
 
     private
 
-    # Sets a PRIVATE-TOKEN or Authorization header for requests.
+    # Returns an Authorization header hash
     #
-    # @param [Hash] options A customizable set of options.
-    # @option options [Boolean] :unauthenticated true if the API call does not require user authentication.
     # @raise [Error::MissingCredentials] if private_token and auth_token are not set.
-    def authorization_header(options)
-      return if options[:unauthenticated]
-      raise Error::MissingCredentials, 'Please provide a private_token or auth_token for user' unless @private_token
-
-      options[:headers] = if @private_token.size < 21
-                            { 'PRIVATE-TOKEN' => @private_token }
-                          else
-                            { 'Authorization' => "Bearer #{@private_token}" }
-                          end
+    def authorization_header
+      raise Error::MissingCredentials, 'Please provide a private_token or auth_token for user' unless private_token
+
+      if private_token.size < 21
+        { 'PRIVATE-TOKEN' => private_token }
+      else
+        { 'Authorization' => "Bearer #{private_token}" }
+      end
     end
 
     # Set HTTParty configuration

data/lib/gitlab/shell_history.rb

@@ -30,12 +30,8 @@ class Gitlab::Shell
     private
 
     def history_file
-      if defined?(@history_file)
-        @history_file
-      else
-        @history_file = File.open(history_file_path, 'w', 0o600).tap do |file|
-          file.sync = true
-        end
+      @history_file ||= File.open(history_file_path, 'w', 0o600).tap do |file|
+        file.sync = true
       end
     rescue Errno::EACCES
       warn 'History not saved; unable to open your history file for writing.'
@@ -46,12 +42,12 @@ class Gitlab::Shell
       File.expand_path(@file_path)
     end
 
-    def read_from_file
+    def read_from_file(&block)
       path = history_file_path
 
-      File.foreach(path) { |line| yield(line) } if File.exist?(path)
-    rescue StandardError => error
-      warn "History file not loaded: #{error.message}"
+      File.foreach(path, &block) if File.exist?(path)
+    rescue StandardError => e
+      warn "History file not loaded: #{e.message}"
     end
 
     def max_lines

data/lib/gitlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gitlab
-  VERSION = '4.10.0'
+  VERSION = '4.19.0'
 end

data/lib/gitlab.rb

@@ -21,11 +21,18 @@ module Gitlab
     Gitlab::Client.new(options)
   end
 
-  # Delegate to Gitlab::Client
-  def self.method_missing(method, *args, &block)
-    return super unless client.respond_to?(method)
-
-    client.send(method, *args, &block)
+  if Gem::Version.new(RUBY_VERSION).release >= Gem::Version.new('3.0.0')
+    def self.method_missing(method, *args, **keywargs, &block)
+      return super unless client.respond_to?(method)
+
+      client.send(method, *args, **keywargs, &block)
+    end
+  else
+    def self.method_missing(method, *args, &block)
+      return super unless client.respond_to?(method)
+
+      client.send(method, *args, &block)
+    end
   end
 
   # Delegate to Gitlab::Client
@@ -42,7 +49,8 @@ module Gitlab
   #
   # @return [Array<Symbol>]
   def self.actions
-    hidden = /endpoint|private_token|auth_token|user_agent|sudo|get|post|put|\Adelete\z|validate|request_defaults|httparty/
+    hidden =
+      /endpoint|private_token|auth_token|user_agent|sudo|get|post|put|\Adelete\z|validate\z|request_defaults|httparty/
     (Gitlab::Client.instance_methods - Object.methods).reject { |e| e[hidden] }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.19.0
 platform: ruby
 authors:
 - Nihad Abbasov
@@ -9,35 +9,26 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2022-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.14.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.14.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.20'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.1
@@ -45,26 +36,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.1
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -93,20 +67,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -140,6 +100,7 @@ files:
 - lib/gitlab/cli_helpers.rb
 - lib/gitlab/client.rb
 - lib/gitlab/client/access_requests.rb
+- lib/gitlab/client/application_settings.rb
 - lib/gitlab/client/avatar.rb
 - lib/gitlab/client/award_emojis.rb
 - lib/gitlab/client/boards.rb
@@ -148,23 +109,31 @@ files:
 - lib/gitlab/client/build_variables.rb
 - lib/gitlab/client/builds.rb
 - lib/gitlab/client/commits.rb
+- lib/gitlab/client/container_registry.rb
 - lib/gitlab/client/deployments.rb
 - lib/gitlab/client/environments.rb
+- lib/gitlab/client/epic_issues.rb
+- lib/gitlab/client/epics.rb
 - lib/gitlab/client/events.rb
 - lib/gitlab/client/features.rb
+- lib/gitlab/client/group_badges.rb
 - lib/gitlab/client/group_boards.rb
 - lib/gitlab/client/group_labels.rb
 - lib/gitlab/client/group_milestones.rb
 - lib/gitlab/client/groups.rb
+- lib/gitlab/client/issue_links.rb
 - lib/gitlab/client/issues.rb
 - lib/gitlab/client/jobs.rb
 - lib/gitlab/client/keys.rb
 - lib/gitlab/client/labels.rb
+- lib/gitlab/client/lint.rb
+- lib/gitlab/client/markdown.rb
 - lib/gitlab/client/merge_request_approvals.rb
 - lib/gitlab/client/merge_requests.rb
 - lib/gitlab/client/milestones.rb
 - lib/gitlab/client/namespaces.rb
 - lib/gitlab/client/notes.rb
+- lib/gitlab/client/packages.rb
 - lib/gitlab/client/pipeline_schedules.rb
 - lib/gitlab/client/pipeline_triggers.rb
 - lib/gitlab/client/pipelines.rb
@@ -174,10 +143,12 @@ files:
 - lib/gitlab/client/project_releases.rb
 - lib/gitlab/client/projects.rb
 - lib/gitlab/client/protected_tags.rb
+- lib/gitlab/client/remote_mirrors.rb
 - lib/gitlab/client/repositories.rb
 - lib/gitlab/client/repository_files.rb
 - lib/gitlab/client/repository_submodules.rb
 - lib/gitlab/client/resource_label_events.rb
+- lib/gitlab/client/resource_state_events.rb
 - lib/gitlab/client/runners.rb
 - lib/gitlab/client/search.rb
 - lib/gitlab/client/services.rb
@@ -187,6 +158,7 @@ files:
 - lib/gitlab/client/tags.rb
 - lib/gitlab/client/templates.rb
 - lib/gitlab/client/todos.rb
+- lib/gitlab/client/user_snippets.rb
 - lib/gitlab/client/users.rb
 - lib/gitlab/client/versions.rb
 - lib/gitlab/client/wikis.rb
@@ -204,7 +176,12 @@ files:
 homepage: https://github.com/NARKOZ/gitlab
 licenses:
 - BSD-2-Clause
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/NARKOZ/gitlab
+  source_code_uri: https://github.com/NARKOZ/gitlab
+  bug_tracker_uri: https://github.com/NARKOZ/gitlab/issues
+  changelog_uri: https://github.com/NARKOZ/gitlab/releases
+  funding_uri: https://github.com/NARKOZ/SponsorMe
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -213,14 +190,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper and CLI for the GitLab API