gitlab 3.5.0 → 3.6.0

data/spec/gitlab/cli_spec.rb

@@ -60,7 +60,6 @@ describe Gitlab::CLI do
       end
     end
 
-
     context "when command with json output" do
       before do
         stub_get("/user", "user")
@@ -74,7 +73,6 @@ describe Gitlab::CLI do
       end
     end
 
-
     context "when command with required fields" do
       before do
         stub_get("/user", "user")

data/spec/gitlab/client/branches_spec.rb

@@ -16,8 +16,8 @@ describe Gitlab::Client do
       expect(a_get("/projects/3/repository/branches")).to have_been_made
     end
 
-    it "should return an array of repository branches" do
-      expect(@branches).to be_an Array
+    it "should return a paginated response of repository branches" do
+      expect(@branches).to be_a Gitlab::PaginatedResponse
       expect(@branches.first.name).to eq("api")
     end
   end

data/spec/gitlab/client/commits_spec.rb

@@ -12,17 +12,17 @@ describe Gitlab::Client do
   describe ".commits" do
     before do
       stub_get("/projects/3/repository/commits", "project_commits").
-        with(:query => {:ref_name => "api"})
-      @commits = Gitlab.commits(3, :ref_name => "api")
+        with(query: { ref_name: "api" })
+      @commits = Gitlab.commits(3, ref_name: "api")
     end
 
     it "should get the correct resource" do
       expect(a_get("/projects/3/repository/commits").
-        with(:query => {:ref_name => "api"})).to have_been_made
+        with(query: { ref_name: "api" })).to have_been_made
     end
 
-    it "should return an array of repository commits" do
-      expect(@commits).to be_an Array
+    it "should return a paginated response of repository commits" do
+      expect(@commits).to be_a Gitlab::PaginatedResponse
       expect(@commits.first.id).to eq("f7dd067490fe57505f7226c3b54d3127d2f7fd46")
     end
   end
@@ -34,8 +34,8 @@ describe Gitlab::Client do
     end
 
     it "should get the correct resource" do
-      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6"))
-        .to have_been_made
+      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6")).
+        to have_been_made
     end
 
     it "should return a repository commit" do
@@ -50,8 +50,8 @@ describe Gitlab::Client do
     end
 
     it "should get the correct resource" do
-      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6/diff"))
-        .to have_been_made
+      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6/diff")).
+        to have_been_made
     end
 
     it "should return a diff of a commit" do
@@ -66,12 +66,12 @@ describe Gitlab::Client do
     end
 
     it "should get the correct resource" do
-      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6/comments"))
-        .to have_been_made
+      expect(a_get("/projects/3/repository/commits/6104942438c14ec7bd21c6cd5bd995272b3faff6/comments")).
+        to have_been_made
     end
 
     it "should return commit's comments" do
-      expect(@commit_comments).to be_an Array
+      expect(@commit_comments).to be_a Gitlab::PaginatedResponse
       expect(@commit_comments.length).to eq(2)
       expect(@commit_comments[0].note).to eq("this is the 1st comment on commit 6104942438c14ec7bd21c6cd5bd995272b3faff6")
       expect(@commit_comments[0].author.id).to eq(11)
@@ -101,11 +101,11 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_get("/projects/6/repository/commits/7d938cb8ac15788d71f4b67c035515a160ea76d8/statuses").
-        with(query: {all: true}))
+        with(query: { all: true }))
     end
 
     it "should get statuses of a commit" do
-      expect(@statuses).to be_kind_of Array
+      expect(@statuses).to be_kind_of Gitlab::PaginatedResponse
       expect(@statuses.first.sha).to eq('7d938cb8ac15788d71f4b67c035515a160ea76d8')
       expect(@statuses.first.ref).to eq('decreased-spec')
       expect(@statuses.first.status).to eq('failed')
@@ -117,13 +117,13 @@ describe Gitlab::Client do
   describe ".update_commit_status" do
     before do
       stub_post("/projects/6/statuses/7d938cb8ac15788d71f4b67c035515a160ea76d8", 'project_update_commit_status').
-        with(query: {name: 'test', ref: 'decreased-spec', state: 'failed'})
+        with(query: { name: 'test', ref: 'decreased-spec', state: 'failed' })
       @status = Gitlab.update_commit_status(6, '7d938cb8ac15788d71f4b67c035515a160ea76d8', 'failed', name: 'test', ref: 'decreased-spec')
     end
 
     it "should get the correct resource" do
       expect(a_post('/projects/6/statuses/7d938cb8ac15788d71f4b67c035515a160ea76d8').
-        with(query: {name: 'test', ref: 'decreased-spec', state: 'failed'}))
+        with(query: { name: 'test', ref: 'decreased-spec', state: 'failed' }))
     end
 
     it "should information about the newly created status" do

data/spec/gitlab/client/groups_spec.rb

@@ -14,8 +14,8 @@ describe Gitlab::Client do
       expect(a_get("/groups/3")).to have_been_made
     end
 
-    it "should return an array of Groups" do
-      expect(@groups).to be_an Array
+    it "should return a paginated response of groups" do
+      expect(@groups).to be_a Gitlab::PaginatedResponse
       expect(@groups.first.path).to eq("threegroup")
     end
   end
@@ -29,7 +29,7 @@ describe Gitlab::Client do
 
       it "should get the correct resource" do
         expect(a_post("/groups").
-            with(:body => {:path => 'gitlab-path', :name => 'GitLab-Group'})).to have_been_made
+            with(body: { path: 'gitlab-path', name: 'GitLab-Group' })).to have_been_made
       end
 
       it "should return information about a created group" do
@@ -41,13 +41,13 @@ describe Gitlab::Client do
     context "with description" do
       before do
         stub_post("/groups", "group_create_with_description")
-        @group = Gitlab.create_group('GitLab-Group', 'gitlab-path', :description => 'gitlab group description')
+        @group = Gitlab.create_group('GitLab-Group', 'gitlab-path', description: 'gitlab group description')
       end
 
       it "should get the correct resource" do
         expect(a_post("/groups").
-                 with(:body => {:path => 'gitlab-path', :name => 'GitLab-Group',
-                                :description => 'gitlab group description'})).to have_been_made
+                 with(body: { path: 'gitlab-path', name: 'GitLab-Group',
+                              description: 'gitlab group description' })).to have_been_made
       end
 
       it "should return information about a created group" do
@@ -66,11 +66,11 @@ describe Gitlab::Client do
       @group = Gitlab.create_group('GitLab-Group', 'gitlab-path')
 
       stub_post("/groups/#{@group.id}/projects/#{@project.id}", "group_create")
-      @group_transfer = Gitlab.transfer_project_to_group(@group.id,@project.id)
+      @group_transfer = Gitlab.transfer_project_to_group(@group.id, @project.id)
     end
 
     it "should post to the correct resource" do
-      expect(a_post("/groups/#{@group.id}/projects/#{@project.id}").with(:body => {:id => @group.id.to_s, :project_id => @project.id.to_s})).to have_been_made
+      expect(a_post("/groups/#{@group.id}/projects/#{@project.id}").with(body: { id: @group.id.to_s, project_id: @project.id.to_s })).to have_been_made
     end
 
     it "should return information about the group" do
@@ -91,7 +91,7 @@ describe Gitlab::Client do
     end
 
     it "should return information about a group members" do
-      expect(@members).to be_an Array
+      expect(@members).to be_a Gitlab::PaginatedResponse
       expect(@members.size).to eq(2)
       expect(@members[1].name).to eq("John Smith")
     end
@@ -105,10 +105,10 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_post("/groups/3/members").
-        with(:body => {:user_id => '1', :access_level => '40'})).to have_been_made
+        with(body: { user_id: '1', access_level: '40' })).to have_been_made
     end
 
-    it "should return information about an added member" do
+    it "should return information about the added member" do
       expect(@member.name).to eq("John Smith")
     end
   end
@@ -128,7 +128,6 @@ describe Gitlab::Client do
     end
   end
 
-
   describe ".group_search" do
     before do
       stub_get("/groups?search=Group", "group_search")
@@ -144,6 +143,4 @@ describe Gitlab::Client do
       expect(@groups.last.id).to eq(8)
     end
   end
-
-
 end

data/spec/gitlab/client/issues_spec.rb

@@ -12,8 +12,8 @@ describe Gitlab::Client do
         expect(a_get("/projects/3/issues")).to have_been_made
       end
 
-      it "should return an array of project's issues" do
-        expect(@issues).to be_an Array
+      it "should return a paginated response of project's issues" do
+        expect(@issues).to be_a Gitlab::PaginatedResponse
         expect(@issues.first.project_id).to eq(3)
       end
     end
@@ -28,8 +28,8 @@ describe Gitlab::Client do
         expect(a_get("/issues")).to have_been_made
       end
 
-      it "should return an array of user's issues" do
-        expect(@issues).to be_an Array
+      it "should return a paginated response of user's issues" do
+        expect(@issues).to be_a Gitlab::PaginatedResponse
         expect(@issues.first.closed).to be_falsey
         expect(@issues.first.author.name).to eq("John Smith")
       end
@@ -60,7 +60,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_post("/projects/3/issues").
-        with(:body => {:title => 'title'})).to have_been_made
+        with(body: { title: 'title' })).to have_been_made
     end
 
     it "should return information about a created issue" do
@@ -72,12 +72,12 @@ describe Gitlab::Client do
   describe ".edit_issue" do
     before do
       stub_put("/projects/3/issues/33", "issue")
-      @issue = Gitlab.edit_issue(3, 33, :title => 'title')
+      @issue = Gitlab.edit_issue(3, 33, title: 'title')
     end
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/issues/33").
-        with(:body => {:title => 'title'})).to have_been_made
+        with(body: { title: 'title' })).to have_been_made
     end
 
     it "should return information about an edited issue" do
@@ -94,7 +94,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/issues/33").
-        with(:body => {:state_event => 'close'})).to have_been_made
+        with(body: { state_event: 'close' })).to have_been_made
     end
 
     it "should return information about an closed issue" do
@@ -111,7 +111,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/issues/33").
-        with(:body => {:state_event => 'reopen'})).to have_been_made
+        with(body: { state_event: 'reopen' })).to have_been_made
     end
 
     it "should return information about an reopened issue" do

data/spec/gitlab/client/labels_spec.rb

@@ -11,8 +11,8 @@ describe Gitlab::Client do
       expect(a_get("/projects/3/labels")).to have_been_made
     end
 
-    it "should return an array of project's labels" do
-      expect(@labels).to be_an Array
+    it "should return a paginated response of project's labels" do
+      expect(@labels).to be_a Gitlab::PaginatedResponse
       expect(@labels.first.name).to eq("Backlog")
     end
   end
@@ -25,7 +25,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_delete("/projects/3/labels").
-             with(:body => {:name => 'Backlog'})).to have_been_made
+             with(body: { name: 'Backlog' })).to have_been_made
     end
 
     it "should return information about a deleted snippet" do
@@ -36,12 +36,12 @@ describe Gitlab::Client do
   describe ".edit_label" do
     before do
       stub_put("/projects/3/labels", "label")
-      @label = Gitlab.edit_label(3, "TODO", :new_name => 'Backlog')
+      @label = Gitlab.edit_label(3, "TODO", new_name: 'Backlog')
     end
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/labels").
-             with(:body => {:name => 'TODO', :new_name => "Backlog"})).to have_been_made
+             with(body: { name: 'TODO', new_name: "Backlog" })).to have_been_made
     end
 
     it "should return information about an edited label" do
@@ -57,7 +57,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_post("/projects/3/labels").
-             with(:body => {:name => 'Backlog', :color => '#DD10AA'})).to have_been_made
+             with(body: { name: 'Backlog', color: '#DD10AA' })).to have_been_made
     end
 
     it "should return information about a created label" do

data/spec/gitlab/client/merge_requests_spec.rb

@@ -11,8 +11,8 @@ describe Gitlab::Client do
       expect(a_get("/projects/3/merge_requests")).to have_been_made
     end
 
-    it "should return an array of project's merge requests" do
-      expect(@merge_requests).to be_an Array
+    it "should return a paginated response of project's merge requests" do
+      expect(@merge_requests).to be_a Gitlab::PaginatedResponse
       expect(@merge_requests.first.project_id).to eq(3)
     end
   end
@@ -40,9 +40,9 @@ describe Gitlab::Client do
 
     it "should return information about a merge request" do
       @merge_request = Gitlab.create_merge_request(3, 'New feature',
-        :source_branch => 'api',
-        :target_branch => 'master'
-      )
+                                                   source_branch: 'api',
+                                                   target_branch: 'master'
+                                                  )
       expect(@merge_request.project_id).to eq(3)
       expect(@merge_request.assignee.name).to eq("Jack Smith")
     end
@@ -51,25 +51,25 @@ describe Gitlab::Client do
   describe ".update_merge_request" do
     before do
       stub_put("/projects/3/merge_request/2", "merge_request").
-        with(:body => {
-          :assignee_id => '1',
-          :target_branch => 'master',
-          :title => 'A different new feature'
-        })
+        with(body: {
+               assignee_id: '1',
+               target_branch: 'master',
+               title: 'A different new feature'
+             })
       @merge_request = Gitlab.update_merge_request(3, 2,
-        :assignee_id   => '1',
-        :target_branch => 'master',
-        :title         => 'A different new feature'
-      )
+                                                   assignee_id: '1',
+                                                   target_branch: 'master',
+                                                   title: 'A different new feature'
+                                                  )
     end
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/merge_request/2").
-        with(:body => {
-          :assignee_id => '1',
-          :target_branch => 'master',
-          :title => 'A different new feature'
-        })).to have_been_made
+        with(body: {
+               assignee_id: '1',
+               target_branch: 'master',
+               title: 'A different new feature'
+             })).to have_been_made
     end
 
     it "should return information about a merge request" do
@@ -81,13 +81,13 @@ describe Gitlab::Client do
   describe ".accept_merge_request" do
     before do
       stub_put("/projects/5/merge_request/42/merge", "merge_request").
-        with(:body => {:merge_commit_message => 'Nice!'})
-      @merge_request = Gitlab.accept_merge_request(5, 42, :merge_commit_message => 'Nice!')
+        with(body: { merge_commit_message: 'Nice!' })
+      @merge_request = Gitlab.accept_merge_request(5, 42, merge_commit_message: 'Nice!')
     end
 
     it "should get the correct resource" do
       expect(a_put("/projects/5/merge_request/42/merge").
-        with(:body => {:merge_commit_message => 'Nice!'})).to have_been_made
+        with(body: { merge_commit_message: 'Nice!' })).to have_been_made
     end
 
     it "should return information about merged merge request" do
@@ -107,7 +107,7 @@ describe Gitlab::Client do
     end
 
     it "should return merge request's comments" do
-      expect(@merge_request).to be_an Array
+      expect(@merge_request).to be_an Gitlab::PaginatedResponse
       expect(@merge_request.length).to eq(2)
       expect(@merge_request[0].note).to eq("this is the 1st comment on the 2merge merge request")
       expect(@merge_request[0].author.id).to eq(11)

data/spec/gitlab/client/milestones_spec.rb

@@ -11,8 +11,8 @@ describe Gitlab::Client do
       expect(a_get("/projects/3/milestones")).to have_been_made
     end
 
-    it "should return an array of project's milestones" do
-      expect(@milestones).to be_an Array
+    it "should return a paginated response of project's milestones" do
+      expect(@milestones).to be_a Gitlab::PaginatedResponse
       expect(@milestones.first.project_id).to eq(3)
     end
   end
@@ -31,19 +31,19 @@ describe Gitlab::Client do
       expect(@milestone.project_id).to eq(3)
     end
   end
-  
+
   describe ".milestone_issues" do
     before do
       stub_get("/projects/3/milestones/1/issues", "milestone_issues")
       @milestone_issues = Gitlab.milestone_issues(3, 1)
     end
-    
+
     it "should get the correct resource" do
       expect(a_get("/projects/3/milestones/1/issues")).to have_been_made
     end
 
-    it "should return an array of milestone's issues" do
-      expect(@milestone_issues).to be_an Array
+    it "should return a paginated response of milestone's issues" do
+      expect(@milestone_issues).to be_a Gitlab::PaginatedResponse
       expect(@milestone_issues.first.milestone.id).to eq(1)
     end
   end
@@ -56,7 +56,7 @@ describe Gitlab::Client do
 
     it "should get the correct resource" do
       expect(a_post("/projects/3/milestones").
-        with(:body => {:title => 'title'})).to have_been_made
+        with(body: { title: 'title' })).to have_been_made
     end
 
     it "should return information about a created milestone" do
@@ -67,12 +67,12 @@ describe Gitlab::Client do
   describe ".edit_milestone" do
     before do
       stub_put("/projects/3/milestones/33", "milestone")
-      @milestone = Gitlab.edit_milestone(3, 33, :title => 'title')
+      @milestone = Gitlab.edit_milestone(3, 33, title: 'title')
     end
 
     it "should get the correct resource" do
       expect(a_put("/projects/3/milestones/33").
-        with(:body => {:title => 'title'})).to have_been_made
+        with(body: { title: 'title' })).to have_been_made
     end
 
     it "should return information about an edited milestone" do