gitlab-triage 1.53.1 → 1.55.0

data/lib/gitlab/triage/entity_builders/summary_builder.rb

@@ -1,11 +1,14 @@
 # frozen_string_literal: true
 
 require_relative '../command_builders/text_content_builder'
+require_relative 'issue_fields'
 
 module Gitlab
   module Triage
     module EntityBuilders
       class SummaryBuilder
+        include IssueFields
+
         def initialize(
           type:, action:, resources:, network:,
           policy_spec: {}, separator: "\n")
@@ -21,6 +24,7 @@ module Gitlab
           @network = network
           @separator = separator
           @is_custom = policy_spec[:type] == 'custom'
+          init_issue_fields(action)
         end
 
         def title
@@ -53,6 +57,10 @@ module Gitlab
 
         private
 
+        def evaluate(template)
+          build_text(title_resource, template)
+        end
+
         def title_present?
           /\S+/.match?(title)
         end

data/lib/gitlab/triage/graphql_network.rb

@@ -71,14 +71,31 @@ module Gitlab
 
       private
 
+      # Builds a resource from one GraphQL node, holding only the fields the response
+      # actually carried. The query asks for a field only when the rule's conditions
+      # or actions need it, and the caller merges this over the REST resource, so a
+      # key written for a field nobody asked for would wipe what REST returned.
       def normalize(resource)
         resource
           .slice(:iid, :title, :state, :author, :merged_at, :user_notes_count, :user_discussions_count, :upvotes, :downvotes, :project_id, :web_url)
-          .merge(
-            id: extract_id_from_global_id(resource[:id]),
-            labels: [*resource.dig(:labels, :nodes)].pluck(:title),
-            assignees: [*resource.dig(:assignees, :nodes)]
-          )
+          .merge(id: extract_id_from_global_id(resource[:id]))
+          .merge(normalize_labels(resource))
+          .merge(normalize_users(resource, :assignees))
+          .merge(normalize_users(resource, :reviewers))
+      end
+
+      def normalize_labels(resource)
+        nodes = resource.dig(:labels, :nodes)
+        return {} unless nodes
+
+        { labels: nodes.pluck(:title) }
+      end
+
+      def normalize_users(resource, key)
+        nodes = resource.dig(key, :nodes)
+        return {} unless nodes
+
+        { key => nodes.map { |node| node.merge(id: extract_id_from_global_id(node[:id])) } }
       end
 
       def extract_id_from_global_id(global_id)

data/lib/gitlab/triage/graphql_queries/query_builder.rb

@@ -25,10 +25,17 @@ module Gitlab
           }
         GRAPHQL
 
-        def initialize(source_type, resource_type, conditions, graphql_only: false)
+        # Neither user field exists on every type in GitLab's GraphQL schema: Epic
+        # carries no assignees, and reviewers belong to MergeRequest alone.
+        # Selecting a field the type lacks makes the whole query fail to parse.
+        ASSIGNEES_RESOURCE_TYPES = %w[issues merge_requests].freeze
+        REVIEWERS_RESOURCE_TYPES = %w[merge_requests].freeze
+
+        def initialize(source_type, resource_type, conditions, graphql_only: false, actions: {})
           @source_type = source_type.to_s.singularize
           @resource_type = resource_type
           @conditions = conditions
+          @actions = actions || {}
           @graphql_only = graphql_only
           @resource_declarations = [
             '$source: ID!',
@@ -60,7 +67,7 @@ module Gitlab
 
         private
 
-        attr_reader :source_type, :resource_type, :conditions, :graphql_only, :resource_declarations
+        attr_reader :source_type, :resource_type, :conditions, :actions, :graphql_only, :resource_declarations
 
         def vote_attribute
           @vote_attribute ||= (conditions.dig(:votes, :attribute) || conditions.dig(:upvotes, :attribute)).to_s
@@ -75,7 +82,8 @@ module Gitlab
           if graphql_only
             fields << 'labels { nodes { title } }'
             fields << 'author { id name username }'
-            fields << 'assignees { nodes { id name username } }' if conditions.key?(:assignee_member)
+            fields << 'assignees { nodes { id name username } }' if query_assignees?
+            fields << 'reviewers { nodes { id name username } }' if query_reviewers?
             fields << 'upvotes' if vote_attribute == 'upvotes'
             fields << 'downvotes' if vote_attribute == 'downvotes'
             fields.push('draft', 'mergedAt') if resource_type == 'merge_requests'
@@ -84,6 +92,41 @@ module Gitlab
           fields
         end
 
+        def query_assignees?
+          return false unless ASSIGNEES_RESOURCE_TYPES.include?(resource_type)
+
+          conditions.key?(:assignee_member) || actions_need?(:assignees)
+        end
+
+        def query_reviewers?
+          return false unless REVIEWERS_RESOURCE_TYPES.include?(resource_type)
+
+          actions_need?(:reviewers)
+        end
+
+        # An action needs a user field when it removes from that field, or when its
+        # text carries the field's placeholder. Either way the users have to be on
+        # the resource before the action runs, so the rule's actions decide these
+        # fields as much as its conditions do. The placeholder test matches the one
+        # in TextContentBuilder#replace_placeholders, so a policy that reaches for
+        # the users through Ruby interpolation instead is not covered.
+        def actions_need?(field)
+          actions[:"remove_#{field}"].present? || action_text.include?("{{#{field}}}")
+        end
+
+        def action_text
+          @action_text ||= collect_strings(actions).join("\n")
+        end
+
+        def collect_strings(value)
+          case value
+          when String then [value]
+          when Hash then value.values.flat_map { |nested| collect_strings(nested) }
+          when Array then value.flat_map { |nested| collect_strings(nested) }
+          else []
+          end
+        end
+
         def resource_query
           condition_queries = []
 

data/lib/gitlab/triage/network.rb

@@ -41,6 +41,10 @@ module Gitlab
         restapi.patch_api(...)
       end
 
+      def put_api(...)
+        restapi.put_api(...)
+      end
+
       def delete_api(...)
         restapi.delete_api(...)
       end

data/lib/gitlab/triage/network_adapters/httparty_adapter.rb

@@ -86,6 +86,30 @@ module Gitlab
           }
         end
 
+        def put(token, url, body)
+          response = HTTParty.put(
+            url,
+            body: body.to_json,
+            headers: {
+              'User-Agent' => USER_AGENT,
+              'Content-type' => 'application/json',
+              'PRIVATE-TOKEN' => token
+            }
+          )
+
+          raise_on_unauthorized_error!(response)
+          raise_on_internal_server_error!(response)
+          raise_on_too_many_requests!(response)
+
+          tracker&.record('PUT', url)
+
+          {
+            results: response.parsed_response,
+            ratelimit_remaining: response.headers['ratelimit-remaining'].to_i,
+            ratelimit_reset_at: Time.at(response.headers['ratelimit-reset'].to_i)
+          }
+        end
+
         def delete(token, url)
           response = HTTParty.delete(
             url,

data/lib/gitlab/triage/network_adapters/test_adapter.rb

@@ -35,6 +35,14 @@ module Gitlab
             ratelimit_reset_at: Time.now
           }
         end
+
+        def put(_token, _url, _body)
+          {
+            results: {},
+            ratelimit_remaining: 600,
+            ratelimit_reset_at: Time.now
+          }
+        end
       end
     end
   end

data/lib/gitlab/triage/policies/base_policy.rb

@@ -6,6 +6,11 @@ module Gitlab
       class BasePolicy
         InvalidPolicyError = Class.new(StandardError)
 
+        UPDATE_ACTION_KEYS = %i[
+          labels remove_labels assignees reviewers remove_assignees remove_reviewers
+          milestone due_date weight health_status title status discussion_locked move
+        ].freeze
+
         attr_reader :type, :policy_spec, :resources, :network
         attr_accessor :summary
 
@@ -55,8 +60,11 @@ module Gitlab
         end
 
         def comment?
-          # The actual keys are strings
-          (actions.keys.map(&:to_sym) - [:summarize, :comment_on_summary, :delete, :issue, :work_item_status]).any?
+          actions.key?(:comment) || actions.key?(:mention)
+        end
+
+        def update?
+          (actions.keys.map(&:to_sym) & UPDATE_ACTION_KEYS).any?
         end
 
         def issue?

data/lib/gitlab/triage/policies/rule_policy.rb

@@ -9,27 +9,37 @@ module Gitlab
     module Policies
       class RulePolicy < BasePolicy
         # Build a summary from a single rule policy
+        #
+        # The builder is kept for the life of the policy. Every action that asks
+        # for it gets the same one, so the title and description templates are
+        # evaluated once for the run rather than once per action.
         def build_summary
-          action = actions.fetch(:summarize, {})
-
-          EntityBuilders::SummaryBuilder.new(
+          @build_summary ||= EntityBuilders::SummaryBuilder.new(
             type: type,
             policy_spec: policy_spec,
-            action: action,
+            action: actions.fetch(:summarize, {}),
             resources: resources,
             network: network)
         end
 
+        # The builder for one resource, kept for the life of the policy the same
+        # way build_summary is. Keyed on the resource itself, which the policy
+        # holds for the whole run, so two actions handed the same resource share
+        # one builder.
         def build_issue(resource)
-          action = actions.fetch(:issue, {})
-
-          EntityBuilders::IssueBuilder.new(
+          issue_builders[resource] ||= EntityBuilders::IssueBuilder.new(
             type: type,
             policy_spec: policy_spec,
-            action: action,
+            action: actions.fetch(:issue, {}),
             resource: resource,
             network: network)
         end
+
+        private
+
+        def issue_builders
+          @issue_builders ||= {}.compare_by_identity
+        end
       end
     end
   end

data/lib/gitlab/triage/policies/summary_policy.rb

@@ -8,7 +8,16 @@ module Gitlab
     module Policies
       class SummaryPolicy < BasePolicy
         # Build a summary from several rules policies
+        #
+        # Kept for the life of the policy, like the single-rule version, so the
+        # child summaries are built once for the run.
         def build_summary
+          @build_summary ||= build_combined_summary
+        end
+
+        private
+
+        def build_combined_summary
           action = actions[:summarize]
           child_summaries = resources.map do |inner_policy_spec, inner_resources|
             Policies::RulePolicy.new(

data/lib/gitlab/triage/rest_api_network.rb

@@ -112,6 +112,28 @@ module Gitlab
         end
       end
 
+      def put_api(url, body)
+        response = execute_with_retry(
+          exception_types: [Net::ReadTimeout, Errors::Network::InternalServerError],
+          backoff_exceptions: Errors::Network::TooManyRequests, debug: options.debug) do
+          puts Gitlab::Triage::UI.debug "put_api: #{url}" if options.debug
+
+          @adapter.put(token, url, body)
+        end
+
+        rate_limit_debug(response) if options.debug
+        rate_limit_wait(response)
+
+        results = response.delete(:results)
+
+        case results
+        when Hash
+          results.with_indifferent_access
+        else
+          raise_unexpected_response(results)
+        end
+      end
+
       def delete_api(url)
         response = execute_with_retry(
           exception_types: [Net::ReadTimeout, Errors::Network::InternalServerError],

data/lib/gitlab/triage/validators/policy_validator.rb

@@ -17,9 +17,7 @@ module Gitlab
             'Use the issues policy type for comment actions.'
 
         # Action keys Action.actions_for dispatches for work_items policies.
-        # Unlike the legacy resource types, work_items have no quick-actions
-        # comment fallback for unrecognized keys, so anything outside this
-        # list would silently do nothing - reject it up front instead.
+        # Anything outside this list would silently do nothing, so reject it up front.
         SUPPORTED_WORK_ITEM_ACTIONS = %i[labels assignees summarize comment_on_summary].freeze
 
         def initialize(resource_rules)

data/lib/gitlab/triage/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Triage
-    VERSION = '1.53.1'
+    VERSION = '1.55.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 1.53.1
+  version: 1.55.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-09-02 00:00:00.000000000 Z
+date: 2026-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -245,6 +245,7 @@ files:
 - lib/gitlab/triage/action/delete.rb
 - lib/gitlab/triage/action/issue.rb
 - lib/gitlab/triage/action/summarize.rb
+- lib/gitlab/triage/action/update.rb
 - lib/gitlab/triage/action/work_item.rb
 - lib/gitlab/triage/action/work_item_status.rb
 - lib/gitlab/triage/api_observability.rb
@@ -255,13 +256,10 @@ files:
 - lib/gitlab/triage/command_builders/base_command_builder.rb
 - lib/gitlab/triage/command_builders/cc_command_builder.rb
 - lib/gitlab/triage/command_builders/comment_command_builder.rb
-- lib/gitlab/triage/command_builders/label_command_builder.rb
-- lib/gitlab/triage/command_builders/move_command_builder.rb
-- lib/gitlab/triage/command_builders/remove_label_command_builder.rb
-- lib/gitlab/triage/command_builders/status_command_builder.rb
 - lib/gitlab/triage/command_builders/text_content_builder.rb
 - lib/gitlab/triage/engine.rb
 - lib/gitlab/triage/entity_builders/issue_builder.rb
+- lib/gitlab/triage/entity_builders/issue_fields.rb
 - lib/gitlab/triage/entity_builders/summary_builder.rb
 - lib/gitlab/triage/errors.rb
 - lib/gitlab/triage/errors/network.rb

data/lib/gitlab/triage/command_builders/label_command_builder.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'base_command_builder'
-
-module Gitlab
-  module Triage
-    module CommandBuilders
-      class LabelCommandBuilder < BaseCommandBuilder
-        def build_command
-          ensure_labels_exist!
-
-          super
-        end
-
-        private
-
-        def ensure_labels_exist!
-          items.each do |label|
-            source_id_key = resource.key?(:group_id) ? :group_id : :project_id
-            label_opts = {
-              source_id_key => resource[source_id_key],
-              name: label
-            }
-
-            unless Resource::Label.new(label_opts, network: network).exist?
-              raise Resource::Label::LabelDoesntExistError,
-                "Label `#{label}` doesn't exist!"
-            end
-          end
-        end
-
-        def slash_command_string
-          "/label"
-        end
-
-        def format_item(item)
-          "~\"#{item}\""
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/triage/command_builders/move_command_builder.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'base_command_builder'
-
-module Gitlab
-  module Triage
-    module CommandBuilders
-      class MoveCommandBuilder < BaseCommandBuilder
-        private
-
-        def slash_command_string
-          "/move"
-        end
-
-        def format_item(item)
-          item
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/triage/command_builders/remove_label_command_builder.rb

@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'base_command_builder'
-
-module Gitlab
-  module Triage
-    module CommandBuilders
-      class RemoveLabelCommandBuilder < LabelCommandBuilder
-        private
-
-        def slash_command_string
-          '/unlabel'
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/triage/command_builders/status_command_builder.rb

@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'base_command_builder'
-
-module Gitlab
-  module Triage
-    module CommandBuilders
-      class StatusCommandBuilder < BaseCommandBuilder
-        private
-
-        def separator
-          ''
-        end
-
-        def slash_command_string
-          "/"
-        end
-
-        def format_item(item)
-          item
-        end
-      end
-    end
-  end
-end