gitlab-triage 1.42.2 → 1.43.1

data/Gemfile.lock

@@ -0,0 +1,239 @@
+PATH
+  remote: .
+  specs:
+    gitlab-triage (1.43.1)
+      activesupport (>= 5.1)
+      globalid (~> 1.0, >= 1.0.1)
+      graphql (< 2.1.0)
+      graphql-client (~> 0.16)
+      httparty (~> 0.20.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (7.1.3.4)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      mutex_m
+      tzinfo (~> 2.0)
+    addressable (2.8.6)
+      public_suffix (>= 2.0.2, < 6.0)
+    ast (2.4.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.8)
+    claide (1.1.0)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    concurrent-ruby (1.3.3)
+    connection_pool (2.4.1)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    crack (1.0.0)
+      bigdecimal
+      rexml
+    danger (9.4.3)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 3.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.13)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (>= 4.0)
+      terminal-table (>= 1, < 4)
+    danger-gitlab (8.0.0)
+      danger
+      gitlab (~> 4.2, >= 4.2.0)
+    diff-lcs (1.5.1)
+    drb (2.2.1)
+    faraday (2.9.1)
+      faraday-net_http (>= 2.0, < 3.2)
+    faraday-http-cache (2.5.1)
+      faraday (>= 0.8)
+    faraday-net_http (3.1.0)
+      net-http
+    ffi (1.17.0)
+    formatador (1.1.0)
+    git (1.19.1)
+      addressable (~> 2.8)
+      rchardet (~> 1.8)
+    gitlab (4.19.0)
+      httparty (~> 0.20)
+      terminal-table (>= 1.5.1)
+    gitlab-dangerfiles (2.11.0)
+      danger (>= 8.4.5)
+      danger-gitlab (>= 8.0.0)
+    gitlab-styles (12.0.1)
+      rubocop (~> 1.62.1)
+      rubocop-factory_bot (~> 2.25.1)
+      rubocop-graphql (~> 1.5.0)
+      rubocop-performance (~> 1.20.2)
+      rubocop-rails (~> 2.24.0)
+      rubocop-rspec (~> 2.27.1)
+    globalid (1.2.1)
+      activesupport (>= 6.1)
+    graphql (2.0.31)
+      base64
+    graphql-client (0.22.0)
+      activesupport (>= 3.0)
+      graphql (>= 1.13.0)
+    guard (2.18.1)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.13.0)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    hashdiff (1.1.0)
+    httparty (0.20.0)
+      mime-types (~> 3.0)
+      multi_xml (>= 0.5.2)
+    i18n (1.14.5)
+      concurrent-ruby (~> 1.0)
+    json (2.7.2)
+    kramdown (2.4.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    language_server-protocol (3.17.0.3)
+    lefthook (1.6.16)
+    listen (3.9.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.10)
+    method_source (1.1.0)
+    mime-types (3.5.2)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2024.0305)
+    minitest (5.23.1)
+    multi_xml (0.6.0)
+    mutex_m (0.2.0)
+    nap (1.1.0)
+    nenv (0.3.0)
+    net-http (0.4.1)
+      uri
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (9.1.0)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
+    open4 (1.3.4)
+    parallel (1.25.1)
+    parser (3.3.3.0)
+      ast (~> 2.4.1)
+      racc
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (5.0.5)
+    racc (1.8.0)
+    rack (3.1.3)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.11.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (2.9.2)
+    rexml (3.3.0)
+      strscan
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.62.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
+    rubocop-capybara (2.21.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-graphql (1.5.2)
+      rubocop (>= 0.90, < 2)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.24.1)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (2.27.1)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+    ruby-progressbar (1.13.0)
+    sawyer (0.9.2)
+      addressable (>= 2.3.5)
+      faraday (>= 0.17.3, < 3)
+    shellany (0.0.1)
+    strscan (3.1.0)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.3.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.5.0)
+    uri (0.13.0)
+    webmock (3.23.1)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    yard (0.9.36)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  gitlab-dangerfiles (~> 2.11.0)
+  gitlab-styles (~> 12.0)
+  gitlab-triage!
+  guard-rspec (~> 4.7.3)
+  lefthook (~> 1.3)
+  rake (~> 13.2)
+  rspec (~> 3.8)
+  webmock (~> 3.4)
+  yard
+
+BUNDLED WITH
+   2.5.11

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/gitlab-triage

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'yaml'
 require_relative '../lib/gitlab/triage/option_parser'

data/gitlab-triage.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gitlab/triage/version'
@@ -14,6 +16,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["rubygems_mfa_required"] = 'false'
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage"
@@ -22,7 +25,7 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match?(%r{^(docs?|spec|tmp)/}) }
+    `git ls-files -z`.split("\x0").grep_v(%r{^(docs?|spec|tmp)/})
   end
   spec.bindir        = 'bin'
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
@@ -37,18 +40,15 @@ Gem::Specification.new do |spec|
   # see: https://github.com/github/graphql-client/pull/314
   # We can remove this check once PR 314 is merged and released
   spec.add_dependency 'graphql', '< 2.1.0'
-  spec.add_dependency 'httparty', '~> 0.17'
+  # Matching version of triage-ops's httparty
+  spec.add_dependency 'httparty', '~> 0.20.0'
 
   spec.add_development_dependency 'gitlab-dangerfiles', '~> 2.11.0'
-  spec.add_development_dependency 'gitlab-styles', '~> 10.0'
+  spec.add_development_dependency 'gitlab-styles', '~> 12.0'
   spec.add_development_dependency 'guard-rspec', '~> 4.7.3'
   spec.add_development_dependency 'lefthook', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.2'
+  spec.add_development_dependency 'rake', '~> 13.2'
   spec.add_development_dependency 'rspec', '~> 3.8'
-  # we do not commit the bundle lockfile, so this temporary workaround needs to be
-  # present until 2.21.3 or 2.22.x is released
-  # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/63
-  spec.add_development_dependency 'rubocop-rails', '!= 2.21.2'
   spec.add_development_dependency 'webmock', '~> 3.4'
   spec.add_development_dependency 'yard'
 end

data/lib/gitlab/triage/action/base.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Action
       class Base
         attr_reader :policy, :network
 
-        def initialize(policy:, network:)
-          @policy = policy
-          @network = network
+        def initialize(**args)
+          @policy = args[:policy]
+          @network = args[:network]
         end
       end
     end

data/lib/gitlab/triage/action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'action/summarize'
 require_relative 'action/comment'
 require_relative 'action/comment_on_summary'

data/lib/gitlab/triage/api_query_builders/base_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module APIQueryBuilders

data/lib/gitlab/triage/api_query_builders/date_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../param_builders/date_param_builder'
 require_relative 'base_query_param_builder'
 
@@ -25,7 +27,7 @@ module Gitlab
         private
 
         def build_param_name(condition_hash)
-          prefix = condition_hash[:attribute].to_s.sub(/_at\z/, '')
+          prefix = condition_hash[:attribute].to_s.delete_suffix('_at')
           suffix =
             case condition_hash[:condition].to_sym
             when :older_than

data/lib/gitlab/triage/api_query_builders/multi_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_query_param_builder'
 
 module Gitlab

data/lib/gitlab/triage/api_query_builders/single_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_query_param_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/base_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module CommandBuilders

data/lib/gitlab/triage/command_builders/cc_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/comment_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab
@@ -22,7 +24,7 @@ module Gitlab
 
             unless Resource::Label.new(label_opts, network: network).exist?
               raise Resource::Label::LabelDoesntExistError,
-                    "Label `#{label}` doesn't exist!"
+                "Label `#{label}` doesn't exist!"
             end
           end
         end

data/lib/gitlab/triage/command_builders/move_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/remove_label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/status_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/text_content_builder.rb

@@ -35,7 +35,7 @@ module Gitlab
           items: "{{items}}",
           name: "{{name}}"
         }.freeze
-        PLACEHOLDER_REGEX = /{{([\w\.]+)}}/.freeze
+        PLACEHOLDER_REGEX = /{{([\w.]+)}}/
 
         def initialize(
           items, resource: nil, network: nil, redact_confidentials: true)
@@ -69,7 +69,7 @@ module Gitlab
           SUPPORTED_PLACEHOLDERS.inject(item) do |comment, (placeholder, template)|
             next comment unless comment.include?("{{#{placeholder}}}")
 
-            path = template[/.*#{PLACEHOLDER_REGEX}.*/, 1]
+            path = template[/.*#{PLACEHOLDER_REGEX}.*/o, 1]
             attributes = extract_attributes(path)
 
             formatted_text = attributes.map do |attribute|

data/lib/gitlab/triage/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 require 'active_support/all'
 require 'active_support/inflector'
 
@@ -166,7 +168,7 @@ module Gitlab
           raise(
             ArgumentError,
             "--resource-reference can only start with '#' or '!' when --source=projects is passed " \
-            "('#{options.resource_reference}' passed)!"
+              "('#{options.resource_reference}' passed)!"
           )
         end
       end
@@ -425,7 +427,7 @@ module Gitlab
       def decorate_resources_with_graphql_data(resources, graphql_resources)
         return if graphql_resources.nil?
 
-        graphql_resources_by_id = graphql_resources.to_h { |resource| [resource[:id], resource] }
+        graphql_resources_by_id = graphql_resources.index_by { |resource| resource[:id] }
         resources.each { |resource| resource.merge!(graphql_resources_by_id[resource[:id]].to_h) }
       end
 
@@ -467,7 +469,7 @@ module Gitlab
 
             # If the :ruby condition exists then filter based off of conditions
             # else we base off of the `conditions[condition_key]`.
-            results <<
+            result =
               if condition_key.to_s == 'no_additional_labels'
                 filter.new(resource, conditions[:labels]).calculate
               elsif filter.instance_method(:initialize).arity == 2
@@ -475,6 +477,8 @@ module Gitlab
               else
                 filter.new(resource, conditions[condition_key], network).calculate
               end
+
+            results << result
           end
         end
         results.all?
@@ -580,6 +584,7 @@ module Gitlab
           else
             ['iteration_title', iteration_value]
           end
+
         APIQueryBuilders::SingleQueryParamBuilder.new(*args)
       end
 

data/lib/gitlab/triage/errors/network.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Errors

data/lib/gitlab/triage/errors.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require_relative 'errors/network'

data/lib/gitlab/triage/expand_condition/expansion.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module ExpandCondition

data/lib/gitlab/triage/expand_condition/list.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require_relative 'expansion'
 
 module Gitlab
   module Triage
     module ExpandCondition
       module List
-        PATTERN = /\{.+?,.+?\}/m.freeze
+        PATTERN = /\{.+?,.+?\}/m
 
         def self.expand(conditions)
           labels = conditions[:labels]

data/lib/gitlab/triage/expand_condition/sequence.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require_relative 'expansion'
 
 module Gitlab
   module Triage
     module ExpandCondition
       module Sequence
-        PATTERN = /\{\s*(\d+)\s*\.\.\s*(\d+)\s*\}/.freeze
+        PATTERN = /\{\s*(\d+)\s*\.\.\s*(\d+)\s*\}/
 
         def self.expand(conditions)
           labels = conditions[:labels]

data/lib/gitlab/triage/expand_condition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'expand_condition/list'
 require_relative 'expand_condition/sequence'
 

data/lib/gitlab/triage/filters/assignee_member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'member_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/author_member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'member_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/base_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 require_relative '../validators/params_validator'
 
@@ -22,9 +24,7 @@ module Gitlab
         def self.params_filter_names(params = nil)
           params ||= filter_parameters
 
-          params.map do |param|
-            param[:name]
-          end
+          params.pluck(:name)
         end
 
         def self.all_params_filter_names

data/lib/gitlab/triage/filters/branch_date_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/branch_protected_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/discussions_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/issue_date_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 require_relative '../url_builders/url_builder'
 
@@ -43,9 +45,7 @@ module Gitlab
         end
 
         def condition_value
-          members.map do |member|
-            member[:username]
-          end
+          members.pluck(:username)
         end
 
         def calculate
@@ -55,7 +55,7 @@ module Gitlab
           when :member_of
             condition_value.include?(resource_value)
           when :not_member_of
-            !condition_value.include?(resource_value)
+            condition_value.exclude?(resource_value)
           end
         end
 

data/lib/gitlab/triage/filters/merge_request_date_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/name_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/no_additional_labels_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/ruby_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 require_relative '../resource/context'
 require 'date'

data/lib/gitlab/triage/filters/votes_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab