gitlab-triage 1.42.2 → 1.43.0

data/lib/gitlab/triage/command_builders/label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab
@@ -22,7 +24,7 @@ module Gitlab
 
             unless Resource::Label.new(label_opts, network: network).exist?
               raise Resource::Label::LabelDoesntExistError,
-                    "Label `#{label}` doesn't exist!"
+                "Label `#{label}` doesn't exist!"
             end
           end
         end

data/lib/gitlab/triage/command_builders/move_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/remove_label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/status_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/text_content_builder.rb

@@ -35,7 +35,7 @@ module Gitlab
           items: "{{items}}",
           name: "{{name}}"
         }.freeze
-        PLACEHOLDER_REGEX = /{{([\w\.]+)}}/.freeze
+        PLACEHOLDER_REGEX = /{{([\w.]+)}}/
 
         def initialize(
           items, resource: nil, network: nil, redact_confidentials: true)
@@ -69,7 +69,7 @@ module Gitlab
           SUPPORTED_PLACEHOLDERS.inject(item) do |comment, (placeholder, template)|
             next comment unless comment.include?("{{#{placeholder}}}")
 
-            path = template[/.*#{PLACEHOLDER_REGEX}.*/, 1]
+            path = template[/.*#{PLACEHOLDER_REGEX}.*/o, 1]
             attributes = extract_attributes(path)
 
             formatted_text = attributes.map do |attribute|

data/lib/gitlab/triage/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 require 'active_support/all'
 require 'active_support/inflector'
 
@@ -425,7 +427,7 @@ module Gitlab
       def decorate_resources_with_graphql_data(resources, graphql_resources)
         return if graphql_resources.nil?
 
-        graphql_resources_by_id = graphql_resources.to_h { |resource| [resource[:id], resource] }
+        graphql_resources_by_id = graphql_resources.index_by { |resource| resource[:id] }
         resources.each { |resource| resource.merge!(graphql_resources_by_id[resource[:id]].to_h) }
       end
 
@@ -467,7 +469,7 @@ module Gitlab
 
             # If the :ruby condition exists then filter based off of conditions
             # else we base off of the `conditions[condition_key]`.
-            results <<
+            result =
               if condition_key.to_s == 'no_additional_labels'
                 filter.new(resource, conditions[:labels]).calculate
               elsif filter.instance_method(:initialize).arity == 2
@@ -475,6 +477,8 @@ module Gitlab
               else
                 filter.new(resource, conditions[condition_key], network).calculate
               end
+
+            results << result
           end
         end
         results.all?
@@ -580,6 +584,7 @@ module Gitlab
           else
             ['iteration_title', iteration_value]
           end
+
         APIQueryBuilders::SingleQueryParamBuilder.new(*args)
       end
 

data/lib/gitlab/triage/errors/network.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Errors

data/lib/gitlab/triage/errors.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require_relative 'errors/network'

data/lib/gitlab/triage/expand_condition/expansion.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module ExpandCondition

data/lib/gitlab/triage/expand_condition/list.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require_relative 'expansion'
 
 module Gitlab
   module Triage
     module ExpandCondition
       module List
-        PATTERN = /\{.+?,.+?\}/m.freeze
+        PATTERN = /\{.+?,.+?\}/m
 
         def self.expand(conditions)
           labels = conditions[:labels]

data/lib/gitlab/triage/expand_condition/sequence.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require_relative 'expansion'
 
 module Gitlab
   module Triage
     module ExpandCondition
       module Sequence
-        PATTERN = /\{\s*(\d+)\s*\.\.\s*(\d+)\s*\}/.freeze
+        PATTERN = /\{\s*(\d+)\s*\.\.\s*(\d+)\s*\}/
 
         def self.expand(conditions)
           labels = conditions[:labels]

data/lib/gitlab/triage/expand_condition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'expand_condition/list'
 require_relative 'expand_condition/sequence'
 

data/lib/gitlab/triage/filters/assignee_member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'member_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/author_member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'member_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/base_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 require_relative '../validators/params_validator'
 
@@ -22,9 +24,7 @@ module Gitlab
         def self.params_filter_names(params = nil)
           params ||= filter_parameters
 
-          params.map do |param|
-            param[:name]
-          end
+          params.pluck(:name)
         end
 
         def self.all_params_filter_names

data/lib/gitlab/triage/filters/branch_date_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/branch_protected_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/discussions_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/issue_date_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/member_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 require_relative '../url_builders/url_builder'
 
@@ -43,9 +45,7 @@ module Gitlab
         end
 
         def condition_value
-          members.map do |member|
-            member[:username]
-          end
+          members.pluck(:username)
         end
 
         def calculate
@@ -55,7 +55,7 @@ module Gitlab
           when :member_of
             condition_value.include?(resource_value)
           when :not_member_of
-            !condition_value.include?(resource_value)
+            condition_value.exclude?(resource_value)
           end
         end
 

data/lib/gitlab/triage/filters/merge_request_date_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/name_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/no_additional_labels_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/filters/ruby_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 require_relative '../resource/context'
 require 'date'

data/lib/gitlab/triage/filters/votes_conditions_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_conditions_filter'
 
 module Gitlab

data/lib/gitlab/triage/graphql_network.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 require 'net/protocol'
 require 'globalid'

data/lib/gitlab/triage/graphql_queries/query_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'query_param_builders/base_param_builder'
 require_relative 'query_param_builders/date_param_builder'
 require_relative 'query_param_builders/array_param_builder'
@@ -43,7 +45,7 @@ module Gitlab
 
         attr_reader :source_type, :resource_type, :conditions, :graphql_only, :resource_declarations
 
-        BASE_QUERY = <<~GRAPHQL.freeze
+        BASE_QUERY = <<~GRAPHQL
           query(%{resource_declarations}) {
             %{source_type}(fullPath: $source) {
               id

data/lib/gitlab/triage/graphql_queries/query_param_builders/array_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../utils'
 require_relative 'base_param_builder'
 

data/lib/gitlab/triage/graphql_queries/query_param_builders/base_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../utils'
 
 module Gitlab

data/lib/gitlab/triage/graphql_queries/query_param_builders/date_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../param_builders/date_param_builder'
 require_relative 'base_param_builder'
 
@@ -17,7 +19,7 @@ module Gitlab
           private
 
           def build_param_name(condition_hash)
-            prefix = condition_hash[:attribute].to_s.sub(/_at\z/, '')
+            prefix = condition_hash[:attribute].to_s.delete_suffix('_at')
             suffix =
               case condition_hash[:condition].to_sym
               when :older_than

data/lib/gitlab/triage/limiters/base_limiter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 
 module Gitlab

data/lib/gitlab/triage/limiters/date_field_limiter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_limiter'
 require_relative '../validators/limiter_validator'
 

data/lib/gitlab/triage/network.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'graphql_network'
 require_relative 'rest_api_network'
 

data/lib/gitlab/triage/network_adapters/base_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../version'
 
 module Gitlab

data/lib/gitlab/triage/network_adapters/graphql_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'graphql/client'
 require 'graphql/client/http'
 

data/lib/gitlab/triage/network_adapters/httparty_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'httparty'
 
 require_relative 'base_adapter'

data/lib/gitlab/triage/network_adapters/test_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'httparty'
 
 require_relative 'base_adapter'
@@ -26,7 +28,7 @@ module Gitlab
           }
         end
 
-        def post(token, url, body)
+        def post(_token, _url, _body)
           {
             results: {},
             ratelimit_remaining: 600,

data/lib/gitlab/triage/option_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # frozen_string_literal
 
 require 'optparse'

data/lib/gitlab/triage/options.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     Options = Struct.new(

data/lib/gitlab/triage/param_builders/date_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../validators/params_validator'
 
 module Gitlab

data/lib/gitlab/triage/resource/base.rb

@@ -9,6 +9,7 @@ module Gitlab
         attr_reader :resource, :parent
 
         CONFIDENTIAL_TEXT = '(confidential)'
+        SOURCE_ERROR_MSG = 'This resource is missing project_id and group_id and unable to parse source.'
 
         def self.define_field(name, &block)
           define_method(name) do
@@ -94,6 +95,8 @@ module Gitlab
             'projects'
           elsif resource[:group_id]
             'groups'
+          else
+            raise ArgumentError, SOURCE_ERROR_MSG
           end
         end
       end

data/lib/gitlab/triage/resource/instance_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base'
 
 module Gitlab

data/lib/gitlab/triage/resource/milestone.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base'
 require 'date'
 require 'time'

data/lib/gitlab/triage/rest_api_network.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 require 'net/protocol'
 

data/lib/gitlab/triage/retryable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Retryable

data/lib/gitlab/triage/ui.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     class UI

data/lib/gitlab/triage/url_builders/url_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 module Gitlab
   module Triage
     module UrlBuilders

data/lib/gitlab/triage/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Utils

data/lib/gitlab/triage/validators/limiter_validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'params_validator'
 
 module Gitlab
@@ -6,9 +8,7 @@ module Gitlab
       private
 
       def params_limiter_names
-        @parameter_definitions.map do |param|
-          param[:name]
-        end
+        @parameter_definitions.pluck(:name)
       end
 
       def validate_required_parameters(value)

data/lib/gitlab/triage/validators/params_validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     class ParamsValidator
@@ -33,9 +35,7 @@ module Gitlab
 
       def validate_parameter_content(value)
         @parameter_definitions.each do |param|
-          if param[:values]
-            raise InvalidParameter, "#{param[:name]} must be one of #{param[:values].join(',')}" unless param[:values].include?(value[param[:name]])
-          end
+          raise InvalidParameter, "#{param[:name]} must be one of #{param[:values].join(',')}" if param[:values]&.exclude?(value[param[:name]])
         end
       end
     end

data/lib/gitlab/triage/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Triage
-    VERSION = '1.42.2'
+    VERSION = '1.43.0'
   end
 end

data/lib/gitlab/triage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gitlab/triage/version'
 
 module Gitlab

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 1.42.2
+  version: 1.43.0
 platform: ruby
 authors:
 - GitLab
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-12 00:00:00.000000000 Z
+date: 2024-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,14 +148,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.2'
+        version: '13.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.2'
+        version: '13.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -212,7 +212,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - gitlab_rubygems@gitlab.com
 executables:
@@ -221,6 +221,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".git-blame-ignore-revs"
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".gitlab/CODEOWNERS"
@@ -332,10 +333,11 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
+  rubygems_mfa_required: 'false'
   homepage_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage
   source_code_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage
   changelog_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -350,8 +352,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.27
+signing_key:
 specification_version: 4
 summary: GitLab triage automation project.
 test_files: []