gitlab-triage 1.42.1 → 1.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b58096f8556f0fceef5cb4ad808627438bbbad5962902ac4cebfdf01b20d28b
-  data.tar.gz: 1678304df863fa81f4977551d1e204efbbeb1befd8ab0a829feb51c5b843ddc0
+  metadata.gz: 95d1d38e50b3032593baffe5e3122da139f542294529cadaaffa5e2861d0a428
+  data.tar.gz: 83ac90f1c5815c5a39a6cb5d3d84b34112a1a3a72f2dd9a9481291bc171648c3
 SHA512:
-  metadata.gz: ea8a58b37b831b5ed2bc4194358696b55d63bb4250a1f0b8683437d68a8937660017bc497a7c6dc77090593bcb30f603f695a64472ecc4400264513be1bf53df
-  data.tar.gz: 8a636467bd94cf03817d97810a5cc082946631586f00c6e82d4ef1f83d7eda5809e113ac6edb61541e9db56333a9d01d67fb49b581dfdc1f36ef18b6bd5aa555
+  metadata.gz: 8d0aef0429e6892959468c199b0bddbb18ecf02bf864ee038f59b01f35e779a200724e8841b3f603add6267a5a6b3c7746520d10bc48d77c2a6a025e5d3ddaa2
+  data.tar.gz: 70ea6376e7855ce5ac2207d0f0dc779d8d4e32eb800192c5d3ec8cbfa546425797087525c6a281bfd5513b4d8d4619cf6a81e7fd2e59b7c48d77972653ca5b37

data/.git-blame-ignore-revs

@@ -0,0 +1,43 @@
+# This file contains revisions to be ignored by git blame.
+# These revisions are expected to be formatting-only changes.
+#
+# Calling `git blame --ignore-revs-file .git-blame-ignore-revs` will
+# tell git blame to ignore changes made by these revisions when
+# assigning blame, as if the change never happened.
+#
+# You can enable this as a default for your local repository by running
+# `git config blame.ignoreRevsFile .git-blame-ignore-revs`
+# This will probably be automatically picked by your IDE
+# (VSCode+GitLens and JetBrains products are confirmed to this)
+#
+# Important: if you are switching to the branch without this file,
+# `git blame` will fail with an error
+#
+# Guidelines:
+# - Only large automated refactorings are expected to be included in this file.
+#   Do not add a new revision just because it is deemed trivial or unimportant
+# - When adding a single revision, use inline comments to link relevant issues and merge requests
+#   Example:
+# 
+# # d4a8b7307acc2dc8a8833ccfa65426ad28b3ffc9 # https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/60
+#
+# - When adding multiple revisions precede each addition (this could be multiple revisions) with a link to
+#   line with word START and link to relevant issue/MR/epic and conclude with line END and link to the
+#   same issue/MR/epic
+#   Example:
+#   # START https://gitlab.com/gitlab-org/issues/12345
+#   6f0bd2d8a1e6cd2e794cd39976e9756e0c85ac66
+#   d53974df11dbc22cbea9dc7dcbc9896c25979a27
+#   ... <rest of the list>
+#   # END https://gitlab.com/gitlab-org/issues/12345
+# - Please append new lines to the end of the file, no matter of real chronological
+#   order of revisions
+# - Since this is using hashes for reformatting it might be a good idea to update
+#   this file in separate MR when relevant changes already landed in master. By
+#   utilizing this manner you will be safe from random rebase/squash issues
+# - Only put full 40-character hashes on this list
+
+# START https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/issues/340
+49e0b4f890c4f38ae586c6b1bdca5ff3b0c04af1
+aba491f68f0d4a6c088deb6cb281755d6c7a7f0b
+# END https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/issues/340

data/.gitlab-ci.yml

@@ -5,9 +5,10 @@ stages:
   - deploy
 
 default:
-  image: ruby:3.0
   tags:
     - gitlab-org
+ 
+.ruby-cache: &ruby-cache
   cache:
     key:
       files:
@@ -17,9 +18,13 @@ default:
       - vendor/ruby
       - Gemfile.lock
     policy: pull
+
+.use-ruby:
+  image: ruby:3.2
+  <<: *ruby-cache
   before_script:
     - ruby --version
-    - gem install bundler --no-document --version 2.0.2
+    - gem install bundler --no-document
     - bundle --version
     - bundle install --jobs $(nproc) --path=vendor --retry 3 --quiet
     - bundle check
@@ -33,23 +38,11 @@ workflow:
     # For tags, create a pipeline.
     - if: '$CI_COMMIT_TAG'
 
-.use-docker-in-docker:
-  image: docker:${DOCKER_VERSION}
-  services:
-    - docker:${DOCKER_VERSION}-dind
-  variables:
-    DOCKER_VERSION: "19.03.0"
-    DOCKER_DRIVER: overlay2
-    DOCKER_HOST: tcp://docker:2375
-    DOCKER_TLS_CERTDIR: ""
-  tags:
-    # See https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/7019 for tag descriptions
-    - gitlab-org-docker
-
 ###################
 ## Prepare stage ##
 ###################
 setup-test-env:
+  extends: .use-ruby
   stage: prepare
   script:
     - echo "Setup done!"
@@ -63,6 +56,7 @@ setup-test-env:
 ## Test stage ##
 ################
 rubocop:
+  extends: .use-ruby
   stage: test
   needs: ["setup-test-env"]
   dependencies: ["setup-test-env"]
@@ -73,43 +67,26 @@ rubocop:
     paths:
       - .cache/rubocop_cache/
 
-# We need to copy this job's definition from the Code-Quality.gitlab-ci.yml
-# template because `only` is set without `refs`, so it takes precedence over default workflow rules.
-# See https://gitlab.com/gitlab-org/gitlab-ce/issues/66767.
-code_quality:
-  extends: .use-docker-in-docker
-  stage: test
-  allow_failure: true
-  variables:
-    DOCKER_TLS_CERTDIR: ""
-  before_script: []
-  script:
-    - |
-      if ! docker info &>/dev/null; then
-        if [ -z "$DOCKER_HOST" -a "$KUBERNETES_PORT" ]; then
-          export DOCKER_HOST='tcp://localhost:2375'
-        fi
-      fi
-    - docker run
-        --env SOURCE_CODE="$PWD"
-        --volume "$PWD":/code
-        --volume /var/run/docker.sock:/var/run/docker.sock
-        "registry.gitlab.com/gitlab-org/security-products/codequality:12-0-stable" /code
-  artifacts:
-    reports:
-      codequality: gl-code-quality-report.json
-    expire_in: 1 week
-
 specs:
+  extends: .use-ruby
   needs: ["setup-test-env"]
   stage: test
   script:
     - bundle exec rake spec
+  image: $RUBY_IMAGE
+  parallel:
+    matrix:
+      - RUBY_IMAGE:
+        - ruby:3.0
+        - ruby:3.1
+        - ruby:3.2
+        - ruby:3.3
 
 ##################
 ## Triage stage ##
 ##################
 dry-run:gitlab-triage:
+  extends: .use-ruby
   needs: ["setup-test-env"]
   stage: triage
   script:
@@ -129,11 +106,35 @@ dry-run:custom:
       allow_failure: true
 
 include:
-  - template: Security/Dependency-Scanning.gitlab-ci.yml
-  - template: Security/License-Scanning.gitlab-ci.yml
-  - template: Security/SAST.gitlab-ci.yml
-  - template: Security/Secret-Detection.gitlab-ci.yml
-  - project: 'gitlab-org/quality/pipeline-common'
-    file:
-      - '/ci/danger-review.yml'
-      - '/ci/gem-release.yml'
+  - component: gitlab.com/components/code-quality/code-quality@~latest
+  - component: gitlab.com/components/sast/sast@~latest
+  - component: gitlab.com/components/secret-detection/secret-detection@~latest
+  - component: gitlab.com/gitlab-org/components/danger-review/danger-review@~latest
+  - component: gitlab.com/gitlab-org/components/gem-release/gem-release@~latest
+  - template: Jobs/Dependency-Scanning.gitlab-ci.yml
+
+.component-general-rules: &component-general-rules
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+
+code_quality:
+  # We explicitly set dependencies here as the component sets them to []
+  # This allows us to get the cache from the setup job that includes the Gemfile.lock
+  dependencies: ["setup-test-env"]
+  tags:
+    - gitlab-org-docker
+  # We explicitly override allow_failure here as the component sets it to true
+  # Can be moved to a component input after: https://gitlab.com/components/code-quality/-/merge_requests/8
+  allow_failure: false
+  <<: *ruby-cache
+  <<: *component-general-rules
+
+semgrep-sast:
+  <<: *component-general-rules
+
+gemnasium-dependency_scanning:
+  <<: *component-general-rules
+
+secret_detection:
+  <<: *component-general-rules

data/.rubocop.yml

@@ -12,11 +12,42 @@ AllCops:
     - 'tmp/**/*'
   CacheRootDirectory: tmp
 
-Rails/Output:
-  Enabled: false
-
 Layout/LineLength:
   Max: 152
 
 Style/SingleArgumentDig:
   Enabled: false
+
+GitlabSecurity/PublicSend:
+  Enabled: true
+  Exclude:
+    # FIXME: this is not an entirely good practice and we should aim to correct these!
+    # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/issues/342
+    - 'spec/**/*.rb'
+
+# rationale: no easy autocorrection, makes the specs fail.
+# should be possible to fix with some additional work, but
+# the gains do not seem to be worth the effort.
+RSpec/Rails/TravelAround:
+  Enabled: false
+
+# rationale: we upload via CI - so this is currently not supported in our workflow.
+# context: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/merge_requests/313#note_1601520801
+Gemspec/RequireMFA:
+  Enabled: false
+
+# rationale: it's okay to have empty blocks in specs
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/**/*.rb'
+
+# rationale: these files do not seem overly harmful to violate this rule,
+# but overall, seems good to keep enabled
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/integration/select_issues_by_weight_spec.rb'
+    - 'spec/integration/select_merge_requests_by_source_branch_spec.rb'
+
+# rationale: Maybe we should? For now, let's keep it disabled and revisit at a later point.
+Rails/Output:
+  Enabled: false

data/.rubocop_todo.yml

@@ -1,83 +1,65 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2022-05-26 15:15:19 UTC using RuboCop version 0.93.1.
+# `rubocop --auto-gen-config --exclude-limit 10000`
+# on 2024-04-16 16:23:46 UTC using RuboCop version 1.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 43
+# Offense count: 67
 CodeReuse/ActiveRecord:
   Exclude:
     - 'lib/gitlab/triage/engine.rb'
+    - 'lib/gitlab/triage/filters/base_conditions_filter.rb'
+    - 'lib/gitlab/triage/filters/member_conditions_filter.rb'
     - 'lib/gitlab/triage/graphql_network.rb'
+    - 'lib/gitlab/triage/validators/limiter_validator.rb'
+    - 'spec/gitlab/triage/action_spec.rb'
     - 'spec/gitlab/triage/engine_spec.rb'
     - 'spec/gitlab/triage/graphql_network_spec.rb'
     - 'spec/gitlab/triage/network_adapters/graphql_adapter_spec.rb'
-    - 'spec/gitlab/triage/rest_api_network_spec.rb'
     - 'spec/gitlab/triage/policies/rule_policy_spec.rb'
     - 'spec/gitlab/triage/resource/label_spec.rb'
-    - 'spec/support/expect_next_instance_of.rb'
+    - 'spec/gitlab/triage/rest_api_network_spec.rb'
     - 'spec/support/shared_examples/issuable_shared_examples.rb'
     - 'spec/support/shared_examples/label_command_shared_examples.rb'
     - 'spec/support/stub_api.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Cop/LineBreakAroundConditionalBlock:
+Lint/ToEnumArguments:
   Exclude:
     - 'lib/gitlab/triage/engine.rb'
 
-# Offense count: 1
-# Configuration parameters: Include.
-# Include: **/*.gemspec
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'gitlab-triage.gemspec'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/NonDeterministicRequireOrder:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Configuration parameters: IgnoredMethods.
-Metrics/AbcSize:
-  Max: 57
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Performance/ConstantRegexp:
-  Exclude:
-    - 'lib/gitlab/triage/command_builders/text_content_builder.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: SafeMultiline.
-Performance/DeleteSuffix:
-  Exclude:
-    - 'lib/gitlab/triage/api_query_builders/date_query_param_builder.rb'
-    - 'lib/gitlab/triage/graphql_queries/query_param_builders/date_param_builder.rb'
-
-# Offense count: 5
+# Offense count: 4
 Performance/MethodObjectAsBlock:
   Exclude:
     - 'lib/gitlab/triage/engine.rb'
-    - 'lib/gitlab/triage/entity_builders/issue_builder.rb'
     - 'lib/gitlab/triage/expand_condition.rb'
     - 'lib/gitlab/triage/expand_condition/expansion.rb'
     - 'lib/gitlab/triage/limiters/date_field_limiter.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
-RSpec/EmptyLineAfterLetBlock:
-  Enabled: false
-
-# Offense count: 93
+# Offense count: 167
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
-  Max: 12
+  Max: 10
+
+# Offense count: 10
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/integration/filter_by_votes_spec.rb'
+    - 'spec/integration/generate_summary_spec.rb'
+    - 'spec/integration/no_newline_in_titles_spec.rb'
+    - 'spec/integration/redact_confidentials_spec.rb'
+    - 'spec/integration/summary_policies_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/SpecFilePathSuffix:
+  Exclude:
+    - 'spec/integration/issue_action_policy.rb'
 
 # Offense count: 12
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
@@ -89,57 +71,11 @@ RSpec/VerifiedDoubles:
     - 'spec/support/shared_examples/label_command_shared_examples.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Rails/IndexBy:
+Style/DocumentDynamicEvalDefinition:
   Exclude:
-    - 'lib/gitlab/triage/engine.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Rails/NegateInclude:
-  Exclude:
-    - 'lib/gitlab/triage/filters/member_conditions_filter.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Rails/Pluck:
-  Exclude:
-    - 'lib/gitlab/triage/filters/base_conditions_filter.rb'
-    - 'lib/gitlab/triage/filters/member_conditions_filter.rb'
-    - 'lib/gitlab/triage/validators/limiter_validator.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/ArrayCoercion:
-  Exclude:
-    - 'lib/gitlab/triage/graphql_network.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/ExplicitBlockArgument:
-  Exclude:
-    - 'spec/support/expect_next_instance_of.rb'
-
-# Offense count: 115
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
+    - 'lib/gitlab/triage/resource/context.rb'
 
 # Offense count: 5
 Style/OpenStructUse:
   Exclude:
     - 'spec/gitlab/triage/network_adapters/httparty_adapter_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RedundantRegexpEscape:
-  Exclude:
-    - 'lib/gitlab/triage/command_builders/text_content_builder.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowModifier.
-Style/SoleNestedConditional:
-  Exclude:
-    - 'lib/gitlab/triage/validators/params_validator.rb'

data/.ruby-version

@@ -1 +1 @@
-3.0.5
+3.2.3

data/.tool-versions

@@ -1 +1 @@
-ruby 3.0.5
+ruby 3.2.3

data/Gemfile

@@ -1,16 +1,6 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in gitlab-rubocop.gemspec
 gemspec
-
-gem "yard"
-
-group :test do
-  gem 'gitlab-styles', '~> 7.0'
-end
-
-group :development, :test, :danger do
-  gem 'gitlab-dangerfiles', '~> 2.11.0', require: false
-  gem 'guard-rspec', '~> 4.7.3', require: false
-  gem 'lefthook', '~> 1.3', require: false
-end

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/gitlab-triage

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'yaml'
 require_relative '../lib/gitlab/triage/option_parser'

data/gitlab-triage.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gitlab/triage/version'
@@ -14,6 +16,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["rubygems_mfa_required"] = 'false'
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage"
@@ -22,7 +25,7 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match?(%r{^(docs?|spec|tmp)/}) }
+    `git ls-files -z`.split("\x0").grep_v(%r{^(docs?|spec|tmp)/})
   end
   spec.bindir        = 'bin'
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
@@ -39,9 +42,16 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'graphql', '< 2.1.0'
   spec.add_dependency 'httparty', '~> 0.17'
 
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'gitlab-styles', '~> 2.8'
-  spec.add_development_dependency 'rake', '~> 10.2'
+  spec.add_development_dependency 'gitlab-dangerfiles', '~> 2.11.0'
+  spec.add_development_dependency 'gitlab-styles', '~> 10.0'
+  spec.add_development_dependency 'guard-rspec', '~> 4.7.3'
+  spec.add_development_dependency 'lefthook', '~> 1.3'
+  spec.add_development_dependency 'rake', '~> 13.2'
   spec.add_development_dependency 'rspec', '~> 3.8'
+  # we do not commit the bundle lockfile, so this temporary workaround needs to be
+  # present until 2.21.3 or 2.22.x is released
+  # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/63
+  spec.add_development_dependency 'rubocop-rails', '!= 2.21.2'
   spec.add_development_dependency 'webmock', '~> 3.4'
+  spec.add_development_dependency 'yard'
 end

data/lib/gitlab/triage/action/base.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module Action
       class Base
         attr_reader :policy, :network
 
-        def initialize(policy:, network:)
-          @policy = policy
-          @network = network
+        def initialize(**args)
+          @policy = args[:policy]
+          @network = args[:network]
         end
       end
     end

data/lib/gitlab/triage/action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'action/summarize'
 require_relative 'action/comment'
 require_relative 'action/comment_on_summary'

data/lib/gitlab/triage/api_query_builders/base_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module APIQueryBuilders

data/lib/gitlab/triage/api_query_builders/date_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../param_builders/date_param_builder'
 require_relative 'base_query_param_builder'
 
@@ -25,7 +27,7 @@ module Gitlab
         private
 
         def build_param_name(condition_hash)
-          prefix = condition_hash[:attribute].to_s.sub(/_at\z/, '')
+          prefix = condition_hash[:attribute].to_s.delete_suffix('_at')
           suffix =
             case condition_hash[:condition].to_sym
             when :older_than

data/lib/gitlab/triage/api_query_builders/multi_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_query_param_builder'
 
 module Gitlab

data/lib/gitlab/triage/api_query_builders/single_query_param_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_query_param_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/base_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Triage
     module CommandBuilders

data/lib/gitlab/triage/command_builders/cc_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/comment_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab
@@ -22,7 +24,7 @@ module Gitlab
 
             unless Resource::Label.new(label_opts, network: network).exist?
               raise Resource::Label::LabelDoesntExistError,
-                    "Label `#{label}` doesn't exist!"
+                "Label `#{label}` doesn't exist!"
             end
           end
         end

data/lib/gitlab/triage/command_builders/move_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/remove_label_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/status_command_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base_command_builder'
 
 module Gitlab

data/lib/gitlab/triage/command_builders/text_content_builder.rb

@@ -35,7 +35,7 @@ module Gitlab
           items: "{{items}}",
           name: "{{name}}"
         }.freeze
-        PLACEHOLDER_REGEX = /{{([\w\.]+)}}/.freeze
+        PLACEHOLDER_REGEX = /{{([\w.]+)}}/
 
         def initialize(
           items, resource: nil, network: nil, redact_confidentials: true)
@@ -69,7 +69,7 @@ module Gitlab
           SUPPORTED_PLACEHOLDERS.inject(item) do |comment, (placeholder, template)|
             next comment unless comment.include?("{{#{placeholder}}}")
 
-            path = template[/.*#{PLACEHOLDER_REGEX}.*/, 1]
+            path = template[/.*#{PLACEHOLDER_REGEX}.*/o, 1]
             attributes = extract_attributes(path)
 
             formatted_text = attributes.map do |attribute|