gitlab-triage 1.10.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ac5f595e5dffde9a3135eec982d931510615517b7512168291944252cd6f2ed
-  data.tar.gz: 3336902a5864b878ad60091442fd2047eeef620981ae4d8e40c73c0ca2394cb1
+  metadata.gz: 817c2b22f9f62ba6ec09e4441aea29dd4f7ae639bd8b49888236ff11a27e33a9
+  data.tar.gz: fbd6f4fff1adc6e99e271d438fe7ced46cc40db7a83c59ae985a156d9f57a414
 SHA512:
-  metadata.gz: a5669015087540e47ea682b07a3282a7fbb49e3206cb635e71086fa180f82084908dc964c659d7faeca8e0a8cabe83a0b296e7835ea161f43c26887aa5066ec6
-  data.tar.gz: b6f348f4d5adf7e7685f97d10fdaf0545e0952a91ee74b0997cdcba10b7a0c0a9823ed14dde92188f749731fd7b870cc8700d3fbc7733128b219a51287504517
+  metadata.gz: bab557c9169e861a96fce7b471080194943da6753541860ec3bb01d8790b43bc1c604a59d8fa3e73a0e4dd8dac735dec98746ff2e8a6c97d78d3ee7d87681fa1
+  data.tar.gz: 76a6ce14b74488879f14ca43bb0dcbd1b8d2f22e55d1ce7ee7b4cca5efd42715f462eac219c9f5f40de2a81060aa0c4e58e87db8dd3f1e90788a74c1c61b8f2c

data/.gitlab-ci.yml

@@ -2,7 +2,7 @@ stages:
   - prepare
   - test
   - triage
-  - release
+  - deploy
 
 default:
   image: ruby:2.7
@@ -38,6 +38,7 @@ workflow:
   services:
     - docker:${DOCKER_VERSION}-dind
   variables:
+    DOCKER_VERSION: "19.03.0"
     DOCKER_DRIVER: overlay2
     DOCKER_HOST: tcp://docker:2375
     DOCKER_TLS_CERTDIR: ""
@@ -118,7 +119,7 @@ dry-run:gitlab-triage:
     - gitlab-triage --version
     - gitlab-triage --help
     - gitlab-triage --init
-    - gitlab-triage --dry-run --debug --token $API_TOKEN --source-id $CI_PROJECT_PATH
+    - gitlab-triage --dry-run --debug --token $GITLAB_API_TOKEN --source-id $CI_PROJECT_PATH
 
 # This job requires allows to override the `CI_PROJECT_PATH` variable when triggered.
 dry-run:custom:
@@ -127,26 +128,6 @@ dry-run:custom:
     - when: manual
       allow_failure: true
 
-###################
-## Release stage ##
-###################
-release:
-  stage: release
-  rules:
-    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "push"'
-      changes: ["lib/gitlab/triage/version.rb"]
-    - if: '$CI_MERGE_REQUEST_TITLE =~ /RELEASE/'
-      when: manual
-  before_script: []
-  script:
-    - version=$(ruby -r ./lib/gitlab/triage/version -e 'puts Gitlab::Triage::VERSION' | tr -d "\n")
-    - tag="v${version}"
-    - message="Version ${version}."
-    # TODO: Add release notes from the Release MR?
-    - 'curl --request POST --header "PRIVATE-TOKEN: ${API_TOKEN}" -d "tag_name=${tag}" -d "ref=${CI_COMMIT_SHA}" -d "message=${message}" "${CI_API_V4_URL}/projects/${CI_PROJECT_ID}/repository/tags"'
-    - gem build gitlab-triage.gemspec
-    - gem push "gitlab-triage-${version}.gem"
-  artifacts:
-    paths:
-      - gitlab-triage*.gem
-    expire_in: 30 days
+include:
+  - project: 'gitlab-org/quality/pipeline-common'
+    file: '/ci/gem-release.yml'

data/.gitlab/merge_request_templates/Release.md

@@ -7,7 +7,7 @@ with the latest commit from https://gitlab.com/gitlab-org/gitlab-triage/commits/
 <!-- Keep the sections order but remove the empty sections -->
 
 ```markdown
-### New scenarios and scenario updates
+### New features and features updates
 
 - !aaa <Title of the aaa MR>.
 
@@ -19,7 +19,7 @@ with the latest commit from https://gitlab.com/gitlab-org/gitlab-triage/commits/
 
 - !ccc <Title of the ccc MR>.
 
-### Other changes (CI, backstage)
+### Other changes (tooling, technical debt)
 
 - !ddd <Title of the ddd MR>.
 ```

data/Guardfile

@@ -24,7 +24,7 @@
 #  * zeus: 'zeus rspec' (requires the server to be started separately)
 #  * 'just' rspec: 'rspec'
 
-guard :rspec, cmd: "bundle exec rspec" do
+guard :rspec, cmd: "bundle exec rspec -f doc" do
   require "guard/rspec/dsl"
   dsl = Guard::RSpec::Dsl.new(self)
 

data/README.md

@@ -141,6 +141,8 @@ Available condition types:
 - [`assignee_member` condition](#assignee-member-condition)
 - [`source_branch` condition](#source-branch-condition)
 - [`target_branch` condition](#target-branch-condition)
+- [`weight` condition](#weight-condition)
+- [`discussions` condition](#discussions-condition)
 - [`ruby` condition](#ruby-condition)
 
 ##### Date condition
@@ -467,6 +469,44 @@ conditions:
   target_branch: 'master'
 ```
 
+##### Weight condition
+
+Accepts a string per the [API documentation](https://docs.gitlab.com/ee/api/issues.html#list-issues).
+This condition is only applicable for issues (not merge requests).
+
+| State           | Type    | Value     |
+| ---------       | ----    | ------    |
+| Any weight      | string  | `Any`  |
+| No weight       | string  | `None`  |
+| Specific weight | integer  | integer |
+
+Example:
+
+```yml
+conditions:
+  weight: Any
+```
+
+##### Discussions condition
+
+Accepts a hash of fields.
+
+| Field           | Type    | Values                              | Required  |
+| ---------       | ----    | ----                                | --------  |
+| `attribute`     | string  | `threads`, `notes`                  | yes       |
+| `condition`     | string  | `less_than`, `greater_than`         | yes       |
+| `threshold`     | integer | integer                             | yes       |
+
+Example:
+
+```yml
+conditions:
+  discussions:
+    attribute: threads
+    condition: greater_than
+    threshold: 15
+```
+
 ##### Ruby condition
 
 This condition allows users to write a Ruby expression to be evaluated for
@@ -552,6 +592,10 @@ Adds a number of labels to the resource.
 
 Accepts an array of strings. Each element is the name of a label to add.
 
+If any of the labels doesn't exist, the automation will stop immediately so
+that if a label is renamed or deleted, you'll have to explicitly update or remove
+it in your policy file.
+
 Example:
 
 ```yml
@@ -567,6 +611,10 @@ Removes a number of labels from the resource.
 
 Accepts an array of strings. Each element is the name of a label to remove.
 
+If any of the labels doesn't exist, the automation will stop immediately so
+that if a label is renamed or deleted, you'll have to explicitly update or remove
+it in your policy file.
+
 Example:
 
 ```yml
@@ -1016,22 +1064,22 @@ Usage: gitlab-triage [options]
 Triaging against a specific project:
 
 ```
-gitlab-triage --dry-run --token $API_TOKEN --source-id gitlab-org/triage
+gitlab-triage --dry-run --token $GITLAB_API_TOKEN --source-id gitlab-org/triage
 ```
 
 Triaging against a whole group:
 
 ```
-gitlab-triage --dry-run --token $API_TOKEN --source-id gitlab-org --source groups
+gitlab-triage --dry-run --token $GITLAB_API_TOKEN --source-id gitlab-org --source groups
 ```
 
 Triaging against an entire instance:
 
 ```
-gitlab-triage --dry-run --token $API_TOKEN --all-projects
+gitlab-triage --dry-run --token $GITLAB_API_TOKEN --all-projects
 ```
 
-> **Note:** The `--all-projects` option will process all resources for all projects visible to the specified `$API_TOKEN`
+> **Note:** The `--all-projects` option will process all resources for all projects visible to the specified `$GITLAB_API_TOKEN`
 
 #### Running on GitLab CI pipeline
 
@@ -1042,7 +1090,7 @@ run:triage:triage:
   stage: triage
   script:
     - gem install gitlab-triage
-    - gitlab-triage --token $API_TOKEN --source-id $CI_PROJECT_PATH
+    - gitlab-triage --token $GITLAB_API_TOKEN --source-id $CI_PROJECT_PATH
   only:
     - schedules
 ```
@@ -1056,7 +1104,7 @@ Yes, you can override the host url using the following options:
 ##### CLI
 
 ```
-gitlab-triage --dry-run --token $API_TOKEN --source-id gitlab-org/triage --host-url https://gitlab.host.com
+gitlab-triage --dry-run --token $GITLAB_API_TOKEN --source-id gitlab-org/triage --host-url https://gitlab.host.com
 ```
 
 ##### Policy file
@@ -1093,7 +1141,7 @@ Gitlab::Triage::Resource::Context.include MyPlugin
 And then run it with:
 
 ```shell
-gitlab-triage -r ./my_plugin.rb --token $API_TOKEN --source-id gitlab-org/triage
+gitlab-triage -r ./my_plugin.rb --token $GITLAB_API_TOKEN --source-id gitlab-org/triage
 ```
 
 This allows you to use `has_severity_label?` in the Ruby condition:

data/gitlab-triage.gemspec

@@ -20,6 +20,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'activesupport', '~> 5.1'
+  spec.add_dependency 'globalid', '~> 0.4'
+  spec.add_dependency 'graphql-client', '~> 0.16'
   spec.add_dependency 'httparty', '~> 0.17'
 
   spec.add_development_dependency 'bundler'

data/lib/gitlab/triage/action/comment.rb

@@ -41,8 +41,8 @@ module Gitlab
           CommandBuilders::CommentCommandBuilder.new(
             [
               CommandBuilders::TextContentBuilder.new(policy.actions[:comment], resource: resource, network: network).build_command,
-              CommandBuilders::LabelCommandBuilder.new(policy.actions[:labels]).build_command,
-              CommandBuilders::RemoveLabelCommandBuilder.new(policy.actions[:remove_labels]).build_command,
+              CommandBuilders::LabelCommandBuilder.new(policy.actions[:labels], resource: resource, network: network).build_command,
+              CommandBuilders::RemoveLabelCommandBuilder.new(policy.actions[:remove_labels], resource: resource, network: network).build_command,
               CommandBuilders::CcCommandBuilder.new(policy.actions[:mention]).build_command,
               CommandBuilders::MoveCommandBuilder.new(policy.actions[:move]).build_command,
               CommandBuilders::StatusCommandBuilder.new(policy.actions[:status]).build_command

data/lib/gitlab/triage/api_query_builders/date_query_param_builder.rb

@@ -49,7 +49,7 @@ module Gitlab
         end
 
         def param_name
-          prefix = attribute.delete_suffix('_at')
+          prefix = attribute.sub(/_at\z/, '')
           suffix =
             case interval_condition
             when :older_than

data/lib/gitlab/triage/command_builders/base_command_builder.rb

@@ -2,13 +2,15 @@ module Gitlab
   module Triage
     module CommandBuilders
       class BaseCommandBuilder
-        def initialize(items)
+        def initialize(items, resource: nil, network: nil)
           @items = Array.wrap(items)
           @items.delete('')
+          @resource = resource&.with_indifferent_access
+          @network = network
         end
 
         def build_command
-          if @items.any?
+          if items.any?
             [slash_command_string, content_string].compact.join(separator)
           else
             ""
@@ -17,6 +19,8 @@ module Gitlab
 
         private
 
+        attr_reader :items, :resource, :network
+
         def separator
           ' '
         end
@@ -26,7 +30,7 @@ module Gitlab
         end
 
         def content_string
-          @items.map do |item|
+          items.map do |item|
             format_item(item)
           end.join(separator)
         end

data/lib/gitlab/triage/command_builders/label_command_builder.rb

@@ -4,8 +4,25 @@ module Gitlab
   module Triage
     module CommandBuilders
       class LabelCommandBuilder < BaseCommandBuilder
+        def build_command
+          ensure_labels_exist!
+
+          super
+        end
+
         private
 
+        def ensure_labels_exist!
+          items.each do |label|
+            label_opts = { project_id: resource[:project_id], name: label }
+
+            unless Resource::Label.new(label_opts, network: network).exist?
+              raise Resource::Label::LabelDoesntExistError,
+                    "Label `#{label}` doesn't exist!"
+            end
+          end
+        end
+
         def slash_command_string
           "/label"
         end

data/lib/gitlab/triage/command_builders/text_content_builder.rb

@@ -34,13 +34,9 @@ module Gitlab
         }.freeze
         PLACEHOLDER_REGEX = /{{([\w\.]+)}}/.freeze
 
-        attr_reader :resource, :network
-
         def initialize(
           items, resource: nil, network: nil, redact_confidentials: true)
-          super(items)
-          @resource = resource&.with_indifferent_access
-          @network = network
+          super(items, resource: resource, network: network)
           @redact_confidentials = redact_confidentials
         end
 

data/lib/gitlab/triage/engine.rb

@@ -4,10 +4,10 @@ require 'active_support/inflector'
 require_relative 'expand_condition'
 require_relative 'filters/merge_request_date_conditions_filter'
 require_relative 'filters/votes_conditions_filter'
-require_relative 'filters/forbidden_labels_conditions_filter'
 require_relative 'filters/no_additional_labels_conditions_filter'
 require_relative 'filters/author_member_conditions_filter'
 require_relative 'filters/assignee_member_conditions_filter'
+require_relative 'filters/discussions_conditions_filter'
 require_relative 'filters/ruby_conditions_filter'
 require_relative 'limiters/date_field_limiter'
 require_relative 'action'
@@ -20,7 +20,10 @@ require_relative 'api_query_builders/single_query_param_builder'
 require_relative 'api_query_builders/multi_query_param_builder'
 require_relative 'url_builders/url_builder'
 require_relative 'network'
+require_relative 'graphql_network'
 require_relative 'network_adapters/httparty_adapter'
+require_relative 'network_adapters/graphql_adapter'
+require_relative 'graphql_queries/query_builder'
 require_relative 'ui'
 
 module Gitlab
@@ -28,7 +31,10 @@ module Gitlab
     class Engine
       attr_reader :per_page, :policies, :options
 
-      def initialize(policies:, options:, network_adapter_class: Gitlab::Triage::NetworkAdapters::HttpartyAdapter)
+      DEFAULT_NETWORK_ADAPTER = Gitlab::Triage::NetworkAdapters::HttpartyAdapter
+      DEFAULT_GRAPHQL_ADAPTER = Gitlab::Triage::NetworkAdapters::GraphqlAdapter
+
+      def initialize(policies:, options:, network_adapter_class: DEFAULT_NETWORK_ADAPTER, graphql_network_adapter_class: DEFAULT_GRAPHQL_ADAPTER)
         options.host_url = policies.delete(:host_url) { options.host_url }
         options.api_version = policies.delete(:api_version) { 'v4' }
         options.dry_run = ENV['TEST'] == 'true' if options.dry_run.nil?
@@ -37,6 +43,7 @@ module Gitlab
         @policies = policies
         @options = options
         @network_adapter_class = network_adapter_class
+        @graphql_network_adapter_class = graphql_network_adapter_class
 
         assert_all!
         assert_project_id!
@@ -63,6 +70,10 @@ module Gitlab
         @network ||= Network.new(network_adapter)
       end
 
+      def graphql_network
+        @graphql_network ||= GraphqlNetwork.new(graphql_network_adapter)
+      end
+
       private
 
       def assert_project_id!
@@ -95,6 +106,10 @@ module Gitlab
         @network_adapter ||= @network_adapter_class.new(options)
       end
 
+      def graphql_network_adapter
+        @graphql_network_adapter ||= @graphql_network_adapter_class.new(options)
+      end
+
       def rule_conditions(rule)
         rule.fetch(:conditions) { {} }
       end
@@ -159,8 +174,11 @@ module Gitlab
           # retrieving the resources for every rule is inefficient
           # however, previous rules may affect those upcoming
           resources = network.query_api(build_get_url(resource_type, conditions))
+          graphql_query = build_graphql_query(resource_type, conditions)
+          graphql_resources = graphql_network.query(graphql_query, source: options.source_id) if graphql_query.present?
           # In some filters/actions we want to know which resource type it is
           attach_resource_type(resources, resource_type)
+          decorate_resources_with_graphql_data(resources, graphql_resources)
 
           puts "\n\n* Found #{resources.count} resources..."
           print "* Filtering resources..."
@@ -181,6 +199,13 @@ module Gitlab
         resources.each { |resource| resource[:type] ||= resource_type }
       end
 
+      def decorate_resources_with_graphql_data(resources, graphql_resources)
+        return if graphql_resources.nil?
+
+        graphql_resources_by_id = graphql_resources.to_h { |resource| [resource[:id], resource] }
+        resources.each { |resource| resource.merge!(graphql_resources_by_id[resource[:id]].to_h) }
+      end
+
       def process_action(policy)
         Action.process(
           policy: policy,
@@ -202,10 +227,6 @@ module Gitlab
             results << Filters::VotesConditionsFilter.new(resource, conditions[:upvotes]).calculate
           end
 
-          if conditions[:forbidden_labels]
-            results << Filters::ForbiddenLabelsConditionsFilter.new(resource, conditions[:forbidden_labels]).calculate
-          end
-
           if conditions[:no_additional_labels]
             results << Filters::NoAdditionalLabelsConditionsFilter.new(resource, conditions.fetch(:labels) { [] }).calculate
           end
@@ -218,6 +239,10 @@ module Gitlab
             results << Filters::AssigneeMemberConditionsFilter.new(resource, conditions[:assignee_member], network).calculate
           end
 
+          if conditions[:discussions]
+            results << Filters::DiscussionsConditionsFilter.new(resource, conditions[:discussions]).calculate
+          end
+
           if conditions[:ruby]
             results << Filters::RubyConditionsFilter.new(resource, conditions, network).calculate
           end
@@ -244,6 +269,11 @@ module Gitlab
 
         condition_builders = []
         condition_builders << APIQueryBuilders::MultiQueryParamBuilder.new('labels', conditions[:labels], ',') if conditions[:labels]
+
+        if conditions[:forbidden_labels]
+          condition_builders << APIQueryBuilders::MultiQueryParamBuilder.new('not[labels]', conditions[:forbidden_labels], ',')
+        end
+
         condition_builders << APIQueryBuilders::SingleQueryParamBuilder.new('state', conditions[:state]) if conditions[:state]
         condition_builders << APIQueryBuilders::SingleQueryParamBuilder.new('milestone', Array(conditions[:milestone])[0]) if conditions[:milestone]
         condition_builders << APIQueryBuilders::SingleQueryParamBuilder.new('source_branch', conditions[:source_branch]) if conditions[:source_branch]
@@ -253,6 +283,10 @@ module Gitlab
           condition_builders << APIQueryBuilders::DateQueryParamBuilder.new(conditions.delete(:date))
         end
 
+        if conditions[:weight] && resource_type.to_sym == :issues
+          condition_builders << APIQueryBuilders::SingleQueryParamBuilder.new('weight', conditions[:weight])
+        end
+
         condition_builders.each do |condition_builder|
           params[condition_builder.param_name] = condition_builder.param_content
         end
@@ -266,6 +300,11 @@ module Gitlab
           params: params
         ).build
       end
+
+      def build_graphql_query(resource_type, conditions)
+        Gitlab::Triage::GraphqlQueries::QueryBuilder
+          .new(options.source, resource_type, conditions)
+      end
     end
   end
 end

data/lib/gitlab/triage/filters/discussions_conditions_filter.rb

@@ -0,0 +1,60 @@
+require_relative 'base_conditions_filter'
+
+module Gitlab
+  module Triage
+    module Filters
+      class DiscussionsConditionsFilter < BaseConditionsFilter
+        ATTRIBUTES = %w[notes threads].freeze
+        CONDITIONS = %w[greater_than less_than].freeze
+
+        def self.filter_parameters
+          [
+            {
+              name: :attribute,
+              type: String,
+              values: ATTRIBUTES
+            },
+            {
+              name: :condition,
+              type: String,
+              values: CONDITIONS
+            },
+            {
+              name: :threshold,
+              type: Numeric
+            }
+          ]
+        end
+
+        def initialize_variables(condition)
+          @attribute = condition[:attribute].to_sym
+          @condition = condition[:condition].to_sym
+          @threshold = condition[:threshold]
+        end
+
+        def resource_value
+          if @attribute == :notes
+            @resource[:user_notes_count]
+          else
+            @resource.dig(:discussions, :nodes)&.count do |node|
+              !node&.dig(:notes, :nodes, 0, :system)
+            end
+          end
+        end
+
+        def condition_value
+          @threshold
+        end
+
+        def calculate
+          case @condition
+          when :greater_than
+            resource_value.to_i > condition_value
+          when :less_than
+            resource_value.to_i < condition_value
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/graphql_network.rb

@@ -0,0 +1,54 @@
+require 'active_support/all'
+require 'net/protocol'
+require 'globalid'
+
+require_relative 'retryable'
+require_relative 'ui'
+require_relative 'errors'
+
+module Gitlab
+  module Triage
+    class GraphqlNetwork
+      attr_reader :options, :adapter
+
+      def initialize(adapter)
+        @adapter = adapter
+        @options = adapter.options
+      end
+
+      def query(graphql_query, variables = {})
+        return if graphql_query.blank?
+
+        response = {}
+        resources = []
+
+        parsed_graphql_query = adapter.parse(graphql_query.query)
+
+        begin
+          print '.'
+
+          response = adapter.query(
+            parsed_graphql_query,
+            resource_path: graphql_query.resource_path,
+            variables: variables.merge(after: response.delete(:end_cursor))
+          )
+
+          resources.concat(Array.wrap(response.delete(:results)))
+        end while response.delete(:more_pages)
+
+        resources
+          .map { |resource| resource.deep_transform_keys(&:underscore) }
+          .map(&:with_indifferent_access)
+          .map { |resource| resource.merge(id: extract_id_from_global_id(resource[:id])) }
+      end
+
+      private
+
+      def extract_id_from_global_id(global_id)
+        return if global_id.blank?
+
+        GlobalID.parse(global_id).model_id.to_i
+      end
+    end
+  end
+end

data/lib/gitlab/triage/graphql_queries/query_builder.rb

@@ -0,0 +1,41 @@
+require_relative 'user_notes_query'
+require_relative 'threads_query'
+
+module Gitlab
+  module Triage
+    module GraphqlQueries
+      class QueryBuilder
+        def initialize(source_type, resource_type, conditions)
+          @source_type = source_type.to_s.singularize
+          @resource_type = resource_type
+          @conditions = conditions
+        end
+
+        def resource_path
+          [source_type, resource_type]
+        end
+
+        def query
+          return if query_template.nil?
+
+          format(query_template, source_type: source_type, resource_type: resource_type.to_s.camelize(:lower))
+        end
+
+        delegate :present?, to: :query_template
+
+        private
+
+        attr_reader :source_type, :resource_type, :conditions
+
+        def query_template
+          case conditions.dig(:discussions, :attribute).to_s
+          when 'notes'
+            UserNotesQuery
+          when 'threads'
+            ThreadsQuery
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/graphql_queries/threads_query.rb

@@ -0,0 +1,31 @@
+module Gitlab
+  module Triage
+    module GraphqlQueries
+      ThreadsQuery = <<-GRAPHQL.freeze # rubocop:disable Naming/ConstantName
+        query($source: ID!, $after: String) {
+          %{source_type}(fullPath: $source) {
+            id
+            %{resource_type}(after: $after) {
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+              nodes {
+                id
+                discussions {
+                  nodes {
+                    notes {
+                      nodes {
+                        system
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      GRAPHQL
+    end
+  end
+end

data/lib/gitlab/triage/graphql_queries/user_notes_query.rb

@@ -0,0 +1,23 @@
+module Gitlab
+  module Triage
+    module GraphqlQueries
+      UserNotesQuery = <<-GRAPHQL.freeze # rubocop:disable Naming/ConstantName
+        query($source: ID!, $after: String) {
+          %{source_type}(fullPath: $source) {
+            id
+            %{resource_type}(after: $after) {
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+              nodes {
+                id
+                userNotesCount
+              }
+            }
+          }
+        }
+      GRAPHQL
+    end
+  end
+end

data/lib/gitlab/triage/network_adapters/graphql_adapter.rb

@@ -0,0 +1,69 @@
+require 'graphql/client'
+require 'graphql/client/http'
+
+require_relative 'base_adapter'
+require_relative '../ui'
+require_relative '../errors'
+
+module Gitlab
+  module Triage
+    module NetworkAdapters
+      class GraphqlAdapter < BaseAdapter
+        Client = GraphQL::Client
+
+        def query(graphql_query, resource_path: [], variables: {})
+          response = client.query(graphql_query, variables: variables, context: { token: options.token })
+
+          raise_on_error!(response)
+
+          parsed_response = parse_response(response, resource_path)
+
+          return { results: {} } if parsed_response.nil?
+          return { results: parsed_response.map(&:to_h) } if parsed_response.is_a?(Client::List)
+          return { results: parsed_response.to_h } unless parsed_response.nodes?
+
+          {
+            more_pages: parsed_response.page_info.has_next_page,
+            end_cursor: parsed_response.page_info.end_cursor,
+            results: parsed_response.nodes.map(&:to_h)
+          }
+        end
+
+        delegate :parse, to: :client
+
+        private
+
+        def parse_response(response, resource_path)
+          resource_path.reduce(response.data) { |data, resource| data&.send(resource) }
+        end
+
+        def raise_on_error!(response)
+          return if response.errors.blank?
+
+          puts Gitlab::Triage::UI.debug response.inspect if options.debug
+
+          raise "There was an error: #{response.errors.messages.to_json}"
+        end
+
+        def http_client
+          Client::HTTP.new("#{options.host_url}/api/graphql") do
+            def headers(context) # rubocop:disable Lint/NestedMethodDefinition
+              {
+                'Content-type' => 'application/json',
+                'PRIVATE-TOKEN' => context[:token]
+              }
+            end
+          end
+        end
+
+        def schema
+          @schema ||= Client.load_schema(http_client)
+        end
+
+        def client
+          @client ||= Client.new(schema: schema, execute: http_client).tap { |client| client.allow_dynamic_queries = true }
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/policies_resources/rule_resources.rb

@@ -1,20 +1,11 @@
 # frozen_string_literal: true
 
-require 'forwardable'
+require 'delegate'
 
 module Gitlab
   module Triage
     module PoliciesResources
-      class RuleResources
-        include Enumerable
-        extend Forwardable
-
-        def initialize(new_resources)
-          @resources = new_resources
-        end
-
-        def_delegator :@resources, :each
-      end
+      RuleResources = Class.new(SimpleDelegator)
     end
   end
 end

data/lib/gitlab/triage/policies_resources/summary_resources.rb

@@ -1,20 +1,11 @@
 # frozen_string_literal: true
 
-require 'forwardable'
+require 'delegate'
 
 module Gitlab
   module Triage
     module PoliciesResources
-      class SummaryResources
-        include Enumerable
-        extend Forwardable
-
-        def initialize(new_rule_to_resources)
-          @rule_to_resources = new_rule_to_resources
-        end
-
-        def_delegator :@rule_to_resources, :each
-      end
+      SummaryResources = Class.new(SimpleDelegator)
     end
   end
 end

data/lib/gitlab/triage/resource/base.rb

@@ -58,11 +58,15 @@ module Gitlab
           build_url(params: params)
         end
 
+        def resource_id
+          resource[:iid]
+        end
+
         def resource_url(params: {}, sub_resource_type: nil)
           build_url(
             params: params,
             options: {
-              resource_id: resource[:iid],
+              resource_id: resource_id,
               sub_resource_type: sub_resource_type
             }
           )

data/lib/gitlab/triage/resource/label.rb

@@ -8,6 +8,8 @@ module Gitlab
   module Triage
     module Resource
       class Label < Base
+        LabelDoesntExistError = Class.new(StandardError)
+
         FIELDS = %i[
           id
           project_id
@@ -35,6 +37,19 @@ module Gitlab
             Time.parse(value) if value
           end
         end
+
+        def exist?
+          label = network.query_api_cached(resource_url).first
+          return false unless label
+
+          label[:name] == name
+        end
+
+        private
+
+        def resource_id
+          name
+        end
       end
     end
   end

data/lib/gitlab/triage/url_builders/url_builder.rb

@@ -17,7 +17,7 @@ module Gitlab
 
         def build
           url = base_url
-          url << "/#{@resource_id}" if @resource_id
+          url << "/#{percent_encode(@resource_id.to_s)}" if @resource_id
           url << "/#{@sub_resource_type}" if @sub_resource_type
           url << params_string if @params
           url
@@ -31,16 +31,20 @@ module Gitlab
 
         def base_url
           url = host_with_api_url
-          url << "/#{@source}/#{CGI.escape(@source_id.to_s)}" unless @all
+          url << "/#{@source}/#{percent_encode(@source_id.to_s)}" unless @all
           url << "/#{@resource_type}" if @resource_type
           url
         end
 
         def params_string
           "?" << @params.map do |k, v|
-            "#{k}=#{v}"
+            "#{percent_encode(k.to_s)}=#{percent_encode(v.to_s)}"
           end.join("&")
         end
+
+        def percent_encode(str)
+          CGI.escape(str).gsub('+', '%20')
+        end
       end
     end
   end

data/lib/gitlab/triage/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Triage
-    VERSION = '1.10.0'
+    VERSION = '1.14.0'
   end
 end

data/support/.gitlab-ci.example.yml

@@ -8,7 +8,7 @@ dry-run:triage:
   script:
     - gem install gitlab-triage
     - gitlab-triage --help
-    - gitlab-triage --dry-run --token $API_TOKEN --source projects --source-id $CI_PROJECT_PATH
+    - gitlab-triage --dry-run --token $GITLAB_API_TOKEN --source projects --source-id $CI_PROJECT_PATH
   when: manual
   except:
     - schedules
@@ -17,6 +17,6 @@ run:triage:
   stage: triage
   script:
     - gem install gitlab-triage
-    - gitlab-triage --token $API_TOKEN --source projects --source-id $CI_PROJECT_PATH
+    - gitlab-triage --token $GITLAB_API_TOKEN --source projects --source-id $CI_PROJECT_PATH
   only:
     - schedules

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.14.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: globalid
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: graphql-client
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -158,17 +186,22 @@ files:
 - lib/gitlab/triage/filters/assignee_member_conditions_filter.rb
 - lib/gitlab/triage/filters/author_member_conditions_filter.rb
 - lib/gitlab/triage/filters/base_conditions_filter.rb
-- lib/gitlab/triage/filters/forbidden_labels_conditions_filter.rb
+- lib/gitlab/triage/filters/discussions_conditions_filter.rb
 - lib/gitlab/triage/filters/member_conditions_filter.rb
 - lib/gitlab/triage/filters/merge_request_date_conditions_filter.rb
 - lib/gitlab/triage/filters/name_conditions_filter.rb
 - lib/gitlab/triage/filters/no_additional_labels_conditions_filter.rb
 - lib/gitlab/triage/filters/ruby_conditions_filter.rb
 - lib/gitlab/triage/filters/votes_conditions_filter.rb
+- lib/gitlab/triage/graphql_network.rb
+- lib/gitlab/triage/graphql_queries/query_builder.rb
+- lib/gitlab/triage/graphql_queries/threads_query.rb
+- lib/gitlab/triage/graphql_queries/user_notes_query.rb
 - lib/gitlab/triage/limiters/base_limiter.rb
 - lib/gitlab/triage/limiters/date_field_limiter.rb
 - lib/gitlab/triage/network.rb
 - lib/gitlab/triage/network_adapters/base_adapter.rb
+- lib/gitlab/triage/network_adapters/graphql_adapter.rb
 - lib/gitlab/triage/network_adapters/httparty_adapter.rb
 - lib/gitlab/triage/network_adapters/test_adapter.rb
 - lib/gitlab/triage/option_parser.rb
@@ -214,7 +247,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: GitLab triage automation project.

data/lib/gitlab/triage/filters/forbidden_labels_conditions_filter.rb

@@ -1,32 +0,0 @@
-require_relative 'base_conditions_filter'
-
-module Gitlab
-  module Triage
-    module Filters
-      class ForbiddenLabelsConditionsFilter < BaseConditionsFilter
-        def validate_condition(condition)
-          raise ArgumentError, 'condition must be an array containing forbidden label values' unless condition.is_a?(Array)
-        end
-
-        def initialize_variables(forbidden_labels)
-          @attribute = :labels
-          @forbidden_labels = forbidden_labels
-        end
-
-        def resource_value
-          @resource[@attribute]
-        end
-
-        def calculate
-          label_intersection.empty?
-        end
-
-        private
-
-        def label_intersection
-          resource_value & @forbidden_labels
-        end
-      end
-    end
-  end
-end