gitlab-styles 9.1.0 → 10.0.0

data/rubocop-performance.yml

@@ -28,6 +28,11 @@ Performance/Casecmp:
 Performance/CollectionLiteralInLoop: # (new in 1.8)
   Enabled: true
 
+# Identifies places where Concurrent.monotonic_time can be replaced by
+# Process.clock_gettime(Process::CLOCK_MONOTONIC).
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
+
 Performance/ConstantRegexp: # (new in 1.9)
   Enabled: true
 
@@ -36,6 +41,17 @@ Performance/ConstantRegexp: # (new in 1.9)
 Performance/DoubleStartEndWith:
   Enabled: true
 
+# Identifies usages of map { ... }.flatten and change them to use
+# flat_map { ... } instead.
+Performance/FlatMap:
+  Enabled: true
+  EnabledForFlattenWithoutParams: true
+
+# This cop identifies places where map { …​ }.compact can be replaced by
+# filter_map.
+Performance/MapCompact:
+  Enabled: true
+
 Performance/MethodObjectAsBlock: # (new in 1.9)
   Enabled: true
 
@@ -52,6 +68,11 @@ Performance/RangeInclude:
 Performance/RedundantBlockCall:
   Enabled: true
 
+# Checks for uses Enumerable#all?, Enumerable#any?, Enumerable#one?, and
+# Enumerable#none? are compared with === or similar methods in block.
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: true
+
 # This cop identifies use of `Regexp#match` or `String#match in a context
 # where the integral return value of `=~` would do just as well.
 Performance/RedundantMatch:
@@ -73,6 +94,11 @@ Performance/RedundantSortBlock:
 Performance/RedundantStringChars:
   Enabled: true
 
+# Identifies places where split argument can be replaced from a deterministic
+# regexp to a string.
+Performance/RedundantSplitRegexpArgument:
+  Enabled: true
+
 # Identifies places where reverse.first(n) and reverse.first can be replaced by last(n).reverse and last.
 # https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancereversefirst
 Performance/ReverseFirst:
@@ -98,6 +124,12 @@ Performance/StartWith:
 Performance/StringInclude:
   Enabled: true
 
+# Identifies places where string identifier argument can be replaced by symbol
+# identifier argument. It prevents the redundancy of the internal
+# string-to-symbol conversion.
+Performance/StringIdentifierArgument:
+  Enabled: true
+
 # Use `tr` instead of `gsub` when you are replacing the same number of
 # characters. Use `delete` instead of `gsub` when you are deleting
 # characters.

data/rubocop-rails.yml

@@ -3,6 +3,31 @@ require:
   - rubocop-rails
   - ./lib/gitlab/styles/rubocop
 
+# Cop that prevents the use of `dependent: ...` in ActiveRecord models.
+Cop/ActiveRecordDependent:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+# Cop that prevents the use of `serialize` in ActiveRecord models.
+Cop/ActiveRecordSerialize:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+# Cop that prevents the use of polymorphic associations.
+Cop/PolymorphicAssociations:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
+# Prevents usage of 'redirect_to' in actions 'destroy' and 'destroy_all'
+# without specifying 'status'.
+Cop/RedirectWithStatus:
+  Enabled: true
+  Include:
+    - app/controllers/**/*.rb
+
 # Enables Rails cops.
 Rails:
   Enabled: true

data/rubocop-rspec.yml

@@ -14,11 +14,6 @@ RSpec/BeEql:
 RSpec/BeforeAfterAll:
   Enabled: false
 
-# Checks if there is a more specific finder offered by Capybara.
-# https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/131#note_1141024624
-RSpec/Capybara/SpecificFinders:
-  Enabled: false
-
 # Enforces consistent use of be_a or be_kind_of.
 # https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/131#note_1141022718
 RSpec/ClassCheck:
@@ -40,6 +35,7 @@ RSpec/DescribeSymbol:
 # Checks that tests use `described_class`.
 RSpec/DescribedClass:
   Enabled: true
+  SkipBlocks: true
 
 # Checks if an example group does not include any tests.
 RSpec/EmptyExampleGroup:

data/rubocop-security.yml

@@ -1,6 +1,11 @@
 ---
 require:
-  - rubocop-gitlab-security
+  - ./lib/gitlab/styles/rubocop
+
+# Checks for implementations of the hash method which combine values using
+# custom logic instead of delegating to Array#hash.
+Security/CompoundHash:
+  Enabled: true
 
 # This cop checks for the use of JSON class methods which have potential
 # security issues.
@@ -16,17 +21,23 @@ Security/IoMethods:
   Enabled: true
 
 GitlabSecurity/DeepMunge:
+  Description: Checks for disabling the deep munge security control.
   Enabled: true
+  StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/DeepMunge
   Exclude:
     - 'lib/**/*.rake'
     - 'spec/**/*'
 
 # To be enabled by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13610
 GitlabSecurity/JsonSerialization:
+  Description: Checks for `to_json` / `as_json` without allowing via `only`.
   Enabled: false
+  StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/JsonSerialization
 
 GitlabSecurity/PublicSend:
+  Description: Checks for the use of `public_send`, `send`, and `__send__` methods.
   Enabled: true
+  StyleGuide: https://www.rubydoc.info/gems/gitlab-styles/RuboCop/Cop/GitlabSecurity/PublicSend
   Exclude:
     - 'config/**/*'
     - 'db/**/*'
@@ -35,19 +46,26 @@ GitlabSecurity/PublicSend:
     - 'qa/**/*'
     - 'spec/**/*'
 
+GitlabSecurity/SendFileParams:
+  Description: Check for passing of params hash to send_file()
+  Enabled: true
+
 GitlabSecurity/RedirectToParamsUpdate:
+  Description: Check for use of redirect_to(params.update())
   Enabled: true
   Exclude:
     - 'lib/**/*.rake'
     - 'spec/**/*'
 
 GitlabSecurity/SqlInjection:
+  Description: Check for SQL Injection in where()
   Enabled: true
   Exclude:
     - 'lib/**/*.rake'
     - 'spec/**/*'
 
 GitlabSecurity/SystemCommandInjection:
+  Description: Check for Command Injection in System()
   Enabled: true
   Exclude:
     - 'lib/**/*.rake'

data/rubocop-style.yml

@@ -18,10 +18,14 @@ Style/AndOr:
   Enabled: true
   EnforcedStyle: always
 
-# Enforces the use of Array() instead of explicit Array check or [*var]
-# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylearraycoercion
+# This cop enforces the use of Array() instead of explicit Array check or [*var]
+# It must remain disabled because of safety concern on Array().
+# A false positive may occur depending on how the argument is handled by Array()
+# (which can be different than just wrapping the argument in an array)
+# As of Rubocop 1.0, this cop has been disabled by default.
+# https://docs.rubocop.org/rubocop/1.44/cops_style.html#safety-3
 Style/ArrayCoercion:
-  Enabled: true
+  Enabled: false
 
 # Use `Array#join` instead of `Array#*`.
 Style/ArrayJoin:
@@ -289,6 +293,17 @@ Style/NonNilCheck:
 Style/Not:
   Enabled: true
 
+# Checks for numbered parameters. It can either restrict the use of numbered
+# parameters to single-lined blocks, or disallow completely numbered
+# parameters.
+Style/NumberedParameters:
+  EnforcedStyle: disallow
+  Enabled: true
+
+# Detects use of an excessive amount of numbered parameters in a single block.
+Style/NumberedParametersLimit:
+  Enabled: false
+
 # Add underscores to large numeric literals to improve their readability.
 Style/NumericLiterals:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 9.1.0
+  version: 10.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-15 00:00:00.000000000 Z
+date: 2023-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,84 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.38.0
+        version: 1.43.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.38.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-gitlab-security
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 1.43.0
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.18'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '1.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '1.15'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.17'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.15'
+        version: '2.18'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +136,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 description: 
 email:
 - gitlab_rubygems@gitlab.com
@@ -165,6 +165,8 @@ files:
 - ".gitlab/merge_request_templates/Release.md"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".tests_mapping.yml"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Dangerfile
@@ -180,7 +182,6 @@ files:
 - lib/gitlab/styles/common/banned_constants.rb
 - lib/gitlab/styles/rubocop.rb
 - lib/gitlab/styles/rubocop/migration_helpers.rb
-- lib/gitlab/styles/rubocop/model_helpers.rb
 - lib/gitlab/styles/version.rb
 - lib/rubocop/cop/active_record_dependent.rb
 - lib/rubocop/cop/active_record_serialize.rb
@@ -191,6 +192,13 @@ files:
 - lib/rubocop/cop/fips/open_ssl.rb
 - lib/rubocop/cop/fips/sha1.rb
 - lib/rubocop/cop/gem_fetcher.rb
+- lib/rubocop/cop/gitlab_security/deep_munge.rb
+- lib/rubocop/cop/gitlab_security/json_serialization.rb
+- lib/rubocop/cop/gitlab_security/public_send.rb
+- lib/rubocop/cop/gitlab_security/redirect_to_params_update.rb
+- lib/rubocop/cop/gitlab_security/send_file_params.rb
+- lib/rubocop/cop/gitlab_security/sql_injection.rb
+- lib/rubocop/cop/gitlab_security/system_command_injection.rb
 - lib/rubocop/cop/in_batches.rb
 - lib/rubocop/cop/internal_affairs/deprecate_cop_helper.rb
 - lib/rubocop/cop/line_break_after_guard_clauses.rb
@@ -212,6 +220,7 @@ files:
 - lib/rubocop/cop/without_reactive_cache.rb
 - rubocop-all.yml
 - rubocop-bundler.yml
+- rubocop-capybara.yml
 - rubocop-code_reuse.yml
 - rubocop-default.yml
 - rubocop-fips.yml

data/lib/gitlab/styles/rubocop/model_helpers.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Gitlab::Styles::Rubocop::ModelHelpers
-        # Returns true if the given node originated from the models directory.
-        def in_model?(node)
-          path = node.location.expression.source_buffer.name
-          pwd = Dir.pwd
-          models_path = File.join(pwd, 'app', 'models')
-          ee_models_path = File.join(pwd, 'ee', 'app', 'models')
-
-          path.start_with?(models_path, ee_models_path)
-        end
-      end
-    end
-  end
-end