gitlab-styles 6.2.1 → 6.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c3dfc98241b9f277b993b5a8e599903c804202bf1324e5770463f7f0f85dee91
-  data.tar.gz: 0d52074c0f1b5679c777e290094b36a2b2ecc473a3239e406134d1c014614cf4
+  metadata.gz: bdb4b922d729575676263e2cb9cf6f63b50be1d8b4205d96af7ecb6aaa2c4c84
+  data.tar.gz: 46a11af0a19079547b1d25e988e80d8271a5fe15fda707096662aee73a4cc9c3
 SHA512:
-  metadata.gz: 2e644dfd8ee68ec0700f5953d65fc0c6b2e535b20779e317178360b5879fa174f3c9d44077cdf0dee2bb28b79054d053ff8673b2c609dc4bd7262bd38566b428
-  data.tar.gz: dc9fbcf0d42ed4b8ce6e9dd05348068aa3478d987b03fc4306d6e0b55893b619de5b0e0830285f9f2f59bcc38e02be9b61046523a20b3c46b049ce52b93cf1e4
+  metadata.gz: df88cc8b9ea74b138c8768130b310d50d2204bed62e4648b292a8b0f058dad46335e23432564a546e0acc0ae9ef3c8a2487f4690f8e4ee2a73e6209665441746
+  data.tar.gz: 2d744fd1097268298c1073404bf84ddd4d65b28dbfa4b5bfad95857ea310734d24f93b81870e0c03454c26a2aa8de19470c7f75374e73db25ac0067a2665bebf

data/lib/gitlab/styles/rubocop/cop/rails/include_url_helper.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require_relative '../../model_helpers'
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module Rails
+          class IncludeUrlHelper < RuboCop::Cop::Cop
+            MSG = <<~MSG
+              Avoid including `ActionView::Helpers::UrlHelper`.
+              It adds/overrides ~40 methods while usually only one is needed.
+              Instead, use the `Gitlab::Routing.url_helpers`/`Application.routes.url_helpers`(outside of gitlab)
+              and `ActionController::Base.helpers.link_to`.
+              See https://gitlab.com/gitlab-org/gitlab/-/issues/340567.
+            MSG
+
+            def_node_matcher :include_url_helpers_node?, <<~PATTERN
+              (send nil? :include (const (const (const {nil? cbase} :ActionView) :Helpers) :UrlHelper))
+            PATTERN
+
+            def on_send(node)
+              add_offense(node) if include_url_helpers_node?(node)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '6.2.1'
+    VERSION = '6.3.0'
   end
 end

data/rubocop-rails.yml

@@ -1,6 +1,7 @@
 ---
 require:
   - rubocop-rails
+  - ./lib/gitlab/styles/rubocop
 
 # Enables Rails cops.
 Rails:
@@ -186,3 +187,7 @@ Rails/WhereExists:
 # https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railswherenot
 Rails/WhereNot:
   Enabled: true
+
+# Bans the use of `include ActionView::Helpers::UrlHelper`.
+Rails/IncludeUrlHelper:
+  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 6.2.1
+  version: 6.3.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-12 00:00:00.000000000 Z
+date: 2021-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -164,6 +164,7 @@ files:
 - lib/gitlab/styles/rubocop/cop/line_break_around_conditional_block.rb
 - lib/gitlab/styles/rubocop/cop/migration/update_large_table.rb
 - lib/gitlab/styles/rubocop/cop/polymorphic_associations.rb
+- lib/gitlab/styles/rubocop/cop/rails/include_url_helper.rb
 - lib/gitlab/styles/rubocop/cop/redirect_with_status.rb
 - lib/gitlab/styles/rubocop/cop/rspec/base.rb
 - lib/gitlab/styles/rubocop/cop/rspec/empty_line_after_final_let_it_be.rb