gitlab-styles 2.4.1 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aeca885328893c47690fb115fdc821e2255fb7e21142a6edbf2611903aa02a2a
-  data.tar.gz: 225b86b35e811c7757619520e93b63caf65c62039d26938d07a8b8803c7f141c
+  metadata.gz: e5456ef238c551c2da10ce79b0156c917d2508018d583e116548e9d16ac17341
+  data.tar.gz: a27c84b492eaabdaa294821443f319eb2b123e4537af2a6471ef82c928417e25
 SHA512:
-  metadata.gz: ed7b77a8f0f191d2db69628e3d38c574b53b667da357cb5776c1d0fda05e28ce8e5b66c1275f202bd6d9e721a2e1c28aa00cb17548dddf09e4064a9109c43c4c
-  data.tar.gz: 682b6007b316b01c6b3f13d8b3c2b0cdf7d3f00adbe8901d71ebfd1f8dee622c0afadc0748d31e61b407c517399416c22bbb24cb958be798aacc960b2f042050
+  metadata.gz: 1c2634e54f417f5efb69acdd10f708b3a6b91fb368303249ca44f3f7936180f59c2b939ca47252ccd59b9beabf5b7bec0b48a60ab5f98380231c0f5a27ad1393
+  data.tar.gz: d5561e402bfc11239cd1964f432bdac38e0781281e29dcf0da99e124aaf550133fdd047470a1920689ac30ec21711749f68183200593e0ed6e4b608c1ef6d55c

data/lib/gitlab/styles/rubocop/cop/rspec/have_link_parameters.rb

@@ -0,0 +1,41 @@
+require 'rubocop-rspec'
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module RSpec
+          # This cop checks for unused parameters to the `have_link` matcher.
+          #
+          # @example
+          #
+          #   # bad
+          #   expect(page).to have_link('Link', 'https://example.com')
+          #
+          #   # good
+          #   expect(page).to have_link('Link', href: 'https://example.com')
+          #   expect(page).to have_link('Example')
+          class HaveLinkParameters < RuboCop::Cop::RSpec::Cop
+            MESSAGE = "The second argument to `have_link` should be a Hash.".freeze
+
+            def_node_matcher :unused_parameters?, <<~PATTERN
+              (send nil? :have_link
+                _ !{hash nil}
+              )
+            PATTERN
+
+            def on_send(node)
+              return unless unused_parameters?(node)
+
+              location = node.arguments[1..-1]
+                .map(&:source_range)
+                .reduce(:join)
+
+              add_offense(node, location: location, message: MESSAGE)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Styles
-    VERSION = '2.4.1'.freeze
+    VERSION = '2.5.0'.freeze
   end
 end

data/rubocop-rails.yml

@@ -52,7 +52,7 @@ Rails/HasAndBelongsToMany:
 # `put`, `patch` without the usage of keyword arguments in your tests and
 # change them to use keyword args.
 Rails/HttpPositionalArguments:
-  Enabled: false
+  Enabled: true
 
 # Checks for calls to puts, print, etc.
 Rails/Output:

data/rubocop-rspec.yml

@@ -62,10 +62,6 @@ RSpec/ExpectOutput:
 RSpec/FilePath:
   Enabled: true
   IgnoreMethods: true
-  Exclude:
-    - 'qa/**/*'
-    - 'spec/javascripts/fixtures/*'
-    - 'spec/requests/api/v3/*'
 
 # Checks if there are focused specs.
 RSpec/Focus:
@@ -76,6 +72,10 @@ RSpec/HookArgument:
   Enabled: true
   EnforcedStyle: implicit
 
+# Checks for unused parameters to the `have_link` matcher.
+RSpec/HaveLinkParameters:
+  Enabled: true
+
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: is_expected, should
 RSpec/ImplicitExpect:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.5.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-04 00:00:00.000000000 Z
+date: 2018-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -125,6 +125,7 @@ files:
 - lib/gitlab/styles/rubocop/cop/line_break_after_guard_clauses.rb
 - lib/gitlab/styles/rubocop/cop/polymorphic_associations.rb
 - lib/gitlab/styles/rubocop/cop/redirect_with_status.rb
+- lib/gitlab/styles/rubocop/cop/rspec/have_link_parameters.rb
 - lib/gitlab/styles/rubocop/cop/rspec/single_line_hook.rb
 - lib/gitlab/styles/rubocop/cop/rspec/verbose_include_metadata.rb
 - lib/gitlab/styles/rubocop/migration_helpers.rb
@@ -163,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: GitLab style guides and shared style configs.