gitlab-styles 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57a1acb3ef70890ea8910224f5060a90089a66d9081d71d11967994ef85bb84c
-  data.tar.gz: 23f566be54f55ce37116a9697c31b1cfff7070fad2778134ba4f0aa99ed8772e
+  metadata.gz: aeca885328893c47690fb115fdc821e2255fb7e21142a6edbf2611903aa02a2a
+  data.tar.gz: 225b86b35e811c7757619520e93b63caf65c62039d26938d07a8b8803c7f141c
 SHA512:
-  metadata.gz: 10885dd2546e0d265046bd11d9cbde03f333dddbc2ae2e2ae7de1e76822186387f086658e9753a046b9875b1d0aebdcf56bacf366eef590c2986d83c04f45984
-  data.tar.gz: 86d7e449a1ca5789f64e13d898cbcf8460eff0547866b21ca2bc9533ec39873c17bf8ee41669dcfbf197d6162c43b53186aa948b7181aa2ec9b38d21cd8681ed
+  metadata.gz: ed7b77a8f0f191d2db69628e3d38c574b53b667da357cb5776c1d0fda05e28ce8e5b66c1275f202bd6d9e721a2e1c28aa00cb17548dddf09e4064a9109c43c4c
+  data.tar.gz: 682b6007b316b01c6b3f13d8b3c2b0cdf7d3f00adbe8901d71ebfd1f8dee622c0afadc0748d31e61b407c517399416c22bbb24cb958be798aacc960b2f042050

data/lib/gitlab/styles/rubocop/migration_helpers.rb

@@ -7,7 +7,11 @@ module Gitlab
         def in_migration?(node)
           dirname = File.dirname(node.location.expression.source_buffer.name)
 
-          dirname.end_with?('db/migrate', 'db/post_migrate')
+          dirname.end_with?(
+            'db/migrate',
+            'db/post_migrate',
+            'ee/db/migrate',
+            'ee/db/post_migrate')
         end
       end
     end

data/lib/gitlab/styles/rubocop/model_helpers.rb

@@ -5,9 +5,11 @@ module Gitlab
         # Returns true if the given node originated from the models directory.
         def in_model?(node)
           path = node.location.expression.source_buffer.name
-          models_path = File.join(Dir.pwd, 'app', 'models')
+          pwd = Dir.pwd
+          models_path = File.join(pwd, 'app', 'models')
+          ee_models_path = File.join(pwd, 'ee', 'app', 'models')
 
-          path.start_with?(models_path)
+          path.start_with?(models_path, ee_models_path)
         end
       end
     end

data/lib/gitlab/styles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Styles
-    VERSION = '2.4.0'.freeze
+    VERSION = '2.4.1'.freeze
   end
 end

data/rubocop-naming.yml

@@ -22,6 +22,10 @@ Naming/ConstantName:
 Naming/FileName:
   Enabled: true
 
+# Memoized methods whose instance variable name does not match the method name.
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
 # Use the configured style when naming methods.
 Naming/MethodName:
   Enabled: true
@@ -38,6 +42,13 @@ Naming/PredicateName:
     - 'spec/**/*'
     - 'features/**/*'
 
+# Method parameter names for how descriptive they are.
+Naming/UncommunicativeMethodParamName:
+  Enabled: true
+  MinNameLength: 2
+  AllowedNames:
+    - _
+
 # Use the configured style when naming variables.
 Naming/VariableName:
   EnforcedStyle: snake_case

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-01 00:00:00.000000000 Z
+date: 2018-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop