gitlab-styles 2.3.2 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62b4d9e6b278468a8273fc38b8b2b831d37bc6266ebe89da7ae85588634614c7
-  data.tar.gz: a2fd1aa98133e79043d54f3935baa5ce15b7f33f4f8c808bdebd83b81abcf79c
+  metadata.gz: 57a1acb3ef70890ea8910224f5060a90089a66d9081d71d11967994ef85bb84c
+  data.tar.gz: 23f566be54f55ce37116a9697c31b1cfff7070fad2778134ba4f0aa99ed8772e
 SHA512:
-  metadata.gz: eb8319738228a328b912c1f7de68064ce9993002bb140eebe9c2ddcf55d07962db6213a6f0a1a8df7eb415457af782f0458c749fafef26f01896bb0d2204e5ab
-  data.tar.gz: 973dcdb303f79786f9c615e472655a9568a3dd2fed3b48af71bf9b8408fc09568ce0e21248d20713d6eee7b080a89743cd6f2826e37e1bba55fdcb81dfede74b
+  metadata.gz: 10885dd2546e0d265046bd11d9cbde03f333dddbc2ae2e2ae7de1e76822186387f086658e9753a046b9875b1d0aebdcf56bacf366eef590c2986d83c04f45984
+  data.tar.gz: 86d7e449a1ca5789f64e13d898cbcf8460eff0547866b21ca2bc9533ec39873c17bf8ee41669dcfbf197d6162c43b53186aa948b7181aa2ec9b38d21cd8681ed

data/Gemfile

@@ -5,6 +5,6 @@ gemspec
 
 group :test do
   # Pin these dependencies, otherwise a new rule could break the CI pipelines
-  gem 'rubocop', '0.52.0'
+  gem 'rubocop', '0.54.0'
   gem 'rubocop-rspec', '1.20.1'
 end

data/gitlab-styles.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gitlab/styles/version'
 
@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.51'
+  spec.add_dependency 'rubocop', '~> 0.54.0'
   spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.0'
   spec.add_dependency 'rubocop-rspec', '~> 1.19'
 

data/lib/gitlab/styles/rubocop/cop/custom_error_class.rb

@@ -25,7 +25,7 @@ module Gitlab
 
             parent_klass = class_name_from_node(parent)
 
-            return unless parent_klass && parent_klass.to_s.end_with?('Error')
+            return unless parent_klass&.to_s&.end_with?('Error')
 
             add_offense(node, location: :expression)
           end

data/lib/gitlab/styles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Styles
-    VERSION = '2.3.2'.freeze
+    VERSION = '2.4.0'.freeze
   end
 end

data/rubocop-layout.yml

@@ -15,6 +15,10 @@ Layout/AlignHash:
 Layout/AlignParameters:
   Enabled: false
 
+# Align block ends correctly.
+Layout/BlockAlignment:
+  Enabled: true
+
 # Put end statement of multiline block on its own line.
 Layout/BlockEndNewline:
   Enabled: true
@@ -27,6 +31,14 @@ Layout/CaseIndentation:
 Layout/CommentIndentation:
   Enabled: true
 
+# Checks for condition placed in a confusing position relative to the keyword.
+Layout/ConditionPosition:
+  Enabled: true
+
+# Align ends corresponding to defs correctly.
+Layout/DefEndAlignment:
+  Enabled: true
+
 # Multi-line method chaining should be done with leading dots.
 Layout/DotPosition:
   Enabled: true
@@ -72,6 +84,10 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: true
 
+# Align ends correctly.
+Layout/EndAlignment:
+  Enabled: true
+
 # Use Unix-style line endings.
 Layout/EndOfLine:
   Enabled: true

data/rubocop-lint.yml

@@ -18,27 +18,15 @@ Lint/AmbiguousRegexpLiteral:
 Lint/AssignmentInCondition:
   Enabled: false
 
-# Align block ends correctly.
-Lint/BlockAlignment:
-  Enabled: true
-
 # Default values in optional keyword arguments and optional ordinal arguments
 # should not refer back to the name of the argument.
 Lint/CircularArgumentReference:
   Enabled: true
 
-# Checks for condition placed in a confusing position relative to the keyword.
-Lint/ConditionPosition:
-  Enabled: true
-
 # Check for debugger calls.
 Lint/Debugger:
   Enabled: true
 
-# Align ends corresponding to defs correctly.
-Lint/DefEndAlignment:
-  Enabled: true
-
 # Check for deprecated class method calls.
 Lint/DeprecatedClassMethods:
   Enabled: true
@@ -59,10 +47,6 @@ Lint/EmptyEnsure:
 Lint/EmptyWhen:
   Enabled: true
 
-# Align ends correctly.
-Lint/EndAlignment:
-  Enabled: true
-
 # END blocks should not be placed inside method definitions.
 Lint/EndInMethod:
   Enabled: true
@@ -151,12 +135,6 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Enabled: true
 
-# Checks for rubocop:disable comments that can be removed.
-# Note: this cop is not disabled when disabling all cops.
-# It must be explicitly disabled.
-Lint/UnneededDisable:
-  Enabled: false
-
 # This cop checks for unneeded usages of splat expansion
 Lint/UnneededSplatExpansion:
   Enabled: false

data/rubocop-style.yml

@@ -265,8 +265,13 @@ Style/StringMethods:
 Style/SymbolArray:
   Enabled: false
 
-# This cop checks for trailing comma in array and hash literals.
-Style/TrailingCommaInLiteral:
+# This cop checks for trailing comma in array literals.
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: no_comma
+
+# This cop checks for trailing comma in hash literals.
+Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: no_comma
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 2.3.2
+  version: 2.4.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-26 00:00:00.000000000 Z
+date: 2018-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: 0.54.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
@@ -163,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: GitLab style guides and shared style configs.