gitlab-styles 14.1.0 → 15.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.gitlab-ci.yml +2 -3
- data/.rubocop.yml +2 -23
- data/.rubocop_todo.yml +1 -2
- data/Gemfile.lock +243 -132
- data/README.md +21 -10
- data/gitlab-styles.gemspec +21 -22
- data/lib/gitlab/styles/rubocop/rspec.rb +4 -0
- data/lib/gitlab/styles/rubocop.rb +6 -3
- data/lib/gitlab/styles/version.rb +1 -1
- data/lib/rubocop/cop/avoid_return_from_blocks.rb +4 -3
- data/lib/rubocop/cop/rspec/base.rb +1 -0
- data/lib/rubocop/cop/rspec/empty_line_after_let_block.rb +1 -0
- data/lib/rubocop/cop/rspec/empty_line_after_shared_example.rb +3 -2
- data/lib/rubocop/cop/rspec/example_starting_character.rb +3 -4
- data/lib/rubocop/cop/rspec/feature_spec_max_examples.rb +1 -0
- data/lib/rubocop/cop/rspec/single_line_hook.rb +1 -0
- data/rubocop-all.yml +1 -1
- data/rubocop-capybara.yml +1 -2
- data/rubocop-code_reuse.yml +1 -1
- data/rubocop-default.yml +0 -3
- data/rubocop-factory_bot.yml +1 -2
- data/rubocop-fips.yml +3 -1
- data/rubocop-graphql.yml +1 -1
- data/rubocop-internal-affairs.yml +4 -1
- data/rubocop-layout.yml +6 -1
- data/rubocop-migrations.yml +1 -1
- data/rubocop-performance.yml +3 -8
- data/rubocop-rails.yml +8 -2
- data/rubocop-rspec.yml +19 -2
- data/rubocop-security.yml +7 -1
- data/rubocop-style.yml +4 -1
- data/rubocop-tailwind.yml +2 -1
- metadata +42 -57
- data/lib/rubocop/cop/line_break_after_guard_clauses.rb +0 -99
- data/lib/rubocop/cop/style/open_struct_use.rb +0 -49
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: gitlab-styles
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version:
|
|
4
|
+
version: 15.0.0
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- GitLab
|
|
8
8
|
autorequire:
|
|
9
9
|
bindir: exe
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date: 2026-05
|
|
11
|
+
date: 2026-11-05 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: rubocop
|
|
@@ -16,280 +16,266 @@ dependencies:
|
|
|
16
16
|
requirements:
|
|
17
17
|
- - '='
|
|
18
18
|
- !ruby/object:Gem::Version
|
|
19
|
-
version: 1.
|
|
19
|
+
version: 1.92.1
|
|
20
20
|
type: :runtime
|
|
21
21
|
prerelease: false
|
|
22
22
|
version_requirements: !ruby/object:Gem::Requirement
|
|
23
23
|
requirements:
|
|
24
24
|
- - '='
|
|
25
25
|
- !ruby/object:Gem::Version
|
|
26
|
-
version: 1.
|
|
26
|
+
version: 1.92.1
|
|
27
27
|
- !ruby/object:Gem::Dependency
|
|
28
28
|
name: rubocop-capybara
|
|
29
29
|
requirement: !ruby/object:Gem::Requirement
|
|
30
30
|
requirements:
|
|
31
31
|
- - '='
|
|
32
32
|
- !ruby/object:Gem::Version
|
|
33
|
-
version:
|
|
33
|
+
version: 3.1.0
|
|
34
34
|
type: :runtime
|
|
35
35
|
prerelease: false
|
|
36
36
|
version_requirements: !ruby/object:Gem::Requirement
|
|
37
37
|
requirements:
|
|
38
38
|
- - '='
|
|
39
39
|
- !ruby/object:Gem::Version
|
|
40
|
-
version:
|
|
40
|
+
version: 3.1.0
|
|
41
41
|
- !ruby/object:Gem::Dependency
|
|
42
42
|
name: rubocop-factory_bot
|
|
43
43
|
requirement: !ruby/object:Gem::Requirement
|
|
44
44
|
requirements:
|
|
45
45
|
- - '='
|
|
46
46
|
- !ruby/object:Gem::Version
|
|
47
|
-
version: 2.
|
|
47
|
+
version: 2.28.0
|
|
48
48
|
type: :runtime
|
|
49
49
|
prerelease: false
|
|
50
50
|
version_requirements: !ruby/object:Gem::Requirement
|
|
51
51
|
requirements:
|
|
52
52
|
- - '='
|
|
53
53
|
- !ruby/object:Gem::Version
|
|
54
|
-
version: 2.
|
|
54
|
+
version: 2.28.0
|
|
55
55
|
- !ruby/object:Gem::Dependency
|
|
56
56
|
name: rubocop-graphql
|
|
57
57
|
requirement: !ruby/object:Gem::Requirement
|
|
58
58
|
requirements:
|
|
59
59
|
- - '='
|
|
60
60
|
- !ruby/object:Gem::Version
|
|
61
|
-
version: 1.
|
|
61
|
+
version: 1.8.0
|
|
62
62
|
type: :runtime
|
|
63
63
|
prerelease: false
|
|
64
64
|
version_requirements: !ruby/object:Gem::Requirement
|
|
65
65
|
requirements:
|
|
66
66
|
- - '='
|
|
67
67
|
- !ruby/object:Gem::Version
|
|
68
|
-
version: 1.
|
|
68
|
+
version: 1.8.0
|
|
69
69
|
- !ruby/object:Gem::Dependency
|
|
70
70
|
name: rubocop-performance
|
|
71
71
|
requirement: !ruby/object:Gem::Requirement
|
|
72
72
|
requirements:
|
|
73
73
|
- - '='
|
|
74
74
|
- !ruby/object:Gem::Version
|
|
75
|
-
version: 1.
|
|
75
|
+
version: 1.27.0
|
|
76
76
|
type: :runtime
|
|
77
77
|
prerelease: false
|
|
78
78
|
version_requirements: !ruby/object:Gem::Requirement
|
|
79
79
|
requirements:
|
|
80
80
|
- - '='
|
|
81
81
|
- !ruby/object:Gem::Version
|
|
82
|
-
version: 1.
|
|
82
|
+
version: 1.27.0
|
|
83
83
|
- !ruby/object:Gem::Dependency
|
|
84
84
|
name: rubocop-rails
|
|
85
85
|
requirement: !ruby/object:Gem::Requirement
|
|
86
86
|
requirements:
|
|
87
87
|
- - '='
|
|
88
88
|
- !ruby/object:Gem::Version
|
|
89
|
-
version: 2.
|
|
89
|
+
version: 2.38.0
|
|
90
90
|
type: :runtime
|
|
91
91
|
prerelease: false
|
|
92
92
|
version_requirements: !ruby/object:Gem::Requirement
|
|
93
93
|
requirements:
|
|
94
94
|
- - '='
|
|
95
95
|
- !ruby/object:Gem::Version
|
|
96
|
-
version: 2.
|
|
96
|
+
version: 2.38.0
|
|
97
97
|
- !ruby/object:Gem::Dependency
|
|
98
98
|
name: rubocop-rspec
|
|
99
99
|
requirement: !ruby/object:Gem::Requirement
|
|
100
100
|
requirements:
|
|
101
101
|
- - '='
|
|
102
102
|
- !ruby/object:Gem::Version
|
|
103
|
-
version: 3.
|
|
103
|
+
version: 3.10.2
|
|
104
104
|
type: :runtime
|
|
105
105
|
prerelease: false
|
|
106
106
|
version_requirements: !ruby/object:Gem::Requirement
|
|
107
107
|
requirements:
|
|
108
108
|
- - '='
|
|
109
109
|
- !ruby/object:Gem::Version
|
|
110
|
-
version: 3.
|
|
110
|
+
version: 3.10.2
|
|
111
111
|
- !ruby/object:Gem::Dependency
|
|
112
112
|
name: rubocop-rspec_rails
|
|
113
113
|
requirement: !ruby/object:Gem::Requirement
|
|
114
114
|
requirements:
|
|
115
115
|
- - '='
|
|
116
116
|
- !ruby/object:Gem::Version
|
|
117
|
-
version: 2.
|
|
117
|
+
version: 2.33.0
|
|
118
118
|
type: :runtime
|
|
119
119
|
prerelease: false
|
|
120
120
|
version_requirements: !ruby/object:Gem::Requirement
|
|
121
121
|
requirements:
|
|
122
122
|
- - '='
|
|
123
123
|
- !ruby/object:Gem::Version
|
|
124
|
-
version: 2.
|
|
124
|
+
version: 2.33.0
|
|
125
125
|
- !ruby/object:Gem::Dependency
|
|
126
126
|
name: bundler
|
|
127
127
|
requirement: !ruby/object:Gem::Requirement
|
|
128
128
|
requirements:
|
|
129
129
|
- - "~>"
|
|
130
130
|
- !ruby/object:Gem::Version
|
|
131
|
-
version: '
|
|
131
|
+
version: '4.0'
|
|
132
132
|
type: :development
|
|
133
133
|
prerelease: false
|
|
134
134
|
version_requirements: !ruby/object:Gem::Requirement
|
|
135
135
|
requirements:
|
|
136
136
|
- - "~>"
|
|
137
137
|
- !ruby/object:Gem::Version
|
|
138
|
-
version: '
|
|
138
|
+
version: '4.0'
|
|
139
139
|
- !ruby/object:Gem::Dependency
|
|
140
140
|
name: gitlab-dangerfiles
|
|
141
141
|
requirement: !ruby/object:Gem::Requirement
|
|
142
142
|
requirements:
|
|
143
143
|
- - "~>"
|
|
144
144
|
- !ruby/object:Gem::Version
|
|
145
|
-
version: 4.
|
|
145
|
+
version: 4.14.0
|
|
146
146
|
type: :development
|
|
147
147
|
prerelease: false
|
|
148
148
|
version_requirements: !ruby/object:Gem::Requirement
|
|
149
149
|
requirements:
|
|
150
150
|
- - "~>"
|
|
151
151
|
- !ruby/object:Gem::Version
|
|
152
|
-
version: 4.
|
|
152
|
+
version: 4.14.0
|
|
153
153
|
- !ruby/object:Gem::Dependency
|
|
154
154
|
name: lefthook
|
|
155
155
|
requirement: !ruby/object:Gem::Requirement
|
|
156
156
|
requirements:
|
|
157
157
|
- - "~>"
|
|
158
158
|
- !ruby/object:Gem::Version
|
|
159
|
-
version:
|
|
159
|
+
version: '2.2'
|
|
160
160
|
type: :development
|
|
161
161
|
prerelease: false
|
|
162
162
|
version_requirements: !ruby/object:Gem::Requirement
|
|
163
163
|
requirements:
|
|
164
164
|
- - "~>"
|
|
165
165
|
- !ruby/object:Gem::Version
|
|
166
|
-
version:
|
|
166
|
+
version: '2.2'
|
|
167
167
|
- !ruby/object:Gem::Dependency
|
|
168
168
|
name: pry-byebug
|
|
169
169
|
requirement: !ruby/object:Gem::Requirement
|
|
170
170
|
requirements:
|
|
171
171
|
- - "~>"
|
|
172
172
|
- !ruby/object:Gem::Version
|
|
173
|
-
version: '3.
|
|
173
|
+
version: '3.12'
|
|
174
174
|
type: :development
|
|
175
175
|
prerelease: false
|
|
176
176
|
version_requirements: !ruby/object:Gem::Requirement
|
|
177
177
|
requirements:
|
|
178
178
|
- - "~>"
|
|
179
179
|
- !ruby/object:Gem::Version
|
|
180
|
-
version: '3.
|
|
180
|
+
version: '3.12'
|
|
181
181
|
- !ruby/object:Gem::Dependency
|
|
182
182
|
name: rake
|
|
183
183
|
requirement: !ruby/object:Gem::Requirement
|
|
184
184
|
requirements:
|
|
185
185
|
- - "~>"
|
|
186
186
|
- !ruby/object:Gem::Version
|
|
187
|
-
version: '13.
|
|
187
|
+
version: '13.4'
|
|
188
188
|
type: :development
|
|
189
189
|
prerelease: false
|
|
190
190
|
version_requirements: !ruby/object:Gem::Requirement
|
|
191
191
|
requirements:
|
|
192
192
|
- - "~>"
|
|
193
193
|
- !ruby/object:Gem::Version
|
|
194
|
-
version: '13.
|
|
194
|
+
version: '13.4'
|
|
195
195
|
- !ruby/object:Gem::Dependency
|
|
196
196
|
name: rspec
|
|
197
197
|
requirement: !ruby/object:Gem::Requirement
|
|
198
198
|
requirements:
|
|
199
199
|
- - "~>"
|
|
200
200
|
- !ruby/object:Gem::Version
|
|
201
|
-
version: '3.
|
|
201
|
+
version: '3.13'
|
|
202
202
|
type: :development
|
|
203
203
|
prerelease: false
|
|
204
204
|
version_requirements: !ruby/object:Gem::Requirement
|
|
205
205
|
requirements:
|
|
206
206
|
- - "~>"
|
|
207
207
|
- !ruby/object:Gem::Version
|
|
208
|
-
version: '3.
|
|
208
|
+
version: '3.13'
|
|
209
209
|
- !ruby/object:Gem::Dependency
|
|
210
210
|
name: rspec-parameterized-table_syntax
|
|
211
211
|
requirement: !ruby/object:Gem::Requirement
|
|
212
212
|
requirements:
|
|
213
213
|
- - "~>"
|
|
214
214
|
- !ruby/object:Gem::Version
|
|
215
|
-
version: 1
|
|
215
|
+
version: '2.1'
|
|
216
216
|
type: :development
|
|
217
217
|
prerelease: false
|
|
218
218
|
version_requirements: !ruby/object:Gem::Requirement
|
|
219
219
|
requirements:
|
|
220
220
|
- - "~>"
|
|
221
221
|
- !ruby/object:Gem::Version
|
|
222
|
-
version: 1
|
|
222
|
+
version: '2.1'
|
|
223
223
|
- !ruby/object:Gem::Dependency
|
|
224
224
|
name: rubocop-rake
|
|
225
225
|
requirement: !ruby/object:Gem::Requirement
|
|
226
226
|
requirements:
|
|
227
227
|
- - "~>"
|
|
228
228
|
- !ruby/object:Gem::Version
|
|
229
|
-
version: '0.
|
|
229
|
+
version: '0.7'
|
|
230
230
|
type: :development
|
|
231
231
|
prerelease: false
|
|
232
232
|
version_requirements: !ruby/object:Gem::Requirement
|
|
233
233
|
requirements:
|
|
234
234
|
- - "~>"
|
|
235
235
|
- !ruby/object:Gem::Version
|
|
236
|
-
version: '0.
|
|
236
|
+
version: '0.7'
|
|
237
237
|
- !ruby/object:Gem::Dependency
|
|
238
238
|
name: simplecov
|
|
239
239
|
requirement: !ruby/object:Gem::Requirement
|
|
240
240
|
requirements:
|
|
241
241
|
- - "~>"
|
|
242
242
|
- !ruby/object:Gem::Version
|
|
243
|
-
version:
|
|
243
|
+
version: '1.3'
|
|
244
244
|
type: :development
|
|
245
245
|
prerelease: false
|
|
246
246
|
version_requirements: !ruby/object:Gem::Requirement
|
|
247
247
|
requirements:
|
|
248
248
|
- - "~>"
|
|
249
249
|
- !ruby/object:Gem::Version
|
|
250
|
-
version:
|
|
250
|
+
version: '1.3'
|
|
251
251
|
- !ruby/object:Gem::Dependency
|
|
252
252
|
name: simplecov-cobertura
|
|
253
253
|
requirement: !ruby/object:Gem::Requirement
|
|
254
254
|
requirements:
|
|
255
255
|
- - "~>"
|
|
256
256
|
- !ruby/object:Gem::Version
|
|
257
|
-
version:
|
|
258
|
-
type: :development
|
|
259
|
-
prerelease: false
|
|
260
|
-
version_requirements: !ruby/object:Gem::Requirement
|
|
261
|
-
requirements:
|
|
262
|
-
- - "~>"
|
|
263
|
-
- !ruby/object:Gem::Version
|
|
264
|
-
version: 2.1.0
|
|
265
|
-
- !ruby/object:Gem::Dependency
|
|
266
|
-
name: simplecov-html
|
|
267
|
-
requirement: !ruby/object:Gem::Requirement
|
|
268
|
-
requirements:
|
|
269
|
-
- - "~>"
|
|
270
|
-
- !ruby/object:Gem::Version
|
|
271
|
-
version: 0.12.3
|
|
257
|
+
version: '4.0'
|
|
272
258
|
type: :development
|
|
273
259
|
prerelease: false
|
|
274
260
|
version_requirements: !ruby/object:Gem::Requirement
|
|
275
261
|
requirements:
|
|
276
262
|
- - "~>"
|
|
277
263
|
- !ruby/object:Gem::Version
|
|
278
|
-
version: 0
|
|
264
|
+
version: '4.0'
|
|
279
265
|
- !ruby/object:Gem::Dependency
|
|
280
266
|
name: test_file_finder
|
|
281
267
|
requirement: !ruby/object:Gem::Requirement
|
|
282
268
|
requirements:
|
|
283
269
|
- - "~>"
|
|
284
270
|
- !ruby/object:Gem::Version
|
|
285
|
-
version: 0.
|
|
271
|
+
version: '0.3'
|
|
286
272
|
type: :development
|
|
287
273
|
prerelease: false
|
|
288
274
|
version_requirements: !ruby/object:Gem::Requirement
|
|
289
275
|
requirements:
|
|
290
276
|
- - "~>"
|
|
291
277
|
- !ruby/object:Gem::Version
|
|
292
|
-
version: 0.
|
|
278
|
+
version: '0.3'
|
|
293
279
|
description:
|
|
294
280
|
email:
|
|
295
281
|
- gitlab_rubygems@gitlab.com
|
|
@@ -323,6 +309,7 @@ files:
|
|
|
323
309
|
- lib/gitlab/styles/common/banned_constants.rb
|
|
324
310
|
- lib/gitlab/styles/rubocop.rb
|
|
325
311
|
- lib/gitlab/styles/rubocop/migration_helpers.rb
|
|
312
|
+
- lib/gitlab/styles/rubocop/rspec.rb
|
|
326
313
|
- lib/gitlab/styles/version.rb
|
|
327
314
|
- lib/rubocop/cop/active_record_dependent.rb
|
|
328
315
|
- lib/rubocop/cop/active_record_serialize.rb
|
|
@@ -346,7 +333,6 @@ files:
|
|
|
346
333
|
- lib/rubocop/cop/internal_affairs/missing_cop_department.rb
|
|
347
334
|
- lib/rubocop/cop/internal_affairs/use_restrict_on_send.rb
|
|
348
335
|
- lib/rubocop/cop/layout/line_break_after_final_mixin.rb
|
|
349
|
-
- lib/rubocop/cop/line_break_after_guard_clauses.rb
|
|
350
336
|
- lib/rubocop/cop/line_break_around_conditional_block.rb
|
|
351
337
|
- lib/rubocop/cop/migration/update_large_table.rb
|
|
352
338
|
- lib/rubocop/cop/performance/rubyzip.rb
|
|
@@ -366,7 +352,6 @@ files:
|
|
|
366
352
|
- lib/rubocop/cop/rspec/verbose_include_metadata.rb
|
|
367
353
|
- lib/rubocop/cop/style/hash_transformation.rb
|
|
368
354
|
- lib/rubocop/cop/style/iso8601_date.rb
|
|
369
|
-
- lib/rubocop/cop/style/open_struct_use.rb
|
|
370
355
|
- lib/rubocop/cop/tailwind/max_width_media_queries.rb
|
|
371
356
|
- lib/rubocop/cop/tailwind/string_interpolation.rb
|
|
372
357
|
- rubocop-all.yml
|
|
@@ -403,7 +388,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
|
403
388
|
requirements:
|
|
404
389
|
- - ">="
|
|
405
390
|
- !ruby/object:Gem::Version
|
|
406
|
-
version: '3.
|
|
391
|
+
version: '3.3'
|
|
407
392
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
|
408
393
|
requirements:
|
|
409
394
|
- - ">="
|
|
@@ -1,99 +0,0 @@
|
|
|
1
|
-
# frozen_string_literal: true
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
# Ensures a line break after guard clauses.
|
|
6
|
-
#
|
|
7
|
-
# @example
|
|
8
|
-
# # bad
|
|
9
|
-
# return unless condition
|
|
10
|
-
# do_stuff
|
|
11
|
-
#
|
|
12
|
-
# # good
|
|
13
|
-
# return unless condition
|
|
14
|
-
#
|
|
15
|
-
# do_stuff
|
|
16
|
-
#
|
|
17
|
-
# # bad
|
|
18
|
-
# raise if condition
|
|
19
|
-
# do_stuff
|
|
20
|
-
#
|
|
21
|
-
# # good
|
|
22
|
-
# raise if condition
|
|
23
|
-
#
|
|
24
|
-
# do_stuff
|
|
25
|
-
#
|
|
26
|
-
# Multiple guard clauses are allowed without
|
|
27
|
-
# line break.
|
|
28
|
-
#
|
|
29
|
-
# # good
|
|
30
|
-
# return unless condition_a
|
|
31
|
-
# return unless condition_b
|
|
32
|
-
#
|
|
33
|
-
# do_stuff
|
|
34
|
-
#
|
|
35
|
-
# Guard clauses in case statement are allowed without
|
|
36
|
-
# line break.
|
|
37
|
-
#
|
|
38
|
-
# # good
|
|
39
|
-
# case model
|
|
40
|
-
# when condition_a
|
|
41
|
-
# return true unless condition_b
|
|
42
|
-
# when
|
|
43
|
-
# ...
|
|
44
|
-
# end
|
|
45
|
-
#
|
|
46
|
-
# Guard clauses before end are allowed without
|
|
47
|
-
# line break.
|
|
48
|
-
#
|
|
49
|
-
# # good
|
|
50
|
-
# if condition_a
|
|
51
|
-
# do_something
|
|
52
|
-
# else
|
|
53
|
-
# do_something_else
|
|
54
|
-
# return unless condition
|
|
55
|
-
# end
|
|
56
|
-
#
|
|
57
|
-
# do_something_more
|
|
58
|
-
class LineBreakAfterGuardClauses < RuboCop::Cop::Base
|
|
59
|
-
extend RuboCop::Cop::AutoCorrector
|
|
60
|
-
|
|
61
|
-
MSG = 'Add a line break after guard clauses'
|
|
62
|
-
|
|
63
|
-
# @!method guard_clause_node?(node)
|
|
64
|
-
def_node_matcher :guard_clause_node?, <<-PATTERN
|
|
65
|
-
[{(send nil? {:raise :fail :throw} ...) return break next} single_line?]
|
|
66
|
-
PATTERN
|
|
67
|
-
|
|
68
|
-
def on_if(node)
|
|
69
|
-
return unless node.single_line?
|
|
70
|
-
return unless guard_clause?(node)
|
|
71
|
-
return if next_line(node).blank? || clause_last_line?(next_line(node)) || guard_clause?(next_sibling(node))
|
|
72
|
-
|
|
73
|
-
add_offense(node) do |corrector|
|
|
74
|
-
corrector.insert_after(node, "\n")
|
|
75
|
-
end
|
|
76
|
-
end
|
|
77
|
-
|
|
78
|
-
private
|
|
79
|
-
|
|
80
|
-
def guard_clause?(node)
|
|
81
|
-
return false unless node.if_type?
|
|
82
|
-
|
|
83
|
-
guard_clause_node?(node.if_branch)
|
|
84
|
-
end
|
|
85
|
-
|
|
86
|
-
def next_sibling(node)
|
|
87
|
-
node.parent.children[node.sibling_index + 1]
|
|
88
|
-
end
|
|
89
|
-
|
|
90
|
-
def next_line(node)
|
|
91
|
-
processed_source[node.loc.line]
|
|
92
|
-
end
|
|
93
|
-
|
|
94
|
-
def clause_last_line?(line)
|
|
95
|
-
line =~ /^\s*(?:end|elsif|else|when|rescue|ensure)/
|
|
96
|
-
end
|
|
97
|
-
end
|
|
98
|
-
end
|
|
99
|
-
end
|
|
@@ -1,49 +0,0 @@
|
|
|
1
|
-
# frozen_string_literal: true
|
|
2
|
-
|
|
3
|
-
module Rubocop
|
|
4
|
-
module Cop
|
|
5
|
-
module Style
|
|
6
|
-
# Flags uses of OpenStruct, as it is now officially discouraged
|
|
7
|
-
# to be used for performance, version compatibility, and potential security issues.
|
|
8
|
-
#
|
|
9
|
-
# @example
|
|
10
|
-
# # bad
|
|
11
|
-
# class SubClass < OpenStruct
|
|
12
|
-
# end
|
|
13
|
-
#
|
|
14
|
-
# # good
|
|
15
|
-
# class SubClass
|
|
16
|
-
# end
|
|
17
|
-
#
|
|
18
|
-
# See also:
|
|
19
|
-
# - https://rubyreferences.github.io/rubychanges/3.0.html#standard-library
|
|
20
|
-
# - https://docs.ruby-lang.org/en/3.0.0/OpenStruct.html#class-OpenStruct-label-Caveats
|
|
21
|
-
# - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67855
|
|
22
|
-
class OpenStructUse < RuboCop::Cop::Base
|
|
23
|
-
MSG = 'Avoid using `OpenStruct`. It is officially discouraged. ' \
|
|
24
|
-
'Replace it with `Struct`, `Hash`, or RSpec doubles. ' \
|
|
25
|
-
'See https://docs.ruby-lang.org/en/3.0.0/OpenStruct.html#class-OpenStruct-label-Caveats'
|
|
26
|
-
|
|
27
|
-
# @!method uses_open_struct?(node)
|
|
28
|
-
def_node_matcher :uses_open_struct?, <<-PATTERN
|
|
29
|
-
(const {nil? (cbase)} :OpenStruct)
|
|
30
|
-
PATTERN
|
|
31
|
-
|
|
32
|
-
def on_const(node)
|
|
33
|
-
return unless uses_open_struct?(node)
|
|
34
|
-
return if custom_class_or_module_definition?(node)
|
|
35
|
-
|
|
36
|
-
add_offense(node)
|
|
37
|
-
end
|
|
38
|
-
|
|
39
|
-
private
|
|
40
|
-
|
|
41
|
-
def custom_class_or_module_definition?(node)
|
|
42
|
-
parent = node.parent
|
|
43
|
-
|
|
44
|
-
parent.type?(:class, :module) && node.left_siblings.empty?
|
|
45
|
-
end
|
|
46
|
-
end
|
|
47
|
-
end
|
|
48
|
-
end
|
|
49
|
-
end
|