gitlab-styles 13.0.0 → 13.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c8f4c0e301ccd103fbf7b527b4fc81563742555650b5e660ff4dcb18bad7de5
-  data.tar.gz: 7eb4ec96135389f35d7a5b5787c9ab1963b4bf670b64417cc1d31000a67f13f0
+  metadata.gz: 1b05957f6a3353a50fe37009f0c78239677857f28e6d16589de5eb3aa8120868
+  data.tar.gz: d3169d41ff1af9327b2e1e3a8fb2a5a2357915542ad0bb3352e52451e3cfb0dc
 SHA512:
-  metadata.gz: a16a93bb989ef4057c9018f4cc8ba0916f31401546c50210d6d97f16445be17b0438a6f07d42d00e7fa1dcad711fb9c6e89aa86f19e08f7af6a3a0979ef47b35
-  data.tar.gz: 8304c777e6c7bac4a57a7583ba580367261483bcef4a4fcb97d81cc7086c76e5b1c8065df78466af537fe4bb2f9a85b4fded2e4841f49aae7a00f5c833fa338b
+  metadata.gz: 53891b9794f187eaa55f40dd87d2f89bbe84d4d7204fb40b40de4b7dc3761b2e4a265a670ed4255d49ef419df682a5d5e44d8283e12d01bf530be1a684527ba2
+  data.tar.gz: d77ec1fb537c34c438527eb019c12bfff2f463bfd78212384f15e2cdd327e5de2cd9572d91d6020ef72f3c885bc4f5de244d5b9a1bc842d2aa0347b0bfb75fbd

data/.gitlab/merge_request_templates/Release.md

@@ -2,7 +2,14 @@
 commit from this merge request, and `<NEW_VERSION>` with the upcoming version number. -->
 ## Diff
 
-https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/compare/v<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
+https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/compare/<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
+
+<!--
+
+NOTE:
+If you are working with a fork use: https://gitlab.com/<YOUR_NAMESPACE>/gitlab-styles/-/compare/<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>?from_project_id=4176070
+
+-->
 
 ## Checklist
 
@@ -10,6 +17,7 @@ https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/compare/v<PREVIOUS_VERSI
 - [ ] Ensure the diff link above is up-to-date.
 - [ ] Add release notes to the [Changelog](#changelog) section below.
 - [ ] Based on the diff and the release notes, update the `version.rb` according to [SemVer](https://semver.org).
+- [ ] Run `bundle install` to update `Gemfile.lock`
 - [ ] Create an MR on `gitlab-org/gitlab` project [with the `New Version of gitlab-styles.md` template](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/New%20Version%20of%20gitlab-styles.md) to test the new version of `gitlab-styles`, and follow the MR instructions.
 
 ## Changelog
@@ -19,7 +27,9 @@ Paste output of:
 
 curl https://gitlab.com/api/v4/projects/4176070/repository/changelog?version=<NEW_VERSION> | jq -r ".notes"
 
-NOTE: Skip `v` in `<NEW_VERSION>`. For example, Use `version=10.0.0` instead of `version=v10.0.0`.
+NOTE:
+Emphasize changes via `**BREAKING CHANGE**` or `**IMPORTANT**` etc. if actions are required by users
+Example: https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/releases/13.0.0
 
 -->
 

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (13.0.0)
-      rubocop (~> 1.66.0)
+    gitlab-styles (13.0.2)
+      rubocop (~> 1.68.0)
       rubocop-capybara (~> 2.21.0)
       rubocop-factory_bot (~> 2.26.1)
       rubocop-graphql (~> 1.5.4)
@@ -156,17 +156,17 @@ GEM
       binding_of_caller
       rspec-parameterized-core (< 2)
     rspec-support (3.12.0)
-    rubocop (1.66.0)
+    rubocop (1.68.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.1, < 2.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.1)
+    rubocop-ast (1.32.3)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)

data/gitlab-styles.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.66.0'
+  spec.add_dependency 'rubocop', '~> 1.68.0'
   spec.add_dependency 'rubocop-capybara', '~> 2.21.0'
   spec.add_dependency 'rubocop-factory_bot', '~> 2.26.1'
   spec.add_dependency 'rubocop-graphql', '~> 1.5.4'

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '13.0.0'
+    VERSION = '13.0.2'
   end
 end

data/lib/rubocop/cop/gitlab_security/json_serialization.rb

@@ -30,7 +30,7 @@ module RuboCop
       #   )
       #
       # See https://gitlab.com/gitlab-org/gitlab-ce/issues/29661
-      class JsonSerialization < RuboCop::Cop::Cop
+      class JsonSerialization < RuboCop::Cop::Base
         MSG = "Don't use `%s` without specifying `only`"
 
         # Check for `to_json` sent to any object that's not a Hash literal or
@@ -72,8 +72,9 @@ module RuboCop
           @method = matched.first
 
           if matched.last.nil? || matched.last.empty?
+            @offense_found = true
             # Empty `to_json` call
-            add_offense(node, location: :selector, message: format_message)
+            add_offense(node.loc.selector, message: format_message)
           else
             check_arguments(node, matched)
           end
@@ -102,6 +103,8 @@ module RuboCop
 
           return unless requires_only?
 
+          @offense_found = true
+
           # Add a top-level offense for the entire argument list, but only if
           # we haven't yet added any offenses to the child Hash values (such
           # as `include`)
@@ -117,6 +120,7 @@ module RuboCop
             includes.each_child_node do |child_node|
               next if contains_only?(child_node)
 
+              @offense_found = true
               add_offense(child_node, message: format_message)
             end
           end
@@ -125,7 +129,7 @@ module RuboCop
         def requires_only?
           return false if @_has_top_level_only
 
-          offenses.count.zero?
+          !@offense_found
         end
       end
     end

data/lib/rubocop/cop/internal_affairs/cop_description_with_example.rb

@@ -90,9 +90,3 @@ module Rubocop
     end
   end
 end
-
-# Don't match files programmatically and use `Include` directives instead.
-# See https://github.com/rubocop/rubocop/pull/13209#issuecomment-2337963170
-class RuboCop::Cop::InternalAffairs::CopDescription
-  remove_method :relevant_file? if instance_method(:relevant_file?)
-end

data/lib/rubocop/cop/tailwind/max_width_media_queries.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Rubocop
+  module Cop
+    module Tailwind
+      # This prevents the use of max-width media query Tailwind CSS utility classes unless absolutely necessary.
+      # min-width media query Tailwind CSS utility classes should be used instead.
+      # @example
+      #   # bad
+      #   css_classes = ["gl-mt-5", "max-md:gl-mt-3"]
+      #   %div{ class: ["gl-mt-5", "max-md:gl-mt-3"] }
+      #
+      #   # good
+      #   css_classes = ["gl-mt-3", "md:gl-mt-5"]
+      #   %div{ class: ["gl-mt-3", "md:gl-mt-5"] }
+      class MaxWidthMediaQueries < RuboCop::Cop::Base
+        TAILWIND_CSS_CLASS = /max-(sm|md|lg|xl):gl-/
+        MSG = 'Do not use max-width media query utility classes unless absolutely necessary. ' \
+          'Use min-width media query utility classes instead.'
+
+        # @!method max_width_media_query_class?(node)
+        def_node_matcher :max_width_media_query_class?, <<~PATTERN
+          (str /#{TAILWIND_CSS_CLASS}/)
+        PATTERN
+
+        def on_str(node)
+          return unless max_width_media_query_class?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/rubocop-rspec.yml

@@ -68,6 +68,11 @@ RSpec/ExampleLength:
   Enabled: false
   Max: 5
 
+# Avoid `it do` instead use `specify do`
+RSpec/ExampleWithoutDescription:
+  Enabled: true
+  EnforcedStyle: single_line_only
+
 # Do not use should when describing your tests.
 RSpec/ExampleWording:
   Enabled: true

data/rubocop-style.yml

@@ -182,11 +182,9 @@ Style/HashLikeCase:
 
 # Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
 # over 1.8 syntax `{ :a => 1, :b => 2 }`.
-# Short-hand Hash syntax does not work prior 3.1.
-# See https://gitlab.com/gitlab-org/gitlab/-/issues/435940#note_1703307479
 Style/HashSyntax:
   Enabled: true
-  EnforcedShorthandSyntax: never
+  EnforcedShorthandSyntax: either_consistent
 
 # looks for uses of _.each_with_object({}) {...}, _.map {...}.to_h, and Hash[_.map {...}]
 # that are actually just transforming the keys of a hash, and tries to use a simpler & faster

data/rubocop-tailwind.yml

@@ -5,3 +5,7 @@ require:
 # Prevent string interpolation when building Tailwind CSS utils names
 Tailwind/StringInterpolation:
   Enabled: false
+
+# Prevent max-width media query Tailwind CSS utility classes. min-width media queries should be used instead.
+Tailwind/MaxWidthMediaQueries:
+  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 13.0.2
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-08 00:00:00.000000000 Z
+date: 2024-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.66.0
+        version: 1.68.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.66.0
+        version: 1.68.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
@@ -365,6 +365,7 @@ files:
 - lib/rubocop/cop/style/hash_transformation.rb
 - lib/rubocop/cop/style/iso8601_date.rb
 - lib/rubocop/cop/style/open_struct_use.rb
+- lib/rubocop/cop/tailwind/max_width_media_queries.rb
 - lib/rubocop/cop/tailwind/string_interpolation.rb
 - rubocop-all.yml
 - rubocop-bundler.yml