gitlab-styles 11.0.0 → 12.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aeba900b1e2b7dc4f6a82fa6defd2daaf2b4c6c87101e1d4fd8b2099e1c00aff
-  data.tar.gz: 02c28507a2a0ed18e555b9d2e44fde520e41de6cccd0e7b77a36b9452b651531
+  metadata.gz: 5301968fa7603c90e9ed917011c49e4a3124a7c442963e778fcc1f4862c7cf03
+  data.tar.gz: 4b7676b2fcdb2bed6f3be9c8b0505ba04afa5ec008e95b6c980da5ef3a795032
 SHA512:
-  metadata.gz: 1ba653a6135f6cd2cb62268e6ee7df569827c3e6958763acb0d8b1d263192fbcf5634168266c60c13df05cd8635e9ca65560965a19ad2fb2a1816a6982cfefb6
-  data.tar.gz: 5da95736858e333062c060a33069a248e4b15824fd0d6c759a2c223e3c772a164534c9c2741760dd17d65eee67f98e1b0909d2f4199d96081e16de91967b8f69
+  metadata.gz: bcb7c63e4e3cacd1638d87b2406483d763ecad6dbdb218a3da292f8be56112ca64d0d1596ac108143981d502834f6672e4c9128981edc8b6bd05566c924289f7
+  data.tar.gz: e08bb7c660e85a30ffc64d669363e6b420219745231a5ea7e5524e657ae72c4f6b1fcb00c9d01d31c9bb846c5d8be57db22d8640dff67ae554f76db2092375ae

data/.gitlab-ci.yml

@@ -1,44 +1,43 @@
+workflow:
+  rules:
+    # For merge requests, create a pipeline.
+    - if: '$CI_MERGE_REQUEST_IID'
+    # For the default branch, create a pipeline (this includes on schedules, pushes, merges, etc.).
+    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+    # For tags, create a pipeline.
+    - if: '$CI_COMMIT_TAG'
+
 stages:
   - test
   - deploy
 
 default:
-  image: "ruby:${RUBY_VERSION}"
   tags:
     - gitlab-org
+
+.base-ruby-job:
+  image: "ruby:${RUBY_VERSION}"
   before_script:
     - bundle --version
-    - bundle install
-
-variables:
-  BUNDLE_FROZEN: 'true'
-
-workflow:
-  rules:
-    # For merge requests, create a pipeline.
-    - if: '$CI_MERGE_REQUEST_IID'
-    # For the default branch, create a pipeline (this includes on schedules, pushes, merges, etc.).
-    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
-    # For tags, create a pipeline.
-    - if: '$CI_COMMIT_TAG'
+    - bundle config set --local deployment 'true'
+    - bundle install -j $(nproc)
+  parallel:
+    matrix:
+      - RUBY_VERSION: ['3.0', '3.1', '3.2']
 
 styles:
+  extends: .base-ruby-job
   stage: test
   script:
     - bundle exec rubocop --debug --parallel
-  parallel:
-    matrix:
-      - RUBY_VERSION: ['2.7', '3.0', '3.1', '3.2']
 
 specs:
+  extends: .base-ruby-job
   stage: test
   script:
     # Disable simplecov for all Ruby version other than 3.0
     - if [[ "$RUBY_VERSION" != "3.0" ]]; then export SIMPLECOV=0; fi
     - bundle exec rspec
-  parallel:
-    matrix:
-      - RUBY_VERSION: ['2.7', '3.0', '3.1', '3.2']
   artifacts:
     name: coverage
     expire_in: 31d
@@ -51,7 +50,25 @@ specs:
         path: coverage/coverage.xml
 
 include:
-  - project: 'gitlab-org/quality/pipeline-common'
-    file:
-      - '/ci/gem-release.yml'
-      - '/ci/danger-review.yml'
+  - component: gitlab.com/components/sast/sast@~latest
+  - component: gitlab.com/components/secret-detection/secret-detection@~latest
+  - component: gitlab.com/gitlab-org/components/gem-release/gem-release@~latest
+    inputs:
+      smoke_test_script: "ruby -r 'gitlab/styles' -e \"puts Gitlab::Styles::VERSION\""
+  - template: Security/Dependency-Scanning.gitlab-ci.yml
+  - component: gitlab.com/gitlab-org/components/danger-review/danger-review@~latest
+
+semgrep-sast:
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+
+gemnasium-dependency_scanning:
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+
+secret_detection:
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-06-05 10:15:47 UTC using RuboCop version 1.50.2.
+# on 2024-01-24 13:27:15 UTC using RuboCop version 1.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -25,12 +25,3 @@ InternalAffairs/MissingCopDepartment:
     - 'lib/rubocop/cop/polymorphic_associations.rb'
     - 'lib/rubocop/cop/redirect_with_status.rb'
     - 'lib/rubocop/cop/without_reactive_cache.rb'
-
-# Offense count: 5
-InternalAffairs/UseRestrictOnSend:
-  Exclude:
-    - 'lib/rubocop/cop/active_record_dependent.rb'
-    - 'lib/rubocop/cop/active_record_serialize.rb'
-    - 'lib/rubocop/cop/in_batches.rb'
-    - 'lib/rubocop/cop/polymorphic_associations.rb'
-    - 'lib/rubocop/cop/without_reactive_cache.rb'

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (11.0.0)
-      rubocop (~> 1.57.1)
-      rubocop-graphql (~> 0.18)
-      rubocop-performance (~> 1.15)
-      rubocop-rails (~> 2.17)
-      rubocop-rspec (~> 2.22)
+    gitlab-styles (12.0.1)
+      rubocop (~> 1.62.1)
+      rubocop-factory_bot (~> 2.25.1)
+      rubocop-graphql (~> 1.5.0)
+      rubocop-performance (~> 1.20.2)
+      rubocop-rails (~> 2.24.0)
+      rubocop-rspec (~> 2.27.1)
 
 GEM
   remote: https://rubygems.org/
@@ -19,7 +20,6 @@ GEM
     addressable (2.8.5)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
-    base64 (0.1.1)
     binding_of_caller (1.0.0)
       debug_inspector (>= 0.0.1)
     byebug (11.1.3)
@@ -92,7 +92,7 @@ GEM
       multi_xml (>= 0.5.2)
     i18n (1.13.0)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
+    json (2.7.1)
     kramdown (2.4.0)
       rexml
     kramdown-parser-gfm (1.1.0)
@@ -110,8 +110,8 @@ GEM
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
     open4 (1.3.4)
-    parallel (1.23.0)
-    parser (3.2.2.4)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
     proc_to_ast (0.1.0)
@@ -125,12 +125,12 @@ GEM
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
     public_suffix (5.0.3)
-    racc (1.7.1)
+    racc (1.7.3)
     rack (3.0.7)
     rainbow (3.1.1)
     rake (13.0.6)
     rchardet (1.8.0)
-    regexp_parser (2.8.1)
+    regexp_parser (2.8.3)
     rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
@@ -153,37 +153,37 @@ GEM
       binding_of_caller
       rspec-parameterized-core (< 2)
     rspec-support (3.12.0)
-    rubocop (1.57.1)
-      base64 (~> 0.1.1)
+    rubocop (1.62.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.4)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.29.0)
-      parser (>= 3.2.1.0)
-    rubocop-capybara (2.19.0)
+    rubocop-ast (1.31.2)
+      parser (>= 3.3.0.4)
+    rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.24.0)
-      rubocop (~> 1.33)
-    rubocop-graphql (0.19.0)
-      rubocop (>= 0.87, < 2)
-    rubocop-performance (1.19.1)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.19.1)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-graphql (1.5.0)
+      rubocop (>= 0.90, < 2)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.24.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.24.1)
-      rubocop (~> 1.33)
+    rubocop-rspec (2.27.1)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)

data/README.md

@@ -91,7 +91,7 @@ To release a new version:
 1. Create a Merge Request.
 1. Use Merge Request template [Release.md](https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/blob/master/.gitlab/merge_request_templates/Release.md).
 1. Follow the instructions.
-1. After the Merge Request has been merged, a new gem version is [published automatically](https://gitlab.com/gitlab-org/quality/pipeline-common/-/blob/master/ci/gem-release.yml).
+1. After the Merge Request has been merged, a new gem version is [published automatically](https://gitlab.com/gitlab-org/components/gem-release).
 1. Once the new gem version is visible on [RubyGems.org](https://rubygems.org/gems/gitlab-styles), it is recommended to update [GitLab's `Gemfile`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/Gemfile) to bump the `gitlab-styles` Ruby gem to the new version also.
 
 See [!123](https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/123) as an example.

data/gitlab-styles.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gitlab/styles/version'
 
 Gem::Specification.new do |spec|
-  spec.required_ruby_version = '>= 2.6'
+  spec.required_ruby_version = '>= 3.0'
   spec.name          = 'gitlab-styles'
   spec.version       = Gitlab::Styles::VERSION
   spec.authors       = ['GitLab']
@@ -22,11 +22,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.57.1'
-  spec.add_dependency 'rubocop-graphql', '~> 0.18'
-  spec.add_dependency 'rubocop-performance', '~> 1.15'
-  spec.add_dependency 'rubocop-rails', '~> 2.17'
-  spec.add_dependency 'rubocop-rspec', '~> 2.22'
+  spec.add_dependency 'rubocop', '~> 1.62.1'
+  spec.add_dependency 'rubocop-factory_bot', '~> 2.25.1'
+  spec.add_dependency 'rubocop-graphql', '~> 1.5.0'
+  spec.add_dependency 'rubocop-performance', '~> 1.20.2'
+  spec.add_dependency 'rubocop-rails', '~> 2.24.0'
+  spec.add_dependency 'rubocop-rspec', '~> 2.27.1'
 
   spec.add_development_dependency 'bundler', '~> 2.1'
   spec.add_development_dependency 'gitlab-dangerfiles', '~> 4.6.0'

data/lib/gitlab/styles/rubocop.rb

@@ -2,7 +2,7 @@
 
 # Auto-require all cops under `rubocop/cop/**/*.rb`
 cops_glob = File.join(__dir__, '..', '..', 'rubocop', 'cop', '**', '*.rb')
-Dir[cops_glob].sort.each { |cop| require(cop) }
+Dir[cops_glob].each { |cop| require(cop) }
 
 module Gitlab
   module Styles

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '11.0.0'
+    VERSION = '12.0.1'
   end
 end

data/lib/rubocop/cop/active_record_dependent.rb

@@ -5,21 +5,19 @@ module Rubocop
     # Cop that prevents the use of `dependent: ...` in ActiveRecord models.
     class ActiveRecordDependent < RuboCop::Cop::Base
       MSG = 'Do not use `dependent:` to remove associated data, ' \
-            'use foreign keys with cascading deletes instead.'
+        'use foreign keys with cascading deletes instead.'
 
-      METHOD_NAMES = [:has_many, :has_one, :belongs_to].freeze
-      ALLOWED_OPTIONS = [:restrict_with_error].freeze
+      RESTRICT_ON_SEND = %i[has_many has_one belongs_to].to_set.freeze
+      ALLOWED_OPTIONS = %i[restrict_with_error].freeze
 
-      def on_send(node)
-        return unless METHOD_NAMES.include?(node.children[1])
-
-        node.children.last.each_node(:pair) do |pair|
-          key_name = pair.children[0].children[0]
-          option_name = pair.children[1].children[0]
+      # @!method dependent_use(node)
+      def_node_matcher :dependent_use, <<~PATTERN
+        (send _ %RESTRICT_ON_SEND ... (hash <$(pair (sym :dependent) (sym $_)) ...>))
+      PATTERN
 
-          break if ALLOWED_OPTIONS.include?(option_name)
-
-          add_offense(pair) if key_name == :dependent
+      def on_send(node)
+        dependent_use(node) do |pair, value|
+          add_offense(pair) unless ALLOWED_OPTIONS.include?(value)
         end
       end
     end

data/lib/rubocop/cop/active_record_serialize.rb

@@ -6,8 +6,12 @@ module Rubocop
     class ActiveRecordSerialize < RuboCop::Cop::Base
       MSG = 'Do not store serialized data in the database, use separate columns and/or tables instead'
 
+      RESTRICT_ON_SEND = %i[serialize].freeze
+
       def on_send(node)
-        add_offense(node.loc.selector) if node.children[1] == :serialize
+        return if node.receiver
+
+        add_offense(node.loc.selector)
       end
     end
   end

data/lib/rubocop/cop/code_reuse/active_record.rb

@@ -6,7 +6,7 @@ module Rubocop
       # Cop that denies the use of ActiveRecord methods outside of models.
       class ActiveRecord < RuboCop::Cop::Base
         MSG = 'This method can only be used inside an ActiveRecord model: ' \
-              'https://gitlab.com/gitlab-org/gitlab-foss/issues/49653'
+          'https://gitlab.com/gitlab-org/gitlab-foss/issues/49653'
 
         # Various methods from ActiveRecord::Querying that are denied. We
         # exclude some generic ones such as `any?` and `first`, as these may

data/lib/rubocop/cop/gem_fetcher.rb

@@ -7,7 +7,7 @@ module Rubocop
     # rubygems.org.
     class GemFetcher < RuboCop::Cop::Base
       MSG = 'Do not use gems from git repositories, only use gems from RubyGems or vendored gems. ' \
-            'See https://docs.gitlab.com/ee/development/gemfile.html#no-gems-fetched-from-git-repositories'
+        'See https://docs.gitlab.com/ee/development/gemfile.html#no-gems-fetched-from-git-repositories'
 
       # See https://bundler.io/guides/git.html#custom-git-sources
       GIT_SOURCES = %i[git github gist bitbucket].freeze

data/lib/rubocop/cop/gitlab_security/redirect_to_params_update.rb

@@ -17,7 +17,7 @@ module RuboCop
       #
       class RedirectToParamsUpdate < RuboCop::Cop::Base
         MSG = 'Avoid using `redirect_to(params.%<name>s(...))`. ' \
-              'Only pass allowed arguments into redirect_to() (e.g. not including `host`)'
+          'Only pass allowed arguments into redirect_to() (e.g. not including `host`)'
 
         # @!method redirect_to_params_update_node(node)
         def_node_matcher :redirect_to_params_update_node, <<-PATTERN

data/lib/rubocop/cop/gitlab_security/send_file_params.rb

@@ -21,7 +21,7 @@ module RuboCop
       #
       class SendFileParams < RuboCop::Cop::Base
         MSG = 'Do not pass user provided params directly to send_file(), ' \
-              'verify the path with file.expand_path() first.'
+          'verify the path with file.expand_path() first.'
 
         # @!method params_node?(node)
         def_node_search :params_node?, <<-PATTERN

data/lib/rubocop/cop/gitlab_security/system_command_injection.rb

@@ -19,7 +19,7 @@ module RuboCop
       #
       class SystemCommandInjection < RuboCop::Cop::Base
         MSG = 'Do not include variables in the command name for system(). ' \
-              'Use parameters "system(cmd, params)" or exec() instead.'
+          'Use parameters "system(cmd, params)" or exec() instead.'
 
         # @!method system_var?(node)
         def_node_matcher :system_var?, <<-PATTERN

data/lib/rubocop/cop/in_batches.rb

@@ -6,9 +6,9 @@ module Rubocop
     class InBatches < RuboCop::Cop::Base
       MSG = 'Do not use `in_batches`, use `each_batch` from the EachBatch module instead'
 
-      def on_send(node)
-        return unless node.children[1] == :in_batches
+      RESTRICT_ON_SEND = %i[in_batches].freeze
 
+      def on_send(node)
         add_offense(node.loc.selector)
       end
     end

data/lib/rubocop/cop/internal_affairs/use_restrict_on_send.rb

@@ -43,7 +43,7 @@ module RuboCop
       #   end
       class UseRestrictOnSend < Base
         MSG = 'Define constant `RESTRICT_ON_SEND` to speed up calls to `on_send`. ' \
-              'The following line is then no longer necessary:'
+          'The following line is then no longer necessary:'
 
         # @!method method_name_plain(node)
         def_node_matcher :method_name_plain, <<~PATTERN

data/lib/rubocop/cop/layout/line_break_after_final_mixin.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Layout
+      # Checks if there is an empty line after the last include/extend/prepend.
+      #
+      # @example
+      #   # bad
+      #   class Hello
+      #     include Something1
+      #     include Something2
+      #     def world
+      #     end
+      #   end
+
+      #   # good
+      #   class Hello
+      #     include Something1
+      #     include Something2
+      #
+      #     def world
+      #     end
+      #   end
+      class LineBreakAfterFinalMixin < RuboCop::Cop::Base
+        extend RuboCop::Cop::AutoCorrector
+
+        MSG = 'Add an empty line after the last `%<mixin>s`.'
+
+        MIXIN_METHODS = %i[include extend prepend].to_set.freeze
+
+        # @!method mixin?(node)
+        def_node_matcher :mixin?, <<~PATTERN
+          (send {nil? | self} MIXIN_METHODS ...)
+        PATTERN
+
+        def on_class(node)
+          return unless node.body
+
+          mixins = node.body.child_nodes.select { |child| mixin?(child) }
+
+          return if mixins.empty?
+
+          last_mixin = mixins.last
+
+          return if next_line_valid?(last_mixin)
+
+          add_offense(last_mixin, message: format(MSG, mixin: last_mixin.method_name)) do |corrector|
+            corrector.insert_after(last_mixin, "\n")
+          end
+        end
+
+        private
+
+        def next_line_valid?(node)
+          next_line = next_line(node)
+
+          empty_line?(next_line) || end_line?(next_line)
+        end
+
+        def next_line(node)
+          processed_source[node.loc.line]
+        end
+
+        def empty_line?(line)
+          line.empty?
+        end
+
+        def end_line?(line)
+          /^\s*end\b/.match?(line)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/migration/update_large_table.rb

@@ -18,8 +18,8 @@ module Rubocop
         include Gitlab::Styles::Rubocop::MigrationHelpers
 
         MSG = 'Using `%s` on the `%s` table will take a long time to ' \
-              'complete, and should be avoided unless absolutely ' \
-              'necessary'
+          'complete, and should be avoided unless absolutely ' \
+          'necessary'
 
         # @!method batch_update?(node)
         def_node_matcher :batch_update?, <<~PATTERN

data/lib/rubocop/cop/performance/rubyzip.rb

@@ -13,10 +13,10 @@ module Rubocop
       # - https://github.com/rubyzip/rubyzip#notes-on-zipinputstream
       class Rubyzip < RuboCop::Cop::Base
         MSG = 'Be careful when opening or iterating zip files via Zip::File. ' \
-              'Zip archives may contain many entries, and their file index is ' \
-              'read into memory upon construction, which can lead to ' \
-              'high memory use and poor performance. ' \
-              'Consider iterating archive entries via Zip::InputStream instead.'
+          'Zip archives may contain many entries, and their file index is ' \
+          'read into memory upon construction, which can lead to ' \
+          'high memory use and poor performance. ' \
+          'Consider iterating archive entries via Zip::InputStream instead.'
 
         # @!method reads_central_directory?(node)
         def_node_matcher :reads_central_directory?, <<-PATTERN

data/lib/rubocop/cop/polymorphic_associations.rb

@@ -6,13 +6,16 @@ module Rubocop
     class PolymorphicAssociations < RuboCop::Cop::Base
       MSG = 'Do not use polymorphic associations, use separate tables instead'
 
-      def on_send(node)
-        return unless node.children[1] == :belongs_to
+      RESTRICT_ON_SEND = %i[belongs_to].to_set.freeze
 
-        node.children.last.each_node(:pair) do |pair|
-          key_name = pair.children[0].children[0]
+      # @!method polymorphic_pair(node)
+      def_node_matcher :polymorphic_pair, <<~PATTERN
+        (send _ %RESTRICT_ON_SEND ... (hash <$(pair (sym :polymorphic) _) ...>))
+      PATTERN
 
-          add_offense(pair) if key_name == :polymorphic
+      def on_send(node)
+        polymorphic_pair(node) do |pair|
+          add_offense(pair)
         end
       end
     end

data/lib/rubocop/cop/style/open_struct_use.rb

@@ -12,8 +12,8 @@ module Rubocop
       # - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67855
       class OpenStructUse < RuboCop::Cop::Base
         MSG = 'Avoid using `OpenStruct`. It is officially discouraged. ' \
-              'Replace it with `Struct`, `Hash`, or RSpec doubles. ' \
-              'See https://docs.ruby-lang.org/en/3.0.0/OpenStruct.html#class-OpenStruct-label-Caveats'
+          'Replace it with `Struct`, `Hash`, or RSpec doubles. ' \
+          'See https://docs.ruby-lang.org/en/3.0.0/OpenStruct.html#class-OpenStruct-label-Caveats'
 
         # @!method uses_open_struct?(node)
         def_node_matcher :uses_open_struct?, <<-PATTERN

data/lib/rubocop/cop/without_reactive_cache.rb

@@ -6,9 +6,9 @@ module Rubocop
     class WithoutReactiveCache < RuboCop::Cop::Base
       MSG = 'without_reactive_cache is for debugging purposes only. Please use with_reactive_cache.'
 
-      def on_send(node)
-        return unless node.children[1] == :without_reactive_cache
+      RESTRICT_ON_SEND = %i[without_reactive_cache].freeze
 
+      def on_send(node)
         add_offense(node.loc.selector)
       end
     end

data/rubocop-all.yml

@@ -1,6 +1,7 @@
 ---
 AllCops:
-  TargetRubyVersion: 2.6
+  # The oldest supported Ruby version.
+  TargetRubyVersion: 3.0
   # Cop names are not displayed in offense messages by default. Change behavior
   # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
   # option.

data/rubocop-default.yml

@@ -1,26 +1,12 @@
 ---
 require:
-  - rubocop-performance
-  - rubocop-rspec
-  - rubocop-rails
-  - rubocop-graphql
   - ./lib/gitlab/styles/rubocop
 
 inherit_from:
   - rubocop-all.yml
-  - rubocop-bundler.yml
+  - rubocop-minimal.yml
   - rubocop-capybara.yml
-  - rubocop-fips.yml
-  - rubocop-gemspec.yml
   - rubocop-graphql.yml
   - rubocop-internal-affairs.yml
-  - rubocop-layout.yml
-  - rubocop-lint.yml
-  - rubocop-metrics.yml
   - rubocop-migrations.yml
-  - rubocop-naming.yml
-  - rubocop-performance.yml
   - rubocop-rails.yml
-  - rubocop-rspec.yml
-  - rubocop-security.yml
-  - rubocop-style.yml

data/rubocop-factory_bot.yml

@@ -0,0 +1,8 @@
+---
+require:
+  - ./lib/gitlab/styles/rubocop
+
+# Check for create_list FactoryBot declarations higher than MaxAmount
+FactoryBot/ExcessiveCreateList:
+  Enabled: true
+  MaxAmount: 10

data/rubocop-graphql.yml

@@ -18,12 +18,38 @@ GraphQL/ExtractInputType:
 
 # Suggests extracting fields with common prefixes to the separate type
 GraphQL/ExtractType:
-  Enabled: false
+  Enabled: true
+
+# Enforce use of `graphql_name` in GrahQL types.
+GraphQL/GraphqlName:
+  EnforcedStyle: required
 
 # Checks that types are defined with class-based API
 GraphQL/LegacyDsl:
   Enabled: false
 
+# Detects missing max_complexity configuration in schema files.
+# Max complexity is defined in a different way.
+# See https://gitlab.com/gitlab-org/gitlab/-/blob/9c0dfedd80ede7dbdcc92cf3f5b14bf36998e85c/app/graphql/gitlab_schema.rb#L41-44
+GraphQL/MaxComplexitySchema:
+  Enabled: false
+
+# Detects missing max_depth configuration in schema files.
+# Max depth is defined in a different way.
+# See https://gitlab.com/gitlab-org/gitlab/-/blob/9c0dfedd80ede7dbdcc92cf3f5b14bf36998e85c/app/graphql/gitlab_schema.rb#L41-45
+GraphQL/MaxDepthSchema:
+  Enabled: false
+
+# Detects types that implement Node interface and not have `.authorized?` check.
+# `authorize` is used instead.
+GraphQL/NotAuthorizedNodeType:
+  Enabled: false
+
+# Checks that GraphQL Argument definitions prepare arguments to allow better Sorbet typing.
+# Sorbet is not (yet) used.
+GraphQL/PrepareMethod:
+  Enabled: false
+
 # Ensures all types have a description
 # Disabled because our bespoke Graphql/Descriptions cop covers this.
 GraphQL/ObjectDescription:

data/rubocop-layout.yml

@@ -1,4 +1,7 @@
 ---
+require:
+  - ./lib/gitlab/styles/rubocop
+
 # Check indentation of private/protected visibility modifiers.
 Layout/AccessModifierIndentation:
   Enabled: true
@@ -154,11 +157,9 @@ Layout/IndentationWidth:
 Layout/LeadingCommentSpace:
   Enabled: true
 
-# Limit lines to 120 characters.
-Layout/LineLength:
+# Checks if there is an empty line after the last include/extend/prepend.
+Layout/LineBreakAfterFinalMixin:
   Enabled: true
-  Max: 120
-  AllowedPatterns: ['\s#\srubocop']
 
 # Checks that strings broken over multiple lines (by a backslash) contain
 # trailing spaces instead of leading spaces (default) or leading spaces instead
@@ -171,6 +172,12 @@ Layout/LineContinuationLeadingSpace:
 Layout/LineContinuationSpacing:
   Enabled: true
 
+# Limit lines to 120 characters.
+Layout/LineLength:
+  Enabled: true
+  Max: 120
+  AllowedPatterns: ['\s#\srubocop']
+
 # Checks that the closing brace in an array literal is either on the same line
 # as the last array element, or a new line.
 Layout/MultilineArrayBraceLayout:
@@ -185,6 +192,7 @@ Layout/MultilineBlockLayout:
 # literal and a backslash.
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
+  EnforcedStyle: indented
 
 # Checks that the closing brace in a hash literal is either on the same line as
 # the last hash element, or a new line.
@@ -309,3 +317,7 @@ Layout/TrailingEmptyLines:
 # Avoid trailing whitespace.
 Layout/TrailingWhitespace:
   Enabled: true
+
+# checks if the code style follows the ExpectedOrder
+Layout/ClassStructure:
+  Enabled: true

data/rubocop-minimal.yml

@@ -0,0 +1,17 @@
+---
+# This are the cops that has no external dependency on Rails specific code
+# or GitLab specific code
+#
+# It is intended to be used by any of our Ruby Gems that are plain ruby code only
+inherit_from:
+  - rubocop-bundler.yml
+  - rubocop-fips.yml
+  - rubocop-gemspec.yml
+  - rubocop-layout.yml
+  - rubocop-lint.yml
+  - rubocop-metrics.yml
+  - rubocop-naming.yml
+  - rubocop-performance.yml
+  - rubocop-rspec.yml
+  - rubocop-security.yml
+  - rubocop-style.yml

data/rubocop-rspec.yml

@@ -1,12 +1,8 @@
 ---
 require:
+  - rubocop-rspec
   - ./lib/gitlab/styles/rubocop
 
-# Check for create_list FactoryBot declarations higher than MaxAmount
-RSpec/FactoryBot/ExcessiveCreateList:
-  Enabled: true
-  MaxAmount: 10
-
 # Check that instances are not being stubbed globally.
 RSpec/AnyInstance:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 12.0.1
 platform: ruby
 authors:
 - GitLab
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-11-08 00:00:00.000000000 Z
+date: 2024-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,70 +16,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.57.1
+        version: 1.62.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.57.1
+        version: 1.62.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.25.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.25.1
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: 1.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: 1.5.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 1.20.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 1.20.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.17'
+        version: 2.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.17'
+        version: 2.24.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: 2.27.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: 2.27.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -248,7 +262,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.1.4
-description: 
+description:
 email:
 - gitlab_rubygems@gitlab.com
 executables: []
@@ -302,6 +316,7 @@ files:
 - lib/rubocop/cop/internal_affairs/deprecate_cop_helper.rb
 - lib/rubocop/cop/internal_affairs/missing_cop_department.rb
 - lib/rubocop/cop/internal_affairs/use_restrict_on_send.rb
+- lib/rubocop/cop/layout/line_break_after_final_mixin.rb
 - lib/rubocop/cop/line_break_after_guard_clauses.rb
 - lib/rubocop/cop/line_break_around_conditional_block.rb
 - lib/rubocop/cop/migration/update_large_table.rb
@@ -313,7 +328,6 @@ files:
 - lib/rubocop/cop/rspec/empty_line_after_let_block.rb
 - lib/rubocop/cop/rspec/empty_line_after_shared_example.rb
 - lib/rubocop/cop/rspec/example_starting_character.rb
-- lib/rubocop/cop/rspec/factory_bot/excessive_create_list.rb
 - lib/rubocop/cop/rspec/have_link_parameters.rb
 - lib/rubocop/cop/rspec/single_line_hook.rb
 - lib/rubocop/cop/rspec/specify_expected.rb
@@ -327,6 +341,7 @@ files:
 - rubocop-capybara.yml
 - rubocop-code_reuse.yml
 - rubocop-default.yml
+- rubocop-factory_bot.yml
 - rubocop-fips.yml
 - rubocop-gemspec.yml
 - rubocop-graphql.yml
@@ -335,6 +350,7 @@ files:
 - rubocop-lint.yml
 - rubocop-metrics.yml
 - rubocop-migrations.yml
+- rubocop-minimal.yml
 - rubocop-naming.yml
 - rubocop-performance.yml
 - rubocop-rails.yml
@@ -345,7 +361,7 @@ homepage: https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -353,15 +369,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.27
+signing_key:
 specification_version: 4
 summary: GitLab style guides and shared style configs.
 test_files: []

data/lib/rubocop/cop/rspec/factory_bot/excessive_create_list.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-require 'rubocop-rspec'
-require_relative '../base'
-
-module Rubocop
-  module Cop
-    module RSpec
-      module FactoryBot
-        # Check for create_list FactoryBot declarations higher than configured MaxAmount.
-        #
-        # @example MaxAmount: 20
-        #   We do not allow more than 20 items to be created.
-        #
-        #   # bad
-        #   create_list(:merge_request, 1000, state: :opened)
-        #
-        #   # good
-        #   create_list(:merge_request, 15, state: :opened)
-        #
-        # @example
-        #   We do not allow more than 10 items to be created (default)
-        #   # bad
-        #   create_list(:merge_request, 1000, state: :opened)
-        #
-        #   # good
-        #   create_list(:merge_request, 10, state: :opened)
-        #
-        class ExcessiveCreateList < Base
-          MESSAGE = 'Avoid using `create_list` with more than %{max_amount} items.'
-
-          # @!method create_list?(node)
-          def_node_matcher :create_list?, <<~PATTERN
-            (send nil? :create_list (sym ...) $(int _) ...)
-          PATTERN
-
-          RESTRICT_ON_SEND = %i[create_list].freeze
-
-          def on_send(node)
-            number_node = create_list?(node)
-            return unless number_node
-
-            max_amount = cop_config['MaxAmount']
-            return if number_node.value <= max_amount
-
-            add_offense(number_node, message: format(MESSAGE, max_amount: max_amount))
-          end
-        end
-      end
-    end
-  end
-end