gitlab-secret_detection 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7ff1ed2f6fa1d52463144cfacf4a23bd191822d6660e5f4d3c15cefb349b9dd
-  data.tar.gz: 13af55c3efd41733108968de3d0c8d03648c726947170636a293db174521a81e
+  metadata.gz: cc8541d1251962126cc8a11d661098fbe0713e610f849b554a50ab5cfe546a99
+  data.tar.gz: fc3eea2fbdbc233d0c8198a6cbf43c56d07d762777389f830422be26e90b714a
 SHA512:
-  metadata.gz: 6698802604dffeff97940812c8463dbb21c73698c8f438e825b482d5dc68c97953aaa983d03af7de26f37ff9ec7d1e1418966e495c2ef8f308eb05f40d4ae601
-  data.tar.gz: b6e1b308dddfa644500184058228faf67458702c82994fc9c475ce03ef47a51323f309c1163287a2d1ce0bbd13aaec2a19c71e4a8ca711f6a6beaefbda2649d1
+  metadata.gz: e7c0872064c6c85526ed8fb1d75a5d4ce11bbdf53498db161be7cd6fb54bf4f25e37b798ddd5e38c73762519f9b0d87d63e322706af7349181c832277c435421
+  data.tar.gz: 60b1d7ea4993b00cc2435bff4f0fae542d66c6ec2d1f58fafc47ce2850db0bb55c3a49b8b5e5fb9fa88fe277f941021792efc2892bd816109992438de6bfb888

data/README.md

@@ -329,9 +329,9 @@ Secret Detection service's status can be tracked here: https://gitlab.com/gitlab
 
 #### Changes made in the secret detection logic that were previously not present in the Gem
 
-- [GitLab::SecretDetection::Core::Scanner#initialize(...)](lib/gitlab/secret_detection/core/scanner.rb): To reuse the logic of ruleset parsing from a file source, we parse the ruleset file at once and pass the parsed rules around. So,
+- [Gitlab::SecretDetection::Core::Scanner#initialize(...)](lib/gitlab/secret_detection/core/scanner.rb): To reuse the logic of ruleset parsing from a file source, we parse the ruleset file at once and pass the parsed rules around. So,
 the `initialize()` method now accepts parsed rules instead of ruleset file path
-- [GitLab::SecretDetection::Core::Status](lib/gitlab/secret_detection/core/status.rb): `NOT_FOUND` status moved from `0` to `7` since
+- [Gitlab::SecretDetection::Core::Status](lib/gitlab/secret_detection/core/status.rb): `NOT_FOUND` status moved from `0` to `7` since
 gRPC reserves `0` for enums. We need to reflect this change on the Rails side too
-- [GitLab::SecretDetection::Core::Scanner#scan(...)](lib/gitlab/secret_detection/core/scanner.rb): Introduced `rule_exclusions`, `raw_value_exclusions` and `tags` args to `scan(..)`
+- [Gitlab::SecretDetection::Core::Scanner#scan(...)](lib/gitlab/secret_detection/core/scanner.rb): Introduced `rule_exclusions`, `raw_value_exclusions` and `tags` args to `scan(..)`
 method to suport [exclusions](https://gitlab.com/groups/gitlab-org/-/epics/14315) feature.

data/lib/gitlab/secret_detection/core/finding.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
       # Finding is a data object representing a secret finding identified within a payload

data/lib/gitlab/secret_detection/core/response.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
       # Response is the data object returned by the scan operation with the following structure
       #
-      # +status+:: One of values from GitLab::SecretDetection::Core::Status indicating the scan operation's status
-      # +results+:: Array of GitLab::SecretDetection::Core::Finding values. Default value is nil.
+      # +status+:: One of values from Gitlab::SecretDetection::Core::Status indicating the scan operation's status
+      # +results+:: Array of Gitlab::SecretDetection::Core::Finding values. Default value is nil.
       # +metadata+:: Hash object containing additional meta information about the response. It is currently used
       #   to embed more information on error.
       class Response

data/lib/gitlab/secret_detection/core/ruleset.rb

@@ -3,7 +3,7 @@
 require 'toml-rb'
 require 'logger'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
       class Ruleset

data/lib/gitlab/secret_detection/core/scanner.rb

@@ -4,8 +4,9 @@ require 're2'
 require 'logger'
 require 'timeout'
 require 'English'
+require 'parallel'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
       # Scan is responsible for running Secret Detection scan operation
@@ -24,6 +25,14 @@ module GitLab
         DEFAULT_PAYLOAD_TIMEOUT_SECS = 30 # 30 seconds
         # Tags used for creating default pattern matcher
         DEFAULT_PATTERN_MATCHER_TAGS = ['gitlab_blocking'].freeze
+        # Max no of child processes to spawn per request
+        # ref: https://gitlab.com/gitlab-org/gitlab/-/issues/430160
+        MAX_PROCS_PER_REQUEST = 5
+        # Minimum cumulative size of the payloads required to spawn and
+        # run the scan within a new subprocess.
+        MIN_CHUNK_SIZE_PER_PROC_BYTES = 2_097_152 # 2MiB
+        # Whether to run scan in subprocesses or not. Default is false.
+        RUN_IN_SUBPROCESS = false
 
         # Initializes the instance with logger along with following operations:
         # 1. Extract keywords from the parsed ruleset to use it for matching keywords before regex operation.
@@ -52,13 +61,20 @@ module GitLab
         #                  the scan duration on each payload
         # +raw_value_exclusions:+:: Array of raw values to exclude from the scan.
         # +rule_exclusions+:: Array of rules to exclude from the ruleset used for the scan. Each rule is represented
-        #           by its ID. For example: `gitlab_personal_access_token` for representing GitLab Personal Access
+        #           by its ID. For example: `gitlab_personal_access_token` for representing Gitlab Personal Access
         #           Token. By default, no rule is excluded from the ruleset.
         # +tags+:: Array of tag values to filter from the default ruleset when determining the rules used for the scan.
         #           For example: Add `gitlab_blocking` to include only rules for Push Protection. Defaults to
         #           [`gitlab_blocking`] (+DEFAULT_PATTERN_MATCHER_TAGS+).
         #
-        # Returns an instance of GitLab::SecretDetection::Core::Response by following below structure:
+        # NOTE:
+        # Running the scan in fork mode primarily focuses on reducing the memory consumption of the scan by
+        # offloading regex operations on large payloads to sub-processes. However, it does not assure the improvement
+        # in the overall latency of the scan, specifically in the case of smaller payloads, where the overhead of
+        # forking a new process adds to the overall latency of the scan instead. More reference on Subprocess-based
+        # execution is found here: https://gitlab.com/gitlab-org/gitlab/-/issues/430160.
+        #
+        # Returns an instance of Gitlab::SecretDetection::Core::Response by following below structure:
         # {
         #     status: One of the Core::Status values
         #     results: [SecretDetection::Finding]
@@ -70,7 +86,8 @@ module GitLab
           payload_timeout: DEFAULT_PAYLOAD_TIMEOUT_SECS,
           raw_value_exclusions: [],
           rule_exclusions: [],
-          tags: DEFAULT_PATTERN_MATCHER_TAGS
+          tags: DEFAULT_PATTERN_MATCHER_TAGS,
+          subprocess: RUN_IN_SUBPROCESS
         )
 
           return Core::Response.new(Core::Status::INPUT_ERROR) unless validate_scan_input(payloads)
@@ -87,11 +104,13 @@ module GitLab
 
             next Core::Response.new(Core::Status::NOT_FOUND) if matched_payloads.empty?
 
-            secrets = run_scan(
+            scan_args = {
               payloads: matched_payloads, payload_timeout:,
               pattern_matcher: build_pattern_matcher(tags:),
               raw_value_exclusions:, rule_exclusions:
-            )
+            }
+
+            secrets = subprocess ? run_scan_within_subprocess(**scan_args) : run_scan(**scan_args)
 
             scan_status = overall_scan_status(secrets)
 
@@ -205,6 +224,36 @@ module GitLab
           end
         end
 
+        def run_scan_within_subprocess(
+          payloads:, payload_timeout:, pattern_matcher:, raw_value_exclusions: [],
+          rule_exclusions: [])
+          payload_sizes = payloads.map(&:size)
+          grouped_payload_indices = group_by_chunk_size(payload_sizes)
+
+          grouped_payloads = grouped_payload_indices.map { |idx_arr| idx_arr.map { |i| payloads[i] } }
+
+          found_secrets = Parallel.flat_map(
+            grouped_payloads,
+            in_processes: MAX_PROCS_PER_REQUEST,
+            isolation: true # do not reuse sub-processes
+          ) do |grouped_payload|
+            grouped_payload.flat_map do |payload|
+              Timeout.timeout(payload_timeout) do
+                find_secrets_in_payload(
+                  payload:,
+                  pattern_matcher:,
+                  raw_value_exclusions:, rule_exclusions:
+                )
+              end
+            rescue Timeout::Error => e
+              logger.error "Secret Detection scan timed out on the payload(id:#{payload.id}): #{e}"
+              Core::Finding.new(payload.id, Core::Status::PAYLOAD_TIMEOUT)
+            end
+          end
+
+          found_secrets.freeze
+        end
+
         # Finds secrets in the given payload guarded with a timeout as a circuit breaker. It accepts
         # literal values to exclude from the input before the scan, also SD rules to exclude during
         # the scan.
@@ -268,6 +317,35 @@ module GitLab
             Core::Status::FOUND_WITH_ERRORS
           end
         end
+
+        # This method accepts an array of payload sizes(in bytes) and groups them into an array
+        # of arrays structure where each element is the group of indices of the input
+        # array whose cumulative payload sizes has at least +MIN_CHUNK_SIZE_PER_PROC_BYTES+
+        def group_by_chunk_size(payload_size_arr)
+          cumulative_size = 0
+          chunk_indexes = []
+          chunk_idx_start = 0
+
+          payload_size_arr.each_with_index do |size, index|
+            cumulative_size += size
+            next unless cumulative_size >= MIN_CHUNK_SIZE_PER_PROC_BYTES
+
+            chunk_indexes << (chunk_idx_start..index).to_a
+
+            chunk_idx_start = index + 1
+            cumulative_size = 0
+          end
+
+          if cumulative_size.positive? && (chunk_idx_start < payload_size_arr.length)
+            chunk_indexes << if chunk_idx_start == payload_size_arr.length - 1
+                               [chunk_idx_start]
+                             else
+                               (chunk_idx_start..payload_size_arr.length - 1).to_a
+                             end
+          end
+
+          chunk_indexes
+        end
       end
     end
   end

data/lib/gitlab/secret_detection/core/status.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
       # All the possible statuses emitted by the scan operation

data/lib/gitlab/secret_detection/core.rb

@@ -6,7 +6,7 @@ require_relative 'core/status'
 require_relative 'core/scanner'
 require_relative 'core/ruleset'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Core
     end

data/lib/gitlab/secret_detection/grpc/client/grpc_client.rb

@@ -7,7 +7,7 @@ require_relative '../../core/status'
 require_relative '../../utils'
 require_relative './stream_request_enumerator'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
       class Client
@@ -24,9 +24,9 @@ module GitLab
         end
 
         # Triggers Secret Detection service's `/Scan` gRPC endpoint. To keep it consistent with SDS gem interface,
-        # this method transforms the gRPC response to +GitLab::SecretDetection::Core::Response+.
+        # this method transforms the gRPC response to +Gitlab::SecretDetection::Core::Response+.
         # Furthermore, any errors that are raised by the service will be translated to
-        # +GitLab::SecretDetection::Core::Response+ type by assiging a appropriate +status+ value to it.
+        # +Gitlab::SecretDetection::Core::Response+ type by assiging a appropriate +status+ value to it.
         def run_scan(request:, auth_token:, extra_headers: {})
           with_rescued_errors do
             grpc_response = stub.scan(
@@ -42,13 +42,13 @@ module GitLab
         # Triggers Secret Detection service's `/ScanStream` gRPC endpoint.
         #
         # To keep it consistent with SDS gem interface, this method transforms the gRPC response to
-        # +GitLab::SecretDetection::Core::Response+ type. Furthermore, any errors that are raised by the service will be
-        # translated to +GitLab::SecretDetection::Core::Response+ type by assiging a appropriate +status+ value to it.
+        # +Gitlab::SecretDetection::Core::Response+ type. Furthermore, any errors that are raised by the service will be
+        # translated to +Gitlab::SecretDetection::Core::Response+ type by assiging a appropriate +status+ value to it.
         #
         # Note: If one of the stream requests result in an error, the stream will end immediately without processing the
         # remaining requests.
         def run_scan_stream(requests:, auth_token:, extra_headers: {})
-          request_stream = GitLab::SecretDetection::GRPC::StreamRequestEnumerator.new(requests)
+          request_stream = Gitlab::SecretDetection::GRPC::StreamRequestEnumerator.new(requests)
           results = []
           with_rescued_errors do
             stub.scan_stream(
@@ -72,7 +72,7 @@ module GitLab
         attr_reader :secure, :host, :compression
 
         def stub
-          GitLab::SecretDetection::GRPC::Scanner::Stub.new(
+          Gitlab::SecretDetection::GRPC::Scanner::Stub.new(
             host,
             channel_credentials,
             channel_args:
@@ -100,7 +100,7 @@ module GitLab
         def channel_credentials
           return :this_channel_is_insecure unless secure
 
-          certs = GitLab::SecretDetection::Utils::X509::Certificate.ca_certs_bundle
+          certs = Gitlab::SecretDetection::Utils::X509::Certificate.ca_certs_bundle
 
           ::GRPC::Core::ChannelCredentials.new(certs)
         end

data/lib/gitlab/secret_detection/grpc/client/stream_request_enumerator.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
       class StreamRequestEnumerator

data/lib/gitlab/secret_detection/grpc/generated/secret_detection_pb.rb

@@ -5,12 +5,12 @@
 require 'google/protobuf'
 
 
-descriptor_data = "\n\x16secret_detection.proto\x12\x17gitlab.secret_detection\"\xfc\x03\n\x0bScanRequest\x12>\n\x08payloads\x18\x01 \x03(\x0b\x32,.gitlab.secret_detection.ScanRequest.Payload\x12\x19\n\x0ctimeout_secs\x18\x02 \x01(\x02H\x00\x88\x01\x01\x12!\n\x14payload_timeout_secs\x18\x03 \x01(\x02H\x01\x88\x01\x01\x12\x42\n\nexclusions\x18\x04 \x03(\x0b\x32..gitlab.secret_detection.ScanRequest.Exclusion\x12\x0c\n\x04tags\x18\x05 \x03(\t\x1a#\n\x07Payload\x12\n\n\x02id\x18\x01 \x01(\t\x12\x0c\n\x04\x64\x61ta\x18\x02 \x01(\t\x1a\x66\n\tExclusion\x12J\n\x0e\x65xclusion_type\x18\x01 \x01(\x0e\x32\x32.gitlab.secret_detection.ScanRequest.ExclusionType\x12\r\n\x05value\x18\x02 \x01(\t\"f\n\rExclusionType\x12\x1e\n\x1a\x45XCLUSION_TYPE_UNSPECIFIED\x10\x00\x12\x17\n\x13\x45XCLUSION_TYPE_RULE\x10\x01\x12\x1c\n\x18\x45XCLUSION_TYPE_RAW_VALUE\x10\x02\x42\x0f\n\r_timeout_secsB\x17\n\x15_payload_timeout_secs\"\xe2\x03\n\x0cScanResponse\x12>\n\x07results\x18\x01 \x03(\x0b\x32-.gitlab.secret_detection.ScanResponse.Finding\x12\x0e\n\x06status\x18\x02 \x01(\x05\x1a\x9d\x01\n\x07\x46inding\x12\x12\n\npayload_id\x18\x01 \x01(\t\x12\x0e\n\x06status\x18\x02 \x01(\x05\x12\x11\n\x04type\x18\x03 \x01(\tH\x00\x88\x01\x01\x12\x18\n\x0b\x64\x65scription\x18\x04 \x01(\tH\x01\x88\x01\x01\x12\x18\n\x0bline_number\x18\x05 \x01(\x05H\x02\x88\x01\x01\x42\x07\n\x05_typeB\x0e\n\x0c_descriptionB\x0e\n\x0c_line_number\"\xe1\x01\n\x06Status\x12\x16\n\x12STATUS_UNSPECIFIED\x10\x00\x12\x10\n\x0cSTATUS_FOUND\x10\x01\x12\x1c\n\x18STATUS_FOUND_WITH_ERRORS\x10\x02\x12\x17\n\x13STATUS_SCAN_TIMEOUT\x10\x03\x12\x1a\n\x16STATUS_PAYLOAD_TIMEOUT\x10\x04\x12\x15\n\x11STATUS_SCAN_ERROR\x10\x05\x12\x16\n\x12STATUS_INPUT_ERROR\x10\x06\x12\x14\n\x10STATUS_NOT_FOUND\x10\x07\x12\x15\n\x11STATUS_AUTH_ERROR\x10\x08\x32\xc1\x01\n\x07Scanner\x12U\n\x04Scan\x12$.gitlab.secret_detection.ScanRequest\x1a%.gitlab.secret_detection.ScanResponse\"\x00\x12_\n\nScanStream\x12$.gitlab.secret_detection.ScanRequest\x1a%.gitlab.secret_detection.ScanResponse\"\x00(\x01\x30\x01\x42 \xea\x02\x1dGitLab::SecretDetection::GRPCb\x06proto3"
+descriptor_data = "\n\x16secret_detection.proto\x12\x17gitlab.secret_detection\"\xfc\x03\n\x0bScanRequest\x12>\n\x08payloads\x18\x01 \x03(\x0b\x32,.gitlab.secret_detection.ScanRequest.Payload\x12\x19\n\x0ctimeout_secs\x18\x02 \x01(\x02H\x00\x88\x01\x01\x12!\n\x14payload_timeout_secs\x18\x03 \x01(\x02H\x01\x88\x01\x01\x12\x42\n\nexclusions\x18\x04 \x03(\x0b\x32..gitlab.secret_detection.ScanRequest.Exclusion\x12\x0c\n\x04tags\x18\x05 \x03(\t\x1a#\n\x07Payload\x12\n\n\x02id\x18\x01 \x01(\t\x12\x0c\n\x04\x64\x61ta\x18\x02 \x01(\t\x1a\x66\n\tExclusion\x12J\n\x0e\x65xclusion_type\x18\x01 \x01(\x0e\x32\x32.gitlab.secret_detection.ScanRequest.ExclusionType\x12\r\n\x05value\x18\x02 \x01(\t\"f\n\rExclusionType\x12\x1e\n\x1a\x45XCLUSION_TYPE_UNSPECIFIED\x10\x00\x12\x17\n\x13\x45XCLUSION_TYPE_RULE\x10\x01\x12\x1c\n\x18\x45XCLUSION_TYPE_RAW_VALUE\x10\x02\x42\x0f\n\r_timeout_secsB\x17\n\x15_payload_timeout_secs\"\xe2\x03\n\x0cScanResponse\x12>\n\x07results\x18\x01 \x03(\x0b\x32-.gitlab.secret_detection.ScanResponse.Finding\x12\x0e\n\x06status\x18\x02 \x01(\x05\x1a\x9d\x01\n\x07\x46inding\x12\x12\n\npayload_id\x18\x01 \x01(\t\x12\x0e\n\x06status\x18\x02 \x01(\x05\x12\x11\n\x04type\x18\x03 \x01(\tH\x00\x88\x01\x01\x12\x18\n\x0b\x64\x65scription\x18\x04 \x01(\tH\x01\x88\x01\x01\x12\x18\n\x0bline_number\x18\x05 \x01(\x05H\x02\x88\x01\x01\x42\x07\n\x05_typeB\x0e\n\x0c_descriptionB\x0e\n\x0c_line_number\"\xe1\x01\n\x06Status\x12\x16\n\x12STATUS_UNSPECIFIED\x10\x00\x12\x10\n\x0cSTATUS_FOUND\x10\x01\x12\x1c\n\x18STATUS_FOUND_WITH_ERRORS\x10\x02\x12\x17\n\x13STATUS_SCAN_TIMEOUT\x10\x03\x12\x1a\n\x16STATUS_PAYLOAD_TIMEOUT\x10\x04\x12\x15\n\x11STATUS_SCAN_ERROR\x10\x05\x12\x16\n\x12STATUS_INPUT_ERROR\x10\x06\x12\x14\n\x10STATUS_NOT_FOUND\x10\x07\x12\x15\n\x11STATUS_AUTH_ERROR\x10\x08\x32\xc1\x01\n\x07Scanner\x12U\n\x04Scan\x12$.gitlab.secret_detection.ScanRequest\x1a%.gitlab.secret_detection.ScanResponse\"\x00\x12_\n\nScanStream\x12$.gitlab.secret_detection.ScanRequest\x1a%.gitlab.secret_detection.ScanResponse\"\x00(\x01\x30\x01\x42 \xea\x02\x1dGitlab::SecretDetection::GRPCb\x06proto3"
 
 pool = Google::Protobuf::DescriptorPool.generated_pool
 pool.add_serialized_file(descriptor_data)
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
       ScanRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitlab.secret_detection.ScanRequest").msgclass

data/lib/gitlab/secret_detection/grpc/generated/secret_detection_services_pb.rb

@@ -1,10 +1,10 @@
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
-# Source: secret_detection.proto for package 'GitLab.SecretDetection.GRPC'
+# Source: secret_detection.proto for package 'Gitlab.SecretDetection.GRPC'
 
 require 'grpc'
 require 'secret_detection_pb'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
       module Scanner
@@ -18,9 +18,9 @@ module GitLab
           self.service_name = 'gitlab.secret_detection.Scanner'
 
           # Runs secret detection scan for the given request
-          rpc :Scan, ::GitLab::SecretDetection::GRPC::ScanRequest, ::GitLab::SecretDetection::GRPC::ScanResponse
+          rpc :Scan, ::Gitlab::SecretDetection::GRPC::ScanRequest, ::Gitlab::SecretDetection::GRPC::ScanResponse
           # Runs bi-directional streaming of scans for the given stream of requests with a stream of responses
-          rpc :ScanStream, stream(::GitLab::SecretDetection::GRPC::ScanRequest), stream(::GitLab::SecretDetection::GRPC::ScanResponse)
+          rpc :ScanStream, stream(::Gitlab::SecretDetection::GRPC::ScanRequest), stream(::Gitlab::SecretDetection::GRPC::ScanResponse)
         end
 
         Stub = Service.rpc_stub_class

data/lib/gitlab/secret_detection/grpc/scanner_service.rb

@@ -27,7 +27,7 @@ class StreamEnumerator
   end
 end
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
       class ScannerService < Scanner::Service
@@ -89,21 +89,21 @@ module GitLab
           end
 
           findings = result.results&.map do |finding|
-            GitLab::SecretDetection::GRPC::ScanResponse::Finding.new(**finding.to_h)
+            Gitlab::SecretDetection::GRPC::ScanResponse::Finding.new(**finding.to_h)
           end
 
-          GitLab::SecretDetection::GRPC::ScanResponse.new(
+          Gitlab::SecretDetection::GRPC::ScanResponse.new(
             results: findings,
             status: result.status
           )
         end
 
         def scanner
-          @scanner ||= GitLab::SecretDetection::Core::Scanner.new(rules:, logger:)
+          @scanner ||= Gitlab::SecretDetection::Core::Scanner.new(rules:, logger:)
         end
 
         def rules
-          GitLab::SecretDetection::Core::Ruleset.new.rules
+          Gitlab::SecretDetection::Core::Ruleset.new.rules
         end
 
         # validates grpc request body

data/lib/gitlab/secret_detection/grpc.rb

@@ -4,7 +4,7 @@ require_relative 'grpc/scanner_service'
 require_relative 'grpc/client/stream_request_enumerator'
 require_relative 'grpc/client/grpc_client'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module GRPC
     end

data/lib/gitlab/secret_detection/utils/certificate.rb

@@ -3,11 +3,11 @@
 require 'openssl'
 require_relative 'memoize'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Utils
       module X509
-        # Pulled from GitLab.com source
+        # Pulled from Gitlab.com source
         # Link: https://gitlab.com/gitlab-org/gitlab/-/blob/4713a798f997389f04e442db3d1d8349a39d5d46/lib/gitlab/x509/certificate.rb
         class Certificate
           CERT_REGEX = /-----BEGIN CERTIFICATE-----(?:.|\n)+?-----END CERTIFICATE-----/
@@ -99,7 +99,7 @@ module GitLab
           end
 
           class << self
-            include ::GitLab::SecretDetection::Utils::StrongMemoize
+            include ::Gitlab::SecretDetection::Utils::StrongMemoize
           end
         end
       end

data/lib/gitlab/secret_detection/utils/memoize.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Utils
       # Pulled from GitLab.com source
@@ -16,7 +16,7 @@ module GitLab
         #
         # We could write it like:
         #
-        #     include GitLab::SecretDetection::Utils::StrongMemoize
+        #     include Gitlab::SecretDetection::Utils::StrongMemoize
         #
         #     def trigger_from_token
         #       Ci::Trigger.find_by_token(params[:token].to_s)

data/lib/gitlab/secret_detection/utils.rb

@@ -3,7 +3,7 @@
 require_relative 'utils/certificate'
 require_relative 'utils/memoize'
 
-module GitLab
+module Gitlab
   module SecretDetection
     module Utils
     end

data/lib/gitlab/secret_detection/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module GitLab
+module Gitlab
   module SecretDetection
     class Gem
       DEFAULT_VERSION = "0.0.1"

data/lib/gitlab/secret_detection.rb

@@ -5,7 +5,7 @@ require_relative 'secret_detection/core'
 require_relative 'secret_detection/grpc'
 require_relative 'secret_detection/version'
 
-module GitLab
+module Gitlab
   module SecretDetection
   end
 end

data/lib/gitlab.rb

@@ -2,5 +2,5 @@
 
 require_relative 'gitlab/secret_detection'
 
-module GitLab
+module Gitlab
 end

data/proto/secret_detection.proto

@@ -2,10 +2,10 @@ syntax = "proto3";
 
 package gitlab.secret_detection;
 
-/* We keep generated files within grpc namespace i.e GitLab::SecretDetection::GRPC
+/* We keep generated files within grpc namespace i.e Gitlab::SecretDetection::GRPC
  * so that these files are exported too in the Ruby Gem along with Core and GRPC logic.
  */
-option ruby_package = "GitLab::SecretDetection::GRPC";
+option ruby_package = "Gitlab::SecretDetection::GRPC";
 
 /* Request arg for triggering Scan/ScanStream method */
 message ScanRequest {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-secret_detection
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.1
 platform: ruby
 authors:
 - group::secret detection
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-04 00:00:00.000000000 Z
+date: 2024-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: grpc
@@ -40,6 +40,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.63.0
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.19'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.19'
 - !ruby/object:Gem::Dependency
   name: re2
   requirement: !ruby/object:Gem::Requirement