gitlab-qa 7.9.0 → 7.9.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.gitlab-ci.yml +1 -1
- data/.rubocop.yml +14 -8
- data/.rubocop_todo.yml +85 -16
- data/gitlab-qa.gemspec +2 -5
- data/lib/gitlab/qa/component/specs.rb +1 -1
- data/lib/gitlab/qa/docker/shellout.rb +1 -1
- data/lib/gitlab/qa/scenario/test/integration/client_ssl.rb +0 -2
- data/lib/gitlab/qa/scenario/test/integration/geo.rb +0 -3
- data/lib/gitlab/qa/scenario/test/integration/gitaly_cluster.rb +0 -2
- data/lib/gitlab/qa/scenario/test/integration/kubernetes.rb +0 -2
- data/lib/gitlab/qa/scenario/test/integration/mtls.rb +0 -2
- data/lib/gitlab/qa/scenario/test/integration/ssh_tunnel.rb +0 -2
- data/lib/gitlab/qa/version.rb +1 -1
- metadata +6 -34
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: e2c7a87e5b6848fc8a74dba532ff9b5cb11b9f5e4cbb805442c15455581480db
|
4
|
+
data.tar.gz: f52bffc17ce6f6c77438700ac7face46b5c378e47346d1a8fb52d20351002521
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 0bed280e7cb760e5bf3f9402ab79f6eb36677002dc11b6f18d03f76963b6a52d21ee0eef3bf0b9cf488556b35be8bd91bab1bb08669ef612256cdd38ceed55b2
|
7
|
+
data.tar.gz: 10797a35e96fdee11549037153e7670f6b3ed7b919aa158df09695027f72f4e86afa89850b1fd5678292c194835f5d40ddc4a0f443b048389cfa8beb7e710280
|
data/.gitlab-ci.yml
CHANGED
data/.rubocop.yml
CHANGED
@@ -1,15 +1,21 @@
|
|
1
|
-
inherit_from: .rubocop_todo.yml
|
2
|
-
|
3
|
-
require:
|
4
|
-
# Due to a probably bug in rubocop (https://github.com/bbatsov/rubocop/issues/5251)
|
5
|
-
# we need to require rubocop-rspec a second time so that RSpec/FilePath does
|
6
|
-
# not fallback to Rails/FilePath.
|
7
|
-
- rubocop-rspec
|
8
|
-
|
9
1
|
inherit_gem:
|
10
2
|
gitlab-styles:
|
11
3
|
- rubocop-default.yml
|
12
4
|
|
5
|
+
inherit_from:
|
6
|
+
<% unless ENV['REVEAL_RUBOCOP_TODO'] == '1' %>
|
7
|
+
- '.rubocop_todo.yml'
|
8
|
+
<% end %>
|
9
|
+
|
10
|
+
Lint/HashCompareByIdentity:
|
11
|
+
Enabled: true
|
12
|
+
|
13
|
+
Lint/RedundantSafeNavigation:
|
14
|
+
Enabled: true
|
15
|
+
|
16
|
+
Style/ClassEqualityComparison:
|
17
|
+
Enabled: true
|
18
|
+
|
13
19
|
Lint/ShadowingOuterLocalVariable:
|
14
20
|
Enabled: false
|
15
21
|
|
data/.rubocop_todo.yml
CHANGED
@@ -1,17 +1,41 @@
|
|
1
1
|
# This configuration was generated by
|
2
2
|
# `rubocop --auto-gen-config`
|
3
|
-
# on
|
3
|
+
# on 2021-09-17 06:55:33 UTC using RuboCop version 0.93.1.
|
4
4
|
# The point is for the user to remove these configuration records
|
5
5
|
# one by one as the offenses are removed from the code base.
|
6
6
|
# Note that changes in the inspected code, or installation of new
|
7
7
|
# versions of RuboCop, may require this file to be generated again.
|
8
8
|
|
9
|
-
# Offense count:
|
9
|
+
# Offense count: 165
|
10
10
|
# Cop supports --auto-correct.
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
11
|
+
CodeReuse/ActiveRecord:
|
12
|
+
Enabled: false
|
13
|
+
|
14
|
+
# Offense count: 2
|
15
|
+
# Cop supports --auto-correct.
|
16
|
+
Cop/LineBreakAroundConditionalBlock:
|
17
|
+
Exclude:
|
18
|
+
- 'lib/gitlab/qa/release.rb'
|
19
|
+
- 'lib/gitlab/qa/runtime/env.rb'
|
20
|
+
|
21
|
+
# Offense count: 1
|
22
|
+
# Configuration parameters: Include.
|
23
|
+
# Include: **/*.gemspec
|
24
|
+
Gemspec/RequiredRubyVersion:
|
25
|
+
Exclude:
|
26
|
+
- 'gitlab-qa.gemspec'
|
27
|
+
|
28
|
+
# Offense count: 1
|
29
|
+
Lint/ConstantDefinitionInBlock:
|
30
|
+
Exclude:
|
31
|
+
- 'spec/gitlab/qa/scenario/test/instance/deployment_base_spec.rb'
|
32
|
+
|
33
|
+
# Offense count: 5
|
34
|
+
Lint/MixedRegexpCaptureTypes:
|
35
|
+
Exclude:
|
36
|
+
- 'lib/gitlab/qa/release.rb'
|
37
|
+
- 'lib/gitlab/qa/report/relate_failure_issue.rb'
|
38
|
+
- 'lib/gitlab/qa/report/update_screenshot_path.rb'
|
15
39
|
|
16
40
|
# Offense count: 2
|
17
41
|
# Cop supports --auto-correct.
|
@@ -20,6 +44,13 @@ Lint/RedundantCopDisableDirective:
|
|
20
44
|
- 'lib/gitlab/qa/component/staging.rb'
|
21
45
|
- 'lib/gitlab/qa/runtime/scenario.rb'
|
22
46
|
|
47
|
+
# Offense count: 10
|
48
|
+
# Configuration parameters: IgnoredMethods.
|
49
|
+
Metrics/AbcSize:
|
50
|
+
Max: 26
|
51
|
+
IgnoredMethods:
|
52
|
+
- perform
|
53
|
+
|
23
54
|
# Offense count: 1
|
24
55
|
# Cop supports --auto-correct.
|
25
56
|
# Configuration parameters: PreferredName.
|
@@ -33,6 +64,13 @@ Performance/RegexpMatch:
|
|
33
64
|
Exclude:
|
34
65
|
- 'lib/gitlab/qa/component/gitlab.rb'
|
35
66
|
|
67
|
+
# Offense count: 1
|
68
|
+
# Cop supports --auto-correct.
|
69
|
+
# Configuration parameters: AutoCorrect.
|
70
|
+
Performance/StringInclude:
|
71
|
+
Exclude:
|
72
|
+
- 'lib/gitlab/qa/component/gitlab.rb'
|
73
|
+
|
36
74
|
# Offense count: 3
|
37
75
|
# Cop supports --auto-correct.
|
38
76
|
RSpec/EmptyLineAfterLetBlock:
|
@@ -51,7 +89,18 @@ RSpec/LeakyConstantDeclaration:
|
|
51
89
|
Exclude:
|
52
90
|
- 'spec/gitlab/qa/scenario/test/instance/deployment_base_spec.rb'
|
53
91
|
|
54
|
-
# Offense count:
|
92
|
+
# Offense count: 221
|
93
|
+
# Configuration parameters: AllowSubject.
|
94
|
+
RSpec/MultipleMemoizedHelpers:
|
95
|
+
Max: 22
|
96
|
+
|
97
|
+
# Offense count: 1
|
98
|
+
# Cop supports --auto-correct.
|
99
|
+
Style/ExplicitBlockArgument:
|
100
|
+
Exclude:
|
101
|
+
- 'lib/gitlab/qa/scenario/test/integration/ldap.rb'
|
102
|
+
|
103
|
+
# Offense count: 86
|
55
104
|
# Cop supports --auto-correct.
|
56
105
|
# Configuration parameters: EnforcedStyle.
|
57
106
|
# SupportedStyles: always, always_true, never
|
@@ -64,21 +113,19 @@ Style/HashTransformKeys:
|
|
64
113
|
Exclude:
|
65
114
|
- 'lib/gitlab/qa/docker/volumes.rb'
|
66
115
|
|
67
|
-
# Offense count:
|
116
|
+
# Offense count: 1
|
117
|
+
# Cop supports --auto-correct.
|
118
|
+
Style/HashTransformation:
|
119
|
+
Exclude:
|
120
|
+
- 'lib/gitlab/qa/docker/volumes.rb'
|
121
|
+
|
122
|
+
# Offense count: 3
|
68
123
|
# Cop supports --auto-correct.
|
69
124
|
Style/IfUnlessModifier:
|
70
125
|
Exclude:
|
71
|
-
- 'lib/gitlab/qa/component/gitlab.rb'
|
72
|
-
- 'lib/gitlab/qa/release.rb'
|
73
126
|
- 'lib/gitlab/qa/runtime/env.rb'
|
74
127
|
- 'lib/gitlab/qa/runtime/scenario.rb'
|
75
128
|
- 'lib/gitlab/qa/scenario/test/omnibus/upgrade.rb'
|
76
|
-
- 'lib/gitlab/qa/support/http_request.rb'
|
77
|
-
|
78
|
-
# Offense count: 1
|
79
|
-
Style/MethodMissingSuper:
|
80
|
-
Exclude:
|
81
|
-
- 'lib/gitlab/qa/runtime/scenario.rb'
|
82
129
|
|
83
130
|
# Offense count: 1
|
84
131
|
Style/MissingRespondToMissing:
|
@@ -96,3 +143,25 @@ Style/MutableConstant:
|
|
96
143
|
- 'db/geo/migrate/**/*'
|
97
144
|
- 'lib/gitlab/qa/release.rb'
|
98
145
|
- 'lib/gitlab/qa/report/update_screenshot_path.rb'
|
146
|
+
|
147
|
+
# Offense count: 9
|
148
|
+
# Cop supports --auto-correct.
|
149
|
+
Style/RedundantRegexpEscape:
|
150
|
+
Exclude:
|
151
|
+
- 'lib/gitlab/qa/release.rb'
|
152
|
+
- 'lib/gitlab/qa/report/generate_test_session.rb'
|
153
|
+
- 'lib/gitlab/qa/report/relate_failure_issue.rb'
|
154
|
+
- 'lib/gitlab/qa/report/update_screenshot_path.rb'
|
155
|
+
|
156
|
+
# Offense count: 1
|
157
|
+
# Cop supports --auto-correct.
|
158
|
+
Style/StringConcatenation:
|
159
|
+
Exclude:
|
160
|
+
- 'lib/gitlab/qa/reporter.rb'
|
161
|
+
|
162
|
+
# Offense count: 126
|
163
|
+
# Cop supports --auto-correct.
|
164
|
+
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
|
165
|
+
# URISchemes: http, https
|
166
|
+
Layout/LineLength:
|
167
|
+
Max: 192
|
data/gitlab-qa.gemspec
CHANGED
@@ -20,17 +20,14 @@ Gem::Specification.new do |spec|
|
|
20
20
|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
|
21
21
|
spec.require_paths = ['lib']
|
22
22
|
|
23
|
-
# Some dependencies are pinned, to prevent new cops from breaking the CI pipelines
|
24
23
|
spec.add_development_dependency 'climate_control', '~> 0.2'
|
25
|
-
spec.add_development_dependency 'gitlab-styles', '~>
|
24
|
+
spec.add_development_dependency 'gitlab-styles', '~> 6.2.1'
|
26
25
|
spec.add_development_dependency 'pry', '~> 0.11'
|
27
26
|
spec.add_development_dependency 'rake', '~> 12.2'
|
28
27
|
spec.add_development_dependency 'rspec', '~> 3.7'
|
29
|
-
spec.add_development_dependency 'rubocop', '~> 0.82.0'
|
30
|
-
spec.add_development_dependency 'rubocop-rspec', '~> 1.36'
|
31
28
|
spec.add_development_dependency 'solargraph', '~> 0.41'
|
32
29
|
spec.add_development_dependency 'webmock', '3.7.0'
|
33
|
-
spec.add_runtime_dependency 'activesupport', '~> 6.
|
30
|
+
spec.add_runtime_dependency 'activesupport', '~> 6.1'
|
34
31
|
spec.add_runtime_dependency 'gitlab', '~> 4.16.1'
|
35
32
|
spec.add_runtime_dependency 'http', '4.3.0'
|
36
33
|
spec.add_runtime_dependency 'nokogiri', '~> 1.10'
|
@@ -13,7 +13,7 @@ module Gitlab
|
|
13
13
|
puts "Docker shell command: `#{@command.mask_secrets}`"
|
14
14
|
end
|
15
15
|
|
16
|
-
def execute!
|
16
|
+
def execute! # rubocop:disable Metrics/AbcSize
|
17
17
|
raise StatusError, 'Command already executed' if @output.any?
|
18
18
|
|
19
19
|
Open3.popen2e(@command.to_s) do |_in, out, wait|
|
@@ -12,7 +12,6 @@ module Gitlab
|
|
12
12
|
@tag = 'client_ssl'
|
13
13
|
end
|
14
14
|
|
15
|
-
# rubocop:disable Metrics/AbcSize
|
16
15
|
def perform(release, *rspec_args)
|
17
16
|
Component::Gitlab.perform do |gitlab|
|
18
17
|
gitlab.release = QA::Release.new(release)
|
@@ -42,7 +41,6 @@ module Gitlab
|
|
42
41
|
end
|
43
42
|
end
|
44
43
|
end
|
45
|
-
# rubocop:enable Metrics/AbcSize
|
46
44
|
|
47
45
|
def gitlab_omnibus
|
48
46
|
<<~OMNIBUS
|
@@ -19,7 +19,6 @@ module Gitlab
|
|
19
19
|
@tag = 'gitaly_cluster'
|
20
20
|
end
|
21
21
|
|
22
|
-
# rubocop:disable Metrics/AbcSize
|
23
22
|
def perform(release, *rspec_args)
|
24
23
|
gitaly_primary_node = gitaly(@primary_node_name, release)
|
25
24
|
gitaly_secondary_node = gitaly(@secondary_node_name, release)
|
@@ -74,7 +73,6 @@ module Gitlab
|
|
74
73
|
gitaly_secondary_node&.teardown
|
75
74
|
gitaly_tertiary_node&.teardown
|
76
75
|
end
|
77
|
-
# rubocop:enable Metrics/AbcSize
|
78
76
|
|
79
77
|
private
|
80
78
|
|
@@ -6,7 +6,6 @@ module Gitlab
|
|
6
6
|
module Test
|
7
7
|
module Integration
|
8
8
|
class Kubernetes < Scenario::Template
|
9
|
-
# rubocop:disable Metrics/AbcSize
|
10
9
|
def perform(release, *rspec_args)
|
11
10
|
Runtime::Env.require_kubernetes_environment!
|
12
11
|
|
@@ -47,7 +46,6 @@ module Gitlab
|
|
47
46
|
end
|
48
47
|
end
|
49
48
|
end
|
50
|
-
# rubocop:enable Metrics/AbcSize
|
51
49
|
end
|
52
50
|
end
|
53
51
|
end
|
@@ -13,7 +13,6 @@ module Gitlab
|
|
13
13
|
@tag = 'mtls'
|
14
14
|
end
|
15
15
|
|
16
|
-
# rubocop:disable Metrics/AbcSize
|
17
16
|
def perform(release, *rspec_args)
|
18
17
|
Component::Gitlab.perform do |gitaly|
|
19
18
|
gitaly.release = QA::Release.new(release)
|
@@ -53,7 +52,6 @@ module Gitlab
|
|
53
52
|
end
|
54
53
|
end
|
55
54
|
end
|
56
|
-
# rubocop:enable Metrics/AbcSize
|
57
55
|
|
58
56
|
def gitlab_omnibus
|
59
57
|
<<~OMNIBUS
|
@@ -6,7 +6,6 @@ module Gitlab
|
|
6
6
|
module Test
|
7
7
|
module Integration
|
8
8
|
class SSHTunnel < Scenario::Template
|
9
|
-
# rubocop:disable Metrics/AbcSize
|
10
9
|
def perform(release, *rspec_args)
|
11
10
|
Runtime::Env.override_default_password!
|
12
11
|
Runtime::Env.require_ssh_tunnel!
|
@@ -49,7 +48,6 @@ module Gitlab
|
|
49
48
|
end
|
50
49
|
end
|
51
50
|
end
|
52
|
-
# rubocop:enable Metrics/AbcSize
|
53
51
|
end
|
54
52
|
end
|
55
53
|
end
|
data/lib/gitlab/qa/version.rb
CHANGED
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: gitlab-qa
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 7.9.
|
4
|
+
version: 7.9.1
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- GitLab Quality
|
8
8
|
autorequire:
|
9
9
|
bindir: exe
|
10
10
|
cert_chain: []
|
11
|
-
date: 2021-09-
|
11
|
+
date: 2021-09-20 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: climate_control
|
@@ -30,14 +30,14 @@ dependencies:
|
|
30
30
|
requirements:
|
31
31
|
- - "~>"
|
32
32
|
- !ruby/object:Gem::Version
|
33
|
-
version:
|
33
|
+
version: 6.2.1
|
34
34
|
type: :development
|
35
35
|
prerelease: false
|
36
36
|
version_requirements: !ruby/object:Gem::Requirement
|
37
37
|
requirements:
|
38
38
|
- - "~>"
|
39
39
|
- !ruby/object:Gem::Version
|
40
|
-
version:
|
40
|
+
version: 6.2.1
|
41
41
|
- !ruby/object:Gem::Dependency
|
42
42
|
name: pry
|
43
43
|
requirement: !ruby/object:Gem::Requirement
|
@@ -80,34 +80,6 @@ dependencies:
|
|
80
80
|
- - "~>"
|
81
81
|
- !ruby/object:Gem::Version
|
82
82
|
version: '3.7'
|
83
|
-
- !ruby/object:Gem::Dependency
|
84
|
-
name: rubocop
|
85
|
-
requirement: !ruby/object:Gem::Requirement
|
86
|
-
requirements:
|
87
|
-
- - "~>"
|
88
|
-
- !ruby/object:Gem::Version
|
89
|
-
version: 0.82.0
|
90
|
-
type: :development
|
91
|
-
prerelease: false
|
92
|
-
version_requirements: !ruby/object:Gem::Requirement
|
93
|
-
requirements:
|
94
|
-
- - "~>"
|
95
|
-
- !ruby/object:Gem::Version
|
96
|
-
version: 0.82.0
|
97
|
-
- !ruby/object:Gem::Dependency
|
98
|
-
name: rubocop-rspec
|
99
|
-
requirement: !ruby/object:Gem::Requirement
|
100
|
-
requirements:
|
101
|
-
- - "~>"
|
102
|
-
- !ruby/object:Gem::Version
|
103
|
-
version: '1.36'
|
104
|
-
type: :development
|
105
|
-
prerelease: false
|
106
|
-
version_requirements: !ruby/object:Gem::Requirement
|
107
|
-
requirements:
|
108
|
-
- - "~>"
|
109
|
-
- !ruby/object:Gem::Version
|
110
|
-
version: '1.36'
|
111
83
|
- !ruby/object:Gem::Dependency
|
112
84
|
name: solargraph
|
113
85
|
requirement: !ruby/object:Gem::Requirement
|
@@ -142,14 +114,14 @@ dependencies:
|
|
142
114
|
requirements:
|
143
115
|
- - "~>"
|
144
116
|
- !ruby/object:Gem::Version
|
145
|
-
version: 6.
|
117
|
+
version: '6.1'
|
146
118
|
type: :runtime
|
147
119
|
prerelease: false
|
148
120
|
version_requirements: !ruby/object:Gem::Requirement
|
149
121
|
requirements:
|
150
122
|
- - "~>"
|
151
123
|
- !ruby/object:Gem::Version
|
152
|
-
version: 6.
|
124
|
+
version: '6.1'
|
153
125
|
- !ruby/object:Gem::Dependency
|
154
126
|
name: gitlab
|
155
127
|
requirement: !ruby/object:Gem::Requirement
|