gitlab-qa 7.27.1 → 7.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d08b53ffc75578165d38ea6c735882e0fdf9059ece88c1aa91ecdac67df8fa1d
-  data.tar.gz: 35091d5ab69c1a88a21ffe839c73d7fc23744517e28f4d6d193c92a7c1bb3252
+  metadata.gz: 6f3a8d250f26a5899d776475ac349829311045b51aeed7b73f1a40fc41cd23dc
+  data.tar.gz: 2258303729505a302fe0a6d05b57f5deee6efe21f0d7cbfb2542e92febfe2dc7
 SHA512:
-  metadata.gz: 56119714620bfa55ed88e9136d4e5a35e72606996c6bab5e0a613ea16e14653dc50055a54cc4302d26dbd01ceb614ebbf85bca1d8237ffc5f402e36586e6e37e
-  data.tar.gz: 47ba7c6b6603cc8982b5fb5a54732550d13c40eea076f0fd46054a104093c2c97016d3e84a468e073e925ed1633f83085414667740230a2b6511ce2d3836b9c8
+  metadata.gz: 2ad81f0b8d7bcb59ff76963f0463ae2d221be28b262455c22e6ee11ad91a9c6b768291639ed25b9ff756c9b319566f4aa596281ca2c09d470a5a1374174f3929
+  data.tar.gz: 6e5a9601b50167f4cae9c87fe1415b1a6a740c855e56580cc553559d481842f6ed9feced7760a0403bb7993ef5ba7e11c1fd5723d2812a06227d1a64b87aefd1

data/.gitignore

@@ -1,12 +1,10 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/
 /pkg/
 /spec/reports/
-/tmp/
 /.idea
 .ruby-version
 .ruby-gemset

data/.gitlab/ci/jobs/base.gitlab-ci.yml

@@ -245,14 +245,12 @@ generate-allure-report:
   cache:
     policy: pull
   before_script:
-    # Override allure variables for upstream triggers
-    # Override default before script and don't push cache
     - export STORAGE_CREDENTIALS=$QA_ALLURE_REPORT_GCS_CREDENTIALS
     - export GITLAB_AUTH_TOKEN=$GITLAB_QA_MR_ALLURE_REPORT_TOKEN
-    - export ALLURE_PROJECT_PATH=$TOP_UPSTREAM_SOURCE_PROJECT
-    - export ALLURE_MERGE_REQUEST_IID=$TOP_UPSTREAM_MERGE_REQUEST_IID
-    - export ALLURE_COMMIT_SHA=$TOP_UPSTREAM_SOURCE_SHA
-    - export ALLURE_JOB_NAME="${ALLURE_JOB_NAME:-package-and-qa}"
+    # Set allure variables for merge request comment based on pipeline source
+    - export ALLURE_MERGE_REQUEST_IID=${TOP_UPSTREAM_MERGE_REQUEST_IID:-$CI_MERGE_REQUEST_IID}
+    - export ALLURE_PROJECT_PATH=${TOP_UPSTREAM_SOURCE_PROJECT:-$CI_MERGE_REQUEST_PROJECT_PATH}
+    - export ALLURE_COMMIT_SHA=${TOP_UPSTREAM_SOURCE_SHA:-$CI_MERGE_REQUEST_SOURCE_BRANCH_SHA}
   rules:
     # Don't run report generation on release pipelines
     - if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_PATH == "gitlab-org/gitlab-qa" && $RELEASE == null'
@@ -260,11 +258,7 @@ generate-allure-report:
       when: never
     - if: '$CI_COMMIT_TAG'
       when: never
-    - if: '$CI_PIPELINE_SOURCE == "merge_request_event" || $CI_PIPELINE_SOURCE == "parent_pipeline"  || ($CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH)'
-      variables:
-        ALLURE_JOB_NAME: gitlab-qa
-      when: always
-    - if: '$TOP_UPSTREAM_SOURCE_PROJECT != null && $TOP_UPSTREAM_SOURCE_PROJECT != "" && $TOP_UPSTREAM_SOURCE_SHA != null && $TOP_UPSTREAM_SOURCE_SHA != ""'
+    - if: '$ALLURE_JOB_NAME'
       when: always
 
 generate-knapsack-report:

data/.gitlab/ci/jobs/gitaly_cluster.gitlab-ci.yml

@@ -7,7 +7,6 @@ ce:gitaly-cluster:
     - .rspec-report-opts
   variables:
     QA_SCENARIO: "Test::Integration::GitalyCluster"
-    QA_LOG_PATH: "tmp/gitaly_cluster.log"
 
 ce:gitaly-cluster-quarantine:
   extends:
@@ -19,7 +18,6 @@ ce:gitaly-cluster-quarantine:
     - .rspec-report-opts
   variables:
     QA_SCENARIO: "Test::Integration::GitalyCluster"
-    QA_LOG_PATH: "tmp/gitaly_cluster.log"
 
 ee:gitaly-cluster:
   extends:
@@ -30,7 +28,6 @@ ee:gitaly-cluster:
     - .rspec-report-opts
   variables:
     QA_SCENARIO: "Test::Integration::GitalyCluster"
-    QA_LOG_PATH: "tmp/gitaly_cluster.log"
 
 ee:gitaly-cluster-quarantine:
   extends:
@@ -42,4 +39,3 @@ ee:gitaly-cluster-quarantine:
     - .rspec-report-opts
   variables:
     QA_SCENARIO: "Test::Integration::GitalyCluster"
-    QA_LOG_PATH: "tmp/gitaly_cluster.log"

data/.gitlab-ci.yml

@@ -25,12 +25,18 @@ workflow:
   rules:
     # For merge requests, create a pipeline.
     - if: '$CI_MERGE_REQUEST_IID'
+      variables:
+        ALLURE_JOB_NAME: gitlab-qa
     # For the default branch, create a pipeline (this includes on schedules, pushes, merges, etc.).
     - if: '$CI_COMMIT_BRANCH == "master"'
-    # For tags, create a pipeline.
-    - if: '$CI_COMMIT_TAG'
+      variables:
+        ALLURE_JOB_NAME: gitlab-qa
     # For triggers from GitLab MR pipelines (and pipelines from other projects), create a pipeline
     - if: '$CI_PIPELINE_SOURCE == "pipeline"'
+      variables:
+        ALLURE_JOB_NAME: package-and-qa
+    # For tags, create a pipeline.
+    - if: '$CI_COMMIT_TAG'
     # When using Run pipeline button in the GitLab UI, from the project’s CI/CD > Pipelines section, create a pipeline.
     - if: '$CI_PIPELINE_SOURCE == "web"'
 
@@ -94,7 +100,6 @@ generate-jobs:
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag repository_storage
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag packages
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag integrations
-    - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag actioncable
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag mtls
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag jira
     - bundle exec bin/qa Test::Instance::All http://dummy.test --count-examples-only -- $QA_TESTS --tag can_use_large_setup

data/Gemfile.lock

@@ -0,0 +1,248 @@
+PATH
+  remote: .
+  specs:
+    gitlab-qa (7.29.1)
+      activesupport (~> 6.1)
+      gitlab (~> 4.18.0)
+      http (~> 5.0)
+      nokogiri (~> 1.10)
+      rainbow (~> 3.0.0)
+      table_print (= 1.5.7)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (6.1.6)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
+    backport (1.2.0)
+    benchmark (0.2.0)
+    claide (1.1.0)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    climate_control (1.0.1)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    concurrent-ruby (1.1.10)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    crack (0.4.5)
+      rexml
+    danger (8.6.1)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (>= 1, < 4)
+    danger-gitlab (8.0.0)
+      danger
+      gitlab (~> 4.2, >= 4.2.0)
+    diff-lcs (1.5.0)
+    domain_name (0.5.20190701)
+      unf (>= 0.0.5, < 1.0.0)
+    e2mmap (0.1.0)
+    faraday (1.10.0)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.0)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
+      faraday-retry (~> 1.0)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    faraday-httpclient (1.0.1)
+    faraday-multipart (1.0.3)
+      multipart-post (>= 1.2, < 3)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    faraday-retry (1.0.3)
+    ffi (1.15.5)
+    ffi-compiler (1.0.1)
+      ffi (>= 1.0.0)
+      rake
+    git (1.11.0)
+      rchardet (~> 1.8)
+    gitlab (4.18.0)
+      httparty (~> 0.18)
+      terminal-table (>= 1.5.1)
+    gitlab-dangerfiles (2.11.0)
+      danger (>= 8.4.5)
+      danger-gitlab (>= 8.0.0)
+    gitlab-styles (6.2.1)
+      rubocop (~> 0.91, >= 0.91.1)
+      rubocop-gitlab-security (~> 0.1.1)
+      rubocop-performance (~> 1.9.2)
+      rubocop-rails (~> 2.9)
+      rubocop-rspec (~> 1.44)
+    hashdiff (1.0.1)
+    http (5.0.4)
+      addressable (~> 2.8)
+      http-cookie (~> 1.0)
+      http-form_data (~> 2.2)
+      llhttp-ffi (~> 0.4.0)
+    http-cookie (1.0.5)
+      domain_name (~> 0.5)
+    http-form_data (2.3.0)
+    httparty (0.20.0)
+      mime-types (~> 3.0)
+      multi_xml (>= 0.5.2)
+    i18n (1.10.0)
+      concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.4)
+    kramdown (2.4.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    llhttp-ffi (0.4.0)
+      ffi-compiler (~> 1.0)
+      rake (~> 13.0)
+    method_source (1.0.0)
+    mime-types (3.4.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2022.0105)
+    mini_portile2 (2.8.0)
+    minitest (5.15.0)
+    multi_xml (0.6.0)
+    multipart-post (2.1.1)
+    nap (1.1.0)
+    no_proxy_fix (0.1.2)
+    nokogiri (1.13.6)
+      mini_portile2 (~> 2.8.0)
+      racc (~> 1.4)
+    octokit (4.22.0)
+      faraday (>= 0.9)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    open4 (1.3.4)
+    parallel (1.22.1)
+    parser (3.1.2.0)
+      ast (~> 2.4.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.7)
+    racc (1.6.0)
+    rack (2.2.3)
+    rainbow (3.0.0)
+    rake (13.0.6)
+    rchardet (1.8.0)
+    regexp_parser (2.4.0)
+    reverse_markdown (2.1.1)
+      nokogiri
+    rexml (3.2.5)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    rubocop (0.93.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.1.5)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
+      rexml
+      rubocop-ast (>= 0.6.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (1.18.0)
+      parser (>= 3.1.1.0)
+    rubocop-gitlab-security (0.1.1)
+      rubocop (>= 0.51)
+    rubocop-performance (1.9.2)
+      rubocop (>= 0.90.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rails (2.9.1)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.90.0, < 2.0)
+    rubocop-rspec (1.44.1)
+      rubocop (~> 0.87)
+      rubocop-ast (>= 0.7.1)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.5)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
+    solargraph (0.45.0)
+      backport (~> 1.2)
+      benchmark
+      bundler (>= 1.17.2)
+      diff-lcs (~> 1.4)
+      e2mmap
+      jaro_winkler (~> 1.5)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.1)
+      parser (~> 3.0)
+      reverse_markdown (>= 1.0.5, < 3)
+      rubocop (>= 0.52)
+      thor (~> 1.0)
+      tilt (~> 2.0)
+      yard (~> 0.9, >= 0.9.24)
+    table_print (1.5.7)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.2.1)
+    tilt (2.0.10)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unf (0.1.4)
+      unf_ext
+    unf_ext (0.0.8.2)
+    unicode-display_width (1.8.0)
+    webmock (3.7.0)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    webrick (1.7.0)
+    yard (0.9.27)
+      webrick (~> 1.7.0)
+    zeitwerk (2.5.4)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  climate_control (~> 1.0.1)
+  gitlab-dangerfiles (~> 2.11)
+  gitlab-qa!
+  gitlab-styles (~> 6.2.1)
+  pry (~> 0.11)
+  rake (~> 13.0)
+  rspec (~> 3.7)
+  solargraph (~> 0.41)
+  webmock (= 3.7.0)
+
+BUNDLED WITH
+   2.2.33

data/docs/what_tests_can_be_run.md

@@ -68,7 +68,7 @@ All environment variables used by GitLab QA should be defined in [`lib/gitlab/qa
 | `QA_PRAEFECT_REPOSITORY_STORAGE` |-  | The name of repository storage using Praefect. Note: Admin access is required to change repository storage. | No|
 | `QA_COOKIES` |-  | Optionally set to "cookie1=value;cookie2=value" in order to add a cookie to every request. This can be used to set the canary cookie by setting it to "gitlab_canary=true". | No|
 | `QA_DEBUG` |-  | Set to `true` to verbosely log page object actions. Note: if enabled be aware that sensitive data might be logged. If an input element has a QA selector with `password` in the name, data entered into the input element will be masked. If the element doesn't have `password` in its name it won't be masked. | No|
-| `QA_LOG_PATH` |-  | Path to output debug logging to. If not set logging will be output to STDOUT. | No|
+| `QA_LOG_PATH` |-  | Path to output debug logging to. By default `QA_ARTIFACTS_DIR` is used | No|
 | `QA_CAN_TEST_GIT_PROTOCOL_V2` | `true` | Set to `false` to skip tests that require Git protocol v2 if your environment doesn't support it. | No|
 | `QA_CAN_TEST_ADMIN_FEATURES` | `true` | Set to `false` to skip tests that require admin access. | No|
 | `QA_CAN_TEST_PRAEFECT` | `true` | Set to `false` to skip tests that require Praefect to be running. | No|
@@ -651,23 +651,6 @@ $ export EE_LICENSE=$(cat /path/to/GitLab.gitlab_license)
 $ gitlab-qa Test::Integration::Jira EE
 ```
 
-### `Test::Integration::Actioncable CE|EE|<full image address>`
-
-This tests the real-time assignees feature by setting
-`actioncable['enable'] = true` in the Omnibus configuration
-before starting the GitLab container.
-
-To run tests against the GitLab container, a GitLab QA (`gitlab/gitlab-qa`)
-container is spun up and tests are run from it by running the
-`Test::Instance::All` scenario with the `--tag actioncable` RSpec parameter,
-which runs only the tests with `:actioncable` metadata.
-
-Example:
-
-```
-$ gitlab-qa Test::Integration::Actioncable CE
-```
-
 ### `Test::Integration::Integrations CE|<full image address>`
 
 This scenario is intended to test the different integrations that a GitLab instance can offer, such as WebHooks to an external service, Jenkins, etc.
@@ -729,6 +712,23 @@ in the GitLab project).
   This is used to retrieve the version that staging is currently running.
   This can be found in the shared 1Password vault.
 
+- `GITLAB_USERNAME`: An existing user.
+
+- `GITLAB_PASSWORD`: The user's password.
+
+**Required by specific tests:**
+
+- `QA_PRAEFECT_REPOSITORY_STORAGE`: The name of a Gitaly Cluster storage.
+
+- `GITLAB_ADMIN_USERNAME`: An existing user with administrator access. Required by tests that set feature flags or
+  perform other admin actions.
+
+- `GITLAB_ADMIN_PASSWORD`: The administrator user's password.
+
+- `GITLAB_QA_USERNAME_X`: The username of a pre-generated test user, where `X` is `1` to `6`.
+
+- `GITLAB_QA_PASSWORD_X`: The pre-generated test user's password.
+
 **Optional environment variables:**
 
 - `GITLAB_QA_DEV_ACCESS_TOKEN`: A valid personal access token for the
@@ -736,17 +736,24 @@ in the GitLab project).
   This is used to pull the QA Docker image from the Omnibus GitLab `dev` Container Registry.
   If the variable isn't present, the QA image from Docker Hub will be used.
   This can be found in the shared 1Password vault.
+  Please note that this variable must be provided when you need to be sure the version of the
+  tests matches the version of GitLab on Staging. If the version from Docker Hub is used it might not include changes deployed to Staging very recently.
 
-Example:
+An example of how to run the smoke tests:
 
 ```
-$ export GITLAB_QA_USER_AGENT="$GITLAB_QA_USER_AGENT"
-$ export GITLAB_QA_ACCESS_TOKEN=your_api_access_token
-$ export GITLAB_QA_DEV_ACCESS_TOKEN=your_dev_registry_access_token
+$ export GITLAB_QA_USER_AGENT="<value from 1Password>"
+$ export GITLAB_QA_ACCESS_TOKEN="<value from 1Password>"
+$ export GITLAB_QA_DEV_ACCESS_TOKEN="<value from 1Password>"
 $ export GITLAB_USERNAME="gitlab-qa"
-$ export GITLAB_PASSWORD="$GITLAB_QA_PASSWORD"
+$ export GITLAB_PASSWORD="<value from 1Password>"
+$ export GITLAB_ADMIN_USERNAME="<value from 1Password>"
+$ export GITLAB_ADMIN_PASSWORD="<value from 1Password>"
+$ export GITLAB_QA_USERNAME_1="gitlab-qa-user1"
+$ export GITLAB_QA_PASSWORD_1="<value from 1Password>"
+$ export QA_PRAEFECT_REPOSITORY_STORAGE="nfs-file22"
 
-$ gitlab-qa Test::Instance::Staging
+$ gitlab-qa Test::Instance::Staging -- --tag smoke
 ```
 
 ### `Test::Instance::StagingRef`
@@ -845,6 +852,52 @@ by setting `QA_COOKIES=gitlab_canary=true`. This adds a cookie
 to all web requests which will result in them being routed
 to the canary fleet.
 
+**Required environment variables:**
+
+- `GITLAB_QA_USER_AGENT`: The browser user-agent to use instead of the default Chrome user-agent.
+  This is needed for the automated tests to bypass the WAF
+
+- `GITLAB_QA_ACCESS_TOKEN`: A valid personal access token with the `api` scope.
+  This is used to retrieve the version that staging is currently running.
+  This can be found in the shared 1Password vault.
+
+- `GITLAB_USERNAME`: An existing user.
+
+- `GITLAB_PASSWORD`: The user's password.
+
+**Required by specific tests:**
+
+- `GITLAB_QA_USERNAME_X`: The username of a pre-generated test user, where `X` is `1` to `6`.
+
+- `GITLAB_QA_PASSWORD_X`: The pre-generated test user's password.
+
+**Optional environment variables:**
+
+- `GITLAB_QA_DEV_ACCESS_TOKEN`: A valid personal access token for the
+  `gitlab-qa-bot` on `dev.gitlab.org` with the `registry` scope.
+  This is used to pull the QA Docker image from the Omnibus GitLab `dev` Container Registry.
+  If the variable isn't present, the QA image from Docker Hub will be used.
+  This can be found in the shared 1Password vault.
+  Please note that this variable should be provided when you need to be sure the version of the
+  tests matches the version of GitLab on Staging. If the version from Docker Hub is used it might not include changes deployed to Staging very recently.
+
+An example of how to run the smoke tests:
+
+```
+$ export GITLAB_QA_USER_AGENT="<value from 1Password>"
+$ export GITLAB_QA_ACCESS_TOKEN="<value from 1Password>"
+$ export GITLAB_QA_DEV_ACCESS_TOKEN="<value from 1Password>"
+$ export GITLAB_USERNAME="gitlab-qa"
+$ export GITLAB_PASSWORD="<value from 1Password>"
+$ export GITLAB_QA_USERNAME_1="gitlab-qa-user1"
+$ export GITLAB_QA_PASSWORD_1="<value from 1Password>"
+$ export QA_CAN_TEST_GIT_PROTOCOL_V2="false"
+$ export QA_CAN_TEST_ADMIN_FEATURES="false"
+$ export QA_CAN_TEST_PRAEFECT="false"
+
+$ gitlab-qa Test::Instance::Production -- --tag smoke
+```
+
 ### `Test::Instance::Preprod`
 
 This scenario functions the same as `Test::Instance::Staging`

data/lib/gitlab/qa/component/base.rb

@@ -15,8 +15,7 @@ module Gitlab
           @environment = {}
           @volumes = {}
           @network_aliases = []
-
-          self.exec_commands = []
+          @exec_commands = []
         end
 
         def add_network_alias(name)

data/lib/gitlab/qa/component/gitlab.rb

@@ -155,7 +155,6 @@ module Gitlab
           setup_omnibus
 
           @docker.attach(name) do |line, wait|
-            puts line
             # TODO, workaround which allows to detach from the container
             break if /gitlab Reconfigured!/.match?(line)
           end
@@ -174,11 +173,15 @@ module Gitlab
         def process_exec_commands
           @docker.copy(name, DATA_SEED_PATH, DATA_PATH) if seed_admin_token || seed_db
 
-          self.exec_commands += seed_admin_token_command if seed_admin_token
-          self.exec_commands += seed_test_data_command if seed_db
+          exec_commands << seed_admin_token_command if seed_admin_token
+          exec_commands << seed_test_data_command if seed_db
+          exec_commands << Runtime::Scenario.omnibus_exec_commands
+
+          commands = exec_commands.flatten.uniq
+          return if commands.empty?
 
           Runtime::Logger.info("Running exec_commands...")
-          exec_commands.flatten.uniq.each { |command| @docker.exec(name, command) }
+          commands.each { |command| @docker.exec(name, command) }
         end
 
         def sha_version

data/lib/gitlab/qa/component/specs.rb

@@ -11,7 +11,7 @@ module Gitlab
         attr_accessor :suite, :release, :network, :args, :volumes, :env, :runner_network, :hostname
 
         def initialize
-          @docker = Docker::Engine.new
+          @docker = Docker::Engine.new(stream_output: true) # stream test output directly instead of through logger
           @volumes = {}
           @env = {}
         end

data/lib/gitlab/qa/docker/command.rb

@@ -2,11 +2,17 @@ module Gitlab
   module QA
     module Docker
       class Command
-        attr_reader :args
+        attr_reader :args, :stream_output
 
-        def initialize(cmd = nil, mask_secrets: nil)
+        # Shell command
+        #
+        # @param [<String, Array>] cmd
+        # @param [<String, Array>] mask_secrets
+        # @param [Boolean] stream_output stream command output to stdout directly instead of logger
+        def initialize(cmd = nil, mask_secrets: nil, stream_output: false)
           @args = Array(cmd)
           @mask_secrets = Array(mask_secrets)
+          @stream_output = stream_output
         end
 
         def <<(*args)

data/lib/gitlab/qa/docker/engine.rb

@@ -7,6 +7,12 @@ module Gitlab
         DOCKER_HOST = ENV['DOCKER_HOST'] || 'http://localhost'
         PRIVILEGED_COMMANDS = [/^iptables.*/].freeze
 
+        attr_reader :stream_output
+
+        def initialize(stream_output: false)
+          @stream_output = stream_output
+        end
+
         def hostname
           URI(DOCKER_HOST).host
         end
@@ -15,12 +21,17 @@ module Gitlab
           Docker::Command.execute(%(login --username "#{username}" --password "#{password}" #{registry}), mask_secrets: password)
         end
 
-        def pull(image:, tag: nil)
-          Docker::Command.execute("pull #{full_image_name(image, tag)}")
+        def pull(image:, tag: nil, quiet: true)
+          Docker::Command.new("pull").tap do |command|
+            command << "-q" if quiet
+            command << full_image_name(image, tag)
+
+            command.execute!
+          end
         end
 
         def run(image:, tag: nil, args: [])
-          Docker::Command.new('run').tap do |command|
+          Docker::Command.new('run', stream_output: stream_output).tap do |command|
             yield command if block_given?
 
             command << full_image_name(image, tag)

data/lib/gitlab/qa/docker/shellout.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open3'
 require 'rainbow/refinement'
 
@@ -6,35 +8,57 @@ module Gitlab
     module Docker
       class Shellout
         using Rainbow
+
         StatusError = Class.new(StandardError)
 
         def initialize(command)
           @command = command
           @output = []
-
-          Rainbow.enabled = Runtime::Env.colorized_logs?
-          Runtime::Logger.info("Docker shell command: `#{@command.mask_secrets}`".cyan)
+          @logger = Runtime::Logger.logger
         end
 
+        attr_reader :command, :logger
+
         def execute! # rubocop:disable Metrics/AbcSize
           raise StatusError, 'Command already executed' if @output.any?
 
+          logger.info("Docker shell command: `#{@command.mask_secrets.cyan}`")
+
           Open3.popen2e(@command.to_s) do |_in, out, wait|
             out.each do |line|
               @output.push(line)
 
-              if block_given?
-                yield line, wait
-              else
+              if stream_progress
+                print "."
+              elsif command.stream_output
                 puts line
               end
+
+              yield line, wait if block_given?
             end
+            puts if stream_progress
 
-            if wait.value.exited? && wait.value.exitstatus.nonzero? # rubocop:disable Style/IfUnlessModifier
-              raise StatusError, "Docker command `#{@command.mask_secrets}` failed! ✘"
+            if wait.value.exited? && wait.value.exitstatus.nonzero?
+              logger.error("Docker shell command output:\n#{output}") unless command.stream_output
+              raise StatusError, "Docker command `#{@command.mask_secrets[0..100]}` failed! ✘"
             end
+
+            logger.debug("Docker shell command output:\n#{output}") unless command.stream_output || output.empty?
           end
 
+          output
+        end
+
+        private
+
+        # Stream only command execution progress and log output when command finished
+        #
+        # @return [Boolean]
+        def stream_progress
+          !(Runtime::Env.ci || command.stream_output)
+        end
+
+        def output
           @output.join.chomp
         end
       end

data/lib/gitlab/qa/report/test_result.rb

@@ -114,6 +114,9 @@ module Gitlab
                 line.include?(File.basename(report['file_path']))
               end
 
+              exception['message'].gsub!(/(private_token=)[\w-]+/, '********')
+              exception['message_lines'].each { |line| line.gsub!(/(private_token=)([\w-]+)/, '********') }
+
               {
                 'message' => "#{exception['class']}: #{exception['message']}",
                 'message_lines' => exception['message_lines'],
@@ -145,6 +148,7 @@ module Gitlab
 
           private
 
+          # rubocop:disable Metrics/AbcSize
           def failures_from_exceptions
             failures = report.search('failure')
             return [] if failures.empty?
@@ -155,12 +159,15 @@ module Gitlab
                 line.include?(File.basename(report['file']))
               end
 
+              exception['message'].gsub!(/(private_token=)[\w-]+/, '********')
+
               {
                 'message' => "#{exception['type']}: #{exception['message']}",
                 'stacktrace' => trace.slice(0..spec_file_first_index).join("\n")
               }
             end
           end
+          # rubocop:enable Metrics/AbcSize
         end
       end
     end

data/lib/gitlab/qa/runtime/env.rb

@@ -27,7 +27,6 @@ module Gitlab
           'QA_COOKIES' => :qa_cookie,
           'QA_DEBUG' => :qa_debug,
           'QA_DEFAULT_BRANCH' => :qa_default_branch,
-          'QA_LOG_PATH' => :qa_log_path,
           'QA_CAN_TEST_ADMIN_FEATURES' => :qa_can_test_admin_features,
           'QA_CAN_TEST_GIT_PROTOCOL_V2' => :qa_can_test_git_protocol_v2,
           'QA_CAN_TEST_PRAEFECT' => :qa_can_test_praefect,
@@ -168,6 +167,14 @@ module Gitlab
           enabled?(ENV['QA_DEBUG'], default: true)
         end
 
+        def log_level
+          env_var_value_if_defined('QA_LOG_LEVEL')&.upcase || 'INFO'
+        end
+
+        def log_path
+          env_var_value_if_defined('QA_LOG_PATH') || host_artifacts_dir
+        end
+
         def default_branch
           env_var_value_if_defined('QA_DEFAULT_BRANCH') || 'main'
         end

data/lib/gitlab/qa/runtime/logger.rb

@@ -11,7 +11,12 @@ module Gitlab
         def_delegators :logger, :debug, :info, :warn, :error, :fatal, :unknown
 
         def self.logger
-          @logger ||= QA::TestLogger.logger(level: Runtime::Env.debug? ? ::Logger::DEBUG : ::Logger::INFO)
+          @logger ||= begin
+            log_path = Env.log_path
+            ::FileUtils.mkdir_p(log_path) unless File.exist?(log_path)
+
+            TestLogger.logger(level: Env.debug? ? "DEBUG" : Env.log_level, path: log_path)
+          end
         end
       end
     end

data/lib/gitlab/qa/runtime/omnibus_configurations/ci_decomposition.rb

@@ -22,7 +22,8 @@ module Gitlab
               "gitlab-psql -c 'create database gitlabhq_production_ci owner gitlab'",
               "gitlab-psql -d gitlabhq_production_ci -c 'create extension btree_gist'",
               "gitlab-psql -d gitlabhq_production_ci -c 'create extension pg_trgm'",
-              "gitlab-rake db:structure:load:ci"
+              "gitlab-rake db:structure:load:ci",
+              "gitlab-ctl restart"
             ].freeze
           end
         end

data/lib/gitlab/qa/runtime/omnibus_configurations/object_storage.rb

@@ -5,21 +5,19 @@ module Gitlab
     module Runtime
       module OmnibusConfigurations
         class ObjectStorage < Default
-          TYPES = %w[artifacts external_diffs lfs uploads packages dependency_proxy].freeze
+          TYPES = %w[artifacts external_diffs lfs uploads packages dependency_proxy terraform_state pages].freeze
 
           def configuration
-            TYPES.each_with_object(+'') do |object_type, omnibus|
+            config = TYPES.each_with_object(+'') do |object_type, omnibus|
               omnibus << <<~OMNIBUS
-                gitlab_rails['#{object_type}_enabled'] = true
-                gitlab_rails['#{object_type}_storage_path'] = '/var/opt/gitlab/gitlab-rails/shared/#{object_type}'
-                gitlab_rails['#{object_type}_object_store_enabled'] = true
-                gitlab_rails['#{object_type}_object_store_remote_directory'] = '#{object_type}-bucket'
-                gitlab_rails['#{object_type}_object_store_background_upload'] = false
-                gitlab_rails['#{object_type}_object_store_direct_upload'] = true
-                gitlab_rails['#{object_type}_object_store_proxy_download'] = true
-                gitlab_rails['#{object_type}_object_store_connection'] = #{minio.to_config}
+                gitlab_rails['object_store']['objects']['#{object_type}']['bucket'] = '#{object_type}-bucket'
               OMNIBUS
             end
+            config << <<~OMNIBUS
+              gitlab_rails['object_store']['enabled'] = true
+              gitlab_rails['object_store']['proxy_download'] = true
+              gitlab_rails['object_store']['connection'] = #{minio.to_config}
+            OMNIBUS
           end
 
           def prepare

data/lib/gitlab/qa/scenario/test/integration/registry_with_cdn.rb

@@ -13,6 +13,7 @@ module Gitlab
                 gitlab.release = release
                 gitlab.network = 'test'
                 gitlab.name = 'gitlab'
+                gitlab.seed_admin_token = false
                 sign_url_key_path = gitlab.copy_key_file('GOOGLE_CDN_SIGNURL_KEY')
                 cdn_gcloud_path = gitlab.copy_key_file('GOOGLE_CDN_JSON_KEY')
 

data/lib/gitlab/qa/test_logger.rb

@@ -1,13 +1,14 @@
 # frozen_string_literal: true
 
-require 'logger'
 require 'rainbow'
+require 'active_support/logger'
 
 module Gitlab
   module QA
     # Common test logger implementation
     #
     class TestLogger
+      TIME_FORMAT = "%Y-%m-%d %H:%M:%S"
       LEVEL_COLORS = {
         "DEBUG" => :magenta,
         "INFO" => :green,
@@ -18,17 +19,62 @@ module Gitlab
 
       Rainbow.enabled = Runtime::Env.colorized_logs?
 
-      def self.logger(level: ::Logger::INFO, source: 'Gitlab QA')
-        ::Logger.new($stdout).tap do |logger|
-          logger.level = level
+      class << self
+        # Combined logger instance
+        #
+        # @param [<Symbol, String>] level
+        # @param [String] source
+        # @return [ActiveSupport::Logger]
+        def logger(level: :info, source: 'Gitlab QA', path: 'tmp')
+          console_log = console_logger(level: level, source: source)
+          file_log = file_logger(source: source, path: path)
 
-          logger.formatter = proc do |severity, datetime, progname, msg|
-            date_format = datetime.strftime("%Y-%m-%d %H:%M:%S")
-            msg_prefix = "[date=#{date_format} from=#{source}] #{severity.ljust(5)} -- "
+          console_log.extend(ActiveSupport::Logger.broadcast(file_log))
+        end
+
+        private
+
+        # Console logger instance
+        #
+        # @param [<Symbol, String>] level
+        # @param [String] source
+        # @return [ActiveSupport::Logger]
+        def console_logger(level:, source:)
+          ActiveSupport::Logger.new($stdout, level: level, datetime_format: TIME_FORMAT).tap do |logger|
+            logger.formatter = proc do |severity, datetime, progname, msg|
+              msg_prefix = message_prefix(datetime, source, severity)
+
+              Rainbow(msg_prefix).public_send(LEVEL_COLORS.fetch(severity, :silver)) + "#{msg}\n" # rubocop:disable GitlabSecurity/PublicSend
+            end
+          end
+        end
+
+        # File logger
+        #
+        # @param [String] source
+        # @param [String] path
+        # @return [ActiveSupport::Logger]
+        def file_logger(source:, path:)
+          log_file = "#{path}/#{source.downcase.tr(' ', '-')}.log"
+
+          ActiveSupport::Logger.new(log_file, level: :debug, datetime_format: TIME_FORMAT).tap do |logger|
+            logger.formatter = proc do |severity, datetime, progname, msg|
+              msg_prefix = message_prefix(datetime, source, severity)
 
-            Rainbow(msg_prefix).public_send(LEVEL_COLORS.fetch(severity, :silver)) + "#{msg}\n" # rubocop:disable GitlabSecurity/PublicSend
+              "#{msg_prefix}#{msg}\n"
+            end
           end
         end
+
+        # Log message prefix
+        #
+        # @param [DateTime] date
+        # @param [String] source
+        # @param [String] severity
+        # @return [String]
+        def message_prefix(date, source, severity)
+          "[date=#{date} from=#{source}] #{severity.ljust(5)} -- "
+        end
       end
     end
   end

data/lib/gitlab/qa/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module QA
-    VERSION = '7.27.1'
+    VERSION = '7.29.1'
   end
 end

data/lib/gitlab/qa.rb

@@ -55,7 +55,6 @@ module Gitlab
         end
 
         module Integration
-          autoload :Actioncable, 'gitlab/qa/scenario/test/integration/actioncable'
           autoload :Geo, 'gitlab/qa/scenario/test/integration/geo'
           autoload :LDAP, 'gitlab/qa/scenario/test/integration/ldap'
           autoload :LDAPNoTLS, 'gitlab/qa/scenario/test/integration/ldap_no_tls'

data/scripts/generate-qa-jobs.rb

@@ -34,7 +34,6 @@ class GenerateQAJobs
     jobs.concat(load_yml_contents('object_storage_registry_tls')) if should_run?('test_integration_registrytls')
     jobs.concat(load_yml_contents('registry')) if should_run?('test_integration_registry')
     jobs.concat(load_yml_contents('packages')) if should_run?('test_instance_all_packages')
-    jobs.concat(load_yml_contents('actioncable')) if should_run?('test_instance_all_actioncable')
     jobs.concat(load_yml_contents('elasticsearch')) if should_run?('test_integration_elasticsearch')
     jobs.concat(load_yml_contents('praefect')) if should_run?('test_instance_all')
     jobs.concat(load_yml_contents('gitaly_cluster')) if should_run?('test_instance_all')

data/tmp/.gitignore

@@ -0,0 +1,3 @@
+**
+
+!.gitignore

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 7.27.1
+  version: 7.29.1
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-05-17 00:00:00.000000000 Z
+date: 2022-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -218,7 +218,6 @@ files:
 - ".dockerignore"
 - ".gitignore"
 - ".gitlab-ci.yml"
-- ".gitlab/ci/jobs/actioncable.gitlab-ci.yml"
 - ".gitlab/ci/jobs/base.gitlab-ci.yml"
 - ".gitlab/ci/jobs/ci_decomposition.gitlab-ci.yml"
 - ".gitlab/ci/jobs/cloud_activation.gitlab-ci.yml"
@@ -265,6 +264,7 @@ files:
 - CONTRIBUTING.md
 - Dangerfile
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -364,7 +364,6 @@ files:
 - lib/gitlab/qa/scenario/test/instance/staging_geo.rb
 - lib/gitlab/qa/scenario/test/instance/staging_ref.rb
 - lib/gitlab/qa/scenario/test/instance/staging_ref_geo.rb
-- lib/gitlab/qa/scenario/test/integration/actioncable.rb
 - lib/gitlab/qa/scenario/test/integration/client_ssl.rb
 - lib/gitlab/qa/scenario/test/integration/elasticsearch.rb
 - lib/gitlab/qa/scenario/test/integration/geo.rb
@@ -411,6 +410,7 @@ files:
 - tls_certificates/gitlab/gitlab.test.crt
 - tls_certificates/gitlab/gitlab.test.csr
 - tls_certificates/gitlab/gitlab.test.key
+- tmp/.gitignore
 homepage: http://about.gitlab.com/
 licenses:
 - MIT

data/.gitlab/ci/jobs/actioncable.gitlab-ci.yml

@@ -1,41 +0,0 @@
-ce:actioncable:
-  extends:
-    - .rules:ce-never-when-triggered-by-feature-flag-definition-change
-    - .test
-    - .high-capacity
-    - .ce-variables
-    - .rspec-report-opts
-  variables:
-    QA_SCENARIO: "Test::Integration::Actioncable"
-
-ce:actioncable-quarantine:
-  extends:
-    - .rules:ce-never-when-triggered-by-feature-flag-definition-change
-    - .test
-    - .high-capacity
-    - .ce-variables
-    - .quarantine
-    - .rspec-report-opts
-  variables:
-    QA_SCENARIO: "Test::Integration::Actioncable"
-
-ee:actioncable:
-  extends:
-    - .rules:ee-never-when-triggered-by-feature-flag-definition-change
-    - .test
-    - .high-capacity
-    - .ee-variables
-    - .rspec-report-opts
-  variables:
-    QA_SCENARIO: "Test::Integration::Actioncable"
-
-ee:actioncable-quarantine:
-  extends:
-    - .rules:ee-never-when-triggered-by-feature-flag-definition-change
-    - .test
-    - .high-capacity
-    - .ee-variables
-    - .quarantine
-    - .rspec-report-opts
-  variables:
-    QA_SCENARIO: "Test::Integration::Actioncable"

data/lib/gitlab/qa/scenario/test/integration/actioncable.rb

@@ -1,34 +0,0 @@
-module Gitlab
-  module QA
-    module Scenario
-      module Test
-        module Integration
-          class Actioncable < Scenario::Template
-            def perform(release, *rspec_args)
-              Component::Gitlab.perform do |gitlab|
-                gitlab.release = QA::Release.new(release)
-                gitlab.name = 'gitlab-actioncable'
-                gitlab.network = 'test'
-                gitlab.omnibus_configuration << "actioncable['enable'] = true"
-
-                gitlab.instance do
-                  Runtime::Logger.info('Running actioncable specs!')
-
-                  rspec_args << "--" unless rspec_args.include?('--')
-                  rspec_args << %w[--tag actioncable]
-
-                  Component::Specs.perform do |specs|
-                    specs.suite = 'Test::Instance::All'
-                    specs.release = gitlab.release
-                    specs.network = gitlab.network
-                    specs.args = [gitlab.address, *rspec_args]
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end