gitlab-qa 7.24.0 → 7.24.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 667197342275f6df37533b1873c6d0cfc7ae66d43bc600af2baa1eca89dc3891
-  data.tar.gz: 0fa801cb8ba230a40864cc6106edcbaaf1a5190b5e24bf1f2e89a36c2bcf99a3
+  metadata.gz: e2b176f3463abe8bce6879fad13baf9053f8d51175ce9b4c2994b2ad72a308b5
+  data.tar.gz: a93d60ad2678d98b2e94e89e2c97cc24c1a81b42e5e838f5eaa20285a92a92a1
 SHA512:
-  metadata.gz: 0a02f18c341ce5fa7f3435b890db6c2d6b9afba8c501fe818b15f75640840b6cb1bc4af29802007fce8af76390aed2cfa53328ab9861307cda87773add8b730f
-  data.tar.gz: 85fec2a1eb1184e5b519c7af38853759a78bc54366b8b164d8de133833e9a1cf9c35b4670c24c7bca5a4872704f64f940e652fc246998dd933d2984f5208d47c
+  metadata.gz: a6739f73c98c6fc9e044915632a747d990d1f1bb354eaaf77bb0de4d6c6c5abbaffda10a8f60927757a16ca48affc3dca2b8aa8a6bf4f4e6b6977eda9c3b4c20
+  data.tar.gz: 17379496d96c009b6c96ea8953a38bacb253eb6ac80006889557bb068a6270991100926601936dcddd92cf02dca6ea7c3159990a6f3264e601803d5460394259

data/.gitlab/ci/danger.gitlab-ci.yml

@@ -0,0 +1,25 @@
+danger-review:
+  image: ruby:3.0
+  stage: check
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+  needs: []
+  retry:
+    max: 2
+    when:
+      - unknown_failure
+      - api_failure
+      - runner_system_failure
+      - stuck_or_timeout_failure
+  before_script:
+    - bundle install
+  script:
+    - >
+      if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then
+        # Force danger to skip CI source GitLab and fallback to "local only git repo".
+        unset GITLAB_CI
+        # We need the base SHA of the merge request diff to help danger determine the base commit for this shallow clone.
+        bundle exec danger dry_run --fail-on-errors=true --verbose --base='$CI_MERGE_REQUEST_DIFF_BASE_SHA' --head='${CI_MERGE_REQUEST_SOURCE_BRANCH_SHA:-$CI_COMMIT_SHA}'
+      else
+        bundle exec danger --fail-on-errors=true --verbose
+      fi

data/.gitlab-ci.yml

@@ -1384,8 +1384,7 @@ generate-knapsack-report:
 include:
   - local: .gitlab/ci/*.gitlab-ci.yml
   - project: 'gitlab-org/quality/pipeline-common'
-    file: '/ci/gem-release.yml'
-  - project: 'gitlab-org/quality/pipeline-common'
-    file: '/ci/allure-report.yml'
-  - project: 'gitlab-org/quality/pipeline-common'
-    file: '/ci/knapsack-report.yml'
+    file:
+      - '/ci/gem-release.yml'
+      - '/ci/allure-report.yml'
+      - '/ci/knapsack-report.yml'

data/Dangerfile

@@ -0,0 +1,9 @@
+require 'gitlab-dangerfiles'
+
+Gitlab::Dangerfiles.for_project(self) do |dangerfiles|
+  # Import all plugins from the gem
+  dangerfiles.import_plugins
+
+  # Import only a subset of rules
+  dangerfiles.import_dangerfiles(only: %w[changes_size commit_messages simple_roulette])
+end

data/gitlab-qa.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'climate_control', '~> 1.0.1'
+  spec.add_development_dependency 'gitlab-dangerfiles', '~> 2.10'
   spec.add_development_dependency 'gitlab-styles', '~> 6.2.1'
   spec.add_development_dependency 'pry', '~> 0.11'
   spec.add_development_dependency 'rake', '~> 13.0'

data/lib/gitlab/qa/component/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module QA
     module Component

data/lib/gitlab/qa/component/gitlab.rb

@@ -18,9 +18,7 @@ module Gitlab
 
         def_delegators :release, :tag, :image, :edition
 
-        AUTHORITY_CERTIFICATES_PATH = File.expand_path('../../../../tls_certificates/authority', __dir__)
-        GITLAB_CERTIFICATES_PATH = File.expand_path('../../../../tls_certificates/gitlab', __dir__)
-        GITALY_CERTIFICATES_PATH = File.expand_path('../../../../tls_certificates/gitaly', __dir__)
+        CERTIFICATES_PATH = File.expand_path('../../../../tls_certificates', __dir__)
 
         SSL_PATH = '/etc/gitlab/ssl'
         TRUSTED_PATH = '/etc/gitlab/trusted-certs'
@@ -31,10 +29,15 @@ module Gitlab
           @skip_availability_check = false
           @omnibus_gitlab_rails_env = {}
 
-          @volumes[GITLAB_CERTIFICATES_PATH] = SSL_PATH
-          @volumes[AUTHORITY_CERTIFICATES_PATH] = TRUSTED_PATH
+          @omnibus_configuration = Runtime::OmnibusConfiguration.new(Runtime::Scenario.omnibus_configuration)
 
-          @omnibus_configuration ||= Runtime::OmnibusConfiguration.new(Runtime::Scenario.omnibus_configuration)
+          @working_dir_tmp_cert_path = Dir.mktmpdir('certs', FileUtils.mkdir_p("#{Dir.pwd}/tmp"))
+          @authority_cert_path = "#{@working_dir_tmp_cert_path}/authority"
+          @gitlab_cert_path = "#{@working_dir_tmp_cert_path}/gitlab"
+          @gitaly_cert_path = "#{@working_dir_tmp_cert_path}/gitaly"
+
+          @volumes[@gitlab_cert_path] = SSL_PATH
+          @volumes[@authority_cert_path] = TRUSTED_PATH
 
           self.release = 'CE'
         end
@@ -77,8 +80,8 @@ module Gitlab
         end
 
         def gitaly_tls
-          @volumes.delete(GITLAB_CERTIFICATES_PATH)
-          @volumes[GITALY_CERTIFICATES_PATH] = SSL_PATH
+          @volumes.delete(@gitlab_cert_path)
+          @volumes[@gitaly_cert_path] = SSL_PATH
         end
 
         def relative_path
@@ -91,6 +94,13 @@ module Gitlab
 
         def prepare
           prepare_gitlab_omnibus_config
+          copy_certificates
+
+          super
+        end
+
+        def teardown!
+          FileUtils.rm_rf(@working_dir_tmp_cert_path)
 
           super
         end
@@ -168,6 +178,14 @@ module Gitlab
 
         private
 
+        # Copy certs to a temporary directory in current working directory.
+        # This is needed for docker-in-docker ci environments where mount points outside of build dir are not accessible
+        #
+        # @return [void]
+        def copy_certificates
+          FileUtils.cp_r("#{CERTIFICATES_PATH}/.", @working_dir_tmp_cert_path)
+        end
+
         def ensure_configured!
           raise 'Please configure an instance first!' unless [name, release, network].all?
         end

data/lib/gitlab/qa/component/ldap.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'securerandom'
 
 # This component sets up the docker-openldap (https://github.com/osixia/docker-openldap)
@@ -16,18 +18,12 @@ module Gitlab
   module QA
     module Component
       class LDAP < Base
-        DOCKER_IMAGE = 'osixia/openldap'.freeze
-        DOCKER_IMAGE_TAG = 'latest'.freeze
-        LDAP_USER = 'tanuki'.freeze
-        LDAP_PASSWORD = 'password'.freeze
-        BOOTSTRAP_LDIF = '/container/service/slapd/assets/config/bootstrap/ldif/custom'.freeze
-        FIXTURE_PATH = File.expand_path('../../../../fixtures/ldap'.freeze, __dir__)
-
-        def initialize
-          super
-
-          @volumes[FIXTURE_PATH] = BOOTSTRAP_LDIF
-        end
+        DOCKER_IMAGE = 'osixia/openldap'
+        DOCKER_IMAGE_TAG = 'latest'
+        LDAP_USER = 'tanuki'
+        LDAP_PASSWORD = 'password'
+        BOOTSTRAP_LDIF = '/container/service/slapd/assets/config/bootstrap/ldif/custom'
+        FIXTURE_PATH = File.expand_path('../../../../fixtures/ldap', __dir__)
 
         # LDAP_TLS is true by default
         def tls=(status)
@@ -59,6 +55,19 @@ module Gitlab
           super
         end
 
+        def prepare
+          copy_fixtures
+          @volumes["#{working_dir_tmp_fixture_path}/ldap"] = BOOTSTRAP_LDIF
+
+          super
+        end
+
+        def teardown!
+          FileUtils.rm_rf(working_dir_tmp_fixture_path)
+
+          super
+        end
+
         # rubocop:disable Metrics/AbcSize
         def start
           # copy-service needed for bootstraping LDAP user:
@@ -88,6 +97,23 @@ module Gitlab
           ::Gitlab::QA::Runtime::Env.ldap_username = username
           ::Gitlab::QA::Runtime::Env.ldap_password = password
         end
+
+        private
+
+        # Temporary fixture dir in working directory
+        #
+        # @return [String]
+        def working_dir_tmp_fixture_path
+          @local_fixture_path ||= Dir.mktmpdir('ldap', FileUtils.mkdir_p("#{Dir.pwd}/tmp"))
+        end
+
+        # Copy fixtures to current working directory
+        # This is needed for docker-in-docker ci environments where mount points outside of build dir are not accessible
+        #
+        # @return [void]
+        def copy_fixtures
+          FileUtils.cp_r(FIXTURE_PATH, working_dir_tmp_fixture_path)
+        end
       end
     end
   end

data/lib/gitlab/qa/report/relate_failure_issue.rb

@@ -20,6 +20,7 @@ module Gitlab
           super
           @max_diff_ratio = max_diff_ratio.to_f
           @issue_type = 'issue'
+          @commented_issue_list = Set.new
         end
 
         private
@@ -60,7 +61,8 @@ module Gitlab
 
           if issue
             puts "  => Found issue #{issue.web_url} for test '#{test.name}' with a diff ratio of #{(diff_ratio * 100).round(2)}%."
-            post_failed_job_note(issue, test)
+            @commented_issue_list.include?(issue.web_url) ? (puts " => Failure already commented on issue.") : post_failed_job_note(issue, test)
+            @commented_issue_list.add(issue.web_url)
           end
 
           issue

data/lib/gitlab/qa/report/report_as_issue.rb

@@ -106,8 +106,14 @@ module Gitlab
         def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
           labels = issue_labels(issue)
           labels |= new_labels
-          ee_test?(test) ? labels << "Enterprise Edition" : labels.delete("Enterprise Edition")
-          quarantine_job? ? labels << "quarantine" : labels.delete("quarantine")
+          ee_test?(test) ? labels << 'Enterprise Edition' : labels.delete('Enterprise Edition')
+
+          if test.quarantine?
+            labels << 'quarantine'
+            labels << "quarantine::#{test.quarantine_type}"
+          else
+            labels.delete_if { |label| label.include?('quarantine') }
+          end
 
           labels
         end
@@ -133,10 +139,6 @@ module Gitlab
           test.file =~ %r{features/ee/(api|browser_ui)}
         end
 
-        def quarantine_job?
-          Runtime::Env.ci_job_name&.include?('quarantine')
-        end
-
         def partial_file_path(path)
           path.match(/((api|browser_ui).*)/i)[1]
         end

data/lib/gitlab/qa/report/results_in_issues.rb

@@ -100,7 +100,6 @@ module Gitlab
 
         def failure_summary
           summary = [":x: ~\"#{pipeline}::failed\""]
-          summary << "~\"quarantine\"" if quarantine_job?
           summary << "in job `#{Runtime::Env.ci_job_name}` in #{Runtime::Env.ci_job_url}"
           summary.join(' ')
         end

data/lib/gitlab/qa/report/results_in_testcases.rb

@@ -30,6 +30,7 @@ module Gitlab
 
         def update_testcase(testcase, test)
           puts "Test case labels updated." if update_labels(testcase, test)
+          puts "Test case quarantine section updated." if update_quarantine_link(testcase, test)
         end
 
         private
@@ -61,7 +62,9 @@ module Gitlab
         end
 
         def new_issue_description(test)
-          "#{super}\n\n#{execution_graph_section(test)}"
+          quarantine_section = test.quarantine? && test.quarantine_issue ? "\n\n### Quarantine issue\n\n#{test.quarantine_issue}" : ''
+
+          "#{super}#{quarantine_section}\n\n#{execution_graph_section(test)}"
         end
 
         def execution_graph_section(test)
@@ -84,6 +87,24 @@ module Gitlab
         def issue_title_needs_updating?(testcase, test)
           super || !testcase.description.include?(execution_graph_section(test)) && !%w[canary production preprod release].include?(pipeline)
         end
+
+        def quarantine_link_needs_updating?(testcase, test)
+          if test.quarantine? && test.quarantine_issue
+            return false if testcase.description.include?(test.quarantine_issue)
+          else
+            return false unless testcase.description.include?('Quarantine issue')
+          end
+
+          true
+        end
+
+        def update_quarantine_link(testcase, test)
+          return unless quarantine_link_needs_updating?(testcase, test)
+
+          new_description = updated_description(testcase, test)
+
+          gitlab.edit_issue(iid: testcase.iid, options: { description: new_description })
+        end
       end
     end
   end

data/lib/gitlab/qa/report/test_result.rb

@@ -87,6 +87,14 @@ module Gitlab
             report['quarantine'].present?
           end
 
+          def quarantine_type
+            report['quarantine']['type'] if quarantine?
+          end
+
+          def quarantine_issue
+            report['quarantine']['issue'] if quarantine?
+          end
+
           private
 
           # rubocop:disable Metrics/AbcSize

data/lib/gitlab/qa/runtime/env.rb

@@ -149,12 +149,14 @@ module Gitlab
             value = env_var_name_if_defined(name) || send(attribute) # rubocop:disable GitlabSecurity/PublicSend
             vars[name] = value if value
           end
-          qa_variables = ENV.select { |k, _v| k.start_with?('QA_') }
+          qa_variables = ENV.each_with_object({}) do |(name, value), vars|
+            next unless name.start_with?('QA_')
 
-          {
-            **qa_variables,
-            **defined_variables
-          }
+            var_name = env_var_name_if_defined(name)
+            vars[name] = var_name if var_name
+          end
+
+          qa_variables.merge(defined_variables)
         end
 
         def debug?

data/lib/gitlab/qa/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module QA
-    VERSION = '7.24.0'
+    VERSION = '7.24.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 7.24.0
+  version: 7.24.3
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-01 00:00:00.000000000 Z
+date: 2022-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.1
+- !ruby/object:Gem::Dependency
+  name: gitlab-dangerfiles
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.10'
 - !ruby/object:Gem::Dependency
   name: gitlab-styles
   requirement: !ruby/object:Gem::Requirement
@@ -204,12 +218,14 @@ files:
 - ".dockerignore"
 - ".gitignore"
 - ".gitlab-ci.yml"
+- ".gitlab/ci/danger.gitlab-ci.yml"
 - ".gitlab/ci/rules.gitlab-ci.yml"
 - ".gitlab/merge_request_templates/Release.md"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - CONTRIBUTING.md
+- Dangerfile
 - Gemfile
 - LICENSE
 - README.md