gitlab-qa 6.20.0 → 6.21.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5417b9ef6d77d1792479873ba808d93da9fce65bed5ebc13203a1eaf8ac4e6d4
-  data.tar.gz: 024dcea062a32731702635adfac6abf282c42b4487fff269c0a469556230222a
+  metadata.gz: 5b108747b63e44e62bb63b71823e9612f8e32d652713bea427495a2139b61033
+  data.tar.gz: 75b2b9a6ea4ead609c242046b621d4360d192bb9bd8b4da50df8e90a62b38adf
 SHA512:
-  metadata.gz: 942c05b8dbdf34fd1e34509460b701e4454abf85c70ac677a78975ae27788f0f0a95afa2e43695e87c2dd818099c3ae28962ea64d890b7dc87ecf06ce78a5cba
-  data.tar.gz: d2f5083521dd998c7b482985dd3f5b4f1b15c79d6b80eae21c102861d11254bd6a95082b57cab825a8409a4eebe5caf562220e2d283e9b1c9936100d7b083775
+  metadata.gz: 83abd37be38747a36a6c96b23af631df6b878ccc70ac1d2a496acd04dfdef8eb99fd8afc148935269b86b6ba937037b58003f0f53fd979404df76343f15f3d1d
+  data.tar.gz: 996f450bafb008395fbbb6f46afc9d12f6a7ac07d4451a039c57959e983c6eb6b77230144be052e16064990105611af713e2e166f69aa2392eccb3b048e32ed7

data/docs/what_tests_can_be_run.md

@@ -167,6 +167,21 @@ And the following would run all Create API tests as well as UI tests:
 $ gitlab-qa Test::Instance::Image EE -- qa/specs/features/browser_ui/3_create qa/specs/features/api/3_create
 ```
 
+### Running tests for transient bugs
+
+A suite of tests have been written to test for [transient bugs](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#transient-bugs).
+Those tests are tagged `:transient` and therefore can be run via:
+
+```shell
+$ gitlab-qa Test::Instance::Image EE -- --tag transient
+```
+
+If you would like to run the transient bug tests against a specific GitLab instance such as your GDK, you can use the following command:
+
+```shell
+$ gitlab-qa Test::Instance::Any EE https://your.instance.gitlab -- --tag transient
+```
+
 ## Examples
 
 ### `Test::Instance::Image CE|EE|<full image address>`

data/lib/gitlab/qa/component/gitlab.rb

@@ -101,12 +101,17 @@ module Gitlab
         def prepare_gitlab_omnibus_config
           setup_disable_animations if disable_animations
           set_formless_login_token
+          setup_application_settings_cache_expiry
         end
 
         def setup_disable_animations
           @environment['GITLAB_OMNIBUS_CONFIG'] = "gitlab_rails['gitlab_disable_animations'] = true; #{@environment['GITLAB_OMNIBUS_CONFIG'] || ''}"
         end
 
+        def setup_application_settings_cache_expiry
+          @environment['GITLAB_OMNIBUS_CONFIG'] = "gitlab_rails['application_settings_cache_seconds'] = 0; #{@environment['GITLAB_OMNIBUS_CONFIG'] || ''}"
+        end
+
         def start # rubocop:disable Metrics/AbcSize
           ensure_configured!
 
@@ -138,7 +143,7 @@ module Gitlab
             puts line
             # TODO, workaround which allows to detach from the container
             #
-            Process.kill('INT', wait.pid) if line =~ /gitlab Reconfigured!/
+            break if line =~ /gitlab Reconfigured!/
           end
         end
 

data/lib/gitlab/qa/report/generate_test_session.rb

@@ -23,9 +23,11 @@ module Gitlab
           )
 
           # Workaround for https://gitlab.com/gitlab-org/gitlab/-/issues/295493
-          gitlab.create_issue_note(
-            iid: issue.iid,
-            note: "/relate #{Runtime::Env.qa_issue_url}")
+          unless Runtime::Env.qa_issue_url.to_s.empty?
+            gitlab.create_issue_note(
+              iid: issue.iid,
+              note: "/relate #{Runtime::Env.qa_issue_url}")
+          end
 
           File.write('REPORT_ISSUE_URL', issue.web_url)
         end
@@ -151,7 +153,7 @@ module Gitlab
           <<~MARKDOWN.chomp
             <details><summary>Passed tests:</summary>
 
-            #{generate_testcase_listing(passed_tests)}
+            #{generate_testcase_listing(passed_tests, passed: true)}
 
             </details>
           MARKDOWN
@@ -167,11 +169,11 @@ module Gitlab
           MARKDOWN
         end
 
-        def generate_testcase_listing(tests)
+        def generate_testcase_listing(tests, passed: false)
           body = tests.group_by(&:testcase).map do |testcase, tests_with_same_testcase|
             tests_with_same_testcase.sort_by!(&:name)
             [
-              generate_test_text(testcase, tests_with_same_testcase),
+              generate_test_text(testcase, tests_with_same_testcase, passed),
               generate_test_job(tests_with_same_testcase),
               generate_test_status(tests_with_same_testcase),
               generate_test_actions(tests_with_same_testcase)
@@ -185,10 +187,10 @@ module Gitlab
           MARKDOWN
         end
 
-        def generate_test_text(testcase, tests_with_same_testcase)
+        def generate_test_text(testcase, tests_with_same_testcase, passed)
           text = tests_with_same_testcase.map(&:name).uniq.join(', ')
 
-          if testcase
+          if testcase && !passed
             "[#{text}](#{testcase})"
           else
             text

data/lib/gitlab/qa/scenario/test/integration/ssh_tunnel.rb

@@ -26,8 +26,7 @@ module Gitlab
                       external_url '#{tunnel_gitlab.url}';
                       nginx['listen_port'] = 80;
                       nginx['listen_https'] = false;
-                      # documentation: https://docs.gitlab.com/omnibus/settings/database.html#seed-the-database-fresh-installs-only
-                      gitlab_rails['initial_root_password'] = '#{Runtime::Env.require_initial_password!}'
+                      gitlab_rails['initial_root_password'] = '#{Runtime::Env.require_initial_password!}';
 
                       registry_external_url '#{tunnel_registry.url}';
                       registry_nginx['listen_port'] = 80;

data/lib/gitlab/qa/scenario/test/sanity/version.rb

@@ -1,6 +1,7 @@
 require 'json'
 require 'net/http'
 require 'cgi'
+require 'time'
 
 module Gitlab
   module QA
@@ -8,14 +9,10 @@ module Gitlab
       module Test
         module Sanity
           # This test checks that the sha_version of a GitLab was authored in
-          # the window defined by `HOURS_AGO`.  We perform a single API call,
-          # so `COMMITS` needs to be a large enough value that we expect all
-          # the commits in the time window will fit.
+          # the window defined by the `weekday_hours` method.
+          # We perform a single API call to get the commit
           class Version < Scenario::Template
-            HOURS_AGO = 24
-            COMMITS = 10_000
-
-            def perform(release)
+            def perform(release = 'ce')
               version = Component::Gitlab.perform do |gitlab|
                 gitlab.release = release
                 gitlab.act do
@@ -25,9 +22,9 @@ module Gitlab
               end
 
               project = "gitlab-org/#{QA::Release.new(release).api_project_name}"
-              commit = recent_commits(project).find { |c| c['id'] == version }
+              commit = api_commit_detail(project, version)
 
-              if commit
+              if commit_within_hours?(commit['created_at'], weekday_hours(commit['created_at']))
                 puts "Found commit #{version} in recent history of #{project}"
               else
                 puts "Did not find #{version} in recent history of #{project}"
@@ -37,14 +34,28 @@ module Gitlab
 
             private
 
-            def recent_commits(project)
+            def weekday_hours(date_string)
+              case Date.parse(date_string).wday
+                # Sunday
+              when 0
+                48
+                # Monday
+              when 1
+                72
+              else
+                24
+              end
+            end
+
+            def commit_within_hours?(commit_time_string, hours)
+              Time.at(Time.parse(commit_time_string).utc).to_datetime > Time.at((Time.now - hours * 60 * 60).utc).to_datetime
+            end
+
+            def api_commit_detail(project, commit_id)
               api = 'https://gitlab.com/api/v4'
-              url = "#{api}/projects/#{CGI.escape(project)}/repository/commits"
-              since = (Time.now - HOURS_AGO * 60 * 60).strftime('%FT%T')
+              url = "#{api}/projects/#{CGI.escape(project)}/repository/commits/#{commit_id}"
 
-              uri = URI(url)
-              uri.query = URI.encode_www_form(since: since, per_page: COMMITS)
-              JSON.parse(Net::HTTP.get(uri))
+              JSON.parse(Net::HTTP.get(URI(url)))
             end
           end
         end

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '6.20.0'.freeze
+    VERSION = '6.21.3'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 6.20.0
+  version: 6.21.3
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-20 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -208,7 +208,6 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.3.1
-before_install: gem install bundler -v 1.12.5