gitlab-qa 6.19.0 → 6.21.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 981a6afe2aef7aa49d6ea19d627947fa58f24ad84d4443268c582d16ff60a15c
-  data.tar.gz: 2ff55255b8cb84ff2fe4368846da3f1818a069c389afc22e937d49eb2034bc35
+  metadata.gz: c989cb7d8d8a3c9eb94835b3a7c274a4632827f3a32998b8f09a4c450a171917
+  data.tar.gz: 130448315ffff85c9be03face027934d3fbd35f1f2d7039c8188622bed464acc
 SHA512:
-  metadata.gz: 115a7e9805ff2723ffe4d0f41b92315778fc5846481542eafff3f321e0ef23750ef8abeaf620dfcfd8effab56a159b3ac0bf1bed9e07771dc4ea4a3b48f29c2f
-  data.tar.gz: 985e57c53830587cf92d4a9087cd9537382a4247c479b4aec23227d2f703bdf02e58013c60c6d2096e92942af000d5d12855d54a43553ff76c3fb780e4c48dc5
+  metadata.gz: 4d1471f8093cb11cb9a47ce450b46ea2bf358365a89e3bb4ec0831f10f489a4034b36eea079c6e8ea05876834e039c8ce429298340e2934974932eb5ee483b97
+  data.tar.gz: 06b4bd542227007156a4bd7f16dc5f263ae0054ad985348b256faa9e4412943995351a5ffb4dda78c0b650a9e30579b1b7efbc0cbcc5a36c1fe645daa7d0a091

data/.gitlab-ci.yml

@@ -1023,7 +1023,7 @@ relate_test_failures:
       when: always
   variables:
     QA_FAILURES_REPORTING_PROJECT: "gitlab-org/gitlab"
-    QA_FAILURES_MAX_DIFF_RATIO: "0.05"
+    QA_FAILURES_MAX_DIFF_RATIO: "0.15"
     # The --dry-run can be set to modify the behavior of `exe/gitlab-qa-report --relate-failure-issue` without releasing a new gem version.
     QA_FAILURES_REPORTER_OPTIONS: ""
   script:

data/docs/what_tests_can_be_run.md

@@ -84,6 +84,8 @@ All environment variables used by GitLab QA should be defined in [`lib/gitlab/qa
 | `CACHE_NAMESPACE_NAME` | `true` | Cache namespace name for groups. | No|
 | `DEPLOY_VERSION` |- | The version of GitLab being tested against. | No|
 | `GITLAB_QA_USER_AGENT` |- | The browser user-agent to use instead of the default Chrome user-agent. | No|
+| `GEO_FAILOVER` | `false` | Set to `true` when a Geo secondary site has been promoted to a Geo primary site. | No|
+
 
 ## [Supported Remote Grid environment variables](./running_against_remote_grid.md)
 
@@ -165,6 +167,21 @@ And the following would run all Create API tests as well as UI tests:
 $ gitlab-qa Test::Instance::Image EE -- qa/specs/features/browser_ui/3_create qa/specs/features/api/3_create
 ```
 
+### Running tests for transient bugs
+
+A suite of tests have been written to test for [transient bugs](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#transient-bugs).
+Those tests are tagged `:transient` and therefore can be run via:
+
+```shell
+$ gitlab-qa Test::Instance::Image EE -- --tag transient
+```
+
+If you would like to run the transient bug tests against a specific GitLab instance such as your GDK, you can use the following command:
+
+```shell
+$ gitlab-qa Test::Instance::Any EE https://your.instance.gitlab -- --tag transient
+```
+
 ## Examples
 
 ### `Test::Instance::Image CE|EE|<full image address>`

data/lib/gitlab/qa/component/gitlab.rb

@@ -101,12 +101,17 @@ module Gitlab
         def prepare_gitlab_omnibus_config
           setup_disable_animations if disable_animations
           set_formless_login_token
+          setup_application_settings_cache_expiry
         end
 
         def setup_disable_animations
           @environment['GITLAB_OMNIBUS_CONFIG'] = "gitlab_rails['gitlab_disable_animations'] = true; #{@environment['GITLAB_OMNIBUS_CONFIG'] || ''}"
         end
 
+        def setup_application_settings_cache_expiry
+          @environment['GITLAB_OMNIBUS_CONFIG'] = "gitlab_rails['application_settings_cache_seconds'] = 0; #{@environment['GITLAB_OMNIBUS_CONFIG'] || ''}"
+        end
+
         def start # rubocop:disable Metrics/AbcSize
           ensure_configured!
 
@@ -138,7 +143,7 @@ module Gitlab
             puts line
             # TODO, workaround which allows to detach from the container
             #
-            Process.kill('INT', wait.pid) if line =~ /gitlab Reconfigured!/
+            break if line =~ /gitlab Reconfigured!/
           end
         end
 

data/lib/gitlab/qa/report/generate_test_session.rb

@@ -23,9 +23,11 @@ module Gitlab
           )
 
           # Workaround for https://gitlab.com/gitlab-org/gitlab/-/issues/295493
-          gitlab.create_issue_note(
-            iid: issue.iid,
-            note: "/relate #{Runtime::Env.qa_issue_url}")
+          unless Runtime::Env.qa_issue_url.to_s.empty?
+            gitlab.create_issue_note(
+              iid: issue.iid,
+              note: "/relate #{Runtime::Env.qa_issue_url}")
+          end
 
           File.write('REPORT_ISSUE_URL', issue.web_url)
         end

data/lib/gitlab/qa/runtime/env.rb

@@ -87,7 +87,8 @@ module Gitlab
           'JIRA_ADMIN_PASSWORD' => :jira_admin_password,
           'CACHE_NAMESPACE_NAME' => :cache_namespace_name,
           'DEPLOY_VERSION' => :deploy_version,
-          'GITLAB_QA_USER_AGENT' => :gitlab_qa_user_agent
+          'GITLAB_QA_USER_AGENT' => :gitlab_qa_user_agent,
+          'GEO_FAILOVER' => :geo_failover
         }.freeze
 
         ENV_VARIABLES.each do |env_name, method_name|
@@ -283,6 +284,10 @@ module Gitlab
           enabled?(ENV['QA_SKIP_PULL'], default: false)
         end
 
+        def geo_failover?
+          enabled?(ENV['GEO_FAILOVER'], default: false)
+        end
+
         private
 
         def enabled?(value, default: true)

data/lib/gitlab/qa/scenario/test/instance/staging.rb

@@ -4,12 +4,20 @@ module Gitlab
       module Test
         module Instance
           ##
-          # Run test suite against staging.gitlab.com
+          # Run test suite against staging.gitlab.com (or geo.staging.gitlab.com during failover)
           #
           class Staging < DeploymentBase
             def deployment_component
               Component::Staging
             end
+
+            def non_rspec_args
+              if Runtime::Env.geo_failover?
+                [deployment_component::GEO_SECONDARY_ADDRESS]
+              else
+                [deployment_component::ADDRESS]
+              end
+            end
           end
         end
       end

data/lib/gitlab/qa/scenario/test/integration/ssh_tunnel.rb

@@ -26,8 +26,7 @@ module Gitlab
                       external_url '#{tunnel_gitlab.url}';
                       nginx['listen_port'] = 80;
                       nginx['listen_https'] = false;
-                      # documentation: https://docs.gitlab.com/omnibus/settings/database.html#seed-the-database-fresh-installs-only
-                      gitlab_rails['initial_root_password'] = '#{Runtime::Env.require_initial_password!}'
+                      gitlab_rails['initial_root_password'] = '#{Runtime::Env.require_initial_password!}';
 
                       registry_external_url '#{tunnel_registry.url}';
                       registry_nginx['listen_port'] = 80;

data/lib/gitlab/qa/scenario/test/sanity/version.rb

@@ -1,6 +1,7 @@
 require 'json'
 require 'net/http'
 require 'cgi'
+require 'time'
 
 module Gitlab
   module QA
@@ -8,14 +9,10 @@ module Gitlab
       module Test
         module Sanity
           # This test checks that the sha_version of a GitLab was authored in
-          # the window defined by `HOURS_AGO`.  We perform a single API call,
-          # so `COMMITS` needs to be a large enough value that we expect all
-          # the commits in the time window will fit.
+          # the window defined by the `weekday_hours` method.
+          # We perform a single API call to get the commit
           class Version < Scenario::Template
-            HOURS_AGO = 24
-            COMMITS = 10_000
-
-            def perform(release)
+            def perform(release = 'ce')
               version = Component::Gitlab.perform do |gitlab|
                 gitlab.release = release
                 gitlab.act do
@@ -25,9 +22,9 @@ module Gitlab
               end
 
               project = "gitlab-org/#{QA::Release.new(release).api_project_name}"
-              commit = recent_commits(project).find { |c| c['id'] == version }
+              commit = api_commit_detail(project, version)
 
-              if commit
+              if commit_within_hours?(commit['created_at'], weekday_hours(commit['created_at']))
                 puts "Found commit #{version} in recent history of #{project}"
               else
                 puts "Did not find #{version} in recent history of #{project}"
@@ -37,14 +34,28 @@ module Gitlab
 
             private
 
-            def recent_commits(project)
+            def weekday_hours(date_string)
+              case Date.parse(date_string).wday
+                # Sunday
+              when 0
+                48
+                # Monday
+              when 1
+                72
+              else
+                24
+              end
+            end
+
+            def commit_within_hours?(commit_time_string, hours)
+              Time.at(Time.parse(commit_time_string).utc).to_datetime > Time.at((Time.now - hours * 60 * 60).utc).to_datetime
+            end
+
+            def api_commit_detail(project, commit_id)
               api = 'https://gitlab.com/api/v4'
-              url = "#{api}/projects/#{CGI.escape(project)}/repository/commits"
-              since = (Time.now - HOURS_AGO * 60 * 60).strftime('%FT%T')
+              url = "#{api}/projects/#{CGI.escape(project)}/repository/commits/#{commit_id}"
 
-              uri = URI(url)
-              uri.query = URI.encode_www_form(since: since, per_page: COMMITS)
-              JSON.parse(Net::HTTP.get(uri))
+              JSON.parse(Net::HTTP.get(URI(url)))
             end
           end
         end

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '6.19.0'.freeze
+    VERSION = '6.21.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 6.19.0
+  version: 6.21.2
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-14 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -208,7 +208,6 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.3.1
-before_install: gem install bundler -v 1.12.5