gitlab-qa 6.12.0 → 6.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7db5ca406c7143f6b4b8ac2d5061080f52157dbe77f23459fdf15919cc24209
-  data.tar.gz: b0dca304397f7c373ca94b41936f8d04db818b797dc9a09e05e31accfd8a9cfd
+  metadata.gz: '0692b909c3bf06d12d5f0846dc3296b93755d0c58c5969a71773e9664b298a8c'
+  data.tar.gz: 3aac312bb7b6dd2244d92b9bbf9ce1ecf561c65caae723abca625b155c00cfa4
 SHA512:
-  metadata.gz: 25678e888d7a338ef9f54269927e16ab6d5f60bc4b37175185bda64174689d9aecf40ac35c7d31be15e6fb1305527604f4667f09aa6c89f42ba4e02c7187a68d
-  data.tar.gz: ff1c2808b0030677ba8420444e4cb303b0d58d6751511bef90a8bcbea98df6a98e1efea83945d7b6488f076eb8f978519198b4938dc9b99503bd97c0d2b9ea57
+  metadata.gz: 05c3a6b9ad1eec8d6adf2892ae3b90568bbfebc7f7def626126ae2b14da9be902b71edd8d45a7c98a3cb89b596fa6cee6b352da159f7e3ae1ca2daf8b37dc176
+  data.tar.gz: 4554af9b7849516651be2e5f32f4fd5d57690b4af2787292d4b18e6a8838fad92201a9d101edcbc9c2391327322fdaca96a37393fe6ea1a3111f734be7934d2f

data/lib/gitlab/qa/report/generate_test_session.rb

@@ -6,6 +6,7 @@ module Gitlab
       class GenerateTestSession < ReportAsIssue
         private
 
+        # rubocop:disable Metrics/AbcSize
         def run!
           puts "Generating test results in `#{files.join(',')}` as issues in project `#{project}` via the API at `#{Runtime::Env.gitlab_api_base}`."
 
@@ -18,11 +19,12 @@ module Gitlab
           issue = gitlab.create_issue(
             title: "Test session report | #{Runtime::Env.deploy_environment}",
             description: generate_description(tests),
-            labels: ['Quality', 'QA', 'triage report']
+            labels: ['Quality', 'QA', 'triage report', deploy_environment_label]
           )
 
           File.write('REPORT_ISSUE_URL', issue.web_url)
         end
+        # rubocop:enable Metrics/AbcSize
 
         def generate_description(tests)
           <<~MARKDOWN
@@ -32,6 +34,8 @@ module Gitlab
           * Pipeline: [#{Runtime::Env.ci_pipeline_id}](#{Runtime::Env.ci_pipeline_url})
           #{generate_summary(tests: tests)}
 
+          #{generate_failed_jobs_listing}
+
           #{generate_stages_listing(tests)}
 
           ## Release QA issue
@@ -55,6 +59,27 @@ module Gitlab
           MARKDOWN
         end
 
+        def generate_failed_jobs_listing
+          gitlab.handle_gitlab_client_exceptions do
+            failed_jobs = Gitlab.pipeline_jobs(
+              Runtime::Env.ci_project_id,
+              Runtime::Env.ci_pipeline_id,
+              scope: 'failed')
+
+            listings = failed_jobs.map do |job|
+              allowed_to_fail = ' (allowed to fail)' if job.allow_failure
+
+              "* [#{job.name}](#{job.web_url})#{allowed_to_fail}"
+            end.join("\n")
+
+            <<~MARKDOWN.chomp if failed_jobs.any?
+            ## Failed jobs
+
+            #{listings}
+            MARKDOWN
+          end
+        end
+
         def generate_stages_listing(tests)
           generate_tests_by_stage(tests).map do |stage, tests_for_stage|
             tests_by_status = tests_for_stage.group_by(&:status)
@@ -185,7 +210,7 @@ module Gitlab
               tests_with_same_testcase.select(&:failure_issue)
 
             if tests_having_failure_issue.any?
-              items = tests_having_failure_issue.map do |test|
+              items = tests_having_failure_issue.uniq(&:failure_issue).map do |test|
                 "<li>[ ] [failure issue](#{test.failure_issue})</li>"
               end.join(' ')
 

data/lib/gitlab/qa/report/relate_failure_issue.rb

@@ -88,7 +88,12 @@ module Gitlab
             diff_ratio = (distance.to_f / first_test_failure_stacktrace.size).round(3)
             if diff_ratio <= max_diff_ratio
               puts "  => [DEBUG] Issue #{issue} has an acceptable diff ratio of #{(diff_ratio * 100).round(2)}%."
-              memo[issue] = diff_ratio
+              # The `Gitlab::ObjectifiedHash` class overrides `#hash` which is used by `Hash#[]=` to compute the hash key.
+              # This leads to a `TypeError Exception: no implicit conversion of Hash into Integer` error, so we convert the object to a hash before using it as a Hash key.
+              # See:
+              # - https://gitlab.com/gitlab-org/gitlab-qa/-/merge_requests/587#note_453336995
+              # - https://github.com/NARKOZ/gitlab/commit/cbdbd1e32623f018a8fae39932a8e3bc4d929abb?_pjax=%23js-repo-pjax-container#r44484494
+              memo[issue.to_h] = diff_ratio
             else
               puts "  => [DEBUG] Found issue #{issue.web_url} but stacktraces are too different (#{(diff_ratio * 100).round(2)}%)."
             end
@@ -116,6 +121,9 @@ module Gitlab
             raise(MultipleIssuesFound, %(Too many issues found for test '#{test.name}' (`#{test.file}`)!))
           end
 
+          # Re-instantiate a `Gitlab::ObjectifiedHash` object after having converted it to a hash in #find_relevant_failure_issues above.
+          best_matching_issue = Gitlab::ObjectifiedHash.new(best_matching_issue)
+
           test.failure_issue ||= best_matching_issue.web_url
 
           [best_matching_issue, smaller_diff_ratio]
@@ -129,23 +137,6 @@ module Gitlab
           ].join("\n\n")
         end
 
-        def deploy_environment_label
-          environment = Runtime::Env.deploy_environment
-
-          case environment
-          when 'production'
-            'found:gitlab.com'
-          when 'canary', 'staging'
-            "found:#{environment}.gitlab.com"
-          when 'preprod'
-            'found:pre.gitlab.com'
-          when 'staging-orchestrated', 'nightly', 'master'
-            "found:#{environment}"
-          else
-            raise "No `found:*` label for the `#{environment}` environment!"
-          end
-        end
-
         def new_issue_labels(test)
           NEW_ISSUE_LABELS + up_to_date_labels(test: test)
         end

data/lib/gitlab/qa/report/report_as_issue.rb

@@ -104,6 +104,23 @@ module Gitlab
           labels
         end
 
+        def deploy_environment_label
+          environment = Runtime::Env.deploy_environment
+
+          case environment
+          when 'production'
+            'found:gitlab.com'
+          when 'canary', 'staging'
+            "found:#{environment}.gitlab.com"
+          when 'preprod'
+            'found:pre.gitlab.com'
+          when 'staging-orchestrated', 'nightly', 'master'
+            "found:#{environment}"
+          else
+            raise "No `found:*` label for the `#{environment}` environment!"
+          end
+        end
+
         def ee_test?(test)
           test.file =~ %r{features/ee/(api|browser_ui)}
         end

data/lib/gitlab/qa/runtime/env.rb

@@ -136,8 +136,8 @@ module Gitlab
           ENV['CI_PIPELINE_ID']
         end
 
-        def ci_project_name
-          ENV['CI_PROJECT_NAME']
+        def ci_project_id
+          ENV['CI_PROJECT_ID']
         end
 
         def ci_commit_ref_name

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '6.12.0'.freeze
+    VERSION = '6.13.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 6.12.0
+  version: 6.13.0
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-11-24 00:00:00.000000000 Z
+date: 2020-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control