gitlab-qa 5.13.6 → 5.13.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 742350ecaafcf21ca9ff0fc50547cbb6cd28b2cf7a3fc090f5cb6ab542da3154
-  data.tar.gz: e65a23e2620961c5751eca131cf0dfa4b639f2915488b888975e6a0313c8baee
+  metadata.gz: 80567a3f14ce823c574bf448dd57339aa9ac95d39514b2c18ec4f8d9094c5e95
+  data.tar.gz: 4aa694b95e7bc667a58d63d7ac4c2606dbbd3d9a5819cd49e160dfae60b919cc
 SHA512:
-  metadata.gz: e42ac20b6a9dd4881c50d5018956241543395dae6c2aac148c1db87e77daa0ac677950a876ffa730e9d8f991c3850640775213ca6a0c8ebefa4a45dd2ab811c2
-  data.tar.gz: b7f993786ae4ac8fdc7b15d4d936cad11066e2f92731b30f696e8615a9454657f40d67e3cccb9074b6464755ab2d37a2e74569e92b66476328ee8215ea4543e3
+  metadata.gz: 1a9f28e68a1717e93f7df4dda6de613185b3175417092517d56338d35af67679eed4a8d074e6ee5b6efd1f9d425b761aec3d9a8803d9d993341a9a28b1abde4c
+  data.tar.gz: da4ca897e44bd8c398c42f431370b73bb482fdb032b059053b759eb0c97646500057961b8a378a789b39cf5ab093e00a4a8577c36fbb6ef9353ce9116b24f98a

data/docs/run_qa_against_gdk.md

@@ -42,6 +42,9 @@ make a few changes to your `gdk/gitlab/config/gitlab.yml` file.
   $ exe/gitlab-qa Test::Instance::Any gitlab/gitlab-ce:your-custom-tag http://192.168.0.12:3000 -- qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb
   ```
   
+**Note:** The hostname of the URL provided to `gitlab-qa` must match the hostname configured for GDK.
+If they do not match, a test will be signed out when it visits a page directly because the hostname of the URL visited will be different from the hostname that was used when signing in.
+  
 ### Running EE tests
 
 When running EE tests you'll need to have a license available. GitLab engineers can [request a license](https://about.gitlab.com/handbook/developer-onboarding/#working-on-gitlab-ee).

data/docs/what_tests_can_be_run.md

@@ -57,19 +57,19 @@ For more details on the internals, please read the
 | `QA_ARTIFACTS_DIR` |`/tmp/gitlab-qa`| Path to a directory where artifacts (logs and screenshots) for failing tests will be saved. | No|
 | `DOCKER_HOST` |`http://localhost`| Docker host to run tests against. | No|
 | `CHROME_HEADLESS` |-  | When running locally, set to `false` to allow Chrome tests to be visible - watch your tests being run. | No|
-| `QA_ADDITIONAL_REPOSITORY_STORAGE` |-  | The name of additional, non-default storage to be used with tests tagged `repository_storage`, run via the `Test::Instance::RepositoryStorage` scenario. | No|
-| `QA_PRAEFECT_REPOSITORY_STORAGE` |-  | The name of repository storage using Praefect. | No|
+| `QA_ADDITIONAL_REPOSITORY_STORAGE` |-  | The name of additional, non-default storage to be used with tests tagged `repository_storage`, run via the `Test::Instance::RepositoryStorage` scenario.  Note: Admin access is required to change repository storage. | No|
+| `QA_PRAEFECT_REPOSITORY_STORAGE` |-  | The name of repository storage using Praefect. Note: Admin access is required to change repository storage. | No|
 | `QA_COOKIES` |-  | Optionally set to "cookie1=value;cookie2=value" in order to add a cookie to every request. This can be used to set the canary cookie by setting it to "gitlab_canary=true". | No|
 | `QA_DEBUG` |-  | Set to `true` to verbosely log page object actions. Note: if enabled be aware that sensitive data might be logged. If an input element has a QA selector with `password` in the name, data entered into the input element will be masked. If the element doesn't have `password` in its name it won't be masked. | No|
 | `QA_LOG_PATH` |-  | Path to output debug logging to. If not set logging will be output to STDOUT. | No|
-| `QA_CAN_TEST_GIT_PROTOCOL_V2` |-  | Set to `false` to skip tests that require Git protocol v2 if your environment doesn't support it. | No|
-| `QA_CAN_TEST_ADMIN_FEATURES` |-  | Set to `false` to skip tests that require admin access. | No|
-| `QA_CAN_TEST_PRAEFECT` |-  | Set to `false` to skip tests that require Praefect to be running. | No|
+| `QA_CAN_TEST_GIT_PROTOCOL_V2` | `true` | Set to `false` to skip tests that require Git protocol v2 if your environment doesn't support it. | No|
+| `QA_CAN_TEST_ADMIN_FEATURES` | `true` | Set to `false` to skip tests that require admin access. | No|
+| `QA_CAN_TEST_PRAEFECT` | `true` | Set to `false` to skip tests that require Praefect to be running. | No|
 | `QA_DISABLE_RSPEC_RETRY` |-  | Set to `true` to turn off retrying tests on failure. | No|
 | `QA_SIMULATE_SLOW_CONNECTION` |-  | Set to `true` to configure Chrome's network settings to simulate a slow connection. | No|
 | `QA_SLOW_CONNECTION_LATENCY_MS` | `2000` | The additional latency (in ms) of the simulated slow connection. | No|
 | `QA_SLOW_CONNECTION_THROUGHPUT_KBPS` | `32` | The maximum throughput (in kbps) of the simulated slow connection. | No|
-| `QA_SKIP_PULL` |-  | Set to `true` to skip pulling docker images (e.g., to use one you built locally). | No|
+| `QA_SKIP_PULL` | `false` | Set to `true` to skip pulling docker images (e.g., to use one you built locally). | No|
 | `GITHUB_USERNAME` |-  | Username for authenticating with GitHub. | No|
 | `GITHUB_PASSWORD` |-  | Password for authenticating with GitHub. | No|
 | `GITLAB_QA_LOOP_RUNNER_MINUTES` | `1` | Minutes to run and repeat a spec while using the '--loop' option; default value is 1 minute. | No|

data/lib/gitlab/qa.rb

@@ -6,6 +6,7 @@ module Gitlab
 
     module Runtime
       autoload :Env, 'gitlab/qa/runtime/env'
+      autoload :Scenario, 'gitlab/qa/runtime/scenario'
       autoload :TokenFinder, 'gitlab/qa/runtime/token_finder'
     end
 
@@ -63,6 +64,7 @@ module Gitlab
     end
 
     module Component
+      autoload :Base, 'gitlab/qa/component/base'
       autoload :Gitlab, 'gitlab/qa/component/gitlab'
       autoload :InternetTunnel, 'gitlab/qa/component/internet_tunnel'
       autoload :LDAP, 'gitlab/qa/component/ldap'

data/lib/gitlab/qa/component/base.rb

@@ -0,0 +1,131 @@
+module Gitlab
+  module QA
+    module Component
+      class Base
+        include Scenario::Actable
+
+        attr_reader :docker
+        attr_accessor :volumes, :network, :environment
+        attr_writer :name, :exec_commands
+
+        def initialize
+          @docker = Docker::Engine.new
+          @environment = {}
+          @volumes = {}
+          @network_aliases = []
+
+          self.exec_commands = []
+        end
+
+        def add_network_alias(name)
+          @network_aliases.push(name)
+        end
+
+        def name
+          raise NotImplementedError, "#{self.class.name} must specify a default name"
+        end
+
+        def hostname
+          "#{name}.#{network}"
+        end
+
+        def image
+          return self.class.const_get('DOCKER_IMAGE') if self.class.const_defined?('DOCKER_IMAGE')
+
+          raise NotImplementedError, "#{self.class.name} must specify a docker image as DOCKER_IMAGE"
+        end
+
+        def tag
+          return self.class.const_get('DOCKER_IMAGE_TAG') if self.class.const_defined?('DOCKER_IMAGE_TAG')
+
+          raise NotImplementedError, "#{self.class.name} must specify a docker image tag as DOCKER_IMAGE_TAG"
+        end
+
+        def instance
+          prepare
+          start
+          reconfigure
+          wait_until_ready
+          process_exec_commands
+
+          yield self if block_given?
+        ensure
+          teardown
+        end
+
+        alias_method :launch_and_teardown_instance, :instance
+
+        def prepare
+          prepare_docker_image
+          prepare_network
+        end
+
+        def prepare_docker_image
+          return if Runtime::Env.skip_pull?
+
+          pull
+        end
+
+        def prepare_network
+          return if docker.network_exists?(network)
+
+          docker.network_create(network)
+        end
+
+        def start # rubocop:disable Metrics/AbcSize
+          docker.run(image, tag) do |command|
+            command << "-d"
+            command << "--name #{name}"
+            command << "--net #{network}"
+            command << "--hostname #{hostname}"
+
+            @volumes.to_h.each do |to, from|
+              command.volume(to, from, 'Z')
+            end
+
+            command.volume(File.join(Runtime::Env.host_artifacts_dir, name, 'logs'), '/var/log/gitlab', 'Z')
+
+            @environment.to_h.each do |key, value|
+              command.env(key, value)
+            end
+
+            @network_aliases.to_a.each do |network_alias|
+              command << "--network-alias #{network_alias}"
+            end
+          end
+        end
+
+        def restart
+          assert_name!
+
+          docker.restart(name)
+        end
+
+        def teardown
+          assert_name!
+
+          return unless docker.running?(name)
+
+          docker.stop(name)
+          docker.remove(name)
+        end
+
+        def pull
+          docker.pull(image, tag)
+        end
+
+        def process_exec_commands
+          exec_commands.each { |command| docker.exec(name, command) }
+        end
+
+        private
+
+        attr_reader :exec_commands, :wait_until_ready, :reconfigure
+
+        def assert_name!
+          raise 'Invalid instance name!' unless name
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/qa/component/elasticsearch.rb

@@ -1,41 +1,19 @@
 module Gitlab
   module QA
     module Component
-      class Elasticsearch
-        include Scenario::Actable
-
-        ELASTIC_IMAGE = 'docker.elastic.co/elasticsearch/elasticsearch'.freeze
-
-        attr_reader :docker
-        attr_accessor :environment, :network
-        attr_writer :name
-
-        def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-        end
+      class Elasticsearch < Base
+        DOCKER_IMAGE = 'docker.elastic.co/elasticsearch/elasticsearch'.freeze
 
         def name
           @name ||= "elastic68"
         end
 
-        def instance
-          prepare
-          start
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          @docker.pull(ELASTIC_IMAGE, Runtime::Env.elastic_version)
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
+        def tag
+          Runtime::Env.elastic_version
         end
 
         def start
-          @docker.run(ELASTIC_IMAGE, Runtime::Env.elastic_version) do |command|
+          @docker.run(image, tag) do |command|
             command << "-d"
             command << "--name #{name}"
             command << "--net #{network}"
@@ -45,11 +23,6 @@ module Gitlab
             command.env("discovery.type", "single-node")
           end
         end
-
-        def teardown
-          @docker.stop(name)
-          @docker.remove(name)
-        end
       end
     end
   end

data/lib/gitlab/qa/component/gitlab.rb

@@ -7,13 +7,12 @@ require 'openssl'
 module Gitlab
   module QA
     module Component
-      class Gitlab
+      class Gitlab < Base
         extend Forwardable
-        include Scenario::Actable
 
-        attr_reader :release, :docker
-        attr_accessor :volumes, :network, :environment, :tls, :disable_animations
-        attr_writer :name, :relative_path, :exec_commands, :skip_check
+        attr_reader :release
+        attr_accessor :tls, :disable_animations, :skip_availability_check
+        attr_writer :name, :relative_path
 
         def_delegators :release, :tag, :image, :edition
 
@@ -21,17 +20,14 @@ module Gitlab
         SSL_PATH = '/etc/gitlab/ssl'.freeze
 
         def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-          @volumes = {}
-          @network_aliases = []
+          super
+
           @disable_animations = true
-          @skip_check = false
+          @skip_availability_check = false
 
           @volumes[CERTIFICATES_PATH] = SSL_PATH
 
           self.release = 'CE'
-          self.exec_commands = []
         end
 
         def omnibus_config=(config)
@@ -48,10 +44,6 @@ module Gitlab
           @environment['ELASTIC_URL'] = url
         end
 
-        def add_network_alias(name)
-          @network_aliases.push(name)
-        end
-
         def release=(release)
           @release = QA::Release.new(release)
         end
@@ -72,10 +64,6 @@ module Gitlab
           tls ? '443' : '80'
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def relative_path
           @relative_path ||= ''
         end
@@ -84,24 +72,16 @@ module Gitlab
           Runtime::Env.accept_insecure_certs = 'true'
         end
 
-        def instance
-          prepare
-          start
-          reconfigure
-          wait unless @skip_check
-          process_exec_commands
+        def prepare
+          prepare_gitlab_omnibus_config
 
-          yield self if block_given?
-        ensure
-          teardown
+          super
         end
 
-        alias_method :launch_and_teardown_instance, :instance
+        def pull
+          docker.login(**release.login_params) if release.login_params
 
-        def prepare
-          prepare_gitlab_omnibus_config
-          prepare_docker_image
-          prepare_network
+          super
         end
 
         def prepare_gitlab_omnibus_config
@@ -109,18 +89,6 @@ module Gitlab
           set_formless_login_token
         end
 
-        def prepare_docker_image
-          return if Runtime::Env.skip_pull?
-
-          @docker.pull(image, tag)
-        end
-
-        def prepare_network
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
-        end
-
         def setup_disable_animations
           @environment['GITLAB_OMNIBUS_CONFIG'] = "gitlab_rails['gitlab_disable_animations'] = true; #{@environment['GITLAB_OMNIBUS_CONFIG'] || ''}"
         end
@@ -128,28 +96,6 @@ module Gitlab
         def start # rubocop:disable Metrics/AbcSize
           ensure_configured!
 
-          if release.dev_gitlab_org?
-            Docker::Command.execute(
-              [
-                'login',
-                '--username gitlab-qa-bot',
-                %(--password "#{Runtime::Env.dev_access_token_variable}"),
-                QA::Release::DEV_REGISTRY
-              ]
-            )
-          elsif release.omnibus_mirror?
-            bot_token = ENV['GITLAB_BOT_MULTI_PROJECT_PIPELINE_POLLING_TOKEN']
-
-            Docker::Command.execute(
-              [
-                'login',
-                '--username gitlab-bot',
-                %(--password "#{bot_token}"),
-                QA::Release::COM_REGISTRY
-              ]
-            )
-          end
-
           docker.run(image, tag) do |command|
             command << "-d -p #{port}"
             command << "--name #{name}"
@@ -181,18 +127,9 @@ module Gitlab
           end
         end
 
-        def restart
-          @docker.restart(name)
-        end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
         def wait
+          return if skip_availability_check
+
           if Availability.new(name, relative_path: relative_path, scheme: scheme, protocol_port: port.to_i).check(180)
             sleep 12 # TODO, handle that better
             puts ' -> GitLab is available.'
@@ -201,10 +138,6 @@ module Gitlab
           end
         end
 
-        def pull
-          @docker.pull(@release.image, @release.tag)
-        end
-
         def sha_version
           json = @docker.read_file(
             @release.image, @release.tag,
@@ -215,14 +148,8 @@ module Gitlab
           manifest['software']['gitlab-rails']['locked_version']
         end
 
-        def process_exec_commands
-          exec_commands.each { |command| @docker.exec(name, command) }
-        end
-
         private
 
-        attr_reader :exec_commands
-
         def ensure_configured!
           raise 'Please configure an instance first!' unless [name, release, network].all?
         end

data/lib/gitlab/qa/component/internet_tunnel.rb

@@ -3,18 +3,14 @@ require 'tempfile'
 module Gitlab
   module QA
     module Component
-      class InternetTunnel
-        include Scenario::Actable
-
+      class InternetTunnel < Base
         DOCKER_IMAGE = 'gitlab/ssh-tunnel'.freeze
         DOCKER_IMAGE_TAG = '1.0.0'.freeze
 
-        attr_writer :gitlab_hostname, :name
-        attr_accessor :network
+        attr_writer :gitlab_hostname
 
         def initialize
-          @docker = Docker::Engine.new
-          @volumes = {}
+          super
 
           key_dir = ENV['CI_PROJECT_DIR'] || Dir.tmpdir
           @ssh_key = Tempfile.new('tunnel-ssh-private-key', key_dir)
@@ -27,14 +23,9 @@ module Gitlab
         end
 
         def instance
-          raise ArgumentError, 'Please provide a block!' unless block_given?
-
-          prepare
-          start
+          raise 'Please provide a block!' unless block_given?
 
-          yield self
-        ensure
-          teardown
+          super
         end
 
         def url
@@ -47,14 +38,6 @@ module Gitlab
           @name ||= "ssh-tunnel-#{SecureRandom.hex(4)}"
         end
 
-        def prepare
-          @docker.pull(DOCKER_IMAGE, DOCKER_IMAGE_TAG)
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
-        end
-
         def tunnel_server_hostname
           ENV.fetch("TUNNEL_SERVER_HOSTNAME")
         end
@@ -77,15 +60,9 @@ module Gitlab
           end
         end
 
-        def restart
-          @docker.restart(name)
-        end
-
         def teardown
-          raise 'Invalid instance name!' unless name
+          super
 
-          @docker.stop(name)
-          @docker.remove(name)
           @ssh_key.unlink
         end
       end

data/lib/gitlab/qa/component/jira.rb

@@ -1,50 +1,22 @@
 module Gitlab
   module QA
     module Component
-      class Jira
-        include Scenario::Actable
-
-        JIRA_IMAGE = 'registry.gitlab.com/gitlab-org/gitlab-qa/jira-gitlab'.freeze
-        JIRA_IMAGE_TAG = '8.8-project-and-issue'.freeze
-
-        attr_reader :docker
-        attr_accessor :environment, :network
-        attr_writer :name
-
-        def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-        end
+      class Jira < Base
+        DOCKER_IMAGE = 'registry.gitlab.com/gitlab-org/gitlab-qa/jira-gitlab'.freeze
+        DOCKER_IMAGE_TAG = '8.8-project-and-issue'.freeze
 
         def name
           @name ||= "jira"
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def instance
           raise 'Please provide a block!' unless block_given?
 
-          prepare
-          start
-
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          @docker.pull(JIRA_IMAGE, JIRA_IMAGE_TAG)
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
+          super
         end
 
         def start
-          docker.run(JIRA_IMAGE, JIRA_IMAGE_TAG) do |command|
+          docker.run(image, tag) do |command|
             command << '-d '
             command << "--name #{name}"
             command << "--net #{network}"
@@ -53,17 +25,6 @@ module Gitlab
           end
         end
 
-        def restart
-          @docker.restart(name)
-        end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
         def set_jira_hostname
           ::Gitlab::QA::Runtime::Env.jira_hostname = hostname
         end

data/lib/gitlab/qa/component/ldap.rb

@@ -15,25 +15,16 @@ require 'securerandom'
 module Gitlab
   module QA
     module Component
-      class LDAP
-        include Scenario::Actable
-
-        LDAP_IMAGE = 'osixia/openldap'.freeze
-        LDAP_IMAGE_TAG = 'latest'.freeze
+      class LDAP < Base
+        DOCKER_IMAGE = 'osixia/openldap'.freeze
+        DOCKER_IMAGE_TAG = 'latest'.freeze
         LDAP_USER = 'tanuki'.freeze
         LDAP_PASSWORD = 'password'.freeze
         BOOTSTRAP_LDIF = '/container/service/slapd/assets/config/bootstrap/ldif/custom'.freeze
         FIXTURE_PATH = File.expand_path('../../../../fixtures/ldap'.freeze, __dir__)
 
-        attr_reader :docker
-        attr_accessor :volumes, :network, :environment
-        attr_writer :name
-
         def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-          @volumes = {}
-          @network_aliases = []
+          super
 
           @volumes[FIXTURE_PATH] = BOOTSTRAP_LDIF
         end
@@ -58,41 +49,21 @@ module Gitlab
           LDAP_PASSWORD
         end
 
-        def add_network_alias(name)
-          @network_aliases.push(name)
-        end
-
         def name
           @name ||= "openldap-#{SecureRandom.hex(4)}"
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def instance
           raise 'Please provide a block!' unless block_given?
 
-          prepare
-          start
-
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          @docker.pull(LDAP_IMAGE, LDAP_IMAGE_TAG)
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
+          super
         end
 
+        # rubocop:disable Metrics/AbcSize
         def start
           # copy-service needed for bootstraping LDAP user:
           # https://github.com/osixia/docker-openldap#seed-ldap-database-with-ldif
-          docker.run(LDAP_IMAGE, LDAP_IMAGE_TAG, '--copy-service') do |command|
+          docker.run(image, tag, '--copy-service') do |command|
             command << '-d '
             command << "--name #{name}"
             command << "--net #{network}"
@@ -111,21 +82,7 @@ module Gitlab
             end
           end
         end
-
-        def restart
-          @docker.restart(name)
-        end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
-        def pull
-          @docker.pull(LDAP_IMAGE, LDAP_IMAGE_TAG)
-        end
+        # rubocop:enable Metrics/AbcSize
 
         def set_gitlab_credentials
           ::Gitlab::QA::Runtime::Env.ldap_username = username

data/lib/gitlab/qa/component/mail_hog.rb

@@ -4,50 +4,22 @@
 module Gitlab
   module QA
     module Component
-      class MailHog
-        include Scenario::Actable
-
-        MAILHOG_IMAGE = 'mailhog/mailhog'.freeze
-        MAILHOG_IMAGE_TAG = 'v1.0.0'.freeze
-
-        attr_reader :docker
-        attr_accessor :environment, :network
-        attr_writer :name
-
-        def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-        end
+      class MailHog < Base
+        DOCKER_IMAGE = 'mailhog/mailhog'.freeze
+        DOCKER_IMAGE_TAG = 'v1.0.0'.freeze
 
         def name
           @name ||= "mailhog"
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def instance
           raise 'Please provide a block!' unless block_given?
 
-          prepare
-          start
-
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          @docker.pull(MAILHOG_IMAGE, MAILHOG_IMAGE_TAG)
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
+          super
         end
 
         def start
-          docker.run(MAILHOG_IMAGE, MAILHOG_IMAGE_TAG) do |command|
+          docker.run(image, tag) do |command|
             command << '-d '
             command << "--name #{name}"
             command << "--net #{network}"
@@ -57,17 +29,6 @@ module Gitlab
           end
         end
 
-        def restart
-          @docker.restart(name)
-        end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
         def set_mailhog_hostname
           ::Gitlab::QA::Runtime::Env.mailhog_hostname = hostname
         end

data/lib/gitlab/qa/component/minio.rb

@@ -6,23 +6,18 @@ require 'fileutils'
 module Gitlab
   module QA
     module Component
-      class Minio
-        include Scenario::Actable
-
-        MINIO_IMAGE = 'minio/minio'.freeze
-        MINIO_IMAGE_TAG = 'latest'.freeze
+      class Minio < Base
+        DOCKER_IMAGE = 'minio/minio'.freeze
+        DOCKER_IMAGE_TAG = 'latest'.freeze
         # These are secrets used in a local Minio container, they're not used for any online S3 server.
         AWS_ACCESS_KEY = 'AKIAIOSFODNN7EXAMPLE'.freeze
         AWS_SECRET_KEY = 'wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY'.freeze
         DATA_DIR = '/data'.freeze
         DEFAULT_PORT = 9000
 
-        attr_reader :docker
-        attr_accessor :volumes, :network, :environment
-        attr_writer :name
-
         def initialize
-          @docker = Docker::Engine.new
+          super
+
           @environment = { MINIO_ACCESS_KEY: AWS_ACCESS_KEY, MINIO_SECRET_KEY: AWS_SECRET_KEY }
           @volumes = { host_data_dir => DATA_DIR }
           @buckets = []
@@ -31,12 +26,7 @@ module Gitlab
         def instance
           raise 'Please provide a block!' unless block_given?
 
-          prepare
-          start
-
-          yield self
-        ensure
-          teardown
+          super
         end
 
         def add_bucket(name)
@@ -70,16 +60,12 @@ module Gitlab
           @name ||= "minio-#{SecureRandom.hex(4)}"
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def port
           DEFAULT_PORT
         end
 
         def prepare
-          @docker.pull(MINIO_IMAGE, MINIO_IMAGE_TAG)
+          super
 
           FileUtils.mkdir_p(host_data_dir)
 
@@ -87,16 +73,12 @@ module Gitlab
             puts "Creating Minio bucket: #{bucket}"
             FileUtils.mkdir_p(File.join(host_data_dir, bucket))
           end
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
         end
 
-        def start
+        def start # rubocop:disable Metrics/AbcSize
           # --compat needed until https://gitlab.com/gitlab-org/gitlab-workhorse/issues/210
           # is resolved
-          docker.run(MINIO_IMAGE, MINIO_IMAGE_TAG, "server", "--compat", DATA_DIR) do |command|
+          docker.run(image, tag, "server", "--compat", DATA_DIR) do |command|
             command << '-d '
             command << "--name #{name}"
             command << "--net #{network}"
@@ -115,13 +97,6 @@ module Gitlab
             end
           end
         end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
       end
     end
   end

data/lib/gitlab/qa/component/postgresql.rb

@@ -1,43 +1,16 @@
 module Gitlab
   module QA
     module Component
-      class PostgreSQL
-        include Scenario::Actable
-
-        POSTGRES_IMAGE = 'postgres'.freeze
-        POSTGRES_IMAGE_TAG = '11'.freeze
-
-        attr_reader :docker
-        attr_accessor :environment, :network
-        attr_writer :name
-
-        def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-        end
+      class PostgreSQL < Base
+        DOCKER_IMAGE = 'postgres'.freeze
+        DOCKER_IMAGE_TAG = '11'.freeze
 
         def name
           @name ||= "postgres"
         end
 
-        def instance
-          prepare
-          start
-          wait_until_ready
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          @docker.pull(POSTGRES_IMAGE, POSTGRES_IMAGE_TAG)
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
-        end
-
         def start
-          @docker.run(POSTGRES_IMAGE, POSTGRES_IMAGE_TAG) do |command|
+          @docker.run(image, tag) do |command|
             command << "-d"
             command << "--name #{name}"
             command << "--net #{network}"
@@ -46,11 +19,6 @@ module Gitlab
           end
         end
 
-        def teardown
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
         def run_psql(command)
           @docker.exec(name, %(psql -U postgres #{command}))
         end

data/lib/gitlab/qa/component/saml.rb

@@ -6,22 +6,9 @@ require 'securerandom'
 module Gitlab
   module QA
     module Component
-      class SAML
-        include Scenario::Actable
-
-        SAML_IMAGE = 'jamedjo/test-saml-idp'.freeze
-        SAML_IMAGE_TAG = 'latest'.freeze
-
-        attr_reader :docker
-        attr_accessor :volumes, :network, :environment
-        attr_writer :name
-
-        def initialize
-          @docker = Docker::Engine.new
-          @environment = {}
-          @volumes = {}
-          @network_aliases = []
-        end
+      class SAML < Base
+        DOCKER_IMAGE = 'jamedjo/test-saml-idp'.freeze
+        DOCKER_IMAGE_TAG = 'latest'.freeze
 
         def set_entity_id(entity_id)
           @environment['SIMPLESAMLPHP_SP_ENTITY_ID'] = entity_id
@@ -31,18 +18,10 @@ module Gitlab
           @environment['SIMPLESAMLPHP_SP_ASSERTION_CONSUMER_SERVICE'] = assertion_con_service
         end
 
-        def add_network_alias(name)
-          @network_aliases.push(name)
-        end
-
         def name
           @name ||= "saml-qa-idp"
         end
 
-        def hostname
-          "#{name}.#{network}"
-        end
-
         def group_name
           @group_name ||= "saml_sso_group-#{SecureRandom.hex(4)}"
         end
@@ -50,25 +29,12 @@ module Gitlab
         def instance
           raise 'Please provide a block!' unless block_given?
 
-          prepare
-          start
-
-          yield self
-        ensure
-          teardown
-        end
-
-        def prepare
-          pull
-
-          return if @docker.network_exists?(network)
-
-          @docker.network_create(network)
+          super
         end
 
         # rubocop:disable Metrics/AbcSize
         def start
-          docker.run(SAML_IMAGE, SAML_IMAGE_TAG) do |command|
+          docker.run(image, tag) do |command|
             command << '-d '
             command << "--name #{name}"
             command << "--net #{network}"
@@ -91,21 +57,6 @@ module Gitlab
         end
         # rubocop:enable Metrics/AbcSize
 
-        def restart
-          @docker.restart(name)
-        end
-
-        def teardown
-          raise 'Invalid instance name!' unless name
-
-          @docker.stop(name)
-          @docker.remove(name)
-        end
-
-        def pull
-          @docker.pull(SAML_IMAGE, SAML_IMAGE_TAG)
-        end
-
         def set_sandbox_name(sandbox_name)
           ::Gitlab::QA::Runtime::Env.gitlab_sandbox_name = sandbox_name
         end

data/lib/gitlab/qa/component/specs.rb

@@ -19,16 +19,7 @@ module Gitlab
         def perform # rubocop:disable Metrics/AbcSize
           raise ArgumentError unless [suite, release].all?
 
-          if release.dev_gitlab_org?
-            Docker::Command.execute(
-              [
-                'login',
-                '--username gitlab-qa-bot',
-                %(--password "#{Runtime::Env.dev_access_token_variable}"),
-                QA::Release::DEV_REGISTRY
-              ]
-            )
-          end
+          @docker.login(**release.login_params) if release.login_params
 
           puts "Running test suite `#{suite}` for #{release.project_name}"
 

data/lib/gitlab/qa/docker/engine.rb

@@ -8,6 +8,10 @@ module Gitlab
           URI(DOCKER_HOST).host
         end
 
+        def login(username:, password:, registry:)
+          Docker::Command.execute(%(login --username "#{username}" --password "#{password}" #{registry}))
+        end
+
         def pull(image, tag)
           Docker::Command.execute("pull #{image}:#{tag}")
         end
@@ -63,6 +67,10 @@ module Gitlab
         def port(name, port)
           Docker::Command.execute("port #{name} #{port}/tcp")
         end
+
+        def running?(name)
+          Docker::Command.execute("ps -f name=#{name}").include?(name)
+        end
       end
     end
   end

data/lib/gitlab/qa/release.rb

@@ -135,6 +135,26 @@ module Gitlab
         end
       end
 
+      def login_params
+        if dev_gitlab_org?
+          Runtime::Env.require_qa_dev_access_token!
+
+          {
+            username: Runtime::Env.gitlab_dev_username,
+            password: Runtime::Env.dev_access_token_variable,
+            registry: DEV_REGISTRY
+          }
+        elsif omnibus_mirror?
+          Runtime::Env.require_gitlab_bot_multi_project_pipeline_polling_token!
+
+          {
+            username: Runtime::Env.gitlab_username,
+            password: Runtime::Env.gitlab_bot_multi_project_pipeline_polling_token,
+            registry: COM_REGISTRY
+          }
+        end
+      end
+
       def dev_gitlab_org?
         image.start_with?(DEV_REGISTRY)
       end

data/lib/gitlab/qa/runtime/env.rb

@@ -84,10 +84,22 @@ module Gitlab
           send(:attr_accessor, accessor) # rubocop:disable GitlabSecurity/PublicSend
         end
 
+        def gitlab_username
+          ENV['GITLAB_USERNAME'] || 'gitlab-qa'
+        end
+
+        def gitlab_dev_username
+          ENV['GITLAB_DEV_USERNAME'] || 'gitlab-qa-bot'
+        end
+
         def gitlab_api_base
           ENV['GITLAB_API_BASE'] || 'https://gitlab.com/api/v4'
         end
 
+        def gitlab_bot_multi_project_pipeline_polling_token
+          ENV['GITLAB_BOT_MULTI_PROJECT_PIPELINE_POLLING_TOKEN']
+        end
+
         def ci_job_name
           ENV['CI_JOB_NAME']
         end
@@ -195,8 +207,14 @@ module Gitlab
           end
         end
 
+        def require_gitlab_bot_multi_project_pipeline_polling_token!
+          return unless ENV['GITLAB_BOT_MULTI_PROJECT_PIPELINE_POLLING_TOKEN'].to_s.strip.empty?
+
+          raise ArgumentError, "Please provide GITLAB_BOT_MULTI_PROJECT_PIPELINE_POLLING_TOKEN"
+        end
+
         def skip_pull?
-          (ENV['QA_SKIP_PULL'] =~ /^(false|no|0)$/i) != 0
+          enabled?(ENV['QA_SKIP_PULL'], default: false)
         end
 
         def gitlab_qa_formless_login_token
@@ -205,6 +223,12 @@ module Gitlab
 
         private
 
+        def enabled?(value, default: true)
+          return default if value.nil?
+
+          (value =~ /^(false|no|0)$/i) != 0
+        end
+
         def env_value_if_defined(variable)
           # Pass through the variables if they are defined in the environment
           return "$#{variable}" if ENV[variable]

data/lib/gitlab/qa/runtime/scenario.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module QA
+    module Runtime
+      ##
+      # Singleton approach to global test scenario arguments.
+      #
+      module Scenario
+        extend self
+
+        def attributes
+          @attributes ||= {}
+        end
+
+        def define(attribute, value)
+          attributes.store(attribute.to_sym, value)
+
+          define_singleton_method(attribute) do
+            attributes[attribute.to_sym].tap do |value|
+              if value.to_s.empty?
+                raise ArgumentError, "Empty `#{attribute}` attribute!"
+              end
+            end
+          end
+        end
+
+        # rubocop:disable Style/MethodMissing
+        def method_missing(name, *)
+          raise ArgumentError, "Scenario attribute `#{name}` not defined!"
+        end
+        # rubocop:enable Style/MethodMissing
+      end
+    end
+  end
+end

data/lib/gitlab/qa/scenario/test/integration/gitaly_ha.rb

@@ -31,7 +31,7 @@ module Gitlab
                         praefect.release = QA::Release.new(release)
                         praefect.name = @praefect_node
                         praefect.network = @network
-                        praefect.skip_check = true
+                        praefect.skip_availability_check = true
 
                         praefect.omnibus_config = praefect_omnibus_configuration
 
@@ -149,7 +149,7 @@ module Gitlab
                 gitaly.release = QA::Release.new(release)
                 gitaly.name = name
                 gitaly.network = @network
-                gitaly.skip_check = true
+                gitaly.skip_availability_check = true
 
                 gitaly.omnibus_config = gitaly_omnibus_configuration
 

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '5.13.6'.freeze
+    VERSION = '5.13.7'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 5.13.6
+  version: 5.13.7
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-02 00:00:00.000000000 Z
+date: 2020-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -237,6 +237,7 @@ files:
 - fixtures/ldap/tanuki.ldif
 - gitlab-qa.gemspec
 - lib/gitlab/qa.rb
+- lib/gitlab/qa/component/base.rb
 - lib/gitlab/qa/component/elasticsearch.rb
 - lib/gitlab/qa/component/gitlab.rb
 - lib/gitlab/qa/component/internet_tunnel.rb
@@ -263,6 +264,7 @@ files:
 - lib/gitlab/qa/reporter.rb
 - lib/gitlab/qa/runner.rb
 - lib/gitlab/qa/runtime/env.rb
+- lib/gitlab/qa/runtime/scenario.rb
 - lib/gitlab/qa/runtime/token_finder.rb
 - lib/gitlab/qa/scenario/actable.rb
 - lib/gitlab/qa/scenario/cli_commands.rb
@@ -327,7 +329,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Integration tests for GitLab