gitlab-qa 12.2.0 → 12.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bc6e7f6460f83e7480215fa4b9c99738237ee4e300af3ea3ae2817cc9f734f6
-  data.tar.gz: 0535dfb574921a9dd757ef2d628380827f856165c6921fbbfd79458a92e36ae1
+  metadata.gz: 0e4cc0696035cf54be7b10e0153ffb42d59a5da480b4f87b8e313fc19ac50d96
+  data.tar.gz: d773ed2ef468d85328eee38811f03738c97cb8b6679a1e65d6c22d3a91a76936
 SHA512:
-  metadata.gz: d6550c937cdf6c29884168e3aff9f75baaecc1e8919054a49807435f08cdb68fdbab42fb2061fe125228be2be7932cc534a303e831e023967e187add5ec53255
-  data.tar.gz: e6f34c0cbba1f8b35b0ad96cb92fd43234aec4931eae947ad95378f5b8c5d58c9fdaf689acd16a8968eb24c5b2a8cc86a30ca744ee2a0c7166623b51b8fe18c2
+  metadata.gz: eef1ff7b5b65693659df80f4bfb78891238b07a0bdba06d1348d068c780bf52cd6f2b65faf753a700511f0fb28a4bfe2cc6dead51cc8873933bc5fa420445fe3
+  data.tar.gz: bb30bec072843a3939966e1beda00b2468f85f4bf201cd32c4f8d80c42824440d24884f86447b885d687fd627b75f7cf93d74cf20c778ada16986a5c51282d92

data/.gitlab-ci.yml

@@ -34,7 +34,7 @@ workflow:
     # For merge requests, create a pipeline.
     - if: '$CI_MERGE_REQUEST_IID'
     # For the default branch, create a pipeline (this includes on schedules, pushes, merges, etc.).
-    - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+    - if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable$/'
     # For tags, create a pipeline.
     - if: '$CI_COMMIT_TAG'
     # When using Run pipeline button in the GitLab UI, from the project’s CI/CD > Pipelines section, create a pipeline.
@@ -47,6 +47,12 @@ variables:
   BUNDLE_SILENCE_ROOT_WARNING: "true"
   BUNDLE_SUPPRESS_INSTALL_USING_MESSAGES: "true"
 
+# Override rules to allow creating backport releases
+.release-base:
+  rules:
+    - if: '$CI_PIPELINE_SOURCE == "push" && ($CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable$/)'
+      changes: ["lib/**/version.rb"]
+
 package-and-test-env:
   image: ${CI_DEPENDENCY_PROXY_GROUP_IMAGE_PREFIX}/alpine:latest
   stage: .pre
@@ -135,7 +141,6 @@ package-and-test:
     variables:
       - RUBY_VERSION
       - DEBIAN_VERSION
-  when: manual
   trigger:
     strategy: depend
     forward:
@@ -145,3 +150,8 @@ package-and-test:
       - project: gitlab-org/gitlab
         ref: master
         file: .gitlab/ci/package-and-test/main.gitlab-ci.yml
+  rules:
+    - if: '$CI_MERGE_REQUEST_IID'
+      when: manual
+      allow_failure: true
+    - when: always

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-qa (12.2.0)
+    gitlab-qa (12.3.0)
       activesupport (>= 6.1, < 7.1)
       gitlab (~> 4.19)
       http (~> 5.0)
@@ -24,6 +24,7 @@ GEM
     ast (2.4.2)
     backport (1.2.0)
     benchmark (0.2.0)
+    byebug (11.1.3)
     claide (1.1.0)
     claide-plugins (0.9.2)
       cork
@@ -149,6 +150,9 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    pry-byebug (3.10.1)
+      byebug (~> 11.0)
+      pry (>= 0.13, < 0.15)
     public_suffix (5.0.0)
     racc (1.6.0)
     rack (3.0.7)
@@ -263,6 +267,7 @@ DEPENDENCIES
   gitlab-styles (~> 10)
   lefthook (~> 1.2.6)
   pry (~> 0.11)
+  pry-byebug (~> 3.10.1)
   rake (~> 13.0)
   rspec (~> 3.7)
   simplecov (~> 0.22)

data/gitlab-qa.gemspec

@@ -27,6 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'gitlab-styles', '~> 10'
   spec.add_development_dependency 'lefthook', '~> 1.2.6'
   spec.add_development_dependency 'pry', '~> 0.11'
+  spec.add_development_dependency 'pry-byebug', '~> 3.10.1'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.7'
   spec.add_development_dependency 'simplecov', '~> 0.22'

data/lib/gitlab/qa/runtime/env.rb

@@ -85,6 +85,7 @@ module Gitlab
           'KNAPSACK_REPORT_PATH' => :knapsack_report_path,
           'KNAPSACK_TEST_FILE_PATTERN' => :knapsack_test_file_pattern,
           'KNAPSACK_TEST_DIR' => :knapsack_test_dir,
+          'NO_KNAPSACK' => :no_knapsack,
           'QA_KNAPSACK_REPORT_GCS_CREDENTIALS' => :qa_knapsack_report_gcs_credentials,
           'QA_KNAPSACK_REPORT_PATH' => :qa_knapsack_report_path,
           'QA_RSPEC_REPORT_PATH' => :qa_rspec_report_path,

data/lib/gitlab/qa/runtime/omnibus_configuration.rb

@@ -53,28 +53,134 @@ module Gitlab
             #   NOT gitlab_rails['packages_enabled']=true
 
             v.nil? ? k.strip : "#{k.strip} = #{v.strip.tr('"', "'")}".strip
-          end.uniq
+          end
 
-          errors = []
+          sanitized = split_items(sanitized).uniq
+
+          sanitized = merge_arrays(sanitized)
 
           # check for duplicates
           duplicate_keys = []
           duplicates = sanitized.reject do |n|
             key = n.split('=').first
+
             duplicate_keys << key unless duplicate_keys.include?(key)
           end
 
+          errors = []
           duplicates.each { |duplicate| errors << "Duplicate entry found: `#{duplicate}`" }
 
           raise "Errors exist within the Omnibus Configuration!\n#{errors.join(',')}" if errors.any?
 
           @config = sanitized
         end
+
         # rubocop:enable Metrics/AbcSize
 
         def <<(config)
           @config << config.strip unless config.strip.empty?
         end
+
+        private
+
+        # Merge Omnibus configuration values if the value is an array
+        # @example
+        #  array = ['a["setting"] = [1]', 'a["setting"] = [2]']
+        #  merge_arrays(array) #=> ['a["setting"] = [1, 2]']
+        #
+        # @param [Array] arr
+        #
+        # @return [Array]
+        def merge_arrays(arr)
+          entries_with_array = {}
+
+          arr.reject! do |item|
+            key, value = item.split("=", 2)
+
+            array_content_match = value&.match(/^\s?\[([\s\S]+)\][\s;]?$/)
+
+            if array_content_match
+              if entries_with_array[key]
+                entries_with_array[key] << array_content_match[1]
+              else
+                entries_with_array[key] = [array_content_match[1]]
+              end
+            end
+          end
+
+          entries_with_array.each do |k, v|
+            arr << "#{k}= [#{v.map(&:chomp).join(', ')}]".strip
+          end
+
+          arr
+        end
+
+        # Split each Omnibus setting into an array item
+        # @example
+        #  input = ["a['setting_1'] = true",
+        #  "a['setting_2'] = [
+        #    {
+        #      name: 'setting_2a_name'
+        #    }
+        #  ]
+        #  a['setting_3'] = false"]
+        #
+        # split_items(input) #=>
+        # ["a['setting_1'] = true",
+        #  "a['setting_2'] = [
+        #     {
+        #       name: 'setting_2a_name'
+        #     }
+        #   ]",
+        # "a['setting_3'] = false"]
+        #
+        # @param [Array] input
+        #
+        # @return [Array]
+        #
+        # rubocop:disable Metrics/AbcSize
+        def split_items(input)
+          items = []
+
+          input.each do |item|
+            if count_occurrences(item, ' = ') > 1
+              multi_line_item = []
+              item.split("\n").each do |line|
+                if /( = |external_url)/.match?(line)
+
+                  if multi_line_item.count > 1
+                    items.pop
+                    items << multi_line_item.join("\n")
+                  end
+
+                  items << line
+                  multi_line_item = [line]
+                else
+                  multi_line_item << line
+                end
+              end
+
+              if multi_line_item.count > 1
+                items.pop
+                items << multi_line_item.join("\n")
+              end
+            else
+              items << item
+            end
+          end
+
+          items
+        end
+        # rubocop:enable Metrics/AbcSize
+
+        # Count occurrences of a substring in a string
+        # @param [String] str
+        # @param [String] substr
+        #
+        # @return [Array]
+        def count_occurrences(str, substr)
+          str.scan(/(?=#{substr})/).count
+        end
       end
     end
   end

data/lib/gitlab/qa/support/gitlab_version_info.rb

@@ -47,6 +47,10 @@ module Gitlab
 
         private
 
+        MAX_TAGS_HTTP_REQUESTS = 50
+        # https://docs.docker.com/docker-hub/api/latest/#tag/images/operation/GetNamespacesRepositoriesImages
+        TAGS_PER_PAGE = 100
+
         attr_reader :current_version, :edition, :logger
 
         # Current versions major version
@@ -158,22 +162,40 @@ module Gitlab
         def tags
           return @tags if defined?(@tags)
 
-          logger.info("Fetching docker tags from 'gitlab/gitlab-#{edition}' registry")
+          MAX_TAGS_HTTP_REQUESTS.times do |index|
+            tag_list, more_data = fetch_tags(page: index + 1)
+
+            if tag_list
+              @tags = Array(@tags)
+              @tags += tag_list
+            end
+
+            break if tag_list.nil? || more_data.nil?
+          end
+
+          @tags
+        end
+
+        def fetch_tags(page:, per_page: TAGS_PER_PAGE)
+          logger.info("Fetching Docker tags page #{page} from 'gitlab/gitlab-#{edition}' registry")
           response = HttpRequest.make_http_request(
-            url: "https://registry.hub.docker.com/v2/namespaces/gitlab/repositories/gitlab-#{edition}/tags?page_size=1000",
+            url: "https://registry.hub.docker.com/v2/namespaces/gitlab/repositories/gitlab-#{edition}/tags?page=#{page}&page_size=#{per_page}",
             fail_on_error: false
           )
 
           unless response.code == 200
             logger.error("  failed to fetch docker tags - code: #{response.code}, response: '#{response.body}'")
-            return @tags = nil
+            return nil
           end
 
-          @tags = JSON
-            .parse(response.body, symbolize_names: true)
+          response = JSON.parse(response.body, symbolize_names: true)
+          matching_tags = response
             .fetch(:results)
             .map { |tag| tag[:name] }
             .grep(VERSION_PATTERN)
+          more_data = response.fetch(:next)
+
+          [matching_tags, more_data]
         end
       end
     end

data/lib/gitlab/qa/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module QA
-    VERSION = '12.2.0'
+    VERSION = '12.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 12.2.0
+  version: 12.3.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-20 00:00:00.000000000 Z
+date: 2023-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.10.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.10.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement