gitlab-net-dns 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04ce28e53e3b0986fb5a2dcde807ac07bc15ceb3bdd127abe31d125e4ae9e054
-  data.tar.gz: 119fcc2767ae448912fbadb013a82fdeff83fd68c06937fafdefecabbfea0d58
+  metadata.gz: 6894aeca8ca5a877a50f79dd5960888cf153cbf33ae1f367681185ab72eeed25
+  data.tar.gz: 6db68fc71b24701ebe82fb84e13f2a5a131a6aecba929af968b528d2e40650dd
 SHA512:
-  metadata.gz: 0546f72172a83589a710a70cb8ff1e3caabab249cbd49a1ecf8751a802433d6ef6ff9b1667843772598248e7c0b155fd7836cf2aa1131da1be7fa1541bcf0a91
-  data.tar.gz: 469360aa30e2681543719347ce2a1dd488615df7f22eb7a6482bf2c58ce3e4b9d54fceab14de3de9b0a88e7394a3b2f76320877742c533f6a10e62a9fbb0660a
+  metadata.gz: 9d3aae8c3e2868244e5cd5f4da8a89191901f440ca0a999280ee8b1f7b083f57aa10fc1aabe8fe38b13de99579bcfec4805a4ed4eb2c6c35c61d9003c5ea4076
+  data.tar.gz: e4d8e5f5dca3b4b9c704d0c4ff8c695b86f4620b48ccfa9ca505cbc0a5ac784517f045b6257ac2e76d15f3e4ad277385814e56905167ec044bed77f543cf645e

data/.gitlab-ci.yml

@@ -20,4 +20,4 @@ rspec:
     - bundle exec rake
   parallel:
     matrix:
-      - RUBY_VERSION: [ "2.7", "3.0", "3.1", "3.2" ]
+      - RUBY_VERSION: [ "3.0", "3.1", "3.2", "3.3", "3.4" ]

data/gitlab-net-dns.gemspec

@@ -11,12 +11,13 @@ Gem::Specification.new do |s|
   s.description = "Net::DNS is a pure Ruby DNS library, with a clean OO interface and an extensible API."
   s.licenses    = ["Ruby"]
 
-  s.required_ruby_version = ">= 2.1"
+  s.required_ruby_version = ">= 3.0"
 
   s.require_paths    = ["lib"]
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.extra_rdoc_files = %w[LICENSE.txt]
+  s.add_dependency "logger"
 
   s.add_development_dependency "mocha"
   s.add_development_dependency "rake"

data/lib/net/dns/rr/types.rb

@@ -84,6 +84,9 @@ module Net # :nodoc:
           'CAA' => 257, # RFC 6844
         }.freeze
 
+        # Pre-initialize the inverted hash to avoid runtime inversion
+        TYPES_BY_NUMBER = TYPES.invert.freeze
+
         # The default value when type is nil in Resource Records
         @@default = TYPES["A"]
 
@@ -107,7 +110,7 @@ module Net # :nodoc:
           when String
             TYPES.key?(type)
           when Integer
-            TYPES.invert.key?(type)
+            TYPES_BY_NUMBER.key?(type)
           else
             raise ArgumentError, "Wrong type class: #{type.class}"
           end
@@ -118,8 +121,8 @@ module Net # :nodoc:
         def self.to_str(type)
           case type
           when Integer
-            if TYPES.invert.key? type
-              TYPES.invert[type]
+            if TYPES_BY_NUMBER.key? type
+              TYPES_BY_NUMBER[type]
             else
               raise ArgumentError, "Unknown type number #{type}"
             end
@@ -148,7 +151,7 @@ module Net # :nodoc:
             new_from_num(type)
           when nil
             # default type, control with Types.default=
-            @str = TYPES.invert[@@default]
+            @str = TYPES_BY_NUMBER[@@default]
             @num = @@default
           else
             raise ArgumentError, "Wrong type class: #{type.class}"
@@ -197,11 +200,11 @@ module Net # :nodoc:
 
         # Contructor for numeric data type.
         def new_from_num(type)
-          if TYPES.invert.key? type
+          if TYPES_BY_NUMBER.key? type
             @num = type
-            @str = TYPES.invert[type]
+            @str = TYPES_BY_NUMBER[type]
           else
-            raise ArgumentError, "Unkown type number #{type}"
+            raise ArgumentError, "Unknown type number #{type}"
           end
         end
       end

data/lib/net/dns/rr.rb

@@ -298,7 +298,14 @@ module Net
         if self.class == Net::DNS::RR
           temp = dn_expand(data, offset)[1]
           type = Net::DNS::RR::Types.new data.unpack("@#{temp} n")[0]
-          (eval "Net::DNS::RR::#{type}").parse_packet(data, offset)
+          rr_class = Net::DNS::RR.const_get(type.to_s) rescue nil
+
+          if rr_class && rr_class.respond_to?(:parse_packet)
+            rr_class.parse_packet(data, offset)
+          else
+            # This shouldn't happen because Net::DNS::RR::Types.new already raises an error on invalid types
+            raise "Unknown or unsupported RR type: #{type}"
+          end
         else
           @name, offset = dn_expand(data, offset)
           rrtype, cls, @ttl, @rdlength = data.unpack("@#{offset} n2 N n")

data/lib/net/dns/version.rb

@@ -3,6 +3,6 @@
 module Net
   module DNS
     # The current library version.
-    VERSION = "0.10.0"
+    VERSION = "0.11.0"
   end
 end

data/test/unit/rr_test.rb

@@ -124,4 +124,37 @@ class RRTest < Minitest::Test
       Net::DNS::RR.new("google.com. 10800 IM A")
     end
   end
+
+  def test_bad_type
+    assert_raises(ArgumentError) do
+      Net::DNS::RR.new(name: @rr_name,
+                       ttl: @ttl,
+                       cls: @cls,
+                       type: "BOGUS",
+                       address: @rdata)
+    end
+  end
+
+  def test_parse_packet_with_unsupported_type
+    # Create a mock binary packet with an unsupported RR type
+
+    # Start with a normal A record to get valid binary data
+    record = Net::DNS::RR.new("example.com. 3600 IN A 192.168.1.1")
+    binary_data = record.data
+
+    # Find where the name ends by looking for a null byte
+    name_end = binary_data.index("\x00") + 1
+
+    # Replace the type value (2 bytes) with 0xFACE (an undefined type)
+    modified_data = binary_data.dup
+    modified_data[name_end, 2] = [0xFACE].pack("n")
+
+    # The parse_packet should raise an error for unknown types
+    error = assert_raises(ArgumentError) do
+      Net::DNS::RR.parse(modified_data)
+    end
+
+    # Verify the error message mentions the unknown type
+    assert_match(/Unknown type number/, error.message)
+  end
 end

metadata

@@ -1,16 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-net-dns
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Marco Ceresa
 - Simone Carletti
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-16 00:00:00.000000000 Z
+date: 2025-04-28 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +142,6 @@ homepage: https://gitlab.com/gitlab-org/gitlab-net-dns
 licenses:
 - Ruby
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -137,15 +149,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Pure Ruby DNS library.
 test_files: