gitlab-labkit 1.11.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d63e4f781c8e316f19c419a52485bd751cef83e713f7da971e3285709760a669
-  data.tar.gz: a13c2d6a3b9f217f0d65c5a755ff213db29b21dad1e20d2cc5ea17a5bea3dda5
+  metadata.gz: e8c136c0ed8617c5023574687e1b1284621726be410583eb7ee17586fe56c20e
+  data.tar.gz: f9f496d1b6ea56d986b577052f8f50c7a91f1114307af3bd9856734c482afac1
 SHA512:
-  metadata.gz: 5e5983bc819202df660c1965efb7d26dd74f89c7479d01974a3d4f56e5a2c09a4d9fa01cac41719d80048d6737a676cc3fb3d9492cfb1619eb715932cf2ad6ff
-  data.tar.gz: 44d1210ee82ef16a99150316f73b76be43942fedaad296b78c925a3e270a8e6b39e4e3cbf43e63488048b11f7d69b40ad3dcfdcc514b8d6bbb4dfe805a28173a
+  metadata.gz: caed2e7c544c73856cd6a47a0f63655038f636674cf5070a0cb4b5330c2beda0c07ff0a7352b5d367f293ae818ecf08aa414316485f5cc6a262595c5240f334c
+  data.tar.gz: 7c3b49fc037060c21ea36e49e4878f99640e241b5a7358665fddf6bdde354ac26ddda80c87b11f5de183c4a259a9b2d6c8629818a852078393487c1c78ef6ba1

data/lib/labkit/user_experience_sli/experience.rb

@@ -61,7 +61,8 @@ module Labkit
       #
       # @yield [self] When a block is provided, the experience will be completed automatically.
       # @param extra [Hash] Additional data to include in the log event
-      # @return [self]
+      # @return [self] When no block is given.
+      # @return [Object] The result of the block when a block is given.
       # @raise [UserExperienceError] If the block raises an error.
       #
       # Usage:
@@ -104,7 +105,9 @@ module Labkit
       # Resume the User Experience.
       #
       # @yield [self] When a block is provided, the experience will be completed automatically.
-      # @param extra [Hash] Additional data to include in the log
+      # @param extra [Hash] Additional data to include in the log event
+      # @return [self] When no block is given.
+      # @return [Object] The result of the block when a block is given.
       def resume(**extra, &)
         return self unless ensure_started!
 
@@ -190,16 +193,12 @@ module Labkit
       end
 
       def completable(**extra, &)
-        begin
-          yield self
-        rescue StandardError => e
-          error!(e)
-          raise
-        ensure
-          complete(**extra)
-        end
-
-        self
+        yield self
+      rescue StandardError => e
+        error!(e)
+        raise
+      ensure
+        complete(**extra)
       end
 
       def ensure_incomplete!

data/lib/labkit/user_experience_sli/null.rb

@@ -11,12 +11,14 @@ module Labkit
       def id = 'null'
 
       def start(**_extra)
-        yield self if block_given?
+        return yield(self) if block_given?
+
         self
       end
 
       def resume(**_extra)
-        yield self if block_given?
+        return yield(self) if block_given?
+
         self
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-labkit
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.11.1
 platform: ruby
 authors:
 - Andrew Newdigate