gitlab-labkit 0.41.0 → 0.41.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 762df6d0e3348526c7b49929a3a6cdd82db05c80a9d83569a76bd10ddb131ca2
-  data.tar.gz: 0affeb965dd17cfc202a0b64419d46bb92419a051a70972cbab5d57e5844d027
+  metadata.gz: 021f710ca320399402124ec377576c549cb5e323f59da70babd4e70f576cf12f
+  data.tar.gz: ef32fd2ac8e127847a7124f73155b8fc0d7397d2d07a563dde469d0f3c08b58d
 SHA512:
-  metadata.gz: c703503bc9cf08155d72a0ffc61f7f8cc2c573353d67382e7b4d7b22ea554c2a14ee2e2d04f8804696fa95584843cd4a342cbcdb5e9cb8ac775bd0d36df006b3
-  data.tar.gz: 2a598ffe29d7382689637c605db8ba721c993e3fc4b033176b273b99515033577b16d82961007bb9e99da3feac5ec2419e58c7a45b354dfd820e4d9bfa9baa4b
+  metadata.gz: d6fa54d12f6fc16838d116316ca612ec5bc243e282b5b24ffca56547f9a4192e2ae59db05499cf18d4bb2d2f97c4295bb424dffadaa47f760c3614f8f6099e17
+  data.tar.gz: 6ed7ef8bc8a7fa9cfe212ef1329c4dd86ec5613db5e6b80b42cc8e432ba49f10b6af200fdd10a46fd0e63198be4fd061a3555627002de158950adf1a2060ae47

data/.copier-answers.yml

@@ -3,7 +3,7 @@
 # See the project for instructions on how to update the project
 #
 # Changes here will be overwritten by Copier; NEVER EDIT MANUALLY
-_commit: v1.35.1
+_commit: v1.36.0
 _src_path: https://gitlab.com/gitlab-com/gl-infra/common-template-copier.git
 ee_licensed: false
 golang: false

data/.gitlab-ci-asdf-versions.yml

@@ -1,5 +1,5 @@
 # DO NOT MANUALLY EDIT; Run ./scripts/update-asdf-version-variables.sh to update this
 variables:
-    GL_ASDF_RUBY_VERSION: "3.4.5"
+    GL_ASDF_RUBY_VERSION: "3.4.6"
     GL_ASDF_SHELLCHECK_VERSION: "0.11"
     GL_ASDF_SHFMT_VERSION: "3.12"

data/.tool-versions

@@ -1,3 +1,3 @@
-ruby 3.4.5
+ruby 3.4.6
 shfmt 3.12
 shellcheck 0.11

data/lib/labkit/covered_experience/README.md

@@ -149,7 +149,7 @@ experience.checkpoint
 experience.complete
 ```
 
-**Note:** The `resume` method loads the start time from the Labkit context. If no covered experience data exists in the context, it behaves the same as calling methods on an unstarted experience (raises `UnstartedError` in development/test environments, or safely ignores in other environments).
+**Note:** The `resume` method loads the start time from the Labkit context. If no covered experience data exists in the context, it behaves the same as calling methods on an unstarted experience and safely ignores the operation.
 
 ### Error Handling
 
@@ -182,4 +182,4 @@ end
 
 - In `development` and `test` environments, accessing a non-existent covered experience will raise a `NotFoundError`
 - In other environments, a null object is returned that safely ignores all method calls
-- Attempting to checkpoint or complete an unstarted experience will raise an `UnstartedError` in `development` and `test` environments
+- Attempting to checkpoint or complete an unstarted experience will safely ignore the operation

data/lib/labkit/covered_experience/error.rb

@@ -3,8 +3,6 @@
 module Labkit
   module CoveredExperience
     CoveredExperienceError = Class.new(StandardError)
-    UnstartedError = Class.new(CoveredExperienceError)
-    CompletedError = Class.new(CoveredExperienceError)
     NotFoundError = Class.new(CoveredExperienceError)
     ReservedKeywordError = Class.new(CoveredExperienceError)
   end

data/lib/labkit/covered_experience/experience.rb

@@ -90,10 +90,9 @@ module Labkit
       # Checkpoint the Covered Experience.
       #
       # @param extra [Hash] Additional data to include in the log event
-      # @raise [UnstartedError] If the experience has not been started and RAILS_ENV is development or test.
       # @return [self]
       def checkpoint(**extra)
-        return unless ensure_started!
+        return self unless ensure_started!
 
         @checkpoint_time = Time.now.utc
         checkpoint_counter.increment(checkpoint: "intermediate", **base_labels)
@@ -107,7 +106,7 @@ module Labkit
       # @yield [self] When a block is provided, the experience will be completed automatically.
       # @param extra [Hash] Additional data to include in the log
       def resume(**extra, &)
-        return unless ensure_started!
+        return self unless ensure_started!
 
         checkpoint(checkpoint_action: 'resume', **extra)
 
@@ -119,11 +118,9 @@ module Labkit
       # Complete the Covered Experience.
       #
       # @param extra [Hash] Additional data to include in the log event
-      # @raise [UnstartedError] If the experience has not been started and RAILS_ENV is development or test.
       # @return [self]
       def complete(**extra)
-        return unless ensure_started!
-        return unless ensure_incomplete!
+        return self unless ensure_started! && ensure_incomplete!
 
         begin
           @end_time = Time.now.utc
@@ -166,10 +163,8 @@ module Labkit
       def ensure_started!
         return @start_time unless @start_time.nil?
 
-        err = UnstartedError.new("Covered Experience #{@definition.covered_experience} not started")
-
-        warn(err)
-        raise(err) if %w[development test].include?(ENV['RAILS_ENV'])
+        warn("Covered Experience #{@definition.covered_experience} not started")
+        false
       end
 
       def completable(**extra, &)
@@ -188,10 +183,8 @@ module Labkit
       def ensure_incomplete!
         return true if @end_time.nil?
 
-        err = CompletedError.new("Covered Experience #{@definition.covered_experience} already completed")
-
-        warn(err)
-        raise(err) if %w[development test].include?(ENV['RAILS_ENV'])
+        warn("Covered Experience #{@definition.covered_experience} already completed")
+        false
       end
 
       def urgency_threshold
@@ -199,6 +192,8 @@ module Labkit
       end
 
       def elapsed_time
+        return 0 unless @start_time
+
         last_time = @end_time || @checkpoint_time || @start_time
         last_time - @start_time
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-labkit
 version: !ruby/object:Gem::Version
-  version: 0.41.0
+  version: 0.41.2
 platform: ruby
 authors:
 - Andrew Newdigate