gitlab-grack 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2043f542b17f7cfb055ff210da481b0d2396e285
-  data.tar.gz: dbe633ec5179035e0d9f99c90ab4df8af0d6c6c1
+  metadata.gz: 23b1962af9b51c2805167e6b627d5357dcee1752
+  data.tar.gz: 74d0879a706bc19457bc6fae3bbf5dc0c7bdc135
 SHA512:
-  metadata.gz: d64c06b4125048c4bb68136d9dddf4c972ec9a1080f4492d2dafc3d1e1f965cbba40071d2c2f18a434ae824121d006ff5e73ffc936955dbde6fd8a9504e4bf94
-  data.tar.gz: 86032ba1a3c5ed1dba412d029e3b20076f79ceb62f6370012a6afbe87c02d0c2c7871ed4e8713559072457fb0fe2540e96e93ba5bf2c6cb6a4a9b623e2aa5ee3
+  metadata.gz: 3b52af3a8f9be5abaa0f7a0513c127c67a2900ba315a431bb2b2d51dbfd4fd7f10a42a95d71b1d954b5862e34adb28619a3b2831c271bbeca713fc217e9005b3
+  data.tar.gz: bc0cabeec601326501c9c80c56dba59cd19eb4bf39cf905918426d67a2b65625cb77a9a983fb8beb2b3d1b3936c66401c6f69663468c9b9146515875f1fa16df

data/.gitignore

@@ -1,2 +1,3 @@
 coverage/
 pkg/
+*.gem

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+env:
+  - TRAVIS=true
+branches:
+  only:
+    - 'master'
+rvm:
+  - 1.9.3-p327
+  - 2.0.0
+before_script:
+  - "bundle install"
+  - "git submodule init"
+  - "git submodule update"
+script: "bundle exec rake"

data/CHANGELOG

@@ -0,0 +1,2 @@
+1.1.0
+  - Modifies service_rpc to use chunked transfer (https://github.com/gitlabhq/grack/pull/1)

data/lib/grack/server.rb

@@ -55,6 +55,12 @@ module Grack
     # actual command handling functions
     # ---------------------------------
 
+    # Uses chunked (streaming) transfer, otherwise response
+    # blocks to calculate Content-Length header
+    # http://en.wikipedia.org/wiki/Chunked_transfer_encoding
+
+    CRLF = "\r\n"
+
     def service_rpc
       return render_no_access if !has_access(@rpc, true)
       input = read_body
@@ -62,19 +68,32 @@ module Grack
       @res = Rack::Response.new
       @res.status = 200
       @res["Content-Type"] = "application/x-git-%s-result" % @rpc
+      @res["Transfer-Encoding"] = "chunked"
+      @res["Cache-Control"] = "no-cache"
+
       @res.finish do
         command = git_command("#{@rpc} --stateless-rpc #{@dir}")
         IO.popen(command, File::RDWR) do |pipe|
           pipe.write(input)
           pipe.close_write
           while !pipe.eof?
-            block = pipe.read(8192) # 8M at a time
-            @res.write block        # steam it to the client
+            block = pipe.read(8192)           # 8KB at a time
+            @res.write encode_chunk(block)    # stream it to the client
           end
+          @res.write terminating_chunk
         end
       end
     end
 
+    def encode_chunk(chunk)
+      size_in_hex = chunk.size.to_s(16)
+      [ size_in_hex, CRLF, chunk, CRLF ].join
+    end
+
+    def terminating_chunk
+      [ 0, CRLF, CRLF ].join
+    end
+
     def get_info_refs
       service_name = get_service_type
 

data/lib/grack/version.rb

@@ -1,3 +1,3 @@
 module Grack
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-grack
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Scott Chacon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-10 00:00:00.000000000 Z
+date: 2013-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -47,6 +47,8 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .gitmodules
+- .travis.yml
+- CHANGELOG
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -79,7 +81,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Ruby/Rack Git Smart-HTTP Server Handler