gitlab-dangerfiles 4.9.2 → 4.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47060507ff2e0edcae85beb08c439693e308cbff7074866cec3bc0e414862de1
-  data.tar.gz: edda2ec253b32c8a0941ea28b5ff379bb6f4da7b3533ff40a93f704988ea1b89
+  metadata.gz: dc6047699d31bc320127f651d567ddf984b6189eeeb7646eb4f0d46b4185e9fd
+  data.tar.gz: 655da17704203a02f6f138b8493bb8cf2002c2121d1015a63da0677ebf23b48d
 SHA512:
-  metadata.gz: 007afabd122fd47ecdfb142e994383b3bbc248c0dc04bb4703eca41abadc1f02c8950f2383090e8b6f77bdc9aba329580ad212220d3cef9b6e6c8558cd34e439
-  data.tar.gz: 2a00297f352b563de9ef582f87f82030c2bf78ff581b7fa48cff99246a70be6f1123fcac512d5fa56a6b427901ebfebd9cdfb241f4c202a764736128bff94eba
+  metadata.gz: 02613c71246a09f46d15e0117e3f304ae626618c5736ff9b02f5e15bfbeccaa4921cefa694c97548dc5af2f4611866b58eb29f9eb5e0305d7412461097980a2c
+  data.tar.gz: 6703f6fe3502ad2336c33a4296a67d3e7d77d0dd9e46db97f510f0bd4c17a729f1bb20afcbb4ab6a0d5b24da477e4e50378e76cb943b9fc474fbed29320e619b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-dangerfiles (4.9.2)
+    gitlab-dangerfiles (4.10.0)
       danger (>= 9.3.0)
       danger-gitlab (>= 8.0.0)
       rake (~> 13.0)

data/README.md

@@ -202,6 +202,28 @@ project. To use it in your project, perform the following steps:
      dangerfiles.import_dangerfiles(only: %w[simple_roulette])
    end
    ```
+   
+##### Auto-assignment
+
+By default, the simple roulette only suggests reviewers in a comment. You can, optionally, configure it to automatically assign reviewers from the roulette to your merge requests.
+
+Configure `auto_assign_for_roulette_roles` to specify which roles to assign (`:reviewer`, `:maintainer`, or both). If empty (default), no auto-assignment occurs.
+
+Optionally, configure `auto_assign_for_roulette_labels` to only auto-assign for Merge Requests with specific labels. If empty (default), auto-assignment applies to all MRs.
+
+###### Examples
+
+``` ruby
+# Auto-assign reviewers for all MRs
+helper.config.auto_assign_for_roulette_roles = [:reviewer]
+
+# Auto-assign both reviewer and maintainer for all MRs
+helper.config.auto_assign_for_roulette_roles = [:reviewer, :maintainer]
+
+# Auto-assign reviewers only for a specific MR label
+helper.config.auto_assign_for_roulette_roles = [:reviewer]
+helper.config.auto_assign_for_roulette_labels = ["maintenance::dependency"]
+```
 
 ##### Available configurations
 

data/lib/danger/plugins/internal/helper.rb

@@ -185,7 +185,9 @@ module Danger
     # @return [{Symbol => Array<String>}] a hash of the type +{ category1: ["file1", "file2"], category2: ["file3", "file4"] }+
     #   using filename regex (+filename_regex+) and specific change regex (+changes_regex+) from the given +categories+ hash.
     def changes_by_category(categories = [])
-      all_changed_files.each_with_object(Hash.new { |h, k| h[k] = [] }) do |file, hash|
+      changed_and_deleted_files = all_changed_files + changes.deleted.files
+
+      changed_and_deleted_files.each_with_object(Hash.new { |h, k| h[k] = [] }) do |file, hash|
         categories_for_file(file, categories).each { |category| hash[category] << file }
       end
     end

data/lib/danger/plugins/roulette.rb

@@ -87,6 +87,35 @@ module Danger
       Gitlab::Dangerfiles::Teammate.warnings
     end
 
+    # Automatically assigns reviewers from roulette spins if configured to do so
+    #
+    # @param spins [Array<Spin>] The roulette spins to potentially assign from
+    def assign_reviewers_from_roulette(spins)
+      return if helper.mr_reviewers.any?
+
+      reviewers_to_assign = find_reviewers_to_assign(spins)
+
+      if reviewers_to_assign.any?
+        post_assignment_message(reviewers_to_assign)
+      else
+        warn("No reviewers available for assignment")
+      end
+    end
+
+    # Determines if auto-assignment should happen based on configuration
+    #
+    # @return [Boolean]
+    def auto_assign_reviewers?
+      return false if helper.config.auto_assign_for_roulette_roles.empty?
+
+      configured_labels = helper.config.auto_assign_for_roulette_labels
+
+      return true if configured_labels.empty?
+
+      mr_labels = helper.mr_labels
+      configured_labels.any? { |label| mr_labels.include?(label) }
+    end
+
     private
 
     def ux_fallback_reviewer
@@ -158,5 +187,41 @@ module Danger
     def labels
       @labels ||= helper.mr_labels
     end
+
+    # Find reviewers to assign based on configured roles
+    #
+    # @param spins [Array<Spin>] The roulette spins
+    # @return [Array<String>] Array of usernames to assign
+    def find_reviewers_to_assign(spins)
+      roles_to_assign = helper.config.auto_assign_for_roulette_roles
+      reviewers_to_assign = []
+
+      spins.each do |spin|
+        if roles_to_assign.include?(:reviewer) && spin.reviewer&.username
+          reviewers_to_assign << spin.reviewer.username
+        end
+
+        if roles_to_assign.include?(:maintainer) && spin.maintainer&.username
+          reviewers_to_assign << spin.maintainer.username
+        end
+
+        if reviewers_to_assign.any?
+          break
+        end
+      end
+
+      reviewers_to_assign
+    end
+
+    # Posts the assignment message with the selected reviewers
+    #
+    # @param reviewers_to_assign [Array<String>] Array of usernames to assign
+    def post_assignment_message(reviewers_to_assign)
+      role_text = helper.config.auto_assign_for_roulette_roles.map(&:to_s).join(' and ')
+      message = "🎲 Assigned #{role_text}s based on reviewer roulette.\n/assign_reviewer #{reviewers_to_assign.map { |u| "@#{u}" }.join(' ')}"
+      markdown(message)
+    rescue StandardError => e
+      warn("Failed to assign reviewers: #{e.message}")
+    end
   end
 end

data/lib/danger/rules/simple_roulette/Dangerfile

@@ -8,9 +8,6 @@ MESSAGE = <<MARKDOWN
 Changes that require review have been detected! A merge request is normally
 reviewed by both a reviewer and a maintainer in its primary category and by a
 maintainer in all other categories.
-MARKDOWN
-
-TABLE_MARKDOWN = <<MARKDOWN
 
 To spread load more evenly across eligible reviewers, Danger has picked a candidate for each
 review slot. Feel free to
@@ -26,9 +23,11 @@ Please consider assigning a reviewer or maintainer who is a
 [domain expert](https://about.gitlab.com/handbook/engineering/projects/##{PROJECT_NAME})
 in the area of the merge request.
 
+MARKDOWN
+
+NO_AUTO_ASSIGN = <<MARKDOWN
 Once you've decided who will review this merge request, mention them as you
 normally would! Danger does not automatically notify them for you.
-
 MARKDOWN
 
 TABLE_HEADER_WITH_CATEGORIES = <<MARKDOWN
@@ -101,5 +100,11 @@ if changes.any?
 
   markdown(format(WARNING_MESSAGE, warnings: warnings)) if warnings
 
-  markdown(TABLE_MARKDOWN + table_header + rows.join("\n")) unless rows.empty?
+  markdown(table_header + rows.join("\n")) unless rows.empty?
+
+  if roulette.auto_assign_reviewers?
+    roulette.assign_reviewers_from_roulette(random_roulette_spins)
+  else
+    markdown(NO_AUTO_ASSIGN)
+  end
 end

data/lib/gitlab/dangerfiles/config.rb

@@ -55,6 +55,14 @@ module Gitlab
       #   @return [Array] indicating which required codeowners sections should be excluded from roulette. Default to `[]`.
       attr_accessor :excluded_required_codeowners_sections_for_roulette
 
+      # @!attribute auto_assign_for_roulette_roles
+      #   @return [Array<Symbol>] which roles to auto assign as reviewers, given roulette recommendations (:reviewer, :maintainer, or both). If empty, auto-assignment is disabled. Default to `[]`.
+      attr_accessor :auto_assign_for_roulette_roles
+
+      # @!attribute auto_assign_for_roulette_labels
+      #   @return [Array<String>] MR labels that allow auto reviewer assignment. If empty, applies to all MRs, provided :auto_assign_for_roulette_roles is not empty. Default to `[]`.
+      attr_accessor :auto_assign_for_roulette_labels
+
       DEFAULT_CHANGES_SIZE_THRESHOLDS = { high: 2_000, medium: 500 }.freeze
       DEFAULT_COMMIT_MESSAGES_MAX_COMMITS_COUNT = 10
 
@@ -69,6 +77,8 @@ module Gitlab
         @disabled_roulette_categories = []
         @included_optional_codeowners_sections_for_roulette = []
         @excluded_required_codeowners_sections_for_roulette = []
+        @auto_assign_for_roulette_roles = []
+        @auto_assign_for_roulette_labels = []
         @duo_code_review = :optional
       end
     end

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "4.9.2"
+    VERSION = "4.10.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 4.9.2
+  version: 4.10.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-05-26 00:00:00.000000000 Z
+date: 2025-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake