gitlab-dangerfiles 4.8.1 → 4.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b42206a72b735d7a0016622666b37571d85d541a758d5454fbca3260e359f1f2
-  data.tar.gz: ac570434fc3dee200d7656a557668454e2ceb5719c43d49b80c364688d3d0e13
+  metadata.gz: 053ccbe5f18fd65ff059c590e4de66d82b8632aa368453f48e5be40bba809e47
+  data.tar.gz: 104c829cb3c5e1113fb890885abdac06e413d7076b45f26ee406b3d6d38f1fed
 SHA512:
-  metadata.gz: '030678a153058f6c0ab3fdb198d109ca43b8693f763a6259585b2864c7d688faec108dbbe93285226a7b926ab6f99423b6b57d703f83004b588df27917582d22'
-  data.tar.gz: 7a3398d6bc48bdbd28a43329c311088c211b6343e00200a782b0eef9503dae39befeaaa139710847d3a674e1032508b8c938ef889f7907d9739548919fa12c97
+  metadata.gz: 1b0098a095fb630bb6301e2ad78c8d0709b4fdab22de3fb929a306954dd87026f4111e48f17d19d94fc7d62906f9ac413e0879d91df47c976622854b3dd63dca
+  data.tar.gz: 44009f0ea1dc871c36608df7ee2d3d3a28f7c92692573c54781b8fecc36e37965fed1d972004cfef2539904f07820eabf84c06bea8216b12264e36d6732a3951

data/.gitignore

@@ -12,3 +12,4 @@
 
 # rspec failure tracking
 .rspec_status
+.idea

data/.gitlab/merge_request_templates/Release.md

@@ -2,7 +2,7 @@
 commit from this merge request, and `<NEW_VERSION>` with the upcoming version number. -->
 ## Diff
 
-https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/compare/v<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
+https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/compare/<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
 
 ## Checklist
 

data/.gitlab-ci.yml

@@ -23,12 +23,13 @@ default:
       - vendor/ruby
 
 .default-test-job:
-  image: "ruby:${RUBY_VERSION}"
+  image: "${GITLAB_DEPENDENCY_PROXY}ruby:${RUBY_VERSION}"
   stage: test
   needs: []
   before_script:
     - gem install bundler
-    - bundle install -j $(nproc) --path vendor
+    - bundle config set path 'vendor'
+    - bundle install -j $(nproc)
   parallel:
     matrix:
       - RUBY_VERSION: ['3.0', '3.1', '3.2']

data/.rubocop.yml

@@ -16,8 +16,17 @@ Rails:
 CodeReuse/ActiveRecord:
   Enabled: false
 
-Layout/LineLength:
-  Enabled: false
+RSpec/ContextWording:
+  Prefixes:
+    - 'when'
+    - 'with'
+    - 'without'
+    - 'for'
+    - 'and'
+    - 'on'
+    - 'in'
+    - 'as'
+    - 'if'
 
 RSpec/MultipleMemoizedHelpers:
   Max: 35

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2023-01-12 11:28:46 UTC using RuboCop version 1.36.0.
+# `rubocop --auto-gen-config --no-exclude-limit`
+# on 2025-09-22 19:54:32 UTC using RuboCop version 1.43.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,7 +11,7 @@ Fips/MD5:
   Exclude:
     - 'lib/danger/plugins/roulette.rb'
 
-# Offense count: 3
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
 # Include: **/*.gemspec
@@ -21,27 +21,19 @@ Gemspec/OrderedDependencies:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Include.
+# Configuration parameters: Severity, Include.
 # Include: **/*.gemspec
 Gemspec/RequireMFA:
   Exclude:
     - 'gitlab-dangerfiles.gemspec'
 
 # Offense count: 1
-# Configuration parameters: Include.
+# Configuration parameters: Severity, Include.
 # Include: **/*.gemspec
 Gemspec/RequiredRubyVersion:
   Exclude:
     - 'gitlab-dangerfiles.gemspec'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith, Severity.
-# SupportedStylesAlignWith: start_of_line, begin
-Layout/BeginEndAlignment:
-  Exclude:
-    - 'lib/danger/plugins/roulette.rb'
-
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 Layout/ElseAlignment:
@@ -60,14 +52,12 @@ Layout/EndAlignment:
     - 'lib/danger/plugins/internal/helper.rb'
     - 'lib/gitlab/dangerfiles/teammate.rb'
 
-# Offense count: 6
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
+# Configuration parameters: IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_brackets
 Layout/FirstArrayElementIndentation:
-  Exclude:
-    - 'spec/danger/plugins/roulette_spec.rb'
-    - 'spec/gitlab/dangerfiles_spec.rb'
+  EnforcedStyle: consistent
 
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
@@ -86,12 +76,6 @@ Layout/LineEndStringConcatenationIndentation:
   Exclude:
     - 'lib/gitlab/dangerfiles/commit_linter.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/RescueEnsureAlignment:
-  Exclude:
-    - 'lib/danger/plugins/roulette.rb'
-
 # Offense count: 11
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperatorPrecedence:
@@ -107,12 +91,6 @@ Lint/BinaryOperatorWithIdenticalOperands:
   Exclude:
     - 'spec/gitlab/dangerfiles/teammate_spec.rb'
 
-# Offense count: 2
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
-Lint/DuplicateBranch:
-  Exclude:
-    - 'lib/danger/plugins/roulette.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Lint/DuplicateRegexpCharacterClassElement:
@@ -148,28 +126,20 @@ Naming/FileName:
   Exclude:
     - 'lib/gitlab-dangerfiles.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredName.
 Naming/RescuedExceptionsVariableName:
   Exclude:
     - 'lib/danger/plugins/changelog.rb'
-    - 'lib/danger/plugins/roulette.rb'
 
-# Offense count: 2
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'spec/danger/plugins/roulette_spec.rb'
-
-# Offense count: 5
+# Offense count: 3
 Performance/MethodObjectAsBlock:
   Exclude:
-    - 'lib/danger/plugins/roulette.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
+# Offense count: 14
+# This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Exclude:
     - 'spec/danger/plugins/changelog_spec.rb'
@@ -184,7 +154,7 @@ RSpec/BeNil:
   Exclude:
     - 'spec/gitlab/dangerfiles/version_spec.rb'
 
-# Offense count: 24
+# Offense count: 21
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -206,7 +176,7 @@ RSpec/EmptyLineAfterLetBlock:
   Exclude:
     - 'spec/danger/plugins/internal/helper_spec.rb'
 
-# Offense count: 7
+# Offense count: 8
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/danger/plugins/internal/helper_spec.rb'
@@ -218,39 +188,28 @@ RSpec/HooksBeforeExamples:
     - 'spec/danger/plugins/changelog_spec.rb'
     - 'spec/danger/plugins/roulette_spec.rb'
 
-# Offense count: 22
+# Offense count: 20
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_line_only, single_statement_only, disallow
+# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
 RSpec/ImplicitSubject:
   Exclude:
     - 'spec/danger/plugins/changelog_spec.rb'
     - 'spec/danger/plugins/internal/helper_spec.rb'
-    - 'spec/danger/plugins/roulette_spec.rb'
 
-# Offense count: 27
+# Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/LetBeforeExamples:
   Exclude:
     - 'spec/danger/plugins/internal/helper_spec.rb'
     - 'spec/danger/plugins/roulette_spec.rb'
 
-# Offense count: 51
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
-  Exclude:
-    - 'spec/danger/plugins/changelog_spec.rb'
-    - 'spec/danger/plugins/internal/helper_spec.rb'
-    - 'spec/gitlab/dangerfiles/teammate_spec.rb'
-
 # Offense count: 2
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
     - 'spec/gitlab/dangerfiles/commit_linter_spec.rb'
 
-# Offense count: 33
+# Offense count: 37
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
@@ -276,12 +235,11 @@ Style/ExpandPathArguments:
   Exclude:
     - 'gitlab-dangerfiles.gemspec'
 
-# Offense count: 4
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedVars.
 Style/FetchEnvVar:
   Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
     - 'lib/danger/rules/z_retry_link/Dangerfile'
     - 'lib/gitlab/dangerfiles/config.rb'
 
@@ -294,21 +252,32 @@ Style/FormatString:
     - 'lib/danger/rules/simple_roulette/Dangerfile'
     - 'lib/gitlab/dangerfiles/base_linter.rb'
 
-# Offense count: 16
+# Offense count: 17
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 2
-# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
-Style/GuardClause:
   Exclude:
-    - 'lib/danger/rules/type_label/Dangerfile'
+    - 'Dangerfile'
+    - 'Gemfile'
+    - 'Guardfile'
+    - 'Rakefile'
+    - 'gitlab-dangerfiles.gemspec'
+    - 'lib/danger/rules/z_add_labels/Dangerfile'
+    - 'lib/danger/rules/z_retry_link/Dangerfile'
+    - 'lib/gitlab-dangerfiles.rb'
+    - 'lib/gitlab/Dangerfile'
+    - 'lib/gitlab/dangerfiles.rb'
+    - 'lib/gitlab/dangerfiles/commit_messages_helper.rb'
+    - 'lib/gitlab/dangerfiles/spec_helper.rb'
+    - 'lib/gitlab/dangerfiles/task_loader.rb'
+    - 'lib/gitlab/dangerfiles/version.rb'
+    - 'spec/gitlab/dangerfiles/version_spec.rb'
+    - 'spec/spec_helper.rb'
+    - 'spec/support/danger_spec_helper.rb'
 
 # Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/HashExcept:
   Exclude:
     - 'lib/gitlab/dangerfiles.rb'
@@ -322,34 +291,24 @@ Style/HashSyntax:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowIfModifier.
-Style/IfInsideElse:
-  Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
-
-# Offense count: 22
+# Offense count: 18
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Exclude:
     - 'lib/danger/plugins/changelog.rb'
     - 'lib/danger/plugins/roulette.rb'
-    - 'lib/danger/rules/commit_messages/Dangerfile'
-    - 'lib/danger/rules/commits_counter/Dangerfile'
     - 'lib/danger/rules/simple_roulette/Dangerfile'
     - 'lib/danger/rules/z_retry_link/Dangerfile'
     - 'lib/gitlab/dangerfiles.rb'
     - 'lib/gitlab/dangerfiles/base_linter.rb'
     - 'lib/gitlab/dangerfiles/commit_linter.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
     - 'lib/danger/rules/simple_roulette/Dangerfile'
     - 'lib/gitlab/dangerfiles/version.rb'
 
@@ -370,7 +329,7 @@ Style/NumericPredicate:
     - 'lib/danger/plugins/roulette.rb'
     - 'lib/gitlab/dangerfiles/teammate.rb'
 
-# Offense count: 8
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -381,7 +340,7 @@ Style/PercentLiteralDelimiters:
     - 'lib/gitlab/dangerfiles/tasks/main.rake'
     - 'spec/danger/plugins/internal/helper_spec.rb'
 
-# Offense count: 4
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: .
 # SupportedStyles: same_as_string_literals, single_quotes, double_quotes
@@ -405,7 +364,7 @@ Style/RedundantFreeze:
     - 'lib/gitlab/dangerfiles/emoji_checker.rb'
     - 'lib/gitlab/dangerfiles/title_linting.rb'
 
-# Offense count: 4
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantRegexpEscape:
   Exclude:
@@ -413,13 +372,7 @@ Style/RedundantRegexpEscape:
     - 'lib/gitlab/dangerfiles/emoji_checker.rb'
     - 'lib/gitlab/dangerfiles/title_linting.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
-
-# Offense count: 2
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
@@ -434,7 +387,7 @@ Style/RescueModifier:
   Exclude:
     - 'lib/gitlab/dangerfiles/commit_linter.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
@@ -442,15 +395,6 @@ Style/RescueStandardError:
   Exclude:
     - 'lib/danger/plugins/changelog.rb'
     - 'lib/danger/plugins/internal/helper.rb'
-    - 'lib/danger/plugins/roulette.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -458,14 +402,6 @@ Style/SelectByRegexp:
   Exclude:
     - 'lib/danger/plugins/internal/helper.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: only_raise, only_fail, semantic
-Style/SignalException:
-  Exclude:
-    - 'lib/danger/rules/type_label/Dangerfile'
-
 # Offense count: 7
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Mode.
@@ -475,35 +411,24 @@ Style/StringConcatenation:
     - 'spec/gitlab/dangerfiles/commit_linter_spec.rb'
     - 'spec/gitlab/merge_request_linter_spec.rb'
 
-# Offense count: 7
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiteralsInInterpolation:
   Exclude:
     - 'lib/danger/plugins/internal/helper.rb'
-    - 'lib/danger/plugins/roulette.rb'
-    - 'lib/danger/rules/commit_messages/Dangerfile'
     - 'spec/gitlab/dangerfiles/teammate_spec.rb'
 
-# Offense count: 2
+# Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, IgnoredMethods, AllowComments.
-# AllowedMethods: respond_to, define_method
+# AllowedMethods: define_method, mail, respond_to
 Style/SymbolProc:
   Exclude:
-    - 'lib/danger/rules/commit_messages/Dangerfile'
     - 'spec/gitlab/dangerfiles_spec.rb'
 
-# Offense count: 19
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'spec/danger/plugins/roulette_spec.rb'
-
-# Offense count: 24
+# Offense count: 25
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -520,7 +445,9 @@ Style/TrailingCommaInArrayLiteral:
     - 'spec/gitlab/dangerfiles/weightage/maintainers_spec.rb'
     - 'spec/gitlab/dangerfiles/weightage/reviewers_spec.rb'
 
-Style/ArrayIntersect:
-  Exclude:
-    - 'lib/gitlab/dangerfiles/category.rb'
-    - 'lib/danger/plugins/changelog.rb'
+# Offense count: 111
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 374

data/.tool-versions

@@ -0,0 +1 @@
+ruby 3.2.9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-dangerfiles (4.8.1)
+    gitlab-dangerfiles (4.12.0)
       danger (>= 9.3.0)
       danger-gitlab (>= 8.0.0)
       rake (~> 13.0)
@@ -117,6 +117,7 @@ GEM
     parallel (1.22.1)
     parser (3.2.1.0)
       ast (~> 2.4.1)
+      racc
     proc_to_ast (0.1.0)
       coderay
       parser
@@ -125,6 +126,7 @@ GEM
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (5.0.1)
+    racc (1.8.1)
     rack (3.0.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
@@ -220,6 +222,7 @@ DEPENDENCIES
   gitlab-styles (~> 10.0)
   guard-rspec (~> 4.7.3)
   lefthook (~> 1.3)
+  racc (~> 1.8)
   rspec (~> 3.8)
   rspec-parameterized
   rubocop-rails (< 2.21.2)

data/README.md

@@ -171,6 +171,15 @@ This rule ensures the merge request isn't too big to be reviewed, otherwise it s
 
 This rule posts a failure if the merge request has more than 20 commits.
 
+#### `danger_code_review`
+
+This rule posts a warning/failure when `@GitLabDuo` isn't assigned as a reviewer.
+
+##### Available configurations
+
+- `duo_code_review`: Whether a review from GitLab Duo Code is `:mandatory` or `:optional`.
+  Default to `:optional`.
+
 #### `metadata`
 
 This rule ensures basic metadata such as assignee, milestone and description are set on the merge request.
@@ -193,6 +202,38 @@ project. To use it in your project, perform the following steps:
      dangerfiles.import_dangerfiles(only: %w[simple_roulette])
    end
    ```
+   
+##### Auto-assignment
+
+By default, the simple roulette only suggests reviewers in a comment. You can, optionally, configure it to automatically assign reviewers from the roulette to your merge requests.
+
+Configure `auto_assign_for_roulette_roles` to specify which roles to assign (`:reviewer`, `:maintainer`, or both). If empty (default), no auto-assignment occurs.
+
+Optionally, configure `auto_assign_for_roulette_labels` to only auto-assign for Merge Requests with specific labels. If empty (default), auto-assignment applies to all MRs.
+
+###### Examples
+
+``` ruby
+# Auto-assign reviewers for all MRs
+helper.config.auto_assign_for_roulette_roles = [:reviewer]
+
+# Auto-assign both reviewer and maintainer for all MRs
+helper.config.auto_assign_for_roulette_roles = [:reviewer, :maintainer]
+
+# Auto-assign reviewers only for a specific MR label
+helper.config.auto_assign_for_roulette_roles = [:reviewer]
+helper.config.auto_assign_for_roulette_labels = ["maintenance::dependency"]
+```
+
+##### Available configurations
+
+Note: These options aren't actually used in the `simple_roulette` rule, but can be used in your own
+implementation of the roulette if you use `roulette.required_approvals`/`roulette.codeowners_approvals`.
+
+- `included_optional_codeowners_sections_for_roulette`: Indicates which optional codeowners sections
+  should be included in roulette. Default to `[]`.
+- `excluded_required_codeowners_sections_for_roulette`: Indicates which required codeowners sections
+  should be excluded from roulette. Default to `[]`.
 
 #### `type_label`
 
@@ -281,6 +322,16 @@ To run the Danger Rake task in a project that doesn't have `master` as the defau
 DANGER_LOCAL_BASE="origin/main" bundle exec rake danger_local
 ```
 
+## Warnings vs Errors
+
+The following lint violations generate warnings:
+
+1. The commit subject is too short ([code](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/bccb167/lib/gitlab/dangerfiles/base_linter.rb#L74-76)).
+1. The commit changes too many lines across too many files without describing the changes in the commit body ([code](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/bccb167/lib/gitlab/dangerfiles/commit_linter.rb#L83-85)).
+1. The commit body contains too many characters per line ([code](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/bccb167/lib/gitlab/dangerfiles/commit_linter.rb#L87-96)).
+
+All other lint violations generate errors, except when the MR has [Squash commits when merge request is accepted](https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html#squash-commits-in-a-merge-request) enabled, which downgrades lint violations to warnings.
+
 ## Documentation
 
 Latest documentation can be found at <https://www.rubydoc.info/gems/gitlab-dangerfiles>.
@@ -307,8 +358,8 @@ For example, to test `gitlab-dangerfiles` changes from the `your-branch-name` br
 
 ```ruby
 group :development, :test, :danger do
-  gem 'gitlab-dangerfiles', '~> 3.4.3', require: false,
-  git: 'https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles.git',
+  gem 'gitlab-dangerfiles', require: false, feature_category: :tooling,
+  git: 'https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles.git', # rubocop:disable Cop/GemFetcher -- Testing unreleased changes
   ref: 'your-branch-name'
 end
 ```

data/gitlab-dangerfiles.gemspec

@@ -37,6 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "lefthook", "~> 1.3"
   spec.add_development_dependency "rspec-parameterized"
   spec.add_development_dependency "rspec", "~> 3.8"
+  spec.add_development_dependency "racc", "~> 1.8"
   # we do not commit the bundle lockfile, so this temporary workaround needs to be
   # present until 2.21.3 or 2.22.x is released
   # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/63

data/lefthook.yml

@@ -12,3 +12,8 @@ pre-push:
     rubocop:
       run: bundle exec rubocop
       glob: '*.rb'
+
+    danger:
+      files: git diff --name-only $(git merge-base origin/master HEAD)..HEAD
+      # We need to specify {files} as part of the command, otherwise it won't execute the hook
+      run: echo {files} >/dev/null && bundle exec danger dry_run