gitlab-dangerfiles 4.13.0 → 4.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90d11c90b2540e75f8664f62f9e8dca94f3a1ad9da4454af946d578ba5d06bd4
-  data.tar.gz: c3319c3df8c5bdc2fd9a9f1a409da791615b516272872eaf06f4fc1b1f0a6f73
+  metadata.gz: e62a200646d128a780ee1e17bb644f5fe296fef2f530631ebdabe677a2eea93f
+  data.tar.gz: 73aec620889b66c1c7f61fe845ab2b43c528c21301ed7b1bb4a8b6ad6e93656b
 SHA512:
-  metadata.gz: 943f6712c05394b8476f22eb937ebc5267c570e64e4ef2eb9414404353d92ff69dae10dfece405e6d2cbb7b4f117c873ec3b57998d5cf3db620ad8de239dc931
-  data.tar.gz: fd05d33d287a9d6661bd8cadc59613e9ad717427c22dfd97ed14be94cfa90c71b8f0d46b43a4135a07348acf3d173f4fe38183e5164e5afb4cca192630c8eb87
+  metadata.gz: cfaa1d404d59cb656354135dd146d6ea908046f51430fd5d4f7d9aa83f13446bed69f7dc21b018a8f9e6154b6a65b5abf0a3fc90c6863986702b2b64403ffa81
+  data.tar.gz: 6300e9593543c6f635ced6fb6b1c9d04773bf1baac66d0dbc7bb2957607196f094d2a429e2372c64dcdbc31b331047e40ac387e2b99bd7b2777d52956c3e6b25

data/CONTRIBUTING.md

@@ -6,7 +6,7 @@ Except for the license granted herein to GitLab B.V. and recipients of software
 distributed by GitLab B.V., you reserve all right, title, and interest in and to
 your Contributions.
 
-All contributions are subject to the Developer Certificate of Origin and license set out at [docs.gitlab.com/ce/legal/developer_certificate_of_origin](https://docs.gitlab.com/ce/legal/developer_certificate_of_origin).
+All contributions are subject to the Developer Certificate of Origin and license set out at [docs.gitlab.com/legal/developer_certificate_of_origin](https://docs.gitlab.com/legal/developer_certificate_of_origin/).
 
 _This notice should stay as the first item in the CONTRIBUTING.md file._
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-dangerfiles (4.13.0)
+    gitlab-dangerfiles (4.14.0)
       danger (>= 9.3.0)
       danger-gitlab (>= 8.0.0)
       rake (~> 13.0)

data/README.md

@@ -148,7 +148,7 @@ Danger rules are located under `lib/danger/rules`.
 
 #### `changelog`
 
-This rule ensures the merge request follows our [Changelog guidelines](https://docs.gitlab.com/ee/development/changelog.html#changelog-entries).
+This rule ensures the merge request follows our [Changelog guidelines](https://docs.gitlab.com/development/changelog/).
 
 #### `changes_size`
 
@@ -281,7 +281,7 @@ include:
   - component: gitlab.com/gitlab-org/components/danger-review/danger-review@~latest
 ```
 
-3. Create a [Project or group access token](https://docs.gitlab.com/ee/user/project/settings/project_access_tokens.html)
+3. Create a [Project or group access token](https://docs.gitlab.com/user/project/settings/project_access_tokens/)
    with scope `api` and role `Developer`.
 4. Add a [CI/CD variable](https://docs.gitlab.com/ee/ci/variables/#add-a-cicd-variable-to-a-project)
    `DANGER_GITLAB_API_TOKEN` (`Masked` but not `Protected`) and use Project access token as value.
@@ -292,7 +292,7 @@ See a [real world example](https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles
 
 Danger is a Ruby project and uses [`bundler`](https://bundler.io/) to manage
 its dependencies. This requires a project to have a `Gemfile` and
-`Gemfile.lock` commited. This is helpful especially if Danger is also used
+`Gemfile.lock` committed. This is helpful especially if Danger is also used
 locally - with `lefthook`, for example.
 
 You don't need a `Gemfile` to use the `danger-review` component. If your project
@@ -343,7 +343,7 @@ The following lint violations generate warnings:
 1. The commit changes too many lines across too many files without describing the changes in the commit body ([code](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/bccb167/lib/gitlab/dangerfiles/commit_linter.rb#L83-85)).
 1. The commit body contains too many characters per line ([code](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/bccb167/lib/gitlab/dangerfiles/commit_linter.rb#L87-96)).
 
-All other lint violations generate errors, except when the MR has [Squash commits when merge request is accepted](https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html#squash-commits-in-a-merge-request) enabled, which downgrades lint violations to warnings.
+All other lint violations generate errors, except when the MR has [Squash commits when merge request is accepted](https://docs.gitlab.com/user/project/merge_requests/squash_and_merge/#squash-commits-in-a-merge-request) enabled, which downgrades lint violations to warnings.
 
 ## Documentation
 
@@ -381,9 +381,9 @@ See an [example](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92580) fo
 
 ## Contributing
 
-Bug reports and merge requests are welcome at https://gitlab.com/gitlab-org/gitlab-dangerfiles. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://gitlab.com/gitlab-org/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).
+Bug reports and merge requests are welcome at https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).
 
-Make sure to include a changelog entry in your commit message and read the [changelog entries section](https://docs.gitlab.com/ee/development/changelog.html).
+Make sure to include a changelog entry in your commit message and read the [changelog entries section](https://docs.gitlab.com/development/changelog/).
 
 ## Release
 
@@ -415,4 +415,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the Gitlab::Danger project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://gitlab.com/gitlab-org/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Gitlab::Danger project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).

data/lefthook.yml

@@ -1,5 +1,5 @@
 # Lefthook configuration. For more information, see:
-# https://github.com/Arkweid/lefthook/blob/master/docs/full_guide.md
+# https://lefthook.dev/configuration/
 
 pre-push:
   commands:

data/lib/danger/plugins/changelog.rb

@@ -13,34 +13,34 @@ module Danger
     NO_CHANGELOG_CATEGORIES = %i[docs none].freeze
     CHANGELOG_TRAILER_REGEX = /^(?<name>Changelog):\s*(?<category>.+)$/i.freeze
     CHANGELOG_EE_TRAILER_REGEX = /^EE: true$/.freeze
-    CHANGELOG_MODIFIED_URL_TEXT = "**CHANGELOG.md was edited.** Please remove the additions and follow the [changelog guidelines](https://docs.gitlab.com/ee/development/changelog.html).\n\n"
-    CHANGELOG_MISSING_URL_TEXT = "**[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:\n\n"
+    CHANGELOG_MODIFIED_URL_TEXT = "**CHANGELOG.md was edited.** Please remove the additions and follow the [changelog guidelines](https://docs.gitlab.com/development/changelog/).\n\n"
+    CHANGELOG_MISSING_URL_TEXT = "**[CHANGELOG missing](https://docs.gitlab.com/development/changelog/)**:\n\n"
     IF_REVERT_MR_TEXT = <<~MARKDOWN
-      In a revert merge request? Use the revert merge request template to add labels [that skip changelog checks](https://docs.gitlab.com/ee/development/pipelines#revert-mrs).
+      In a revert merge request? Use the revert merge request template to add labels [that skip changelog checks](https://docs.gitlab.com/development/pipelines/#revert-mrs).
 
       Reverting something in the current milestone? A changelog isn't required. Skip changelog checks by adding `~"regression:*"` label, then re-run the danger job (there is a link at the bottom of this comment).
     MARKDOWN
 
     OPTIONAL_CHANGELOG_MESSAGE = {
-      local: "If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.",
+      local: "If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/development/changelog/#what-warrants-a-changelog-entry), feel free to ignore this message.",
       ci: <<~MSG
         If this merge request needs a changelog entry, add the `Changelog` trailer to the commit message you want to add to the changelog.
 
-        If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.
+        If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/development/changelog/#what-warrants-a-changelog-entry), feel free to ignore this message.
       MSG
     }.freeze
-    SEE_DOC = "See the [changelog documentation](https://docs.gitlab.com/ee/development/changelog.html)."
+    SEE_DOC = "See the [changelog documentation](https://docs.gitlab.com/development/changelog/)."
 
     REQUIRED_CHANGELOG_REASONS = {
       db_changes: "introduces a database migration",
       feature_flag_removed: "removes a feature flag"
     }.freeze
     REQUIRED_CHANGELOG_MESSAGE = {
-      local: "This merge request requires a changelog entry because it [%<reason>s](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry).",
+      local: "This merge request requires a changelog entry because it [%<reason>s](https://docs.gitlab.com/development/changelog/#what-warrants-a-changelog-entry).",
       ci: <<~MSG
         To create a changelog entry, add the `Changelog` trailer to one of your Git commit messages.
 
-        This merge request requires a changelog entry because it [%<reason>s](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry).
+        This merge request requires a changelog entry because it [%<reason>s](https://docs.gitlab.com/development/changelog/#what-warrants-a-changelog-entry).
       MSG
     }.freeze
     DEFAULT_CHANGELOG_CATEGORIES = %w[
@@ -191,7 +191,7 @@ module Danger
       ee_changes = helper.changed_files(%r{\Aee/})
 
       if ee_changes.any? && !ee_changelog? && !required?
-        check_result.warning("This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/ee/development/changelog.html#gitlab-enterprise-changes). Consider adding it to your Changelog commits.")
+        check_result.warning("This MR changes code in `ee/`, but its Changelog commit is missing the [`EE: true` trailer](https://docs.gitlab.com/development/changelog/#gitlab-enterprise-changes). Consider adding it to your Changelog commits.")
       end
 
       if ee_changes.empty? && ee_changelog?
@@ -199,7 +199,7 @@ module Danger
       end
 
       if ee_changes.any? && ee_changelog? && required_reasons.include?(:db_changes) && non_ee_database_migration_changes?
-        check_result.warning("This MR has a Changelog commit with the `EE: true` trailer, but there are database changes which [requires](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry) the Changelog commit to not have the `EE: true` trailer. Consider removing the `EE: true` trailer from your commits.")
+        check_result.warning("This MR has a Changelog commit with the `EE: true` trailer, but there are database changes which [requires](https://docs.gitlab.com/development/changelog/#what-warrants-a-changelog-entry) the Changelog commit to not have the `EE: true` trailer. Consider removing the `EE: true` trailer from your commits.")
       end
 
       check_result

data/lib/danger/plugins/commit_messages.rb

@@ -7,7 +7,7 @@ module Danger
   # Common helper functions for our danger scripts. See Danger::Helper
   # for more details
   class CommitMessages < Danger::Plugin
-    COMMIT_MSG_DOC = "https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines"
+    COMMIT_MSG_DOC = "https://docs.gitlab.com/development/contributing/merge_request_workflow/#commit-messages-guidelines"
     MORE_INFO = "For more information, take a look at our [Commit message guidelines](#{COMMIT_MSG_DOC}).".freeze
     THE_DANGER_JOB_TEXT = "the `%<job_name>s` job"
     MAX_COMMITS_COUNT_EXCEEDED_MESSAGE = <<~MSG

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -7,6 +7,7 @@ module Gitlab
     class BaseLinter
       MIN_SUBJECT_WORDS_COUNT = 3
       MAX_LINE_LENGTH = 72
+      PREFIX_REGEX = /\A(\[[^\]]+\]|[^:\s]+:)\s/
 
       attr_reader :commit, :problems
 
@@ -92,11 +93,17 @@ module Gitlab
         return false if subject_starts_with_a_space?
         return false if ("A".."Z").cover?(subject[0])
 
-        first_char = subject.sub(/\A(\[[^\]]+\]|[^:\s]+:)\s/, "")[0]
-        first_char_downcased = first_char.downcase
-        return true unless ("a".."z").cover?(first_char_downcased)
+        if PREFIX_REGEX.match?(subject)
+          first_char = subject.sub(PREFIX_REGEX, "")[0]
+          return true if first_char.nil?
 
-        first_char.downcase == first_char
+          first_char_downcased = first_char.downcase
+          return true unless ("a".."z").cover?(first_char_downcased)
+
+          false
+        else
+          true
+        end
       end
 
       def subject_ends_with_a_period?

data/lib/gitlab/dangerfiles/title_linting.rb

@@ -3,7 +3,10 @@
 module Gitlab
   module Dangerfiles
     module TitleLinting
-      DRAFT_REGEX = /\A*#{Regexp.union(/(?i)(\[WIP\]\s*|WIP:\s*|WIP$)/, /(?i)(\[draft\]|\(draft\)|draft:|draft\s\-\s|draft$)/)}+\s*/i.freeze
+      # Matches the markers a title starts with, one or several in a row, and
+      # a WIP or draft it ends with. The same markers anywhere else in a title
+      # are part of its text.
+      DRAFT_REGEX = /\A(?:(?:\[WIP\]|WIP:|\[draft\]|\(draft\)|draft:|draft\s-\s)\s*)+|(?:WIP|draft)\z/i.freeze
       CHERRY_PICK_REGEX = /cherry[\s-]*pick/i.freeze
       RUN_ALL_RSPEC_REGEX = /RUN ALL RSPEC/i.freeze
       RUN_AS_IF_FOSS_REGEX = /RUN AS-IF-FOSS/i.freeze

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "4.13.0"
+    VERSION = "4.14.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 4.13.0
+  version: 4.14.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-10-09 00:00:00.000000000 Z
+date: 2026-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake