gitlab-dangerfiles 3.6.7 → 3.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8d0bdb87447c7436d0814db68d0e65423a2d693a2d89abdf59331cff1287253
-  data.tar.gz: b79304e093b0be5dc9d0609b957c318c4e672b48a49263624bb9b3922885dfe4
+  metadata.gz: 2c8b3755415a3a732fc13c70da4176927062a9d5b6452a7d2513d3ef29617c89
+  data.tar.gz: 1822e18dcc9e51d93f0ea1f3df574aaf5c1dd5ec1b0fd552bfea34f8b114971d
 SHA512:
-  metadata.gz: 3173b6d8ec73814d7b0d3fdcf32270178fc76b38024ab4ba41cf106589f5f7fa4b9f0dfea9cb8fc9213b011c39691a695948caaca58455b80135e6c9af13d071
-  data.tar.gz: f0922b64b753e15aff30716ca1a6ade6afc6b74bbeda983dfa29190a382990e7d21311175b058f3ef26d7071273426a5ea66e8a8843a57f18411e284f07fe38c
+  metadata.gz: d86af6131e0703fcab736fb75f09b62d1e656bec379f76f8bee6223899e99b34a085c86dc94d7c6d99ce88642acbea4d9079050ab50331abbc10d6c47c0fcc76
+  data.tar.gz: dc878dcd339bed44e0cb4059ec965cce1f6e0513099002126779640c3f8986417bbfabdbbec1ffd4137729839d682d8f7bc6f69cf1654ee03b9a75007f561f93

data/.rubocop.yml

@@ -38,6 +38,10 @@ Style/StringLiterals:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
+# To respect rufo formatting
+Style/TrailingCommaInArguments:
+  Enabled: false
+
 # To respect rufo formatting
 Layout/MultilineOperationIndentation:
   Enabled: false

data/lib/danger/plugins/changelog.rb

@@ -134,7 +134,7 @@ module Danger
     def critical_checks
       check_result = ChangelogCheckResult.empty
 
-      check_result.error(modified_text) if git.modified_files.include?("CHANGELOG.md")
+      check_result.warning(modified_text) if git.modified_files.include?("CHANGELOG.md")
 
       # Help the user to apply the correct labels to skip this danger check in case it's a revert MR
       check_result.warning(IF_REVERT_MR_TEXT) if helper.revert_mr?

data/lib/gitlab/dangerfiles/category.rb

@@ -92,11 +92,46 @@ module Gitlab
       class UX < Category
         private
 
+        def has_particular_capability?(teammate)
+          if labels.any?("Community contribution")
+            can_review_wider_community_contribution?(teammate)
+          else
+            super
+          end
+        end
+
         def has_universal_capability?(teammate)
-          teammate.projects.each_value.find do |capabilities|
+          # No universal reviewer for community contribution.
+          # If we do, then picking from corresponding group won't be accurate.
+          # After solving the following issue, then we can revisit this:
+          # https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/issues/58
+          return false if labels.any?("Community contribution")
+
+          teammate.projects.each_value.any? do |capabilities|
             capabilities.include?(capability)
           end
         end
+
+        def can_review_wider_community_contribution?(teammate)
+          # Pick corresponding group for community contribution
+          # Role can be:
+          # Product Designer, Create:Source Code
+          # Product Designer, Verify:Pipeline Insights, Verify:Runner
+          # Product Designer, Release
+          # Specialty can be:
+          # Source Code
+          # [Growth: Activation, Growth: Expansion]
+          # Runner
+          areas = teammate.role[/Product Designer(?:.*?, (.+))/, 1]&.split(",")
+
+          group_labels = [*teammate.specialty, *areas].map do |field|
+            group = field.strip.sub(/^.+: ?/, "").downcase
+
+            "group::#{group}"
+          end
+
+          (group_labels & labels).any?
+        end
       end
     end
   end

data/lib/gitlab/dangerfiles/teammate.rb

@@ -5,10 +5,10 @@ require_relative "category"
 module Gitlab
   module Dangerfiles
     class Teammate
-      attr_reader :options, :username, :name, :role, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours,
+      attr_reader :options, :username, :name, :role, :specialty, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours,
                   :only_maintainer_reviews
 
-      # The options data are produced by https://gitlab.com/gitlab-org/gitlab-roulette/-/blob/master/lib/team_member.rb
+      # The options data are produced by https://gitlab.com/gitlab-org/gitlab-roulette/-/blob/main/lib/team_member.rb
       def initialize(options = {})
         @options = options
         @username = options["username"]
@@ -16,6 +16,7 @@ module Gitlab
         @markdown_name = options["markdown_name"] ||
                          default_markdown_name(*options.values_at("username", "name"))
         @role = options["role"]
+        @specialty = options["specialty"]
         @projects = process_projects(options["projects"])
         @available = options["available"]
         @hungry = options["hungry"]

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "3.6.7"
+    VERSION = "3.7.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 3.6.7
+  version: 3.7.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-02-10 00:00:00.000000000 Z
+date: 2023-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake