gitlab-dangerfiles 3.6.2 → 3.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c9ef239b79432bbb3b87cd49450338435f8ea5e0d27ed4beff1c2ce019dc79a
-  data.tar.gz: f5b42d80cba45edaba0bbda8fbbb314546489743e16ec74b7ab28dfc89bd4acb
+  metadata.gz: 34ff9782c4b20cd3c7dbb4a25d7ecdf66cf49ef303e1deb0bb04074e1c4fca21
+  data.tar.gz: b21f8643147b7147fca7e5cba536c67bf98d65f827cb169d72fd2ac5ff3de355
 SHA512:
-  metadata.gz: 3dc38989aa7959bac78ec9bcd36fa7ddfcd0c265b6a049c8ac37d5163bf8834e930e317368402d53850a8a12161bdf8f38cb1309068c27319f34c9a5b7c85d06
-  data.tar.gz: 779f8c6c3f1b817b88813010048d1541609fca1e92bd3021abf4f8b18f46fffcbee8ed239a48d78254a6858925d56b62ddf202b3f8c361b62f4ffcc57476fc51
+  metadata.gz: 7f9f43daf58a905f330ad98020327073a47692f24c0494d407d7e76aa8b18819b74839772c58b19d9081b04034154a06e8dee588c70898b71db08bab03fa31a9
+  data.tar.gz: f30572b11ac8e2d9a4ab9cc35c19000c68ecdaefd72f8e276f18e73da3beeb64b81a44d2e4919977c0aabecafec5d3fa64a25443604c27168865a5acb7c6bf97

data/README.md

@@ -128,8 +128,12 @@ project. To use it in your project, perform the following steps:
    see how to set it up.
 1. When using the default roulette, use `import_defaults` or import it manually when setting
    up the gitlab-dangerfiles instance:
+
    ```ruby
+   require 'gitlab-dangerfiles'
+
    Gitlab::Dangerfiles.for_project(self) do |dangerfiles|
+     dangerfiles.import_plugins
      dangerfiles.import_dangerfiles(only: %w[simple_roulette])
    end
    ```

data/lib/danger/plugins/internal/helper.rb

@@ -17,6 +17,7 @@ module Danger
       none: "",
       qa: "~QA",
       ux: "~UX",
+      codeowners: '~"Code Owners"',
       test: "~test for `spec/features/*`",
       # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
@@ -235,7 +236,13 @@ module Danger
     # @return [String] the GFM for a category label, making its best guess if it's not
     #   a category we know about.
     def label_for_category(category)
-      CATEGORY_LABELS.fetch(category, %Q{~"#{category}"})
+      CATEGORY_LABELS[category] ||
+
+        if category.start_with?("`")
+          category.to_s
+        else
+          %Q{~"#{category}"}
+        end
     end
 
     # @return [String] +""+ when not in the CI context, and the MR Source Project ID as a string otherwise.

data/lib/danger/plugins/roulette.rb

@@ -20,7 +20,13 @@ module Danger
 
     Approval = Struct.new(:category, :spin) do
       def self.from_approval_rule(rule, maintainer)
-        category = rule["section"].to_sym
+        category =
+          if rule["section"] == "codeowners"
+            "`#{rule["name"]}`"
+          else
+            rule["section"]
+          end.to_sym
+
         spin = Spin.new(category, nil, maintainer, :reviewer)
 
         new(category, spin)

data/lib/gitlab/dangerfiles/teammate.rb

@@ -5,7 +5,8 @@ require_relative "category"
 module Gitlab
   module Dangerfiles
     class Teammate
-      attr_reader :options, :username, :name, :role, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours
+      attr_reader :options, :username, :name, :role, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours,
+                  :only_maintainer_reviews
 
       # The options data are produced by https://gitlab.com/gitlab-org/gitlab-roulette/-/blob/master/lib/team_member.rb
       def initialize(options = {})
@@ -20,6 +21,7 @@ module Gitlab
         @hungry = options["hungry"]
         @reduced_capacity = options["reduced_capacity"]
         @tz_offset_hours = options["tz_offset_hours"]
+        @only_maintainer_reviews = options["only_maintainer_reviews"]
       end
 
       def to_h

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "3.6.2"
+    VERSION = "3.6.4"
   end
 end

data/lib/gitlab/dangerfiles/weightage/reviewers.rb

@@ -33,6 +33,7 @@ module Gitlab
           # https://gitlab.com/gitlab-org/gitlab/issues/26723
 
           remove_traintainers_from_reviewers!
+          remove_maintainer_only_from_reviewers!
 
           weighted_reviewers + weighted_traintainers
         end
@@ -49,6 +50,11 @@ module Gitlab
           reviewers.reject! { |reviewer| traintainers.include?(reviewer) }
         end
 
+        def remove_maintainer_only_from_reviewers!
+          # Using a maintainer-only reviewer emoji, team members can ensure they only get maintainer reviews
+          reviewers.reject! { |reviewer| reviewer&.only_maintainer_reviews }
+        end
+
         def weighted_reviewers
           reviewers.each_with_object([]) do |reviewer, total_reviewers|
             add_weighted_reviewer(total_reviewers, reviewer, DEFAULT_REVIEWER_WEIGHT)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 3.6.2
+  version: 3.6.4
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-04 00:00:00.000000000 Z
+date: 2022-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake