gitlab-dangerfiles 3.13.0 → 4.10.0

data/lib/gitlab/dangerfiles/spinner.rb

@@ -0,0 +1,191 @@
+# frozen_string_literal: true
+
+require_relative "spin"
+require_relative "teammate"
+require_relative "weightage/maintainers"
+require_relative "weightage/reviewers"
+
+module Gitlab
+  module Dangerfiles
+    class Spinner
+      attr_reader :project, :author, :team_author, :labels, :categories
+
+      def initialize(
+        project:, author:, team_author: nil, labels: [], categories: [],
+        random: Random.new, ux_fallback_wider_community_reviewer: nil)
+        @project = project
+        @author = author
+        @team_author = team_author
+        @labels = labels
+        @categories = categories.reject do |category|
+          import_and_integrate_reject_category?(project, category, labels)
+        end
+        @random = random
+        @ux_fallback_wider_community_reviewer = ux_fallback_wider_community_reviewer
+      end
+
+      # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      def spin
+        spins = categories.sort_by(&:to_s).map do |category|
+          spin_for_category(category)
+        end
+
+        backend_spin = spins.find { |spin| spin.category == :backend }
+        frontend_spin = spins.find { |spin| spin.category == :frontend }
+
+        spins.each do |spin|
+          case spin.category
+          when :qa
+            spin.optional_role = :maintainer if
+              categories.size > 1 && author_no_qa_capability?
+          when :test
+            spin.optional_role = :maintainer
+
+            if spin.no_reviewer?
+              # Fetch an already picked backend reviewer, or pick one otherwise
+              spin.reviewer = backend_spin&.reviewer || spin_for_category(:backend).reviewer
+            end
+          when :tooling
+            if spin.no_maintainer?
+              # Fetch an already picked backend maintainer, or pick one otherwise
+              spin.maintainer = backend_spin&.maintainer || spin_for_category(:backend).maintainer
+            end
+          when :ci_template # rubocop:disable Lint/DuplicateBranch -- bug?
+            if spin.no_maintainer?
+              # Fetch an already picked backend maintainer, or pick one otherwise
+              spin.maintainer = backend_spin&.maintainer || spin_for_category(:backend).maintainer
+            end
+          when :analytics_instrumentation
+            spin.optional_role = :maintainer
+
+            if spin.no_maintainer?
+              # Fetch an already picked maintainer, or pick one otherwise
+              spin.maintainer = backend_spin&.maintainer || frontend_spin&.maintainer || spin_for_category(:backend).maintainer
+            end
+          when :import_integrate_be, :import_integrate_fe
+            spin.optional_role = :maintainer
+          when :ux
+            spin.optional_role = :maintainer
+
+            # We want at least a UX reviewer who can review any wider community
+            # contribution even without a team designer. We assign this to Pedro.
+            spin.reviewer = ux_fallback_wider_community_reviewer if
+              labels.include?("Community contribution") &&
+                spin.no_reviewer? &&
+                spin.no_maintainer?
+          end
+        end
+
+        spins
+      end
+      # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+
+      # Spin a reviewer for a particular approval rule
+      #
+      # @param [Hash] rule of approval
+      #
+      # @return [Gitlab::Dangerfiles::Teammate]
+      def spin_for_approver(rule)
+        approvers = rule["eligible_approvers"].filter_map do |approver|
+          Gitlab::Dangerfiles::Teammate.find_member(
+            approver["username"], project: project)
+        end
+
+        spin_for_person(approvers) || spin_for_approver_fallback(rule)
+      end
+
+      private
+
+      attr_reader :random, :ux_fallback_wider_community_reviewer
+
+      # Reject Import and Integrate categories if the MR author has reviewing abilities for the category.
+      #
+      # @param [String] category name
+      # @return [Boolean]
+      def import_and_integrate_reject_category?(project, category, labels)
+        [:import_integrate_be, :import_integrate_fe].include?(category) && team_author &&
+          (team_author.reviewer?(project, category, labels) || team_author.maintainer?(project, category, labels))
+      end
+
+      # MR includes QA changes, but also other changes, and author isn't an SET
+      def author_no_qa_capability?
+        !(team_author && team_author.capabilities(project).any? { |capability| capability.end_with?("qa") })
+      end
+
+      def spin_for_category(category)
+        reviewers, traintainers, maintainers =
+          %i[reviewer traintainer maintainer].map do |role|
+            spin_role_for_category(role, category)
+          end
+
+        weighted_reviewers = Weightage::Reviewers.new(reviewers, traintainers).execute
+        weighted_maintainers = Weightage::Maintainers.new(maintainers).execute
+
+        reviewer = spin_for_person(weighted_reviewers)
+        maintainer = spin_for_person(weighted_maintainers)
+
+        # allow projects with small number of reviewers to take from maintainers if possible
+        if reviewer.nil? && weighted_maintainers.uniq.size > 1
+          weighted_maintainers.delete(maintainer)
+          reviewer = spin_for_person(weighted_maintainers)
+        end
+
+        Spin.new(category, reviewer, maintainer, false)
+      end
+
+      def spin_role_for_category(role, category)
+        team.select do |member|
+          member.public_send(:"#{role}?", project, category, labels)
+        end
+      end
+
+      # Known issue: If someone is rejected due to OOO, and then becomes not OOO, the
+      # selection will change on next spin.
+      #
+      # @param [Array<Gitlab::Dangerfiles::Teammate>] people
+      #
+      # @return [Gitlab::Dangerfiles::Teammate]
+      def spin_for_person(people)
+        shuffled_people = people.shuffle(random: random)
+
+        shuffled_people.find { |person| valid_person?(person) }
+      end
+
+      # @param [Gitlab::Dangerfiles::Teammate] person
+      # @return [Boolean]
+      def valid_person?(person)
+        person.username != author && person.available
+      end
+
+      # It can be possible that we don't have a valid reviewer for approval.
+      # In this case, we sample again without considering:
+      #
+      # * If they're available
+      # * If they're an actual reviewer from roulette data
+      #
+      # We do this because we strictly require an approval from the approvers.
+      #
+      # @param [Hash] rule of approval
+      #
+      # @return [Gitlab::Dangerfiles::Teammate]
+      def spin_for_approver_fallback(rule)
+        fallback_approvers = rule["eligible_approvers"].map do |approver|
+          Teammate.find_member(approver["username"]) || Teammate.new(approver)
+        end
+
+        # Intentionally not using `spin_for_person` to skip `valid_person?`.
+        # This should strictly return someone so we don't filter anything,
+        # and it's a fallback mechanism which should not happen often that
+        # deserves a complex algorithm.
+        fallback_approvers.sample(random: random)
+      end
+
+      # @return [Array<Gitlab::Dangerfiles::Teammate>]
+      def team
+        @team ||= Teammate.company_members.select do |member|
+          member.in_project?(project)
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/teammate.rb

@@ -1,12 +1,84 @@
 # frozen_string_literal: true
 
-require_relative "category"
+require "net/http"
+require "json"
+
+require_relative "capability"
 
 module Gitlab
   module Dangerfiles
     class Teammate
+      ROULETTE_DATA_URL = "https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json"
+
+      def self.find_member(username, project: nil)
+        company_members.find do |member|
+          member.username == username &&
+            (project.nil? || member.in_project?(project))
+        end
+      end
+
+      def self.has_member_for_the_group?(category, labels:, **arguments)
+        capabilities = %i[reviewer maintainer].map do |kind|
+          # Use new to use the base class for original has_capability? method
+          Capability.new(category: category, kind: kind, labels: labels, **arguments)
+        end
+
+        company_members.any? do |teammate|
+          capabilities.any? do |capability|
+            capability.has_capability?(teammate) &&
+              teammate.member_of_the_group?(labels)
+          end
+        end
+      end
+
+      # Looks up the current list of GitLab team members and parses it into a
+      # useful form.
+      #
+      # @return [Array<Gitlab::Dangerfiles::Teammate>]
+      def self.company_members
+        @company_members ||= fetch_company_members
+      end
+
+      def self.fetch_company_members
+        data = http_get_json(ROULETTE_DATA_URL) || []
+        data.map { |hash| Teammate.new(hash) }
+      rescue JSON::ParserError
+        warnings << "Failed to parse JSON response from #{ROULETTE_DATA_URL}"
+        []
+      end
+
+      # Fetches the given +url+ and parse its response as JSON.
+      #
+      # @param [String] url
+      #
+      # @return [Hash, Array, NilClass]
+      def self.http_get_json(url)
+        rsp = Net::HTTP.get_response(URI.parse(url))
+
+        if rsp.is_a?(Net::HTTPRedirection)
+          uri = URI.parse(rsp.header["location"])
+
+          uri.query = nil if uri
+
+          warnings << "Redirection detected: #{uri}."
+          return nil
+        end
+
+        unless rsp.is_a?(Net::HTTPOK)
+          message = rsp.message[0, 30]
+          warnings << "HTTPError: Failed to read #{url}: #{rsp.code} #{message}."
+          return nil
+        end
+
+        JSON.parse(rsp.body)
+      end
+
+      def self.warnings
+        @warnings ||= []
+      end
+
       attr_reader :options, :username, :name, :role, :specialty, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours,
-                  :only_maintainer_reviews
+        :only_maintainer_reviews
 
       # The options data are produced by https://gitlab.com/gitlab-org/gitlab-roulette/-/blob/main/lib/team_member.rb
       def initialize(options = {})
@@ -14,7 +86,7 @@ module Gitlab
         @username = options["username"]
         @name = options["name"]
         @markdown_name = options["markdown_name"] ||
-                         default_markdown_name(*options.values_at("username", "name"))
+          default_markdown_name(options["username"])
         @role = options["role"]
         @specialty = options["specialty"]
         @projects = process_projects(options["projects"])
@@ -25,6 +97,20 @@ module Gitlab
         @only_maintainer_reviews = options["only_maintainer_reviews"]
       end
 
+      def member_of_the_group?(labels)
+        # Specialty can be:
+        # Source Code
+        # [Growth: Activation, Growth: Expansion]
+        # Runner
+        group_labels = Array(specialty).map do |field|
+          group = field.strip.sub(/^.+: ?/, "").downcase
+
+          "group::#{group}"
+        end
+
+        (group_labels & labels).any?
+      end
+
       def to_h
         options
       end
@@ -55,18 +141,6 @@ module Gitlab
         has_capability?(project, category, :maintainer, labels)
       end
 
-      def import_integrate_be?(project, category, labels)
-        return false unless category == :import_integrate_be
-
-        has_capability?(project, category, :reviewer, labels)
-      end
-
-      def import_integrate_fe?(project, category, labels)
-        return false unless category == :import_integrate_fe
-
-        has_capability?(project, category, :reviewer, labels)
-      end
-
       def markdown_name(author: nil)
         "#{@markdown_name}#{utc_offset_text(author)}"
       end
@@ -89,8 +163,8 @@ module Gitlab
 
       private
 
-      def default_markdown_name(username, name)
-        "[#{name}](https://gitlab.com/#{username}) (`@#{username}`)"
+      def default_markdown_name(username)
+        "`@#{username}` [![profile link](https://gitlab.com/gitlab-org/gitlab-svgs/-/raw/main/sprite_icons/user.svg?ref_type=heads)](https://gitlab.com/#{username})"
       end
 
       def process_projects(projects)
@@ -119,16 +193,16 @@ module Gitlab
 
       def offset_diff_compared_to_author(author)
         diff = floored_offset_hours - author.floored_offset_hours
-        return "same timezone as `@#{author.username}`" if diff == 0
+        return "same timezone as author" if diff == 0
 
         ahead_or_behind = diff < 0 ? "behind" : "ahead of"
         pluralized_hours = pluralize(diff.abs, "hour", "hours")
 
-        "#{pluralized_hours} #{ahead_or_behind} `@#{author.username}`"
+        "#{pluralized_hours} #{ahead_or_behind} author"
       end
 
       def has_capability?(project, category, kind, labels)
-        Category.for(category, project: project, kind: kind, labels: labels).has_capability?(self)
+        Capability.for(category, project: project, kind: kind, labels: labels).has_capability?(self)
       end
 
       def pluralize(count, singular, plural)

data/lib/gitlab/dangerfiles/type_label_guesser.rb

@@ -8,8 +8,8 @@ module Gitlab
         security: %w[type::bug bug::vulnerability],
         performance: %w[type::bug bug::performance],
         added: %w[type::feature feature::addition],
-        deprecated: %w[type::feature feature::removal],
-        removed: %w[type::feature feature::removal],
+        deprecated: %w[type::maintenance maintenance::removal],
+        removed: %w[type::maintenance maintenance::removal]
       }.freeze
 
       def labels_from_changelog_categories(categories)

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "3.13.0"
+    VERSION = "4.10.0"
   end
 end

data/lib/gitlab/dangerfiles.rb

@@ -8,7 +8,6 @@ module Gitlab
       metadata
       simple_roulette
       type_label
-      subtype_label
       z_add_labels
       z_retry_link
     ].freeze

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 3.13.0
+  version: 4.10.0
 platform: ruby
 authors:
 - GitLab
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-02 00:00:00.000000000 Z
+date: 2025-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: danger-gitlab
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,70 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.4.5
+        version: 9.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.4.5
+        version: 9.3.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: climate_control
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: gitlab-styles
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.7.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.7.3
+- !ruby/object:Gem::Dependency
+  name: lefthook
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec-parameterized
   requirement: !ruby/object:Gem::Requirement
@@ -81,21 +123,49 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: timecop
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: racc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.21.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.21.2
+- !ruby/object:Gem::Dependency
+  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +179,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: climate_control
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +193,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rufo
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -157,6 +227,7 @@ files:
 - CONTRIBUTING.md
 - Dangerfile
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LICENSE.txt
 - README.md
@@ -168,29 +239,33 @@ files:
 - gitlab-dangerfiles.gemspec
 - lefthook.yml
 - lib/danger/plugins/changelog.rb
+- lib/danger/plugins/duo_code.rb
 - lib/danger/plugins/internal/helper.rb
 - lib/danger/plugins/roulette.rb
 - lib/danger/rules/changelog/Dangerfile
 - lib/danger/rules/changes_size/Dangerfile
 - lib/danger/rules/commit_messages/Dangerfile
 - lib/danger/rules/commits_counter/Dangerfile
+- lib/danger/rules/duo_code_review/Dangerfile
 - lib/danger/rules/metadata/Dangerfile
 - lib/danger/rules/simple_roulette/Dangerfile
-- lib/danger/rules/subtype_label/Dangerfile
 - lib/danger/rules/type_label/Dangerfile
 - lib/danger/rules/z_add_labels/Dangerfile
 - lib/danger/rules/z_retry_link/Dangerfile
 - lib/gitlab-dangerfiles.rb
 - lib/gitlab/Dangerfile
 - lib/gitlab/dangerfiles.rb
+- lib/gitlab/dangerfiles/approval.rb
 - lib/gitlab/dangerfiles/base_linter.rb
-- lib/gitlab/dangerfiles/category.rb
+- lib/gitlab/dangerfiles/capability.rb
 - lib/gitlab/dangerfiles/changes.rb
 - lib/gitlab/dangerfiles/commit_linter.rb
 - lib/gitlab/dangerfiles/config.rb
 - lib/gitlab/dangerfiles/emoji_checker.rb
 - lib/gitlab/dangerfiles/merge_request_linter.rb
 - lib/gitlab/dangerfiles/spec_helper.rb
+- lib/gitlab/dangerfiles/spin.rb
+- lib/gitlab/dangerfiles/spinner.rb
 - lib/gitlab/dangerfiles/task_loader.rb
 - lib/gitlab/dangerfiles/tasks/main.rake
 - lib/gitlab/dangerfiles/teammate.rb
@@ -208,7 +283,7 @@ metadata:
   homepage_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
   source_code_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
   changelog_uri: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -223,8 +298,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: This gem provides common Dangerfile and plugins for GitLab projects.
 test_files: []

data/lib/danger/rules/subtype_label/Dangerfile

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-SUBTYPE_LABEL_MISSING_MESSAGE = "Please add a [merge request subtype](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request."
-
-types = %w(bug feature maintenance)
-types.each do |type|
-  return if helper.has_scoped_label_with_scope?(type)
-end
-
-if ENV['DANGER_ERROR_WHEN_SUBTYPE_LABEL_IS_MISSING'] == 'true'
-  fail SUBTYPE_LABEL_MISSING_MESSAGE
-else
-  warn SUBTYPE_LABEL_MISSING_MESSAGE
-end