gitlab-dangerfiles 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 635a5f7c76e99281a75a956cc045c25b11e0ba243dca544dfeff4c53c6665826
-  data.tar.gz: baf2cd3b0d5bc499f980ac031c816dbdfe656e099af9db4520ad0a282788b1c8
+  metadata.gz: 93e497ecb88959ef6d916e995491d4a17644b2875b765a87d1b8dbf2a2e245cd
+  data.tar.gz: 2060f3bb306e1abf440eb4d2eead9f4a97dd5999d28a691fe119260fcf338b45
 SHA512:
-  metadata.gz: 8db37fdb8728b021e63c60cf612255894d353224274010ae5ccaf7b110968c5735fbc8ec7bf936c320d6b1c0c5413ab5bd9eb925571035b824d06b6c95cd3a0f
-  data.tar.gz: 1c3a3d119b6be0a19d2648740038d33e1dcba3ed0821dec6c4b4be988983a8d7a45818b33c3510168a924b47950151fc0906f10887f6ac1f21388fad62bd43cb
+  metadata.gz: 01a447e73d6550265ddf775674190816341bd07f484be816b7583fc3b70427bcfb2b1a0c9aa86b651486bed62953a8e97838c58527eee11af4c169f2633d7d2f
+  data.tar.gz: f85733f1b015c3170cafc990b0cf84c773ed8532f11e3978b59d21477ad592d8095ff6b46b4a673da98f956c1368ed4a6501e3ae26b62c1d1c534022bbc4b88b

data/.gitlab/CODEOWNERS

@@ -0,0 +1 @@
+* @gl-quality/eng-prod

data/.gitlab-ci.yml

@@ -28,6 +28,12 @@ workflow:
       - Gemfile.lock
     policy: pull
 
+danger-review:
+  extends: .default
+  stage: test
+  script:
+    - bundle exec danger --fail-on-errors=true --verbose
+
 test:rspec:
   extends: .default
   stage: test

data/Dangerfile

@@ -0,0 +1,10 @@
+require_relative "lib/gitlab-dangerfiles"
+
+# Get an instance of Gitlab::Dangerfiles
+gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self)
+
+# Import all plugins from the gem
+gitlab_dangerfiles.import_plugins
+
+# Import all rules from the gem
+gitlab_dangerfiles.import_dangerfiles

data/Gemfile

@@ -6,3 +6,7 @@ gemspec
 gem "rake", "~> 12.0"
 gem "guard-rspec"
 gem "yard"
+
+group :test do
+  gem "pry-byebug", "~> 3.8", require: false
+end

data/lib/danger/plugins/helper.rb

@@ -16,6 +16,7 @@ module Danger
       docs: "~documentation", # Docs are reviewed along DevOps stages, so don't need roulette for now.
       none: "",
       qa: "~QA",
+      ux: "~UX",
       test: "~test ~Quality for `spec/features/*`",
       # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',

data/lib/danger/plugins/roulette.rb

@@ -34,6 +34,9 @@ module Danger
     #
     # @return [Array<Spin>]
     def spin(project, categories = [nil], timezone_experiment: false)
+      project = project.downcase
+      categories = categories.map { |category| category&.downcase }
+
       spins = categories.sort_by(&:to_s).map do |category|
         including_timezone = INCLUDE_TIMEZONE_FOR_CATEGORY.fetch(category, timezone_experiment)
 

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -82,7 +82,7 @@ module Gitlab
         return false if subject.empty?
         return false if ("A".."Z").cover?(subject[0])
 
-        first_char = subject.sub(/\A(\[.+\]|\w+:)\s/, "")[0]
+        first_char = subject.sub(/\A(\[[^\]]+\]|[^:\s]+:)\s/, "")[0]
         first_char_downcased = first_char.downcase
         return true unless ("a".."z").cover?(first_char_downcased)
 

data/lib/gitlab/dangerfiles/teammate.rb

@@ -12,7 +12,7 @@ module Gitlab
         @name = options["name"]
         @markdown_name = options["markdown_name"]
         @role = options["role"]
-        @projects = options["projects"]
+        @projects = process_projects(options["projects"])
         @available = options["available"]
         @hungry = options["hungry"]
         @reduced_capacity = options["reduced_capacity"]
@@ -79,6 +79,14 @@ module Gitlab
 
       private
 
+      def process_projects(projects)
+        return nil unless projects
+
+        projects.each_with_object({}) do |(project, capabilities), all|
+          all[project.downcase] = Array(capabilities).map(&:downcase)
+        end
+      end
+
       def utc_offset_text(author = nil)
         offset_text = if floored_offset_hours >= 0
             "UTC+#{floored_offset_hours}"

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.4.0"
+    VERSION = "2.5.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-02 00:00:00.000000000 Z
+date: 2021-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab
@@ -131,10 +131,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".gitlab-ci.yml"
+- ".gitlab/CODEOWNERS"
 - ".gitlab/merge_request_templates/Release.md"
 - ".rspec"
 - ".yardopts"
 - CODE_OF_CONDUCT.md
+- Dangerfile
 - Gemfile
 - Guardfile
 - LICENSE.txt