gitlab-dangerfiles 2.3.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9514e55b5f6bd5a29333c3d08cd1cb2b6a0a61dc3f07a363625a60e52708095a
-  data.tar.gz: '05359002275ba7bf06b2aca1d6a9a0acc8f149765ff87970bf12ebcb29b3f796'
+  metadata.gz: 93e497ecb88959ef6d916e995491d4a17644b2875b765a87d1b8dbf2a2e245cd
+  data.tar.gz: 2060f3bb306e1abf440eb4d2eead9f4a97dd5999d28a691fe119260fcf338b45
 SHA512:
-  metadata.gz: 6309c8416ef0952e275acce5ec3fe12bbc72658857ad253e6fd92c86acc5d2d6a952cbb87f80b5d32073d6d9c5eb521482417e7ecfcfc1c93502107a11fbfa62
-  data.tar.gz: 99c591108c94959166847f6bc11f2b0f7bcf7a1114c4176d982ecdbbc8c5cd6c3bef6edca889a6cd3dc0d5902077fcaa117835a521e9eb9d4bfd590a16161cbf
+  metadata.gz: 01a447e73d6550265ddf775674190816341bd07f484be816b7583fc3b70427bcfb2b1a0c9aa86b651486bed62953a8e97838c58527eee11af4c169f2633d7d2f
+  data.tar.gz: f85733f1b015c3170cafc990b0cf84c773ed8532f11e3978b59d21477ad592d8095ff6b46b4a673da98f956c1368ed4a6501e3ae26b62c1d1c534022bbc4b88b

data/.gitlab/CODEOWNERS

@@ -0,0 +1 @@
+* @gl-quality/eng-prod

data/.gitlab-ci.yml

@@ -28,6 +28,12 @@ workflow:
       - Gemfile.lock
     policy: pull
 
+danger-review:
+  extends: .default
+  stage: test
+  script:
+    - bundle exec danger --fail-on-errors=true --verbose
+
 test:rspec:
   extends: .default
   stage: test

data/Dangerfile

@@ -0,0 +1,10 @@
+require_relative "lib/gitlab-dangerfiles"
+
+# Get an instance of Gitlab::Dangerfiles
+gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self)
+
+# Import all plugins from the gem
+gitlab_dangerfiles.import_plugins
+
+# Import all rules from the gem
+gitlab_dangerfiles.import_dangerfiles

data/Gemfile

@@ -6,3 +6,7 @@ gemspec
 gem "rake", "~> 12.0"
 gem "guard-rspec"
 gem "yard"
+
+group :test do
+  gem "pry-byebug", "~> 3.8", require: false
+end

data/README.md

@@ -55,7 +55,6 @@ For the full documentation about the plugins, please see https://www.rubydoc.inf
 
 ### Rules
 
-
 Danger rules are located under `lib/danger/rules`.
 
 #### `changes_size`

data/lib/danger/plugins/helper.rb

@@ -16,12 +16,15 @@ module Danger
       docs: "~documentation", # Docs are reviewed along DevOps stages, so don't need roulette for now.
       none: "",
       qa: "~QA",
+      ux: "~UX",
       test: "~test ~Quality for `spec/features/*`",
       # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
-      tooling: "~tooling for CI, Danger",
+      tooling: '~"type::tooling" for CI, Danger',
       ci_template: '~"ci::templates"',
       product_intelligence: '~"product intelligence"',
+      integrations_be: '~"group::integrations" (backend)',
+      integrations_fe: '~"group::integrations" (frontend)',
     }.freeze
 
     # Allows to set specific rule's configuration by passing a block.

data/lib/danger/plugins/roulette.rb

@@ -34,6 +34,9 @@ module Danger
     #
     # @return [Array<Spin>]
     def spin(project, categories = [nil], timezone_experiment: false)
+      project = project.downcase
+      categories = categories.map { |category| category&.downcase }
+
       spins = categories.sort_by(&:to_s).map do |category|
         including_timezone = INCLUDE_TIMEZONE_FOR_CATEGORY.fetch(category, timezone_experiment)
 
@@ -75,6 +78,8 @@ module Danger
             # Fetch an already picked maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || frontend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
           end
+        when :integrations_be, :integrations_fe
+          spin.optional_role = :maintainer
         end
       end
 

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -28,6 +28,10 @@ module Gitlab
         @problems = {}
       end
 
+      def inspect
+        "#{self.class}:#{object_id} @commit=#{@commit} @problems=#{@problems}"
+      end
+
       def failed?
         problems.any?
       end
@@ -78,7 +82,7 @@ module Gitlab
         return false if subject.empty?
         return false if ("A".."Z").cover?(subject[0])
 
-        first_char = subject.sub(/\A(\[.+\]|\w+:)\s/, "")[0]
+        first_char = subject.sub(/\A(\[[^\]]+\]|[^:\s]+:)\s/, "")[0]
         first_char_downcased = first_char.downcase
         return true unless ("a".."z").cover?(first_char_downcased)
 

data/lib/gitlab/dangerfiles/commit_linter.rb

@@ -9,9 +9,9 @@ module Gitlab
       MAX_CHANGED_FILES_IN_COMMIT = 3
       MAX_CHANGED_LINES_IN_COMMIT = 30
       # Issue, MR, Epic
-      SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)(#|!|&)\d+(?<!`)}.freeze
+      SHORT_REFERENCE_REGEX = %r{(\S*([\w\-\/]+)?(?<!`)(#|!|&)\d+(?<!`))}.freeze
       # Milestone
-      MS_SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)%"?\d{1,3}\.\d{1,3}"?(?<!`)}.freeze
+      MS_SHORT_REFERENCE_REGEX = %r{(\S*([\w\-\/]+)?(?<!`)%"?\d{1,3}\.\d{1,3}"?(?<!`))}.freeze
       SUGGESTIONS_APPLIED_COMMIT_REGEX = /Apply \d+ suggestion\(s\) to \d+ file\(s\)/.freeze
 
       def self.problems_mapping
@@ -143,8 +143,13 @@ module Gitlab
       end
 
       def message_contains_short_reference?
-        commit.message.match?(SHORT_REFERENCE_REGEX) ||
-          commit.message.match?(MS_SHORT_REFERENCE_REGEX)
+        match_data = commit.message.match(SHORT_REFERENCE_REGEX) ||
+                     commit.message.match(MS_SHORT_REFERENCE_REGEX)
+
+        return false unless match_data
+
+        # Any URL would include "//". This works for http/https/ftp etc.
+        !match_data[1].include?("//")
       end
 
       def emoji_checker

data/lib/gitlab/dangerfiles/teammate.rb

@@ -12,7 +12,7 @@ module Gitlab
         @name = options["name"]
         @markdown_name = options["markdown_name"]
         @role = options["role"]
-        @projects = options["projects"]
+        @projects = process_projects(options["projects"])
         @available = options["available"]
         @hungry = options["hungry"]
         @reduced_capacity = options["reduced_capacity"]
@@ -49,6 +49,18 @@ module Gitlab
         has_capability?(project, category, :maintainer, labels)
       end
 
+      def integrations_be?(project, category, labels)
+        return false unless category == :integrations_be
+
+        has_capability?(project, category, :reviewer, labels)
+      end
+
+      def integrations_fe?(project, category, labels)
+        return false unless category == :integrations_fe
+
+        has_capability?(project, category, :reviewer, labels)
+      end
+
       def markdown_name(author: nil)
         "#{@markdown_name} (#{utc_offset_text(author)})"
       end
@@ -67,6 +79,14 @@ module Gitlab
 
       private
 
+      def process_projects(projects)
+        return nil unless projects
+
+        projects.each_with_object({}) do |(project, capabilities), all|
+          all[project.downcase] = Array(capabilities).map(&:downcase)
+        end
+      end
+
       def utc_offset_text(author = nil)
         offset_text = if floored_offset_hours >= 0
             "UTC+#{floored_offset_hours}"
@@ -101,6 +121,12 @@ module Gitlab
           return true if capabilities(project).include?("#{kind} engineering_productivity")
 
           capabilities(project).include?("#{kind} backend")
+        when :integrations_be
+          kind == :reviewer &&
+            role.match?(/Backend Engineer.+Ecosystem:Integrations/)
+        when :integrations_fe
+          kind == :reviewer &&
+            role.match?(/Frontend Engineer.+Ecosystem:Integrations/)
         when nil
           capabilities(project).include?("#{kind}")
         else

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.3.0"
+    VERSION = "2.5.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.5.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-22 00:00:00.000000000 Z
+date: 2021-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab
@@ -131,10 +131,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".gitlab-ci.yml"
+- ".gitlab/CODEOWNERS"
 - ".gitlab/merge_request_templates/Release.md"
 - ".rspec"
 - ".yardopts"
 - CODE_OF_CONDUCT.md
+- Dangerfile
 - Gemfile
 - Guardfile
 - LICENSE.txt