gitlab-dangerfiles 2.2.2 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f81554a60bebe4dbb5cec0a4499df086b580778f5bd2d82a67613a9af166a78
-  data.tar.gz: 83c066d44caca9a1bf05386269f15d92b781891e90b1f3e709cf190faffbb773
+  metadata.gz: 635a5f7c76e99281a75a956cc045c25b11e0ba243dca544dfeff4c53c6665826
+  data.tar.gz: baf2cd3b0d5bc499f980ac031c816dbdfe656e099af9db4520ad0a282788b1c8
 SHA512:
-  metadata.gz: d9369900511e47644c72f843f52f8b212528f1604a50a07427cab956822974ea9b71f5051a4d8313cf962a7430b9ea150c0f3deeca3ed2360542729b1f79d279
-  data.tar.gz: 9d2cc70542f4df753a6d30d194a43c883a1960aefe517f0b1001609ec47cb764c9c90b7a166d633b7a50a4e49a046bc90cdb56b5c3ed0d02c052909458453d65
+  metadata.gz: 8db37fdb8728b021e63c60cf612255894d353224274010ae5ccaf7b110968c5735fbc8ec7bf936c320d6b1c0c5413ab5bd9eb925571035b824d06b6c95cd3a0f
+  data.tar.gz: 1c3a3d119b6be0a19d2648740038d33e1dcba3ed0821dec6c4b4be988983a8d7a45818b33c3510168a924b47950151fc0906f10887f6ac1f21388fad62bd43cb

data/README.md

@@ -7,7 +7,7 @@ The goal of this gem is to centralize Danger plugins and rules that to be used b
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'gitlab-dangerfiles'
+gem 'gitlab-dangerfiles', require: false
 ```
 
 And then execute:
@@ -29,6 +29,8 @@ $ gem install gitlab-dangerfiles
 In your project's `Dangerfile`, add the following two line to import the plugins and rules from this gem:
 
 ```ruby
+require 'gitlab-dangerfiles'
+
 # Get an instance of Gitlab::Dangerfiles
 gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self)
 
@@ -53,7 +55,6 @@ For the full documentation about the plugins, please see https://www.rubydoc.inf
 
 ### Rules
 
-
 Danger rules are located under `lib/danger/rules`.
 
 #### `changes_size`

data/lib/danger/plugins/helper.rb

@@ -17,9 +17,13 @@ module Danger
       none: "",
       qa: "~QA",
       test: "~test ~Quality for `spec/features/*`",
+      # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
+      tooling: '~"type::tooling" for CI, Danger',
       ci_template: '~"ci::templates"',
       product_intelligence: '~"product intelligence"',
+      integrations_be: '~"group::integrations" (backend)',
+      integrations_fe: '~"group::integrations" (frontend)',
     }.freeze
 
     # Allows to set specific rule's configuration by passing a block.
@@ -211,7 +215,7 @@ module Danger
     #                   +filename_regex+ is the regex pattern to match file names. +changes_regex+ is the regex pattern to
     #                   match changed lines in files that match +filename_regex+
     #
-    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend engineering_productivity]+
+    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend tooling]+
     #   using filename regex (+filename_regex+) and specific change regex (+changes_regex+) from the given +categories+ hash.
     def categories_for_file(filename, categories)
       _, categories = categories.find do |key, _|

data/lib/danger/plugins/roulette.rb

@@ -58,7 +58,7 @@ module Danger
             # Fetch an already picked backend reviewer, or pick one otherwise
             spin.reviewer = backend_spin&.reviewer || spin_for_category(project, :backend, timezone_experiment: including_timezone).reviewer
           end
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           if spin.maintainer.nil?
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
@@ -75,6 +75,8 @@ module Danger
             # Fetch an already picked maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || frontend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
           end
+        when :integrations_be, :integrations_fe
+          spin.optional_role = :maintainer
         end
       end
 

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -28,6 +28,10 @@ module Gitlab
         @problems = {}
       end
 
+      def inspect
+        "#{self.class}:#{object_id} @commit=#{@commit} @problems=#{@problems}"
+      end
+
       def failed?
         problems.any?
       end

data/lib/gitlab/dangerfiles/commit_linter.rb

@@ -9,9 +9,9 @@ module Gitlab
       MAX_CHANGED_FILES_IN_COMMIT = 3
       MAX_CHANGED_LINES_IN_COMMIT = 30
       # Issue, MR, Epic
-      SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)(#|!|&)\d+(?<!`)}.freeze
+      SHORT_REFERENCE_REGEX = %r{(\S*([\w\-\/]+)?(?<!`)(#|!|&)\d+(?<!`))}.freeze
       # Milestone
-      MS_SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)%"?\d{1,3}\.\d{1,3}"?(?<!`)}.freeze
+      MS_SHORT_REFERENCE_REGEX = %r{(\S*([\w\-\/]+)?(?<!`)%"?\d{1,3}\.\d{1,3}"?(?<!`))}.freeze
       SUGGESTIONS_APPLIED_COMMIT_REGEX = /Apply \d+ suggestion\(s\) to \d+ file\(s\)/.freeze
 
       def self.problems_mapping
@@ -143,8 +143,13 @@ module Gitlab
       end
 
       def message_contains_short_reference?
-        commit.message.match?(SHORT_REFERENCE_REGEX) ||
-          commit.message.match?(MS_SHORT_REFERENCE_REGEX)
+        match_data = commit.message.match(SHORT_REFERENCE_REGEX) ||
+                     commit.message.match(MS_SHORT_REFERENCE_REGEX)
+
+        return false unless match_data
+
+        # Any URL would include "//". This works for http/https/ftp etc.
+        !match_data[1].include?("//")
       end
 
       def emoji_checker

data/lib/gitlab/dangerfiles/teammate.rb

@@ -49,6 +49,18 @@ module Gitlab
         has_capability?(project, category, :maintainer, labels)
       end
 
+      def integrations_be?(project, category, labels)
+        return false unless category == :integrations_be
+
+        has_capability?(project, category, :reviewer, labels)
+      end
+
+      def integrations_fe?(project, category, labels)
+        return false unless category == :integrations_fe
+
+        has_capability?(project, category, :reviewer, labels)
+      end
+
       def markdown_name(author: nil)
         "#{@markdown_name} (#{utc_offset_text(author)})"
       end
@@ -95,12 +107,18 @@ module Gitlab
           area = role[/Software Engineer in Test(?:.*?, (\w+))/, 1]
 
           area && labels.any?("devops::#{area.downcase}") if kind == :reviewer
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           return false unless role[/Engineering Productivity/]
           return true if kind == :reviewer
           return true if capabilities(project).include?("#{kind} engineering_productivity")
 
           capabilities(project).include?("#{kind} backend")
+        when :integrations_be
+          kind == :reviewer &&
+            role.match?(/Backend Engineer.+Ecosystem:Integrations/)
+        when :integrations_fe
+          kind == :reviewer &&
+            role.match?(/Frontend Engineer.+Ecosystem:Integrations/)
         when nil
           capabilities(project).include?("#{kind}")
         else

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.2.2"
+    VERSION = "2.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.4.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-09 00:00:00.000000000 Z
+date: 2021-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab