gitlab-dangerfiles 2.1.4 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e97286bdfb0262152ab62792bff988f54b6a4c4e518600fc6488868a40aa9e25
-  data.tar.gz: dcebdb1e4d4d97a9b6d2c532c976c1c9ce25296aab56de9bcec9444ac7f7847a
+  metadata.gz: 9514e55b5f6bd5a29333c3d08cd1cb2b6a0a61dc3f07a363625a60e52708095a
+  data.tar.gz: '05359002275ba7bf06b2aca1d6a9a0acc8f149765ff87970bf12ebcb29b3f796'
 SHA512:
-  metadata.gz: d117a697f702f3b2c456957b811e850a564281b9190104b552c2784415e8d26505ed1cc300cef281dab94864cb41bd89bdf8c21d9b42c1875222b8b959d43b53
-  data.tar.gz: 8e5539c873291b0328cc7a5cc2ac5b6bc1965fd550ba04a0700b2e5a19da89f979d30c56967990d4b41de989cd7a5d58a9e3bf6285e49449668431d04f22fb46
+  metadata.gz: 6309c8416ef0952e275acce5ec3fe12bbc72658857ad253e6fd92c86acc5d2d6a952cbb87f80b5d32073d6d9c5eb521482417e7ecfcfc1c93502107a11fbfa62
+  data.tar.gz: 99c591108c94959166847f6bc11f2b0f7bcf7a1114c4176d982ecdbbc8c5cd6c3bef6edca889a6cd3dc0d5902077fcaa117835a521e9eb9d4bfd590a16161cbf

data/README.md

@@ -7,7 +7,7 @@ The goal of this gem is to centralize Danger plugins and rules that to be used b
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'gitlab-dangerfiles'
+gem 'gitlab-dangerfiles', require: false
 ```
 
 And then execute:
@@ -29,6 +29,8 @@ $ gem install gitlab-dangerfiles
 In your project's `Dangerfile`, add the following two line to import the plugins and rules from this gem:
 
 ```ruby
+require 'gitlab-dangerfiles'
+
 # Get an instance of Gitlab::Dangerfiles
 gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self)
 

data/gitlab-dangerfiles.gemspec

@@ -27,7 +27,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "danger-gitlab"
+  spec.add_dependency "danger-gitlab", ">= 8.0.0"
+  spec.add_dependency "danger", ">= 8.3.1"
 
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-parameterized"

data/lib/danger/plugins/helper.rb

@@ -17,7 +17,9 @@ module Danger
       none: "",
       qa: "~QA",
       test: "~test ~Quality for `spec/features/*`",
+      # Deprecated as of 2.3.0 in favor of tooling
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
+      tooling: "~tooling for CI, Danger",
       ci_template: '~"ci::templates"',
       product_intelligence: '~"product intelligence"',
     }.freeze
@@ -211,7 +213,7 @@ module Danger
     #                   +filename_regex+ is the regex pattern to match file names. +changes_regex+ is the regex pattern to
     #                   match changed lines in files that match +filename_regex+
     #
-    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend engineering_productivity]+
+    # @return [Array<Symbol>] the categories a file is in, e.g., +[:frontend]+, +[:backend]+, or +%i[frontend tooling]+
     #   using filename regex (+filename_regex+) and specific change regex (+changes_regex+) from the given +categories+ hash.
     def categories_for_file(filename, categories)
       _, categories = categories.find do |key, _|
@@ -416,7 +418,7 @@ module Danger
       return nil unless ci?
       return nil if defined?(@force_changes_from_git)
 
-      @changes_from_api ||= gitlab_helper.mr_changes.to_h["changes"]
+      @changes_from_api ||= gitlab_helper.mr_changes
     rescue
       # Fallback to the Git strategy in any case
       @force_changes_from_git = true

data/lib/danger/plugins/roulette.rb

@@ -58,7 +58,7 @@ module Danger
             # Fetch an already picked backend reviewer, or pick one otherwise
             spin.reviewer = backend_spin&.reviewer || spin_for_category(project, :backend, timezone_experiment: including_timezone).reviewer
           end
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           if spin.maintainer.nil?
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer

data/lib/danger/rules/commit_messages/Dangerfile

@@ -5,7 +5,7 @@ require_relative "../../../gitlab/dangerfiles/merge_request_linter"
 
 COMMIT_MESSAGE_GUIDELINES = "https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines"
 MORE_INFO = "For more information, take a look at our [Commit message guidelines](#{COMMIT_MESSAGE_GUIDELINES})."
-THE_DANGER_JOB_TEXT = "the `%<job_name>` job"
+THE_DANGER_JOB_TEXT = "the `%<job_name>s` job"
 MAX_COMMITS_COUNT = helper.config.max_commits_count
 MAX_COMMITS_COUNT_EXCEEDED_MESSAGE = <<~MSG
 This merge request includes more than %<max_commits_count>d commits. Each commit should meet the following criteria:

data/lib/gitlab/dangerfiles/spec_helper.rb

@@ -104,7 +104,7 @@ RSpec.shared_context "with dangerfile" do
   end
 
   let(:fake_git) { double("fake-git", added_files: added_files, modified_files: modified_files, deleted_files: deleted_files, renamed_files: renamed_files) }
-  let(:fake_helper) { double("fake-helper", changes: changes, mr_iid: 1234, mr_title: mr_title, mr_labels: mr_labels) }
+  let(:fake_helper) { double("fake-helper", changes: changes, added_files: added_files, modified_files: modified_files, deleted_files: deleted_files, renamed_files: renamed_files, mr_iid: 1234, mr_title: mr_title, mr_labels: mr_labels) }
 
   before do
     allow(dangerfile).to receive(:git).and_return(fake_git)

data/lib/gitlab/dangerfiles/teammate.rb

@@ -95,7 +95,7 @@ module Gitlab
           area = role[/Software Engineer in Test(?:.*?, (\w+))/, 1]
 
           area && labels.any?("devops::#{area.downcase}") if kind == :reviewer
-        when :engineering_productivity
+        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
           return false unless role[/Engineering Productivity/]
           return true if kind == :reviewer
           return true if capabilities(project).include?("#{kind} engineering_productivity")

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "2.1.4"
+    VERSION = "2.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.3.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-07-01 00:00:00.000000000 Z
+date: 2021-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-gitlab
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 8.0.0
+- !ruby/object:Gem::Dependency
+  name: danger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.3.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 8.3.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement