gitlab-dangerfiles 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1376c48a26c7b3a10cc3e649d1cf28f49fdf58fd7b317713b9ac9a0f3771e5a5
-  data.tar.gz: 9ecd1d0db0f583740a73f96f6ffd14905f7a66157e427c6a11410a7bc7c70e55
+  metadata.gz: d8a22cec902c95d63352af51b2b0460e7cb761ddda7ee7ab2833077686ee5428
+  data.tar.gz: 1eb6288e842695e9811d6f8ba88cf43d8c75caa1c441a3419aed3f5988c11864
 SHA512:
-  metadata.gz: e1684cb0a7b5367b37f099cad0dca796cdb5cf01fc71f36e4896268b4abc8c0ee59ed122459261f47ec1b873da8aa2355644c6074b92285ddd1b3f4215bbba86
-  data.tar.gz: 8e8644fa64222def924524b8545397615f7335198e88d35f47fc07c450793879c0c710c380b496eb0c80a6bf856c855ec4bb58266670aff6a526ff3b9c84bc5a
+  metadata.gz: 81214e30c00e1b8c3f164a8b3bdfbc135902b5292a1064a8f4acbcd26ef5f9d9b0e83ebea83c51621e1742b2b6df13af1e81732fb4c9256bb254cac153370170
+  data.tar.gz: dd5be048537a4604d21774622effdb3e02d82aa3aefaaecb5bdcf598a96efcbff9ade89100c753cb26cff12b85b7cded1fdde71bbae10035ea341717b9704c67

data/lib/danger/helper.rb

@@ -3,6 +3,7 @@
 require "net/http"
 require "json"
 require "danger"
+require_relative "../gitlab/dangerfiles/changes"
 require_relative "../gitlab/dangerfiles/teammate"
 require_relative "../gitlab/dangerfiles/title_linting"
 
@@ -22,52 +23,6 @@ module Danger
 
     HTTPError = Class.new(StandardError)
 
-    Change = Struct.new(:file, :change_type, :category)
-
-    class Changes < ::SimpleDelegator
-      def added
-        select_by_change_type(:added)
-      end
-
-      def modified
-        select_by_change_type(:modified)
-      end
-
-      def deleted
-        select_by_change_type(:deleted)
-      end
-
-      def renamed_before
-        select_by_change_type(:renamed_before)
-      end
-
-      def renamed_after
-        select_by_change_type(:renamed_after)
-      end
-
-      def has_category?(category)
-        any? { |change| change.category == category }
-      end
-
-      def by_category(category)
-        Changes.new(select { |change| change.category == category })
-      end
-
-      def categories
-        map(&:category).uniq
-      end
-
-      def files
-        map(&:file)
-      end
-
-      private
-
-      def select_by_change_type(change_type)
-        Changes.new(select { |change| change.change_type == change_type })
-      end
-    end
-
     def gitlab_helper
       # Unfortunately the following does not work:
       # - respond_to?(:gitlab)
@@ -159,27 +114,27 @@ module Danger
       end
     end
 
-    # @return [Changes]
+    # @return [Gitlab::Dangerfiles::Changes]
     def changes(categories)
-      Changes.new([]).tap do |changes|
+      Gitlab::Dangerfiles::Changes.new([]).tap do |changes|
         git.added_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :added, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :added, category) }
         end
 
         git.modified_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :modified, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :modified, category) }
         end
 
         git.deleted_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :deleted, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :deleted, category) }
         end
 
         git.renamed_files.map { |x| x[:before] }.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :renamed_before, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_before, category) }
         end
 
         git.renamed_files.map { |x| x[:after] }.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :renamed_after, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_after, category) }
         end
       end
     end

data/lib/gitlab/dangerfiles/changes.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require_relative "title_linting"
+
+module Gitlab
+  module Dangerfiles
+    Change = Struct.new(:file, :change_type, :category)
+
+    class Changes < ::SimpleDelegator
+      def added
+        select_by_change_type(:added)
+      end
+
+      def modified
+        select_by_change_type(:modified)
+      end
+
+      def deleted
+        select_by_change_type(:deleted)
+      end
+
+      def renamed_before
+        select_by_change_type(:renamed_before)
+      end
+
+      def renamed_after
+        select_by_change_type(:renamed_after)
+      end
+
+      def has_category?(category)
+        any? { |change| change.category == category }
+      end
+
+      def by_category(category)
+        Changes.new(select { |change| change.category == category })
+      end
+
+      def categories
+        map(&:category).uniq
+      end
+
+      def files
+        map(&:file)
+      end
+
+      private
+
+      def select_by_change_type(change_type)
+        Changes.new(select { |change| change.change_type == change_type })
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/spec_helper.rb

@@ -0,0 +1,66 @@
+require "danger"
+require "gitlab/dangerfiles/changes"
+
+module DangerSpecHelper
+  # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+  # If you are expanding these files, see if it's already been done ^.
+
+  # A silent version of the user interface
+  def self.testing_ui
+    Cork::Board.new(silent: true)
+  end
+
+  # Example environment (ENV) that would come from
+  # running a PR on TravisCI
+  def self.testing_env
+    {
+      "GITLAB_CI" => "true",
+      "DANGER_GITLAB_HOST" => "gitlab.example.com",
+      "CI_MERGE_REQUEST_IID" => 28_493,
+      "DANGER_GITLAB_API_TOKEN" => "123sbdq54erfsd3422gdfio",
+    }
+  end
+
+  # A stubbed out Dangerfile for use in tests
+  def self.testing_dangerfile
+    env = Danger::EnvironmentManager.new(testing_env)
+    Danger::Dangerfile.new(env, testing_ui)
+  end
+
+  def self.fake_danger
+    Class.new do
+      attr_reader :git, :gitlab, :helper
+
+      # rubocop:disable Gitlab/ModuleWithInstanceVariables
+      def initialize(git: nil, gitlab: nil, helper: nil)
+        @git = git
+        @gitlab = gitlab
+        @helper = helper
+      end
+
+      # rubocop:enable Gitlab/ModuleWithInstanceVariables
+    end
+  end
+end
+
+RSpec.shared_context "with dangerfile" do
+  let(:dangerfile) { DangerSpecHelper.testing_dangerfile }
+  let(:added_files) { %w[added1] }
+  let(:modified_files) { %w[modified1] }
+  let(:deleted_files) { %w[deleted1] }
+  let(:renamed_before_file) { "renamed_before" }
+  let(:renamed_after_file) { "renamed_after" }
+  let(:renamed_files) { [{ before: renamed_before_file, after: renamed_after_file }] }
+  let(:change_class) { Gitlab::Dangerfiles::Change }
+  let(:changes_class) { Gitlab::Dangerfiles::Changes }
+  let(:changes) { changes_class.new([]) }
+  let(:mr_title) { "Fake Title" }
+  let(:mr_labels) { [] }
+
+  let(:fake_git) { double("fake-git", added_files: added_files, modified_files: modified_files, deleted_files: deleted_files, renamed_files: renamed_files) }
+  let(:fake_helper) { double("fake-helper", changes: changes, mr_iid: 1234, mr_title: mr_title, mr_labels: mr_labels) }
+
+  before do
+    allow(dangerfile).to receive(:git).and_return(fake_git)
+  end
+end

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "0.6.1"
+    VERSION = "0.7.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Rémy Coutable
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-03-03 00:00:00.000000000 Z
+date: 2021-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -136,9 +136,11 @@ files:
 - lib/gitlab/Dangerfile
 - lib/gitlab/dangerfiles.rb
 - lib/gitlab/dangerfiles/base_linter.rb
+- lib/gitlab/dangerfiles/changes.rb
 - lib/gitlab/dangerfiles/commit_linter.rb
 - lib/gitlab/dangerfiles/emoji_checker.rb
 - lib/gitlab/dangerfiles/merge_request_linter.rb
+- lib/gitlab/dangerfiles/spec_helper.rb
 - lib/gitlab/dangerfiles/teammate.rb
 - lib/gitlab/dangerfiles/title_linting.rb
 - lib/gitlab/dangerfiles/version.rb