gitlab-dangerfiles 0.6.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a41237cf8c1b948162962ffd5712cac36034d6e3f6ddbd551f7b7f5c64315ac6
-  data.tar.gz: 9416beb3ed3688db58d83bfafb103a3f21b15c7a1e1dae83fe08dae33b13d329
+  metadata.gz: 953603fac4ea1f44a40296e63e5d67943f0a0ec2d67631eb24822d3c01b76749
+  data.tar.gz: 47c1026b0081cbd279cd097f122b29a6ef382dbb43ea5ce7a714935ead7288d9
 SHA512:
-  metadata.gz: 294c63c0dad1685a71e4110ab5248d96e7efa97ef448dc861c6a443a8123fd490b1fbdf303b87bf7c18802074b24b3b371a433b3ef06c831cc368559c4c832a0
-  data.tar.gz: aa3bc70fe5068018df9dd1eee9010732b4df231033434ba02c3872b0902e3850adde1b97b6228dbda9f58e10c032b7d4b6467c96f18392d3e74dfab497638835
+  metadata.gz: 6e36bec78c26703d1b964ea580b9d3cd1425926d968c80480a901f7c14ebb6f0a0509820adc612587796d85ed29e83ca0c3e9569a288a90a5beab1c1693f92da
+  data.tar.gz: b7fa2dcf949685dd1c24382e8b83c1b06b57c5abc75e85c6123313dae8d9936d8c90b3d8c58e9af237c07a497b6d0eb3c9e929c2dab840baec42bf338883b8c0

data/lib/danger/helper.rb

@@ -3,6 +3,7 @@
 require "net/http"
 require "json"
 require "danger"
+require_relative "../gitlab/dangerfiles/changes"
 require_relative "../gitlab/dangerfiles/teammate"
 require_relative "../gitlab/dangerfiles/title_linting"
 
@@ -22,52 +23,6 @@ module Danger
 
     HTTPError = Class.new(StandardError)
 
-    Change = Struct.new(:file, :change_type, :category)
-
-    class Changes < ::SimpleDelegator
-      def added
-        select_by_change_type(:added)
-      end
-
-      def modified
-        select_by_change_type(:modified)
-      end
-
-      def deleted
-        select_by_change_type(:deleted)
-      end
-
-      def renamed_before
-        select_by_change_type(:renamed_before)
-      end
-
-      def renamed_after
-        select_by_change_type(:renamed_after)
-      end
-
-      def has_category?(category)
-        any? { |change| change.category == category }
-      end
-
-      def by_category(category)
-        Changes.new(select { |change| change.category == category })
-      end
-
-      def categories
-        map(&:category).uniq
-      end
-
-      def files
-        map(&:file)
-      end
-
-      private
-
-      def select_by_change_type(change_type)
-        Changes.new(select { |change| change.change_type == change_type })
-      end
-    end
-
     def gitlab_helper
       # Unfortunately the following does not work:
       # - respond_to?(:gitlab)
@@ -159,27 +114,27 @@ module Danger
       end
     end
 
-    # @return [Changes]
+    # @return [Gitlab::Dangerfiles::Changes]
     def changes(categories)
-      Changes.new([]).tap do |changes|
+      Gitlab::Dangerfiles::Changes.new([]).tap do |changes|
         git.added_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :added, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :added, category) }
         end
 
         git.modified_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :modified, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :modified, category) }
         end
 
         git.deleted_files.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :deleted, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :deleted, category) }
         end
 
         git.renamed_files.map { |x| x[:before] }.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :renamed_before, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_before, category) }
         end
 
         git.renamed_files.map { |x| x[:after] }.each do |file|
-          categories_for_file(file, categories).each { |category| changes << Change.new(file, :renamed_after, category) }
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_after, category) }
         end
       end
     end

data/lib/danger/roulette.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "helper"
 require_relative "../gitlab/dangerfiles/teammate"
 require_relative "../gitlab/dangerfiles/weightage/maintainers"
 require_relative "../gitlab/dangerfiles/weightage/reviewers"
@@ -25,7 +26,7 @@ module Danger
     # for each change category that a Merge Request contains.
     #
     # @return [Array<Spin>]
-    def spin(project, categories, timezone_experiment: false)
+    def spin(project, categories = [nil], timezone_experiment: false)
       spins = categories.sort.map do |category|
         including_timezone = INCLUDE_TIMEZONE_FOR_CATEGORY.fetch(category, timezone_experiment)
 

data/lib/gitlab/dangerfiles.rb

@@ -2,5 +2,8 @@ require "gitlab/dangerfiles/version"
 
 module Gitlab
   module Dangerfiles
+    def self.import_plugins(danger)
+      danger.import_plugin(File.expand_path("../danger/*.rb", __dir__))
+    end
   end
 end

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -59,7 +59,7 @@ module Gitlab
       private
 
       def subject
-        TitleLinting.remove_draft_flag(message_parts[0])
+        @subject ||= TitleLinting.remove_draft_flag(message_parts[0])
       end
 
       def subject_too_short?
@@ -75,6 +75,7 @@ module Gitlab
       end
 
       def subject_starts_with_lowercase?
+        return false if subject.empty?
         return false if ("A".."Z").cover?(subject[0])
 
         first_char = subject.sub(/\A(\[.+\]|\w+:)\s/, "")[0]

data/lib/gitlab/dangerfiles/changes.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require_relative "title_linting"
+
+module Gitlab
+  module Dangerfiles
+    Change = Struct.new(:file, :change_type, :category)
+
+    class Changes < ::SimpleDelegator
+      def added
+        select_by_change_type(:added)
+      end
+
+      def modified
+        select_by_change_type(:modified)
+      end
+
+      def deleted
+        select_by_change_type(:deleted)
+      end
+
+      def renamed_before
+        select_by_change_type(:renamed_before)
+      end
+
+      def renamed_after
+        select_by_change_type(:renamed_after)
+      end
+
+      def has_category?(category)
+        any? { |change| change.category == category }
+      end
+
+      def by_category(category)
+        Changes.new(select { |change| change.category == category })
+      end
+
+      def categories
+        map(&:category).uniq
+      end
+
+      def files
+        map(&:file)
+      end
+
+      private
+
+      def select_by_change_type(change_type)
+        Changes.new(select { |change| change.change_type == change_type })
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/commit_linter.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
+require_relative "base_linter"
 require_relative "emoji_checker"
 
 module Gitlab
   module Dangerfiles
-    class CommitLinter
+    class CommitLinter < BaseLinter
+      MAX_CHANGED_FILES_IN_COMMIT = 3
       MAX_CHANGED_LINES_IN_COMMIT = 30
       SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)(#|!|&|%)\d+(?<!`)}.freeze
 

data/lib/gitlab/dangerfiles/spec_helper.rb

@@ -0,0 +1,66 @@
+require "danger"
+require "gitlab/dangerfiles/changes"
+
+module DangerSpecHelper
+  # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+  # If you are expanding these files, see if it's already been done ^.
+
+  # A silent version of the user interface
+  def self.testing_ui
+    Cork::Board.new(silent: true)
+  end
+
+  # Example environment (ENV) that would come from
+  # running a PR on TravisCI
+  def self.testing_env
+    {
+      "GITLAB_CI" => "true",
+      "DANGER_GITLAB_HOST" => "gitlab.example.com",
+      "CI_MERGE_REQUEST_IID" => 28_493,
+      "DANGER_GITLAB_API_TOKEN" => "123sbdq54erfsd3422gdfio",
+    }
+  end
+
+  # A stubbed out Dangerfile for use in tests
+  def self.testing_dangerfile
+    env = Danger::EnvironmentManager.new(testing_env)
+    Danger::Dangerfile.new(env, testing_ui)
+  end
+
+  def self.fake_danger
+    Class.new do
+      attr_reader :git, :gitlab, :helper
+
+      # rubocop:disable Gitlab/ModuleWithInstanceVariables
+      def initialize(git: nil, gitlab: nil, helper: nil)
+        @git = git
+        @gitlab = gitlab
+        @helper = helper
+      end
+
+      # rubocop:enable Gitlab/ModuleWithInstanceVariables
+    end
+  end
+end
+
+RSpec.shared_context "with dangerfile" do
+  let(:dangerfile) { DangerSpecHelper.testing_dangerfile }
+  let(:added_files) { %w[added1] }
+  let(:modified_files) { %w[modified1] }
+  let(:deleted_files) { %w[deleted1] }
+  let(:renamed_before_file) { "renamed_before" }
+  let(:renamed_after_file) { "renamed_after" }
+  let(:renamed_files) { [{ before: renamed_before_file, after: renamed_after_file }] }
+  let(:change_class) { Gitlab::Dangerfiles::Change }
+  let(:changes_class) { Gitlab::Dangerfiles::Changes }
+  let(:changes) { changes_class.new([]) }
+  let(:mr_title) { "Fake Title" }
+  let(:mr_labels) { [] }
+
+  let(:fake_git) { double("fake-git", added_files: added_files, modified_files: modified_files, deleted_files: deleted_files, renamed_files: renamed_files) }
+  let(:fake_helper) { double("fake-helper", changes: changes, mr_iid: 1234, mr_title: mr_title, mr_labels: mr_labels) }
+
+  before do
+    allow(dangerfile).to receive(:git).and_return(fake_git)
+  end
+end

data/lib/gitlab/dangerfiles/teammate.rb

@@ -101,6 +101,8 @@ module Gitlab
           return true if capabilities(project).include?("#{kind} engineering_productivity")
 
           capabilities(project).include?("#{kind} backend")
+        when nil
+          capabilities(project).include?("#{kind}")
         else
           capabilities(project).include?("#{kind} #{category}")
         end

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "0.6.0"
+    VERSION = "0.9.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Rémy Coutable
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-03-03 00:00:00.000000000 Z
+date: 2021-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -136,9 +136,11 @@ files:
 - lib/gitlab/Dangerfile
 - lib/gitlab/dangerfiles.rb
 - lib/gitlab/dangerfiles/base_linter.rb
+- lib/gitlab/dangerfiles/changes.rb
 - lib/gitlab/dangerfiles/commit_linter.rb
 - lib/gitlab/dangerfiles/emoji_checker.rb
 - lib/gitlab/dangerfiles/merge_request_linter.rb
+- lib/gitlab/dangerfiles/spec_helper.rb
 - lib/gitlab/dangerfiles/teammate.rb
 - lib/gitlab/dangerfiles/title_linting.rb
 - lib/gitlab/dangerfiles/version.rb