gitlab-dangerfiles 0.5.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d044eef9bd28cb411b658eb1211c49a4f0ec769a93121c2fd7ce698fcd10a95c
-  data.tar.gz: 56ab60d3e31b399f314a1653b03c81f36efc84493585f00502e36dbc38d0554b
+  metadata.gz: e8132453b5b4614eaa87813509a18230d9c94d00cdec5b9e6857b032800092b0
+  data.tar.gz: 2e8dfe3056a7da31abbde54e9a8d1cbb96e9c9105d7fde5058903cc2617dbcfe
 SHA512:
-  metadata.gz: 9ffef7ad5e6f4d1ba093f254f210ed70391a395123b7e7d372b4cd947145d9a4958d88454e414686bf292822434ab54087a14c912cf7c16e832ff3b3aeb0d340
-  data.tar.gz: 804db12887f8acf6bcd4cded8d420537c508bf66a684d53522fcaa96b6f7c60f959ad0b86484bded1c9aac19abcf6aa6be38c90e1ba9e47b759670b9a0eaeb0a
+  metadata.gz: 8d1020a4fe7e5bcce74d8c03127373ae1a97ecf7ff57a981167cb6b8b733a17d5aef4b4c40fb31b88e996f8fe5830ecd779c49dc89609c3180f8ccf558a99028
+  data.tar.gz: 0d13715735e7bdded2a526575e276f21e11c11fb57f2fdcecdceb9051143f1995e2527cb4a57d9427aa3d8d2ced85d13775d96819d80610ae555f3108b5e508d

data/lib/danger/helper.rb

@@ -3,7 +3,9 @@
 require "net/http"
 require "json"
 require "danger"
+require_relative "../gitlab/dangerfiles/changes"
 require_relative "../gitlab/dangerfiles/teammate"
+require_relative "../gitlab/dangerfiles/title_linting"
 
 module Danger
   # Common helper functions for our danger scripts.
@@ -16,6 +18,7 @@ module Danger
       qa: "~QA",
       test: "~test ~Quality for `spec/features/*`",
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
+      ci_template: '~"ci::templates"',
     }.freeze
 
     HTTPError = Class.new(StandardError)
@@ -104,13 +107,38 @@ module Danger
       end
     end
 
-    # @return [Hash<String,Array<String>>]
+    # @return [Hash<Symbol,Array<String>>]
     def changes_by_category(categories)
       all_changed_files.each_with_object(Hash.new { |h, k| h[k] = [] }) do |file, hash|
         categories_for_file(file, categories).each { |category| hash[category] << file }
       end
     end
 
+    # @return [Gitlab::Dangerfiles::Changes]
+    def changes(categories)
+      Gitlab::Dangerfiles::Changes.new([]).tap do |changes|
+        git.added_files.each do |file|
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :added, category) }
+        end
+
+        git.modified_files.each do |file|
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :modified, category) }
+        end
+
+        git.deleted_files.each do |file|
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :deleted, category) }
+        end
+
+        git.renamed_files.map { |x| x[:before] }.each do |file|
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_before, category) }
+        end
+
+        git.renamed_files.map { |x| x[:after] }.each do |file|
+          categories_for_file(file, categories).each { |category| changes << Gitlab::Dangerfiles::Change.new(file, :renamed_after, category) }
+        end
+      end
+    end
+
     # Determines the categories a file is in, e.g., `[:frontend]`, `[:backend]`, or  `%i[frontend engineering_productivity]`
     # using filename regex and specific change regex if given.
     #
@@ -140,39 +168,64 @@ module Danger
       usernames.map { |u| Gitlab::Dangerfiles::Teammate.new("username" => u) }
     end
 
-    def sanitize_mr_title(title)
-      title.gsub(/^WIP: */, "").gsub(/`/, '\\\`')
+    def mr_iid
+      return "" unless gitlab_helper
+
+      gitlab_helper.mr_json["iid"]
     end
 
-    def draft_mr?
-      return false unless gitlab_helper
+    def mr_title
+      return "" unless gitlab_helper
 
-      DRAFT_REGEX.match?(gitlab_helper.mr_json["title"])
+      gitlab_helper.mr_json["title"]
     end
 
-    def security_mr?
-      return false unless gitlab_helper
+    def mr_web_url
+      return "" unless gitlab_helper
+
+      gitlab_helper.mr_json["web_url"]
+    end
+
+    def mr_labels
+      return [] unless gitlab_helper
 
-      gitlab_helper.mr_json["web_url"].include?("/gitlab-org/security/")
+      gitlab_helper.mr_labels
+    end
+
+    def mr_target_branch
+      return "" unless gitlab_helper
+
+      gitlab_helper.mr_json["target_branch"]
+    end
+
+    def draft_mr?
+      Gitlab::Dangerfiles::TitleLinting.has_draft_flag?(mr_title)
+    end
+
+    def security_mr?
+      mr_web_url.include?("/gitlab-org/security/")
     end
 
     def cherry_pick_mr?
-      return false unless gitlab_helper
+      Gitlab::Dangerfiles::TitleLinting.has_cherry_pick_flag?(mr_title)
+    end
 
-      /cherry[\s-]*pick/i.match?(gitlab_helper.mr_json["title"])
+    def run_all_rspec_mr?
+      Gitlab::Dangerfiles::TitleLinting.has_run_all_rspec_flag?(mr_title)
     end
 
-    def stable_branch?
-      return false unless gitlab_helper
+    def run_as_if_foss_mr?
+      Gitlab::Dangerfiles::TitleLinting.has_run_as_if_foss_flag?(mr_title)
+    end
 
-      /\A\d+-\d+-stable-ee/i.match?(gitlab_helper.mr_json["target_branch"])
+    def stable_branch?
+      /\A\d+-\d+-stable-ee/i.match?(mr_target_branch)
     end
 
     def mr_has_labels?(*labels)
-      return false unless gitlab_helper
-
       labels = labels.flatten.uniq
-      (labels & gitlab_helper.mr_labels) == labels
+
+      (labels & mr_labels) == labels
     end
 
     def labels_list(labels, sep: ", ")
@@ -189,10 +242,16 @@ module Danger
       all_changed_files.grep(regex)
     end
 
-    private
-
     def has_database_scoped_labels?(current_mr_labels)
       current_mr_labels.any? { |label| label.start_with?("database::") }
     end
+
+    def has_ci_changes?
+      changed_files(%r{\A(\.gitlab-ci\.yml|\.gitlab/ci/)}).any?
+    end
+
+    def group_label(labels)
+      labels.find { |label| label.start_with?("group::") }
+    end
   end
 end

data/lib/danger/roulette.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 
+require_relative "helper"
 require_relative "../gitlab/dangerfiles/teammate"
+require_relative "../gitlab/dangerfiles/weightage/maintainers"
+require_relative "../gitlab/dangerfiles/weightage/reviewers"
 
 module Danger
   # Common helper functions for our danger scripts. See Danger::Helper
@@ -24,7 +27,7 @@ module Danger
     #
     # @return [Array<Spin>]
     def spin(project, categories, timezone_experiment: false)
-      spins = categories.map do |category|
+      spins = categories.sort.map do |category|
         including_timezone = INCLUDE_TIMEZONE_FOR_CATEGORY.fetch(category, timezone_experiment)
 
         spin_for_category(project, category, timezone_experiment: including_timezone)
@@ -37,7 +40,7 @@ module Danger
         case spin.category
         when :qa
           # MR includes QA changes, but also other changes, and author isn't an SET
-          if categories.size > 1 && !team_mr_author&.reviewer?(project, spin.category, [])
+          if categories.size > 1 && !team_mr_author&.any_capability?(project, spin.category)
             spin.optional_role = :maintainer
           end
         when :test
@@ -52,6 +55,11 @@ module Danger
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
           end
+        when :ci_template
+          if spin.maintainer.nil?
+            # Fetch an already picked backend maintainer, or pick one otherwise
+            spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
+          end
         end
       end
 
@@ -146,13 +154,13 @@ module Danger
           spin_role_for_category(team, role, project, category)
         end
 
-      # TODO: take CODEOWNERS into account?
-      # https://gitlab.com/gitlab-org/gitlab/issues/26723
-
-      # Make traintainers have triple the chance to be picked as a reviewer
       random = new_random(mr_source_branch)
-      reviewer = spin_for_person(reviewers + traintainers + traintainers, random: random, timezone_experiment: timezone_experiment)
-      maintainer = spin_for_person(maintainers, random: random, timezone_experiment: timezone_experiment)
+
+      weighted_reviewers = Gitlab::Dangerfiles::Weightage::Reviewers.new(reviewers, traintainers).execute
+      weighted_maintainers = Gitlab::Dangerfiles::Weightage::Maintainers.new(maintainers).execute
+
+      reviewer = spin_for_person(weighted_reviewers, random: random, timezone_experiment: timezone_experiment)
+      maintainer = spin_for_person(weighted_maintainers, random: random, timezone_experiment: timezone_experiment)
 
       Spin.new(category, reviewer, maintainer, false, timezone_experiment)
     end

data/lib/gitlab/dangerfiles.rb

@@ -2,5 +2,8 @@ require "gitlab/dangerfiles/version"
 
 module Gitlab
   module Dangerfiles
+    def self.import_plugins(danger)
+      danger.import_plugin(File.expand_path("../danger/*.rb", __dir__))
+    end
   end
 end

data/lib/gitlab/dangerfiles/base_linter.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require_relative "title_linting"
+
+module Gitlab
+  module Dangerfiles
+    class BaseLinter
+      MIN_SUBJECT_WORDS_COUNT = 3
+      MAX_LINE_LENGTH = 72
+
+      attr_reader :commit, :problems
+
+      def self.problems_mapping
+        {
+          subject_too_short: "The %s must contain at least #{MIN_SUBJECT_WORDS_COUNT} words",
+          subject_too_long: "The %s may not be longer than #{MAX_LINE_LENGTH} characters",
+          subject_starts_with_lowercase: "The %s must start with a capital letter",
+          subject_ends_with_a_period: "The %s must not end with a period",
+        }
+      end
+
+      def self.subject_description
+        "commit subject"
+      end
+
+      def initialize(commit)
+        @commit = commit
+        @problems = {}
+      end
+
+      def failed?
+        problems.any?
+      end
+
+      def add_problem(problem_key, *args)
+        @problems[problem_key] = sprintf(self.class.problems_mapping[problem_key], *args)
+      end
+
+      def lint_subject
+        if subject_too_short?
+          add_problem(:subject_too_short, self.class.subject_description)
+        end
+
+        if subject_too_long?
+          add_problem(:subject_too_long, self.class.subject_description)
+        end
+
+        if subject_starts_with_lowercase?
+          add_problem(:subject_starts_with_lowercase, self.class.subject_description)
+        end
+
+        if subject_ends_with_a_period?
+          add_problem(:subject_ends_with_a_period, self.class.subject_description)
+        end
+
+        self
+      end
+
+      private
+
+      def subject
+        @subject ||= TitleLinting.remove_draft_flag(message_parts[0])
+      end
+
+      def subject_too_short?
+        subject.split(" ").length < MIN_SUBJECT_WORDS_COUNT
+      end
+
+      def subject_too_long?
+        line_too_long?(subject)
+      end
+
+      def line_too_long?(line)
+        line.length > MAX_LINE_LENGTH
+      end
+
+      def subject_starts_with_lowercase?
+        return false if subject.empty?
+        return false if ("A".."Z").cover?(subject[0])
+
+        first_char = subject.sub(/\A(\[.+\]|\w+:)\s/, "")[0]
+        first_char_downcased = first_char.downcase
+        return true unless ("a".."z").cover?(first_char_downcased)
+
+        first_char.downcase == first_char
+      end
+
+      def subject_ends_with_a_period?
+        subject.end_with?(".")
+      end
+
+      def message_parts
+        @message_parts ||= commit.message.split("\n", 3)
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/changes.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require_relative "title_linting"
+
+module Gitlab
+  module Dangerfiles
+    Change = Struct.new(:file, :change_type, :category)
+
+    class Changes < ::SimpleDelegator
+      def added
+        select_by_change_type(:added)
+      end
+
+      def modified
+        select_by_change_type(:modified)
+      end
+
+      def deleted
+        select_by_change_type(:deleted)
+      end
+
+      def renamed_before
+        select_by_change_type(:renamed_before)
+      end
+
+      def renamed_after
+        select_by_change_type(:renamed_after)
+      end
+
+      def has_category?(category)
+        any? { |change| change.category == category }
+      end
+
+      def by_category(category)
+        Changes.new(select { |change| change.category == category })
+      end
+
+      def categories
+        map(&:category).uniq
+      end
+
+      def files
+        map(&:file)
+      end
+
+      private
+
+      def select_by_change_type(change_type)
+        Changes.new(select { |change| change.change_type == change_type })
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/commit_linter.rb

@@ -1,40 +1,35 @@
 # frozen_string_literal: true
 
-emoji_checker_path = File.expand_path("emoji_checker", __dir__)
-defined?(Rails) ? require_dependency(emoji_checker_path) : require_relative(emoji_checker_path)
+require_relative "base_linter"
+require_relative "emoji_checker"
 
 module Gitlab
   module Dangerfiles
-    class CommitLinter
-      MIN_SUBJECT_WORDS_COUNT = 3
-      MAX_LINE_LENGTH = 72
+    class CommitLinter < BaseLinter
       MAX_CHANGED_FILES_IN_COMMIT = 3
       MAX_CHANGED_LINES_IN_COMMIT = 30
-      SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(#|!|&|%)\d+\b}.freeze
-      DEFAULT_SUBJECT_DESCRIPTION = "commit subject"
-      WIP_PREFIX = "WIP: "
-      PROBLEMS = {
-        subject_too_short: "The %s must contain at least #{MIN_SUBJECT_WORDS_COUNT} words",
-        subject_too_long: "The %s may not be longer than #{MAX_LINE_LENGTH} characters",
-        subject_starts_with_lowercase: "The %s must start with a capital letter",
-        subject_ends_with_a_period: "The %s must not end with a period",
-        separator_missing: "The commit subject and body must be separated by a blank line",
-        details_too_many_changes: "Commits that change #{MAX_CHANGED_LINES_IN_COMMIT} or more lines across " \
-        "at least #{MAX_CHANGED_FILES_IN_COMMIT} files must describe these changes in the commit body",
-        details_line_too_long: "The commit body should not contain more than #{MAX_LINE_LENGTH} characters per line",
-        message_contains_text_emoji: "Avoid the use of Markdown Emoji such as `:+1:`. These add limited value " \
-        "to the commit message, and are displayed as plain text outside of GitLab",
-        message_contains_unicode_emoji: "Avoid the use of Unicode Emoji. These add no value to the commit " \
-        "message, and may not be displayed properly everywhere",
-        message_contains_short_reference: "Use full URLs instead of short references (`gitlab-org/gitlab#123` or " \
-        "`!123`), as short references are displayed as plain text outside of GitLab",
-      }.freeze
-
-      attr_reader :commit, :problems
+      SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)(#|!|&|%)\d+(?<!`)}.freeze
+
+      def self.problems_mapping
+        super.merge(
+          {
+            separator_missing: "The commit subject and body must be separated by a blank line",
+            details_too_many_changes: "Commits that change #{MAX_CHANGED_LINES_IN_COMMIT} or more lines across " \
+            "at least #{MAX_CHANGED_FILES_IN_COMMIT} files must describe these changes in the commit body",
+            details_line_too_long: "The commit body should not contain more than #{MAX_LINE_LENGTH} characters per line",
+            message_contains_text_emoji: "Avoid the use of Markdown Emoji such as `:+1:`. These add limited value " \
+            "to the commit message, and are displayed as plain text outside of GitLab",
+            message_contains_unicode_emoji: "Avoid the use of Unicode Emoji. These add no value to the commit " \
+            "message, and may not be displayed properly everywhere",
+            message_contains_short_reference: "Use full URLs instead of short references (`gitlab-org/gitlab#123` or " \
+            "`!123`), as short references are displayed as plain text outside of GitLab",
+          }
+        )
+      end
 
       def initialize(commit)
-        @commit = commit
-        @problems = {}
+        super
+
         @linted = false
       end
 
@@ -58,19 +53,11 @@ module Gitlab
         !details.nil? && !details.empty?
       end
 
-      def failed?
-        problems.any?
-      end
-
-      def add_problem(problem_key, *args)
-        @problems[problem_key] = sprintf(PROBLEMS[problem_key], *args)
-      end
-
-      def lint(subject_description = "commit subject")
+      def lint
         return self if @linted
 
         @linted = true
-        lint_subject(subject_description)
+        lint_subject
         lint_separator
         lint_details
         lint_message
@@ -78,26 +65,6 @@ module Gitlab
         self
       end
 
-      def lint_subject(subject_description)
-        if subject_too_short?
-          add_problem(:subject_too_short, subject_description)
-        end
-
-        if subject_too_long?
-          add_problem(:subject_too_long, subject_description)
-        end
-
-        if subject_starts_with_lowercase?
-          add_problem(:subject_starts_with_lowercase, subject_description)
-        end
-
-        if subject_ends_with_a_period?
-          add_problem(:subject_ends_with_a_period, subject_description)
-        end
-
-        self
-      end
-
       private
 
       def lint_separator
@@ -114,15 +81,11 @@ module Gitlab
         end
 
         details&.each_line do |line|
-          line = line.strip
-
-          next unless line_too_long?(line)
-
-          url_size = line.scan(%r((https?://\S+))).sum { |(url)| url.length } # rubocop:disable CodeReuse/ActiveRecord
+          line_without_urls = line.strip.gsub(%r{https?://\S+}, "")
 
           # If the line includes a URL, we'll allow it to exceed MAX_LINE_LENGTH characters, but
           # only if the line _without_ the URL does not exceed this limit.
-          next unless line_too_long?(line.length - url_size)
+          next unless line_too_long?(line_without_urls)
 
           add_problem(:details_line_too_long)
           break
@@ -159,10 +122,6 @@ module Gitlab
         files_changed > MAX_CHANGED_FILES_IN_COMMIT && lines_changed > MAX_CHANGED_LINES_IN_COMMIT
       end
 
-      def subject
-        message_parts[0].delete_prefix(WIP_PREFIX)
-      end
-
       def separator
         message_parts[1]
       end
@@ -171,37 +130,6 @@ module Gitlab
         message_parts[2]&.gsub(/^Signed-off-by.*$/, "")
       end
 
-      def line_too_long?(line)
-        case line
-        when String
-          line.length > MAX_LINE_LENGTH
-        when Integer
-          line > MAX_LINE_LENGTH
-        else
-          raise ArgumentError, "The line argument (#{line}) should be a String or an Integer! #{line.class} given."
-        end
-      end
-
-      def subject_too_short?
-        subject.split(" ").length < MIN_SUBJECT_WORDS_COUNT
-      end
-
-      def subject_too_long?
-        line_too_long?(subject)
-      end
-
-      def subject_starts_with_lowercase?
-        first_char = subject.sub(/\A\[.+\]\s/, "")[0]
-        first_char_downcased = first_char.downcase
-        return true unless ("a".."z").cover?(first_char_downcased)
-
-        first_char.downcase == first_char
-      end
-
-      def subject_ends_with_a_period?
-        subject.end_with?(".")
-      end
-
       def message_contains_text_emoji?
         emoji_checker.includes_text_emoji?(commit.message)
       end
@@ -217,10 +145,6 @@ module Gitlab
       def emoji_checker
         @emoji_checker ||= Gitlab::Dangerfiles::EmojiChecker.new
       end
-
-      def message_parts
-        @message_parts ||= commit.message.split("\n", 3)
-      end
     end
   end
 end

data/lib/gitlab/dangerfiles/merge_request_linter.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative "base_linter"
+
+module Gitlab
+  module Dangerfiles
+    class MergeRequestLinter < BaseLinter
+      alias_method :lint, :lint_subject
+
+      def self.subject_description
+        "merge request title"
+      end
+
+      def self.mr_run_options_regex
+        [
+          "RUN AS-IF-FOSS",
+          "UPDATE CACHE",
+          "RUN ALL RSPEC",
+          "SKIP RSPEC FAIL-FAST",
+        ].join("|")
+      end
+
+      private
+
+      def subject
+        super.gsub(/\[?(#{self.class.mr_run_options_regex})\]?/, "").strip
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/spec_helper.rb

@@ -0,0 +1,66 @@
+require "danger"
+require "gitlab/dangerfiles/changes"
+
+module DangerSpecHelper
+  # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+  # If you are expanding these files, see if it's already been done ^.
+
+  # A silent version of the user interface
+  def self.testing_ui
+    Cork::Board.new(silent: true)
+  end
+
+  # Example environment (ENV) that would come from
+  # running a PR on TravisCI
+  def self.testing_env
+    {
+      "GITLAB_CI" => "true",
+      "DANGER_GITLAB_HOST" => "gitlab.example.com",
+      "CI_MERGE_REQUEST_IID" => 28_493,
+      "DANGER_GITLAB_API_TOKEN" => "123sbdq54erfsd3422gdfio",
+    }
+  end
+
+  # A stubbed out Dangerfile for use in tests
+  def self.testing_dangerfile
+    env = Danger::EnvironmentManager.new(testing_env)
+    Danger::Dangerfile.new(env, testing_ui)
+  end
+
+  def self.fake_danger
+    Class.new do
+      attr_reader :git, :gitlab, :helper
+
+      # rubocop:disable Gitlab/ModuleWithInstanceVariables
+      def initialize(git: nil, gitlab: nil, helper: nil)
+        @git = git
+        @gitlab = gitlab
+        @helper = helper
+      end
+
+      # rubocop:enable Gitlab/ModuleWithInstanceVariables
+    end
+  end
+end
+
+RSpec.shared_context "with dangerfile" do
+  let(:dangerfile) { DangerSpecHelper.testing_dangerfile }
+  let(:added_files) { %w[added1] }
+  let(:modified_files) { %w[modified1] }
+  let(:deleted_files) { %w[deleted1] }
+  let(:renamed_before_file) { "renamed_before" }
+  let(:renamed_after_file) { "renamed_after" }
+  let(:renamed_files) { [{ before: renamed_before_file, after: renamed_after_file }] }
+  let(:change_class) { Gitlab::Dangerfiles::Change }
+  let(:changes_class) { Gitlab::Dangerfiles::Changes }
+  let(:changes) { changes_class.new([]) }
+  let(:mr_title) { "Fake Title" }
+  let(:mr_labels) { [] }
+
+  let(:fake_git) { double("fake-git", added_files: added_files, modified_files: modified_files, deleted_files: deleted_files, renamed_files: renamed_files) }
+  let(:fake_helper) { double("fake-helper", changes: changes, mr_iid: 1234, mr_title: mr_title, mr_labels: mr_labels) }
+
+  before do
+    allow(dangerfile).to receive(:git).and_return(fake_git)
+  end
+end

data/lib/gitlab/dangerfiles/teammate.rb

@@ -3,7 +3,7 @@
 module Gitlab
   module Dangerfiles
     class Teammate
-      attr_reader :options, :username, :name, :role, :projects, :available, :hungry, :tz_offset_hours
+      attr_reader :options, :username, :name, :role, :projects, :available, :hungry, :reduced_capacity, :tz_offset_hours
 
       # The options data are produced by https://gitlab.com/gitlab-org/gitlab-roulette/-/blob/master/lib/team_member.rb
       def initialize(options = {})
@@ -15,6 +15,7 @@ module Gitlab
         @projects = options["projects"]
         @available = options["available"]
         @hungry = options["hungry"]
+        @reduced_capacity = options["reduced_capacity"]
         @tz_offset_hours = options["tz_offset_hours"]
       end
 
@@ -32,6 +33,10 @@ module Gitlab
         projects&.has_key?(name)
       end
 
+      def any_capability?(project, category)
+        capabilities(project).any? { |capability| capability.end_with?(category.to_s) }
+      end
+
       def reviewer?(project, category, labels)
         has_capability?(project, category, :reviewer, labels)
       end
@@ -93,6 +98,7 @@ module Gitlab
         when :engineering_productivity
           return false unless role[/Engineering Productivity/]
           return true if kind == :reviewer
+          return true if capabilities(project).include?("#{kind} engineering_productivity")
 
           capabilities(project).include?("#{kind} backend")
         else

data/lib/gitlab/dangerfiles/title_linting.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module Dangerfiles
+    module TitleLinting
+      DRAFT_REGEX = /\A*#{Regexp.union(/(?i)(\[WIP\]\s*|WIP:\s*|WIP$)/, /(?i)(\[draft\]|\(draft\)|draft:|draft\s\-\s|draft$)/)}+\s*/i.freeze
+      CHERRY_PICK_REGEX = /cherry[\s-]*pick/i.freeze
+      RUN_ALL_RSPEC_REGEX = /RUN ALL RSPEC/i.freeze
+      RUN_AS_IF_FOSS_REGEX = /RUN AS-IF-FOSS/i.freeze
+
+      module_function
+
+      def sanitize_mr_title(title)
+        remove_draft_flag(title).gsub(/`/, '\\\`')
+      end
+
+      def remove_draft_flag(title)
+        title.gsub(DRAFT_REGEX, "")
+      end
+
+      def has_draft_flag?(title)
+        DRAFT_REGEX.match?(title)
+      end
+
+      def has_cherry_pick_flag?(title)
+        CHERRY_PICK_REGEX.match?(title)
+      end
+
+      def has_run_all_rspec_flag?(title)
+        RUN_ALL_RSPEC_REGEX.match?(title)
+      end
+
+      def has_run_as_if_foss_flag?(title)
+        RUN_AS_IF_FOSS_REGEX.match?(title)
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "0.5.0"
+    VERSION = "0.8.1"
   end
 end

data/lib/gitlab/dangerfiles/weightage.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module Dangerfiles
+    module Weightage
+      CAPACITY_MULTIPLIER = 2 # change this number to change what it means to be a reduced capacity reviewer 1/this number
+      BASE_REVIEWER_WEIGHT = 1
+    end
+  end
+end

data/lib/gitlab/dangerfiles/weightage/maintainers.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require_relative "../weightage"
+
+module Gitlab
+  module Dangerfiles
+    module Weightage
+      class Maintainers
+        def initialize(maintainers)
+          @maintainers = maintainers
+        end
+
+        def execute
+          maintainers.each_with_object([]) do |maintainer, weighted_maintainers|
+            add_weighted_reviewer(weighted_maintainers, maintainer, Gitlab::Dangerfiles::Weightage::BASE_REVIEWER_WEIGHT)
+          end
+        end
+
+        private
+
+        attr_reader :maintainers
+
+        def add_weighted_reviewer(reviewers, reviewer, weight)
+          if reviewer.reduced_capacity
+            reviewers.fill(reviewer, reviewers.size, weight)
+          else
+            reviewers.fill(reviewer, reviewers.size, weight * Gitlab::Dangerfiles::Weightage::CAPACITY_MULTIPLIER)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/dangerfiles/weightage/reviewers.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require_relative "../weightage"
+
+module Gitlab
+  module Dangerfiles
+    module Weightage
+      # Weights after (current multiplier of 2)
+      #
+      # +------------------------------+--------------------------------+
+      # |        reviewer type         | weight(times in reviewer pool) |
+      # +------------------------------+--------------------------------+
+      # | reduced capacity reviewer    |                              1 |
+      # | reviewer                     |                              2 |
+      # | hungry reviewer              |                              4 |
+      # | reduced capacity traintainer |                              3 |
+      # | traintainer                  |                              6 |
+      # | hungry traintainer           |                              8 |
+      # +------------------------------+--------------------------------+
+      #
+      class Reviewers
+        DEFAULT_REVIEWER_WEIGHT = Gitlab::Dangerfiles::Weightage::CAPACITY_MULTIPLIER * Gitlab::Dangerfiles::Weightage::BASE_REVIEWER_WEIGHT
+        TRAINTAINER_WEIGHT = 3
+
+        def initialize(reviewers, traintainers)
+          @reviewers = reviewers
+          @traintainers = traintainers
+        end
+
+        def execute
+          # TODO: take CODEOWNERS into account?
+          # https://gitlab.com/gitlab-org/gitlab/issues/26723
+
+          weighted_reviewers + weighted_traintainers
+        end
+
+        private
+
+        attr_reader :reviewers, :traintainers
+
+        def weighted_reviewers
+          reviewers.each_with_object([]) do |reviewer, total_reviewers|
+            add_weighted_reviewer(total_reviewers, reviewer, Gitlab::Dangerfiles::Weightage::BASE_REVIEWER_WEIGHT)
+          end
+        end
+
+        def weighted_traintainers
+          traintainers.each_with_object([]) do |reviewer, total_traintainers|
+            add_weighted_reviewer(total_traintainers, reviewer, TRAINTAINER_WEIGHT)
+          end
+        end
+
+        def add_weighted_reviewer(reviewers, reviewer, weight)
+          if reviewer.reduced_capacity
+            reviewers.fill(reviewer, reviewers.size, weight)
+          elsif reviewer.hungry
+            reviewers.fill(reviewer, reviewers.size, weight * Gitlab::Dangerfiles::Weightage::CAPACITY_MULTIPLIER + DEFAULT_REVIEWER_WEIGHT)
+          else
+            reviewers.fill(reviewer, reviewers.size, weight * Gitlab::Dangerfiles::Weightage::CAPACITY_MULTIPLIER)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Rémy Coutable
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-29 00:00:00.000000000 Z
+date: 2021-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -135,10 +135,18 @@ files:
 - lib/gitlab-dangerfiles.rb
 - lib/gitlab/Dangerfile
 - lib/gitlab/dangerfiles.rb
+- lib/gitlab/dangerfiles/base_linter.rb
+- lib/gitlab/dangerfiles/changes.rb
 - lib/gitlab/dangerfiles/commit_linter.rb
 - lib/gitlab/dangerfiles/emoji_checker.rb
+- lib/gitlab/dangerfiles/merge_request_linter.rb
+- lib/gitlab/dangerfiles/spec_helper.rb
 - lib/gitlab/dangerfiles/teammate.rb
+- lib/gitlab/dangerfiles/title_linting.rb
 - lib/gitlab/dangerfiles/version.rb
+- lib/gitlab/dangerfiles/weightage.rb
+- lib/gitlab/dangerfiles/weightage/maintainers.rb
+- lib/gitlab/dangerfiles/weightage/reviewers.rb
 homepage: https://gitlab.com/gitlab-org/gitlab-dangerfiles
 licenses:
 - MIT
@@ -162,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: This gem provides common Dangerfile and plugins for GitLab projects.