gitlab-dangerfiles 0.1.0 → 0.2.0

data/lib/gitlab/dangerfiles/specs/Dangerfile

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-NO_SPECS_LABELS = [
-  'backstage', # To be removed by https://gitlab.com/gitlab-org/gitlab/-/issues/222360.
-  'tooling',
-  'tooling::pipelines',
-  'tooling::workflow',
-  'documentation',
-  'QA'
-].freeze
-NO_NEW_SPEC_MESSAGE = <<~MSG
-You've made some app changes, but didn't add any tests.
-That's OK as long as you're refactoring existing code,
-but please consider adding any of the %<labels>s labels.
-MSG
-EE_CHANGE_WITH_FOSS_SPEC_CHANGE_MESSAGE = <<~MSG
-You've made some EE-specific changes, but only made changes to FOSS tests.
-This could be a sign that you're testing an EE-specific behavior in a FOSS test.
-
-Please make sure the spec files pass in AS-IF-FOSS mode either:
-
-1. Locally with `FOSS_ONLY=1 bin/rspec -- %<spec_files>s`.
-1. In the MR pipeline by verifying that the `rspec foss-impact` job has passed.
-1. In the MR pipelines by including `RUN AS-IF-FOSS` in the MR title (you can do it with the ``/title %<mr_title>s [RUN AS-IF-FOSS]`` quick action) and start a new MR pipeline.
-
-MSG
-
-has_app_changes = helper.all_changed_files.grep(%r{\A(app|lib|db/(geo/)?(post_)?migrate)/}).any?
-has_ee_app_changes = helper.all_changed_files.grep(%r{\Aee/(app|lib|db/(geo/)?(post_)?migrate)/}).any?
-spec_changes = helper.all_changed_files.grep(%r{\Aspec/})
-has_spec_changes = spec_changes.any?
-has_ee_spec_changes = helper.all_changed_files.grep(%r{\Aee/spec/}).any?
-new_specs_needed = (gitlab.mr_labels & NO_SPECS_LABELS).empty?
-
-if (has_app_changes || has_ee_app_changes) && !(has_spec_changes || has_ee_spec_changes) && new_specs_needed
-  warn format(NO_NEW_SPEC_MESSAGE, labels: helper.labels_list(NO_SPECS_LABELS)), sticky: false
-end
-
-# The only changes outside `ee/` are in `spec/`
-if has_ee_app_changes && has_spec_changes && !(has_app_changes || has_ee_spec_changes)
-  warn format(EE_CHANGE_WITH_FOSS_SPEC_CHANGE_MESSAGE, spec_files: spec_changes.join(" "), mr_title: gitlab.mr_json['title']), sticky: false
-end

data/lib/gitlab/dangerfiles/tasks.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-desc "Run local Danger rules"
-task :danger_local do
-  require "gitlab/dangerfiles"
-  require "popen/danger/popen"
-
-  puts("#{Gitlab::Dangerfiles.local_warning_message}\n")
-
-  # _status will _always_ be 0, regardless of failure or success :(
-  output, _status = Gitlab::Dangerfiles::Popen.popen(%w{danger dry_run})
-
-  if output.empty?
-    puts(Gitlab::Dangerfiles.success_message)
-  else
-    puts(output)
-    exit(1)
-  end
-end

data/lib/gitlab/dangerfiles/telemetry/Dangerfile

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-TELEMETRY_CHANGED_FILES_MESSAGE = <<~MSG
-For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended
-Please check the ~telemetry [guide](https://docs.gitlab.com/ee/development/telemetry/usage_ping.html) and reach out to @gitlab-org/growth/telemetry/engineers group for a review.
-
-%<changed_files>s
-
-MSG
-
-tracking_files = [
-  'lib/gitlab/tracking.rb',
-  'spec/lib/gitlab/tracking_spec.rb',
-  'app/helpers/tracking_helper.rb',
-  'spec/helpers/tracking_helper_spec.rb',
-  'app/assets/javascripts/tracking.js',
-  'spec/frontend/tracking_spec.js'
-]
-
-usage_data_changed_files = git.modified_files.grep(%r{usage_data})
-snowplow_events_changed_files = git.modified_files & tracking_files
-
-changed_files = (usage_data_changed_files + snowplow_events_changed_files)
-
-if changed_files.any?
-  warn format(TELEMETRY_CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(changed_files))
-
-  telemetry_labels = ['telemetry']
-  telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed')
-
-  markdown(helper.prepare_labels_for_mr(telemetry_labels))
-end

data/lib/gitlab/dangerfiles/utility_css/Dangerfile

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-common = 'app/assets/stylesheets/framework/common.scss'
-utilities = 'app/assets/stylesheets/utilities.scss'
-
-def get_css_files(files, common_filepath, utilities_filepath)
-  files.select do |file|
-    file.include?(common_filepath) ||
-    file.include?(utilities_filepath)
-  end
-end
-
-changed_util_files = get_css_files(helper.all_changed_files.to_a, common, utilities)
-
-unless changed_util_files.empty?
-
-  markdown(<<~MARKDOWN)
-  ## Changes to utility SCSS files
-  MARKDOWN
-
-  if changed_util_files.include?(common)
-
-    markdown(<<~MARKDOWN)
-    ### Addition to `#{common}`
-
-    You have added a new rule to `#{common}`. Are you sure you need this rule?
-
-    If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, you can ignore this warning.
-
-    If it is a new utility class, is there another class that shares the same values in either this file or in `#{utilities}`? If not, please add it to `#{utilities}`, following the [Gitlab UI naming style](https://unpkg.com/browse/@gitlab/ui/src/scss/utilities.scss).
-
-    MARKDOWN
-
-  end
-
-  if changed_util_files.include?(utilities)
-    markdown(<<~MARKDOWN)
-    ### Addition to `#{utilities}`
-
-    You have added a new rule to `#{utilities}`. Are you sure you need this rule?
-
-    If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, consider adding it to `#{common}`
-
-    If it is a new utility class, is there another class that shares the same values in either this file or in `#{utilities}`? If not, please be sure this addition follows the [Gitlab UI naming style](https://unpkg.com/browse/@gitlab/ui/src/scss/utilities.scss) so it may be removed when these rules are included. See [Include gitlab-ui utility-class library](https://gitlab.com/gitlab-org/gitlab/issues/36857) for more about this project.
-
-    MARKDOWN
-  end
-
-  warn "This merge request adds a new rule to #{common} or #{utilities}."
-
-end