gitignores 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0edda6b894e24e50cafe41003380171ab0157e65
-  data.tar.gz: 953d0f542005a7a3ca37dc0bb35f4892f83455d1
+SHA256:
+  metadata.gz: 5a2c227bbcd01fc5db4de822d7fbb850c8d49427f0e09166f0e5a3578cd5db82
+  data.tar.gz: 8b62d2036dba2ec308cf162ef23fa6f1a0cbc9e862f9201f9a76162f0f60a3ee
 SHA512:
-  metadata.gz: 7f6b60527d67e26f41e1160e8a6efa7c44b27fd89f5af17a8dbd0d41fa42e399174fde330785493cec9f2eabf1b71d4da4cfacce89ffbb332a54853ce80e816e
-  data.tar.gz: 003054f16f0868964e2a8275339fc55acb3e011f3d9d85f87aff73f9cb2e8c5e77c58b13ffa33426e5427fa225f2d1d7cdd991e933c73f40be32f88dd40cebb4
+  metadata.gz: b352a098f1efe529bee8f45e99a9634e3b519581cfc96496ed07eec9e17914e7e6affaf04ea636df643d8f347a09af3405cd252dbd959a088037a26832859ab7
+  data.tar.gz: bbd5907f97d298cbfb8581554631c054144b088ef2f64639e69e395e51f5e6a68f184d6c4a7d1f89213dcee17a38abf2f7afce00fbbe92470d249f8ef95bbab5

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+## 0.1.2 (2025-07-11)
+
+Compatibility:
+
+  - Add Ruby 3.x compatibility by replacing deprecated `Dir.exists?` and `File.exists?` methods
+  - Update GLI gem from 2.13.3 to 2.21.5 to fix ERB deprecation warnings
+  - Fix deprecated `Rake::RDocTask`, now uses `RDoc::Task`
+  - Add Ruby version requirement (>= 2.5.0) to gemspec
+
+Security:
+
+  - Fix potential shell command injection vulnerability by using `system()` instead of backticks
+
+Features:
+
+  - Update OS gitignore name from 'OSX' to 'macOS' to match current GitHub repository structure
+
+Development:
+
+  - Update RSpec stubbing syntax to modern `allow().to receive()` pattern
+  - Add proper error handling for git operations with custom exception classes
+
 ## 0.0.3 (2015-05-25)
 
 Features:

data/Gemfile.lock

@@ -1,26 +1,29 @@
 PATH
   remote: .
   specs:
-    gitignores (0.1.0)
-      gli (= 2.13.3)
+    gitignores (0.1.2)
+      gli (= 2.21.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.2.5)
-    gli (2.13.3)
-    json (1.8.3)
-    rake (10.4.2)
-    rdoc (4.2.0)
-      json (~> 1.4)
-    rspec (2.13.0)
-      rspec-core (~> 2.13.0)
-      rspec-expectations (~> 2.13.0)
-      rspec-mocks (~> 2.13.0)
-    rspec-core (2.13.1)
-    rspec-expectations (2.13.0)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.13.1)
+    diff-lcs (1.4.4)
+    gli (2.21.5)
+    rake (13.0.3)
+    rdoc (6.3.0)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
 
 PLATFORMS
   ruby
@@ -30,3 +33,6 @@ DEPENDENCIES
   rake
   rdoc
   rspec
+
+BUNDLED WITH
+   2.6.9

data/README.md

@@ -4,7 +4,7 @@ Tool for building a .gitignore from community templates at [github/gitignore](ht
 
 ## Installation
 
-    $ gem install gitignores
+    gem install gitignores
 
 ## Usage
 
@@ -27,4 +27,3 @@ Prints gitignores for Java, JetBrains, Eclipse to standard out
 **update** updates the github/gitignore cache (by default `$HOME/.gitignores`)
 
     gitignores update
-

data/README.rdoc

@@ -1,7 +1,7 @@
 = gitignores - .gitignore builder
 
 Author::  Johnathan Gilday (me@johnathangilday.com)
-Copyright:: Copyright (c) 2013 Johnathan Gilday
+Copyright:: Copyright (c) 2021 Johnathan Gilday
 
 
 License:: apache, see LICENSE.txt

data/Rakefile

@@ -1,3 +1,4 @@
+require 'bundler/gem_tasks'
 require 'rake/clean'
 require 'rubygems'
 require 'rubygems/package_task'
@@ -6,7 +7,7 @@ require 'rspec/core/rake_task'
 
 CLEAN << 'tmp'
 
-Rake::RDocTask.new do |rd|
+RDoc::Task.new do |rd|
   rd.main = "README.rdoc"
   rd.rdoc_files.include("README.rdoc","lib/**/*.rb","bin/**/*")
   rd.title = 'gitignores'
@@ -14,14 +15,9 @@ end
 
 include Rake::DSL
 
-Bundler::GemHelper.install_tasks
 
 RSpec::Core::RakeTask.new do |t|
 end
 
-spec = eval(File.read('gitignores.gemspec'))
-
-Gem::PackageTask.new(spec) do |pkg|
-end
 
 task :default => [:spec]

data/bin/gitignores

@@ -33,11 +33,11 @@ Use the list command to show possible values for snippet names.
 )
 arg 'snippet', :multiple
 command :add do |c|
-  c.desc 'include snippets for operating systems OSX, Windows, Linux'
+  c.desc 'include snippets for operating systems macOS, Windows, Linux'
   c.switch :os, :negatable => false
   c.action do |global_options,options,args|
     if (options[:os])
-      args.concat ['OSX', 'Windows', 'Linux']
+      args.concat ['macOS', 'Windows', 'Linux']
     end
     args.uniq!
     $gitignores.add(args)

data/gitignores.gemspec

@@ -9,16 +9,16 @@ Gem::Specification.new do |gem|
   gem.platform = Gem::Platform::RUBY
   gem.summary = Gitignores::SUMMARY
   gem.homepage = 'https://github.com/gilday/gitignore-builder'
+  gem.required_ruby_version = '>= 2.5.0'
   
   gem.files = `git ls-files`.split("
 ")
   gem.require_paths << 'lib'
-  gem.has_rdoc = true
   gem.bindir = 'bin'
   gem.executables << 'gitignores'
   gem.add_development_dependency('rake')
   gem.add_development_dependency('rdoc')
   gem.add_development_dependency('rspec')
-  gem.add_runtime_dependency('gli','2.13.3')
+  gem.add_runtime_dependency('gli','2.21.5')
 end
 

data/lib/gitignores/builder.rb

@@ -15,8 +15,8 @@ module Gitignores
 
     def find_gitignores_by_name(ignores) 
       ignores.collect { |x| 
-        path = File.exists?("#{@local_repository}/#{x}.gitignore") ? "#{@local_repository}/#{x}.gitignore" : "#{@local_repository}/Global/#{x}.gitignore"
-        unless File.exists? path
+        path = File.exist?("#{@local_repository}/#{x}.gitignore") ? "#{@local_repository}/#{x}.gitignore" : "#{@local_repository}/Global/#{x}.gitignore"
+        unless File.exist? path
           raise GitignoreNotFoundException.new(x), "File #{path} does not exist"
         end
         File.expand_path(path)

data/lib/gitignores/exceptions.rb

@@ -5,4 +5,7 @@ module Gitignores
       @ignore_name = ignore_name
     end
   end
+  
+  class GitCloneError < RuntimeError; end
+  class GitPullError < RuntimeError; end
 end

data/lib/gitignores/fetcher.rb

@@ -1,4 +1,5 @@
 require 'gitignores'
+require 'shellwords'
 
 module Gitignores
   class GitignoreFetcher
@@ -16,7 +17,7 @@ module Gitignores
     # If @update_ignores? is set, will try to update the latest gitignores
     # Will store all gitignores in the @local_repository
     def fetch_gitignores()
-      unless (Dir.exists?(@local_repository))
+      unless (Dir.exist?(@local_repository))
         @git.clone @remote_repository, @local_repository
       end
       if @update_ignores
@@ -37,12 +38,14 @@ module Gitignores
   class Git
 
     def clone(repository, directory)
-       `git clone #{repository} #{directory}`
+      system('git', 'clone', repository, directory)
+      raise GitCloneError, "Failed to clone #{repository}" unless $?.success?
     end
 
     def pull(directory) 
       Dir.chdir(directory) {
-        `git pull`
+        system('git', 'pull')
+        raise GitPullError, "Failed to pull in #{directory}" unless $?.success?
       }
     end
   end

data/lib/gitignores/version.rb

@@ -1,5 +1,5 @@
 module Gitignores
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 
   SUMMARY = "Generates .gitignore"
 

data/spec/gitignore_builder_spec.rb

@@ -11,7 +11,7 @@ describe GitignoreBuilder do
   # Really simple test because I'm a Ruby newb
   describe "#new" do
     it "creates a new GitignoreBuilder" do
-      @builder.should be_an_instance_of GitignoreBuilder
+      expect(@builder).to be_an_instance_of GitignoreBuilder
     end
   end
 
@@ -21,8 +21,8 @@ describe GitignoreBuilder do
       paths = @builder.find_gitignores_by_name ["foo", "bar"]
 
       fake_ignores_root = File.expand_path(FAKE_IGNORES)
-      paths.should include("#{fake_ignores_root}/foo.gitignore")
-      paths.should include("#{fake_ignores_root}/Global/bar.gitignore")
+      expect(paths).to include("#{fake_ignores_root}/foo.gitignore")
+      expect(paths).to include("#{fake_ignores_root}/Global/bar.gitignore")
     end
 
     it "raises GitignoreNotFound exception if it cannot find a Gitignore" do
@@ -37,7 +37,7 @@ describe GitignoreBuilder do
       out = StringIO.new
       @builder.concatenate_files(["#{FAKE_IGNORES}/foo.gitignore", "#{FAKE_IGNORES}/Global/bar.gitignore"], out)
 
-      out.string.should eq(
+      expect(out.string).to eq(
 "
 \# foo
 

data/spec/gitignore_fetcher_spec.rb

@@ -11,8 +11,8 @@ describe Git do
     FileUtils.rm_rf(test_repository)
     @git.clone '.', test_repository
 
-    File.exists?(test_repository).should be_true
-    Dir[test_repository].empty?.should be_false
+    expect(File.exist?(test_repository)).to be true
+    expect(Dir[test_repository].empty?).to be false
   end
 end
 
@@ -27,15 +27,15 @@ describe GitignoreFetcher do
   describe "#fetch_gitignores" do
 
     it "downloads the github/gitignore repository" do 
-      @mockGit.should_receive(:clone)
+      expect(@mockGit).to receive(:clone)
 
       @fetcher.fetch_gitignores
     end     
 
     it "updates the repository when given update flag" do
       @fetcher.update_ignores = true
-      @mockGit.stub(:clone)
-      @mockGit.should_receive(:pull).with(anything())
+      allow(@mockGit).to receive(:clone)
+      expect(@mockGit).to receive(:pull).with(anything())
 
       @fetcher.fetch_gitignores
     end
@@ -44,11 +44,11 @@ describe GitignoreFetcher do
   describe "#list_gitignores" do
 
     it "finds all gitignores in the directory and returns their names in a list" do
-      @mockGit.stub(:clone)
+      allow(@mockGit).to receive(:clone)
       @fetcher.local_repository = FAKE_IGNORES
       ignores = @fetcher.list_gitignores
 
-      ignores.should include("foo", "bar")
+      expect(ignores).to include("foo", "bar")
     end
   end
 

metadata

@@ -1,55 +1,54 @@
 --- !ruby/object:Gem::Specification
 name: gitignores
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Johnathan Gilday
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -58,22 +57,21 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.3
+        version: 2.21.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.3
-description: 
+        version: 2.21.5
 email: me@johnathangilday.com
 executables:
 - gitignores
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -96,25 +94,22 @@ files:
 homepage: https://github.com/gilday/gitignore-builder
 licenses: []
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Generates .gitignore
 test_files: []